Hi Pavel,
Thanks a lot for your reply!
I will try it.
koizumi
On 2016/06/21 15:41, Pavel Grunt wrote:
Hi,
you need to install dependencies, everything is on the latest Fedora, so let dnf
help you with it:
sudo dnf builddep mingw-spice-gtk
Pavel
On Tue, 2016-06-21 at 09:48 +0900, 小泉 wrot
Hi,
you need to install dependencies, everything is on the latest Fedora, so let dnf
help you with it:
sudo dnf builddep mingw-spice-gtk
Pavel
On Tue, 2016-06-21 at 09:48 +0900, 小泉 wrote:
> Hi all,
>
> I am building spice-gtk for Windows on my fedora based on following
> instruction.
>
>
Hi all,
I am sorry to post similar questions.
In this mail, I would like to know about error when I build virt-viewer
for Windows on my fedora based on following instruction.
Building Instructions/Client
http://www.spice-space.org/page/Building_Instructions/Client
I see following error me
Hi all,
I am building spice-gtk for Windows on my fedora based on following
instruction.
Building Instructions/Client
http://www.spice-space.org/page/Building_Instructions/Client
But I see following error message when I run "mingw32-configure
--prefix=$INST_ROOT".
Could you please tell
Acked-by: Jonathon Jongsma
On Fri, 2016-06-17 at 17:38 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/image-encoders.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/image-encoders.h b/server/image-encoders.h
> index c4600e3.
On Mon, 2016-06-20 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/image-encoders.h | 48
> 1 file changed, 48 insertions(+)
>
> diff --git a/server/image-encoders.h b/server/image-encoders.h
> index e07c036.
>
> From: Marc-André Lureau
>
> vncdisplaykeymap.c: In function 'vnc_display_keymap_gdk2xtkbd_table':
> vncdisplaykeymap.c:223:14: error: self-comparison always evaluates to true
> [-Werror=tautological-compare]
> if (GDK_IS_WIN32_WINDOW(window)) {
>
> Signed-off-by: Marc-André Lureau
> ---
>
> From: Marc-André Lureau
>
> Commit 0fafbe3 broke the build on win32, because it accesses
> d->egl.enabled. Add a helper function and fix the build.
>
> Signed-off-by: Marc-André Lureau
> Reported-by: Frediano Ziglio
> ---
> src/spice-widget.c | 34 ++
> 1
On Mon, Jun 20, 2016 at 11:46:16AM -0400, Frediano Ziglio wrote:
>
> Looks good, however in the generated file code starts with
>
>
> #include
> #include
> #include "common/marshaller.h"
>
> #ifndef _GENERATED_HEADERS_H
> #define _GENERATED_HEADERS_H
>
>
> beside the mix of "" and <> all he
From: Marc-André Lureau
vncdisplaykeymap.c: In function 'vnc_display_keymap_gdk2xtkbd_table':
vncdisplaykeymap.c:223:14: error: self-comparison always evaluates to true
[-Werror=tautological-compare]
if (GDK_IS_WIN32_WINDOW(window)) {
Signed-off-by: Marc-André Lureau
---
src/vncdisplaykeyma
From: Marc-André Lureau
Commit 0fafbe3 broke the build on win32, because it accesses
d->egl.enabled. Add a helper function and fix the build.
Signed-off-by: Marc-André Lureau
Reported-by: Frediano Ziglio
---
src/spice-widget.c | 34 ++
1 file changed, 18 insert
>
> This commit adds autogeneration of a generated_client_marshallers.h
> header, which is then included in client_marshallers.h
>
> This allows to remove the SpiceMessageMarshallers struct from this file,
> which has to match what the generated code expects.
> ---
> common/Makefile.am
On Mon, Jun 20, 2016 at 5:34 PM, Marc-André Lureau
wrote:
> Hi
>
> On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau
> wrote:
>> On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio
>> wrote:
gtk_widget_set_can_focus(widget, true);
+gtk_event_box_set_above_child(GTK_EVENT_BOX(w
Hi
On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau
wrote:
> On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio
> wrote:
>>> gtk_widget_set_can_focus(widget, true);
>>> +gtk_event_box_set_above_child(GTK_EVENT_BOX(widget), true);
>>
>> I'd just do: s/true/TRUE before pushing, but no n
On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio wrote:
>> gtk_widget_set_can_focus(widget, true);
>> +gtk_event_box_set_above_child(GTK_EVENT_BOX(widget), true);
>
> I'd just do: s/true/TRUE before pushing, but no need to resend the
> patch because of this is just my preference :-)
The
On Mon, Jun 20, 2016 at 3:22 PM, wrote:
> From: Marc-André Lureau
>
> Since the switch to a container widget (gtkstack then gtkeventbox), the
> grab may be lost when clicking on the display. Since events are treated
> at the top level container, set widget "above-child" to trap all of them
> to
Hey,
On Mon, Jun 20, 2016 at 03:28:44PM +0200, Marc-André Lureau wrote:
> ping
Sorry, did not follow up on this one after the discussion on the other
thread. If you are fine handling things this way,
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
ack
- Original Message -
> We want to trigger rebuild of libspice-client-gtk-3.0.la or
> libspice-client-glib-2.0.la whenever the corresponding symbol file
> changes.
> However _DEPENDENCIES is not the right way of handling that as it will
> disable automatic automake dependency generation
ack
- Original Message -
> "is_server" is not used in this method
> ---
> python_modules/marshal.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/python_modules/marshal.py b/python_modules/marshal.py
> index 1d38d3d..cc6cbdf 100644
> --- a/python_modules/ma
ack
- Original Message -
> ---
> common/verify.h | 144
> ++--
> 1 file changed, 89 insertions(+), 55 deletions(-)
>
> diff --git a/common/verify.h b/common/verify.h
> index 8445e3d..2f43837 100644
> --- a/common/verify.h
> +++ b/commo
---
common/verify.h | 144 ++--
1 file changed, 89 insertions(+), 55 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 8445e3d..2f43837 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,24 +1,24 @@
/* Compile-time assert-
"is_server" is not used in this method
---
python_modules/marshal.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/python_modules/marshal.py b/python_modules/marshal.py
index 1d38d3d..cc6cbdf 100644
--- a/python_modules/marshal.py
+++ b/python_modules/marshal.py
@@ -333,7
This commit adds autogeneration of a generated_client_marshallers.h
header, which is then included in client_marshallers.h
This allows to remove the SpiceMessageMarshallers struct from this file,
which has to match what the generated code expects.
---
common/Makefile.am | 6 +-
comm
We want to trigger rebuild of libspice-client-gtk-3.0.la or
libspice-client-glib-2.0.la whenever the corresponding symbol file
changes.
However _DEPENDENCIES is not the right way of handling that as it will
disable automatic automake dependency generation.
This was not causing issues mainly because
Hi
- Original Message -
>
> > From: Marc-André Lureau
> >
> > Since the switch to a container widget (gtkstack then gtkeventbox), the
> > grab may be lost when clicking on the display. Since events are treated
> > at the top level container, set widget "above-child" to trap all of them
> From: Marc-André Lureau
>
> Since the switch to a container widget (gtkstack then gtkeventbox), the
> grab may be lost when clicking on the display. Since events are treated
> at the top level container, set widget "above-child" to trap all of them
> to solve this.
>
> Fixes:
> https://bugs.f
ping
On Mon, Jun 13, 2016 at 7:11 PM, Marc-André Lureau
wrote:
> Ignoring the display area offset doesn't work nicely with virgl. Imho,
> this condition is wrong even in QXL case.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-widget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
From: Marc-André Lureau
Since the switch to a container widget (gtkstack then gtkeventbox), the
grab may be lost when clicking on the display. Since events are treated
at the top level container, set widget "above-child" to trap all of them
to solve this.
Fixes:
https://bugs.freedesktop.org/show
Avoid multiple initializations of this library.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 0445623..c139d8d 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2801,8 +2
Avoid not constant globals.
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 23 +---
server/red-channel.c| 59 -
server/red-common.h | 12 -
server/reds-private.h | 2 +-
server/re
This is not going to be modified.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 14d86ec..0445623 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3562,7 +3562,7 @@ static const EnumNames
Was used as write variable only for testing.
Avoid usage of not constant globals.
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 6 +++---
server/red-common.h | 2 +-
server/tests/basic_event_loop.c | 20 +++-
3 files changed, 15 insertions(+),
Users should not change the list of supported subtypes.
This could break the API but not the ABI.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 4 ++--
server/spice-char.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index b2438f
Not used outside the compile unit.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 28ab90a..b2438f6 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3150,7 +3150,7 @@ SPICE_GNUC_VISIBLE voi
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 3f33c32..c4ffee1 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -150,7 +150,7 @@ static pthread_mutex_t *lock_cs;
/* TODO while we can tec
Signed-off-by: Frediano Ziglio
---
server/reds.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index c139d8d..f571379 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -151,6 +151,7 @@ static pthread_mutex_t *lock_cs;
/* TODO while we can technically cr
This patch serie continue the removal of global variable
attempting to support also multiple SpiceServer instances.
Frediano Ziglio (8):
Constify event_loop_core
Make spice_server_char_device_recognized_subtypes_list static
Constify spice_server_char_device_recognized_subtypes
Make servers
Signed-off-by: Frediano Ziglio
---
server/image-encoders.h | 48
1 file changed, 48 insertions(+)
diff --git a/server/image-encoders.h b/server/image-encoders.h
index e07c036..230dd7c 100644
--- a/server/image-encoders.h
+++ b/server/image-encoder
38 matches
Mail list logo
