Re: [Spice-devel] [Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

Hi - Original Message - > Forgot to add RFC to the subject > What's the rationale? if you share the texture id, you must share the GL context too, right? Why not use a lower level dmabuf fd that can be imported by the server gl context (which is also what the protocol require anyway)?

[Spice-devel] [spice-gtk PATCH egl] egl: Fix usage of Vertex Array Object

VAO shouldn't be bound indefinitely. Move glEnableVertexAttribArray and glVertexAttribPointer to init. These settings and currently bound Vertex Buffer Object will be saved to VAO. Unbinding VAO will set these to default (unbinding them). Instead of calling these settings every frame, bind VAO

Re: [Spice-devel] [PATCH RFC 00/12] Remote Virgl support

Hi, On Po, 2016-07-18 at 16:16 +0200, Gerd Hoffmann wrote: > Hi, > > > > What is the state of the hardware supported encoding? > > > How can we pass buffers to the hardware encoder? > > > > The state here is a bit of a mess. > > One reason to pass texture instead of dma buffers is that we

Re: [Spice-devel] [PATCH RFC 00/12] Remote Virgl support

Hi, > > What is the state of the hardware supported encoding? > > How can we pass buffers to the hardware encoder? > > The state here is a bit of a mess. > One reason to pass texture instead of dma buffers is that we use gstreamer > and gstreamer for hardware acceleration uses VAAPI and one

Re: [Spice-devel] [spice-gtk PATCH v1] EGL: Update shader version to 330

SELF NACK We require OpenGL 3.0 after all Got confused by this part of code: static const EGLint ctx_att[] = { #ifdef EGL_CONTEXT_MAJOR_VERSION EGL_CONTEXT_MAJOR_VERSION, 3, #else EGL_CONTEXT_CLIENT_VERSION, 3, #endif EGL_NONE }; Still, do we really need to

Re: [Spice-devel] how we can use more effectively spice protocol alternate to windows RDP

Hello, Can i please get an update/information for my e-mail please? I am looking forward to hear about from you. Kind regards. Sabit Numan ARI Senior System Engineer [gantek_renkli_logo] Tel :+90 216 538 80 65 Mobile :+90 5322758814 Fax :+90 216 322 04 43

Re: [Spice-devel] [PATCH RFC 00/12] Remote Virgl support

> > On Fr, 2016-07-15 at 14:49 +0100, Frediano Ziglio wrote: > > This patch is an improve to last one. There are still many work > > to be done. The main reason I'm posting is to discuss the Qemu > > API changes ("Define a new interface for Qemu to pass texture" > > patch). This code add

Re: [Spice-devel] [PATCH RFC 00/12] Remote Virgl support

On Fr, 2016-07-15 at 14:49 +0100, Frediano Ziglio wrote: > This patch is an improve to last one. There are still many work > to be done. The main reason I'm posting is to discuss the Qemu > API changes ("Define a new interface for Qemu to pass texture" > patch). This code add dependency to EGL

[Spice-devel] [spice-gtk PATCH v1] EGL: Update shader version to 330

Since spice-widget-egl already requires Opengl 3.3, change shader version from 130 (OGL3.0) to 330 (OGL3.3) This change enables more advanced features in OpenGL shaders. --- src/spice-widget-egl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spice-widget-egl.c

Re: [Spice-devel] [RFC PATCH qxl-wddm-dod 02/28] Add printer class to dump debug print statements to kernel debugger output

> > From: Sandy Stutsman > > Allows the usage of Kd_IHVVIDEO_Mask to control print level while debugging > --- > qxldod/driver.cpp | 24 +++- > qxldod/driver.h | 22 ++ > 2 files changed, 41 insertions(+), 5 deletions(-) > > diff

Re: [Spice-devel] [RFC PATCH vdagent 14/16] Adding ioctl operation to update Vdagent state

> > From: Sameeh Jubran > > This patch adds new ioctl operation to Vdagent in order to update > the driver on Vdagent state. This allows the driver to know > when Vdagent is running and when it is off. > > Signed-off-by: Sameeh Jubran > Signed-off-by:

Re: [Spice-devel] [RFC PATCH vdagent 06/16] Fix include path to spice-protocol

> > Signed-off-by: Dmitry Fleytman > --- > vdagent/vdagent.vcxproj | 16 > vdservice/vdservice.vcxproj | 8 > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/vdagent/vdagent.vcxproj b/vdagent/vdagent.vcxproj > index

Re: [Spice-devel] [RFC PATCH vdagent 04/16] spice-protocol: use internal repository and bump up head to include new commits

> > --- > .gitmodules| 2 +- > spice-protocol | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitmodules b/.gitmodules > index 04211d8..2cde8ab 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -1,6 +1,6 @@ > [submodule "spice-protocol"] > path =

Re: [Spice-devel] [RFC PATCH vdagent 03/16] Add cximage submodule

> > Signed-off-by: Dmitry Fleytman > --- > .gitmodules | 3 +++ > cximage | 1 + > 2 files changed, 4 insertions(+) > create mode 16 cximage > > diff --git a/.gitmodules b/.gitmodules > index f946a4d..04211d8 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -1,3

Re: [Spice-devel] [RFC PATCH vdagent 02/16] Provide support for Windows 10 CCD API

> > From: Sandy Stutsman > > --- > Spice.props | 38 ++ > vdagent.sln | 94 ++-- > vdagent/CCD.h | 259 +++ > vdagent/D3Dkmt.h | 134 ++ > vdagent/desktop_layout.cpp| 152

Re: [Spice-devel] [RFC PATCH vdagent 01/16] Fix 'Run-Time Check Failure #2' when running a 64bit guest

> > From: Sandy Stutsman > > --- > vdagent/display_setting.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp > index 1ec7397..f5eb0d7 100644 > --- a/vdagent/display_setting.cpp > +++

[Spice-devel] [RFC PATCH vdagent 09/16] Unify debug options

Signed-off-by: Dmitry Fleytman --- vdagent/vdagent.vcxproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vdagent/vdagent.vcxproj b/vdagent/vdagent.vcxproj index 8ada675..fbd2209 100644 --- a/vdagent/vdagent.vcxproj +++ b/vdagent/vdagent.vcxproj @@ -194,7

[Spice-devel] [RFC PATCH vdagent 14/16] Adding ioctl operation to update Vdagent state

From: Sameeh Jubran This patch adds new ioctl operation to Vdagent in order to update the driver on Vdagent state. This allows the driver to know when Vdagent is running and when it is off. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman

[Spice-devel] [RFC PATCH vdagent 12/16] Unify build output directories

Signed-off-by: Dmitry Fleytman --- vdagent.sln | 42 +- vdagent/vdagent.vcxproj | 55 ++-- vdservice/vdservice.vcxproj | 56 ++--- 3 files

[Spice-devel] [RFC PATCH vdagent 11/16] Unify projects configurations

Signed-off-by: Dmitry Fleytman --- vdagent.sln | 10 +-- vdservice/vdservice.vcxproj | 170 2 files changed, 175 insertions(+), 5 deletions(-) diff --git a/vdagent.sln b/vdagent.sln index 1c29664..38a728d 100644

[Spice-devel] [RFC PATCH vdagent 01/16] Fix 'Run-Time Check Failure #2' when running a 64bit guest

From: Sandy Stutsman --- vdagent/display_setting.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp index 1ec7397..f5eb0d7 100644 --- a/vdagent/display_setting.cpp +++

[Spice-devel] [RFC PATCH vdagent 15/16] Replacing tabs with spaces

From: Sameeh Jubran Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- vdagent/CCD.h | 182 +++--- vdagent/display_configuration.cpp | 2 +-

[Spice-devel] [RFC PATCH qxl-wddm-dod 27/28] Fix source buffer mapping in PresentDisplayOnly

From: Sameeh Jubran Part of source image mapped by PresentDisplayOnly should be big enough to cover all rectangles being transferred. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 28

[Spice-devel] [RFC PATCH spice-protocol 1/1] Adding new ioctl for updating Vdagent state

From: Sameeh Jubran New ioctl for updating the driver with vdagent running state. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index

[Spice-devel] [RFC PATCH vdagent 13/16] VDAgent: Fixing primary display detachment issue

From: Sameeh Jubran After detaching the primary display (when multi monitors are connected) the detached monitor fails to reattach which leads to other issues with arbitrary resolution of attached monitors. The problem is when Vdagent marks the detached monitor as active, it

[Spice-devel] [RFC PATCH vdagent 02/16] Provide support for Windows 10 CCD API

From: Sandy Stutsman --- Spice.props | 38 ++ vdagent.sln | 94 ++-- vdagent/CCD.h | 259 +++ vdagent/D3Dkmt.h | 134 ++ vdagent/desktop_layout.cpp| 152 ++-

[Spice-devel] [RFC PATCH vdagent 10/16] Add simple build script

Signed-off-by: Dmitry Fleytman --- Tools/vs_cmdline.vbs | 23 +++ Tools/vs_run.bat | 26 ++ buildAll.bat | 14 ++ rebuildAll.bat | 13 + 4 files changed, 76 insertions(+) create mode 100644

[Spice-devel] [RFC PATCH spice-protocol 0/1] Win10 support patches

This patch adds definitions of a new QXL escape code used by Win10 QXL-WDDM-DOD/VDAgent patches Sameeh Jubran (1): Adding new ioctl for updating Vdagent state spice/qxl_windows.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.8.3.1

[Spice-devel] [RFC PATCH vdagent 03/16] Add cximage submodule

Signed-off-by: Dmitry Fleytman --- .gitmodules | 3 +++ cximage | 1 + 2 files changed, 4 insertions(+) create mode 16 cximage diff --git a/.gitmodules b/.gitmodules index f946a4d..04211d8 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,6 @@ [submodule

[Spice-devel] [RFC PATCH vdagent 07/16] Advance target platform version

Signed-off-by: Dmitry Fleytman --- vdagent/vdagent.vcxproj | 2 +- vdservice/vdservice.vcxproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/vdagent.vcxproj b/vdagent/vdagent.vcxproj index bffc8a6..80de609 100644 ---

[Spice-devel] [RFC PATCH vdagent 16/16] Fix return value of update_dev_mode_position

From: Sameeh Jubran update_dev_mode_position() should propagate error of update_mode_position() in case it fails. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- vdagent/display_configuration.cpp | 3 +-- 1 file

[Spice-devel] [RFC PATCH vdagent 08/16] Register path to cximage

Signed-off-by: Dmitry Fleytman --- vdagent/vdagent.vcxproj | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/vdagent/vdagent.vcxproj b/vdagent/vdagent.vcxproj index 80de609..8ada675 100644 --- a/vdagent/vdagent.vcxproj +++

[Spice-devel] [RFC PATCH vdagent 06/16] Fix include path to spice-protocol

Signed-off-by: Dmitry Fleytman --- vdagent/vdagent.vcxproj | 16 vdservice/vdservice.vcxproj | 8 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/vdagent/vdagent.vcxproj b/vdagent/vdagent.vcxproj index 4f6f54a..bffc8a6 100644 ---

[Spice-devel] [RFC PATCH vdagent 05/16] Add .gitignore file

Signed-off-by: Dmitry Fleytman --- .gitignore | 13 + 1 file changed, 13 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..5db05d8 --- /dev/null +++ b/.gitignore @@ -0,0 +1,13 @@ +.vs/ +Debug/

[Spice-devel] [RFC PATCH qxl-wddm-dod 05/28] Add functions called from non-pageable functions to non-paged segments

From: Sandy Stutsman Found by Driver Verifier --- qxldod/QxlDod.cpp | 55 --- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 1225f04..1b3bdf1 100755 ---

[Spice-devel] [RFC PATCH qxl-wddm-dod 08/28] Use SrcPitch when calculating size of memory to map PresentDisplayOnly

From: Sandy Stutsman Otherwise, can result in a BSOD. --- qxldod/QxlDod.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 9d13934..7b60e0c 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -3606,7

[Spice-devel] [RFC PATCH qxl-wddm-dod 23/28] Replacing <#ifdef USE_FRAMEBUFFER> with runtime logic

Framebuffer should only be used in VGA mode, however the mode is only known at runtime therefore framebuffer logic should be active when the driver is operating in vga mode only. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman ---

[Spice-devel] [RFC PATCH qxl-wddm-dod 19/28] Add simple build script

Signed-off-by: Dmitry Fleytman --- Tools/vs_cmdline.vbs| 23 +++ Tools/vs_run.bat| 26 ++ buildAll.bat| 15 +++ buildAll_NoSign.bat | 19 +++ qxldod/buildAll.bat

[Spice-devel] [RFC PATCH qxl-wddm-dod 25/28] Support future Qxl revisions

The driver determines operation mode (QXL or VGA) by checking device hardware ids including revision id field. Without this patch driver operates in VGA mode for all revisions other than 4. This patch makes driver operate in QXL mode revision 4 and newer devices. Signed-off-by: Sameeh Jubran

[Spice-devel] [RFC PATCH qxl-wddm-dod 26/28] Set SupportNonVGA in QueryAdapterInfo callback

This capability flag should be set in order to indicate to the OS that callback DxgkDdiStopDeviceAndReleasePostDisplayOwnership is supported. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 2 ++ 1 file changed, 2

[Spice-devel] [RFC PATCH qxl-wddm-dod 03/28] Set DriverStarted flag at the begining of the StartDriver function

From: Sandy Stutsman With the Driver Verifier on, a DPC generated during the call will assert if the flag is not set. Changed error handling so that if something fails, the code will break out of a do loop and reset the flag to false before returning the error status. ---

[Spice-devel] [RFC PATCH qxl-wddm-dod 16/28] Enable HW cursor support and fix handling of monochrome cursors.

From: Sandy Stutsman * Turn on enable pointer * Allow for 1bpp bitmap followed by 1bpp XOR map. --- qxldod/QxlDod.cpp | 19 +++ qxldod/QxlDod.h | 2 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp

[Spice-devel] [RFC PATCH qxl-wddm-dod 04/28] Fix Code Integrity error generated by the Drive Verifier

From: Sandy Stutsman Add MdlMappingNoExecute to MmGetSystemAddressForMDLSafe call in ExecutePresentDisplayOnly. --- qxldod/QxlDod.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 77f4f86..1225f04 100755

[Spice-devel] [RFC PATCH qxl-wddm-dod 10/28] Add arbitrary resolution and monitors_config Escape

From: Sandy Stutsman Implement the escapes for the qxl driver and add some debug output for multiple monitor support --- qxldod/QxlDod.cpp| 162 ++- qxldod/QxlDod.h | 11 ++- qxldod/include/qxl_windows.h |

[Spice-devel] [RFC PATCH qxl-wddm-dod 24/28] Fixing framebuffer usage logic

This patch fixes 2 issues: 1. Framebuffer should only be used in vga mode, therefore when QxlDevice is active FrameBufferIsActive flag shouldn't be checked; 2. FrameBufferIsActive flag should be set true on successfull frame buffer allocation only. Signed-off-by: Sameeh Jubran

[Spice-devel] [RFC PATCH qxl-wddm-dod 09/28] Remove unused notify present display only interrupt and fix interrupt mask

From: Sandy Stutsman This interrupt is used for asynchronous present calls. Fixed the interrupt mask to reflect currently used interrupts. --- qxldod/QxlDod.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/qxldod/QxlDod.cpp

[Spice-devel] [RFC PATCH qxl-wddm-dod 14/28] Comment out frame buffer mapping.

From: Sandy Stutsman WDDM DOD driver doesn't touch the frame buffer (bar0), so no reason to map in into memory. Especially as there were rare BSOD failures when the mapping failed. Leaving the code in place so it clear where the frame buffer should be mapped if we need to

[Spice-devel] [RFC PATCH qxl-wddm-dod 18/28] Unify build output directories

Signed-off-by: Dmitry Fleytman --- qxldod Package/qxldod Package.vcxproj | 81 ++-- qxldod Package/qxldod Package.vcxproj.user | 15 ++ qxldod.sln | 69 +++- qxldod/qxldod.vcxproj

[Spice-devel] [RFC PATCH qxl-wddm-dod 28/28] Fixing Move rectangles implementation

From: Sameeh Jubran As documented in MSDN, "DxgkDdiPresentDisplayOnly" should copy each "move rectangle" from a given source point in the source buffer to the destination. The current implementation dosen't take into account the shift of the given source point at all. This

[Spice-devel] [RFC PATCH qxl-wddm-dod 02/28] Add printer class to dump debug print statements to kernel debugger output

From: Sandy Stutsman Allows the usage of Kd_IHVVIDEO_Mask to control print level while debugging --- qxldod/driver.cpp | 24 +++- qxldod/driver.h | 22 ++ 2 files changed, 41 insertions(+), 5 deletions(-) diff --git

[Spice-devel] [RFC PATCH qxl-wddm-dod 00/28] Win10 support patches

This series contains the latest patches to support Windows 10. Current patches may be compiled and will work for Windows 10 only. Visual Studio 2015 with Win10 WDK is required to compile this code. This series is RFC and not intended for commit. The plan is to rebase patches on top of current

[Spice-devel] [RFC PATCH qxl-wddm-dod 20/28] Adding ioctl operation for updating Vdagent state

From: Sameeh Jubran This patch adds a new ioctl to the driver which allows Vdagent to update it's current state. This allowas the driver to know when Vdgaent is running and when it is off. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman

[Spice-devel] [RFC PATCH qxl-wddm-dod 15/28] Fix up project configuration names to be consistent. (+1 squashed commits)

From: Sandy Stutsman Squashed commits: [7336760] Fix up project configuration names to be consistent. (+1 squashed commits) Squashed commits: [b87ec38] Fix up project configuration names to be consistent. --- qxldod.sln| 20 -

[Spice-devel] [RFC PATCH qxl-wddm-dod 13/28] Set Allow Date, Time and Timestamp property for all builds/platforms

From: Sandy Stutsman Defines standarc C/CPP macros __DATE__, __TIME__, __TIMESTAMP__ --- qxldod/qxldod.vcxproj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qxldod/qxldod.vcxproj b/qxldod/qxldod.vcxproj index ddd3fe0..320748f 100755 --- a/qxldod/qxldod.vcxproj +++

[Spice-devel] [RFC PATCH qxl-wddm-dod 12/28] Use the second bar (VRAM) for qxl command buffer.

From: Sandy Stutsman --- qxldod/QxlDod.cpp | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index a328d2d..e6c4ada 100755 --- a/qxldod/QxlDod.cpp +++

[Spice-devel] [RFC PATCH qxl-wddm-dod 07/28] On power wake call the init functions before setting the vidpn to black. Otherwise, BSOD.

From: Sandy Stutsman --- qxldod/QxlDod.cpp | 66 --- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index ec960e5..9d13934 100755 --- a/qxldod/QxlDod.cpp +++

[Spice-devel] [RFC PATCH qxl-wddm-dod 06/28] Do not use virtual functions for code that must not be paged

From: Sandy Stutsman There is no way to guarantee that the static vtable will be in non-pageable memory. This patch converts 3 virtual non-pageble functions to functions private to each device class, the parent class will make an explicit call (based on a new device type

[Spice-devel] [RFC PATCH qxl-wddm-dod 21/28] Fixing mouse pointer issue when Vdagent is off

From: Sameeh Jubran The mouse pointer disappears once the Vdagent is not running, this happens due to a bug in which the function always returns true. However the client mouse pointer should be disabled when vdagent is off and enabled when it is on and thus this function

[Spice-devel] [RFC PATCH qxl-wddm-dod 22/28] Replacing tabs with spaces

From: Sameeh Jubran Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.h | 2 +- qxldod/driver.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h

[Spice-devel] [RFC PATCH qxl-wddm-dod 17/28] Remove minimum size restrict for custom resolution. (+1 squashed commits)

From: Sandy Stutsman Squashed commits: [9114b8b] Remove minimum size restrict for custom resolution. --- qxldod/QxlDod.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 3139092..74cd259 100755 ---

[Spice-devel] [RFC PATCH qxl-wddm-dod 01/28] Upgrade to Windows 10 WDK

From: Sandy Stutsman Added delete operator. Added Win10 configurations and removed older ones. --- qxldod Package/qxldod Package.vcxproj | 28 +-- qxldod.sln| 84 ++- qxldod/BaseObject.cpp | 11