From: Frediano Ziglio
The field is only used by DisplayChannelClient, not by CursorChannelClient
Signed-off-by: Frediano Ziglio
---
server/dcc-private.h | 1 +
server/dcc-send.c| 2 +-
server/dcc.c | 17 -
server/dcc.h | 2 ++
server/displ
From: Frediano Ziglio
Was just containing a RedChannelClient field
Signed-off-by: Frediano Ziglio
---
server/cache-item.tmpl.c | 2 +-
server/cursor-channel.c | 4 ++--
server/dcc-private.h | 2 +-
server/dcc.c | 10 +-
server/red-worker.h | 4
server/str
From: Frediano Ziglio
Add a few more methods and accessors so that other files don't need to
manipulate the struct members directly. Move the struct definition to a
private header which only the dcc-* files will include.
---
server/Makefile.am | 1 +
server/dcc-private.h | 62
---
server/Makefile.am | 2 +
server/cursor-channel-client.c | 120 +
server/cursor-channel-client.h | 50 +
server/cursor-channel.c| 101 --
server/cursor-channel.h| 12 +
s
---
server/display-channel.c | 2 ++
server/display-channel.h | 2 --
server/red-record-qxl.c | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 555bae2..4f52b79 100644
--- a/server/display-channel.c
+++ b/server/display
From: Frediano Ziglio
This reduce function and void to change an object in a function
which is supposed just to create a new object
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 2 +-
server/dcc.c| 3 ++-
server/red-worker.c | 2 --
server/red-worker.h | 1 -
From: Frediano Ziglio
The function was just calling another function with same parameters
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 16
server/dcc.c| 9 +
server/red-worker.c | 20
server/red-worker.h | 10 --
From: Frediano Ziglio
Make common_graphics_channel_new_client smaller
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/server/red-worker.c b/server/red-worker.c
index 9238632..f15f67a 100644
--- a/server/red
I've rebased my refactory branch to latest master and it's now time to start
getting the rest of these patches merged. Here's a fairly small set to start
with.
Frediano Ziglio (6):
Limit direct access to DisplayChannelClient
move channel window setting to config_socket
move during_target_mig
Hi,
On Thu, Aug 04, 2016 at 02:33:26PM +0200, Pavel Grunt wrote:
> Ack
Thanks, pushed:
https://cgit.freedesktop.org/spice/usbredir/commit/?id=908686a6e0ba28937532b136
>
> On Thu, 2016-08-04 at 14:15 +0200, Victor Toso wrote:
> > Pointed by coverity:
> > 17. usbredir-0.7.1/usbredirhost/usbredirh
Hi,
On Wed, Aug 03, 2016 at 09:49:52AM +0200, Christophe Fergeau wrote:
> Currently, the ConnectAsyncData instance is leaked if for example
> we trigger one codepath calling g_task_return_error(). If we
> associate it with the GTask with g_task_set_task_data(),
> this kind of leak will be avoided.
Hi,
On Thu, Aug 04, 2016 at 04:57:11PM +0200, Christophe Fergeau wrote:
> Rather than returning the whole ConnectAsyncData struct with
> g_task_return_pointer(), we can return only the GIOStream object as this
> is what we are interested in.
>
> This has the side-effect of fixing a ConnectAsyncDat
Hi,
On Mon, Jul 25, 2016 at 07:11:05PM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
>
> As far as I can tell there is no way to tell the server that the stream
> creation failed. So the client will still receive the video as a stream
> and won't be able to display it. But
Rather than returning the whole ConnectAsyncData struct with
g_task_return_pointer(), we can return only the GIOStream object as this
is what we are interested in.
This has the side-effect of fixing a ConnectAsyncData leak as after
calling g_task_propagate_pointer() the old code had ownership of t
Hi,
On Thu, Aug 04, 2016 at 05:07:35PM +0300, Dmitry Fleytman wrote:
> >>> On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
> Hi Victor,
>
> How do we configure server mouse with VDAgent running?
> >>>
> >>> You mean the host/VM configuration? What I mean by my quest
> On 4 Aug 2016, at 17:02 PM, Victor Toso wrote:
>
> Hi,
>
> On Thu, Aug 04, 2016 at 05:00:33PM +0300, Dmitry Fleytman wrote:
>>
>>> On 4 Aug 2016, at 16:44 PM, Victor Toso wrote:
>>>
>>> Hi,
>>>
>>> On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
Hi Victor,
Hi,
On Thu, Aug 04, 2016 at 05:00:33PM +0300, Dmitry Fleytman wrote:
>
> > On 4 Aug 2016, at 16:44 PM, Victor Toso wrote:
> >
> > Hi,
> >
> > On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
> >> Hi Victor,
> >>
> >> How do we configure server mouse with VDAgent running?
> >
> On 4 Aug 2016, at 16:44 PM, Victor Toso wrote:
>
> Hi,
>
> On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
>> Hi Victor,
>>
>> How do we configure server mouse with VDAgent running?
>
> You mean the host/VM configuration? What I mean by my question is that
> we can send a S
Hi,
On Thu, Aug 04, 2016 at 06:34:14AM -0700, Dmitry Fleytman wrote:
> Hi Victor,
>
> How do we configure server mouse with VDAgent running?
You mean the host/VM configuration? What I mean by my question is that
we can send a SpiceMsgcMainMouseModeRequest from client to change mouse
mode and I wo
Hi Victor,
How do we configure server mouse with VDAgent running?
Thanks,
Dmitry
On Thu, Aug 4, 2016 at 6:30 AM, Victor Toso wrote:
> Hi,
>
> On Wed, Aug 03, 2016 at 06:45:29PM +0300, Sameeh Jubran wrote:
> > This patch adds new ioctl operation to Vdagent in order to update
> > the driver on
Hi,
On Wed, Aug 03, 2016 at 06:45:29PM +0300, Sameeh Jubran wrote:
> This patch adds new ioctl operation to Vdagent in order to update
> the driver on Vdagent state. This allows the driver to know
> when Vdagent is running and when it is off.
>
> Spice supports two mouse modes: server and client.
Hi,
On Wed, Aug 03, 2016 at 09:49:53AM +0200, Christophe Fergeau wrote:
> Now that the ConnectAsyncData we need is set as GTask data, we can pass
> around the GTask rather than the ConnectAsyncData instance, and remove
> the GTask pointer from it. We can get the ConnectAsyncData from the
> GTask w
On Thu, Aug 04, 2016 at 03:13:38PM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Aug 03, 2016 at 09:49:51AM +0200, Christophe Fergeau wrote:
> > Rather than returning the whole ConnectAsyncData struct with
> > g_task_return_pointer(), we can return only the GIOStream object as this
> > is what we ar
Hi,
On Wed, Aug 03, 2016 at 09:49:51AM +0200, Christophe Fergeau wrote:
> Rather than returning the whole ConnectAsyncData struct with
> g_task_return_pointer(), we can return only the GIOStream object as this
> is what we are interested in.
> This has the side-effect of fixing a ConnectAsyncData
> > -Original Message-
> > From: cferg...@redhat.com [mailto:cferg...@redhat.com]
> > Sent: Friday, July 29, 2016 4:19 PM
> > To: Li, ZhijianX
> > Cc: gou...@codeweavers.com; Spice-devel@lists.freedesktop.org
> > Subject: Re: [Spice-devel] question: how to test the gstreamer:h264 with
> >
> -Original Message-
> From: cferg...@redhat.com [mailto:cferg...@redhat.com]
> Sent: Friday, July 29, 2016 4:19 PM
> To: Li, ZhijianX
> Cc: gou...@codeweavers.com; Spice-devel@lists.freedesktop.org
> Subject: Re: [Spice-devel] question: how to test the gstreamer:h264 with
> qemu ?
>
>
Ack
On Thu, 2016-08-04 at 14:15 +0200, Victor Toso wrote:
> Pointed by coverity:
> 17. usbredir-0.7.1/usbredirhost/usbredirhost.c:2306: leaked_storage:
> Returning without freeing "data" leaks the storage that it points to.
> # 2304|
> # usbredirhost_bulk_packet_complete(transfer->transfer);
Hi,
On Thu, Aug 04, 2016 at 08:18:19AM -0400, Frediano Ziglio wrote:
> >
> > Complain from coverity:
> > usbredir-0.7.1/usbredirhost/usbredirhost.c:1159: sign_extension:
> > Suspicious implicit sign extension: "max_packetsize" with type
> > "unsigned short" (16 bits, unsigned) is promoted in
>
On Thu, 2016-08-04 at 13:57 +0200, Victor Toso wrote:
> ERROR() is a wrapper for va_log() which takes usbredirhost* as first
> argument. We can't use it if host == NULL. Changing to fprintf to not
> fail the function silently.
>
> This was catched by coverity:
> 3. usbredir-0.7.1/usbredirhost/usb
>
> Complain from coverity:
> usbredir-0.7.1/usbredirhost/usbredirhost.c:1159: sign_extension:
> Suspicious implicit sign extension: "max_packetsize" with type
> "unsigned short" (16 bits, unsigned) is promoted in
> "pkts_per_transfer * transfer_count * max_packetsize" to type "int"
> (32 bit
On Thu, Aug 04, 2016 at 02:02:08PM +0300, Sameeh Jubran wrote:
> New ioctl for updating the driver with vdagent running state.
Please add some rationale to the commit log for having this (ie what is
going to be achieved with that escape).
For what it's worth, I don't think the QXL driver should n
Pointed by coverity:
17. usbredir-0.7.1/usbredirhost/usbredirhost.c:2306: leaked_storage:
Returning without freeing "data" leaks the storage that it points to.
# 2304|
# usbredirhost_bulk_packet_complete(transfer->transfer);
# 2305| }
# 2306|-> }
# 2307|
# 2308| static void us
>
> The Connecting and Configuring Displays (CCD) Win32 APIs
> provide more control over the desktop display setup. The CCD APIs
> move away from using Windows Graphics Device Interface (GDI)
> concepts like view name and toward Windows Display Driver Model
> (WDDM) concepts like adapter, source,
ERROR() is a wrapper for va_log() which takes usbredirhost* as first
argument. We can't use it if host == NULL. Changing to fprintf to not
fail the function silently.
This was catched by coverity:
3. usbredir-0.7.1/usbredirhost/usbredirhost.c:1412: var_deref_model:
Passing null pointer "host"
Hi,
On Thu, Aug 04, 2016 at 01:42:06PM +0200, Pavel Grunt wrote:
> On Thu, 2016-08-04 at 13:38 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Aug 04, 2016 at 08:37:02AM +0200, Pavel Grunt wrote:
> > >
> > > Hey
> > >
> > > On Wed, 2016-08-03 at 18:11 +0200, Victor Toso wrote:
> > > >
> > >
On Thu, 2016-08-04 at 13:38 +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Aug 04, 2016 at 08:37:02AM +0200, Pavel Grunt wrote:
> >
> > Hey
> >
> > On Wed, 2016-08-03 at 18:11 +0200, Victor Toso wrote:
> > >
> > > Pointed by coverity:
> > > 17. usbredir-0.7.1/usbredirhost/usbredirhost.c:2306: lea
Hi,
On Thu, Aug 04, 2016 at 08:37:02AM +0200, Pavel Grunt wrote:
> Hey
>
> On Wed, 2016-08-03 at 18:11 +0200, Victor Toso wrote:
> > Pointed by coverity:
> > 17. usbredir-0.7.1/usbredirhost/usbredirhost.c:2306: leaked_storage:
> > Returning without freeing "data" leaks the storage that it point
Hi,
On Thu, Aug 04, 2016 at 08:30:47AM +0200, Pavel Grunt wrote:
> On Wed, 2016-08-03 at 18:59 +0200, Victor Toso wrote:
> > Another coverity complain.
> Does it say where it is potentially called with null host ?
Oh, indeed it does and the complain makes sense :)
I'll drop this patch and change
The Direct3D 9 API operates on either the Windows XP display driver
model (XPDM) or the Windows Vista display driver model (WDDM), depending
on the operating system installed.
This patch implements the WDDM interface while using the CCD API to do
so. Moreover it introduces multiple monitors suppor
Diffrences from previous patch:
* Replaced LoadLibrary/FreeLibrary with GetModuleHandle.
* Replaced malloc/free with new(std::nothrow)/delete
Sameeh Jubran (2):
Introducing Windows CCD API
Implementing multiple monitors and arbitrary resolution
Makefile.am |2 +
The Connecting and Configuring Displays (CCD) Win32 APIs
provide more control over the desktop display setup. The CCD APIs
move away from using Windows Graphics Device Interface (GDI)
concepts like view name and toward Windows Display Driver Model
(WDDM) concepts like adapter, source, and target id
New ioctl for updating the driver with vdagent running state.
Signed-off-by: Sameeh Jubran
---
spice/qxl_windows.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h
index bc2ceff..6e557f7 100644
--- a/spice/qxl_windows.h
+++ b/spi
This patch adds the necessary stuctures and definitions to spice-protocol
in order to define a new ioctl fow Windows. It should be applied along with
this patch:
https://lists.freedesktop.org/archives/spice-devel/2016-August/031056.html
Sameeh Jubran (1):
Adding new ioctl for updating Vdagent
Hi Frediano,
Thanks for the review.
I'll fix the issues and resend the patch.
Regarding “underscore uppercase” issue, I have already checked the style in
other files
and that's how they did it. For example in desktop_layout.h the identifier
is "_H_DESKTOP_LAYOUT".
On Wed, Aug 3, 2016 at 7:42 PM,
44 matches
Mail list logo
