Re: [Spice-devel] [RFC] Adding support to ssh-agent-forward

2016-09-05 Thread Victor Toso
Hi, On Mon, Sep 05, 2016 at 07:50:59PM +0200, Fabiano Fidêncio wrote: > On Mon, Sep 5, 2016 at 1:36 PM, Victor Toso wrote: > > Hi, > > > > On Sat, Sep 03, 2016 at 01:49:06PM +0200, Fabiano Fidêncio wrote: > >> Howdy! > >> > >> Here is a small patch series adding support to ssh-agent-forward. > >>

Re: [Spice-devel] [PATCH qxl-wddm-dod v2 02/25] Add delete operator

2016-09-05 Thread Frediano Ziglio
> > Based on a patch by Sandy Stutsman > > Signed-off-by: Sameeh Jubran Hi, from https://github.com/flexVDI/qxl-dod/commit/a21bc96bffdd2a298b1e7f86c380bfaabbcbe7cc looks like the original author of this was Javier and not Sandy (contains also the original small typo). You should either chang

Re: [Spice-devel] [RFC] Adding support to ssh-agent-forward

2016-09-05 Thread Fabiano Fidêncio
On Mon, Sep 5, 2016 at 1:36 PM, Victor Toso wrote: > Hi, > > On Sat, Sep 03, 2016 at 01:49:06PM +0200, Fabiano Fidêncio wrote: >> Howdy! >> >> Here is a small patch series adding support to ssh-agent-forward. >> This patch series have been tested using a usable (but not 100% >> working) spice-ssh-

Re: [Spice-devel] [PATCH qxl-wddm-dod v2 00/25] Win10 support patches

2016-09-05 Thread Frediano Ziglio
> > This series contains the latest patches to support Windows 10. > > Visual Studio 2015 with Win10 WDK is required to compile this code, > Current patches may be compiled and will work for Windows 10. > > To ease the process of the reviews, those patches are avilable on: > https://github.com/d

Re: [Spice-devel] [libusb] UsbDk 1.0.15 released

2016-09-05 Thread Ларионов Даниил
> Hmm. 7.5Meg is not a "Short presentation" (not for download over a dialup > connection). Is there something smaller out there? Maybe a plain text README? The PDF is just text with no pictures or (sophisticated) diagrams. Here is the copypaste (the number represents the PDF page): 1) UsbDk at

Re: [Spice-devel] [libusb] UsbDk 1.0.15 released

2016-09-05 Thread Robert Heller
At Mon, 5 Sep 2016 14:58:16 +0300 Dmitry Fleytman wrote: > > Hi All, > > The new version of UsbDk (1.0.15) was released. > > This version contains fixes and improvements for > USB unplug events processing. > > The latest UsbDk source code available at: > http://cgit.freedesktop.org/spice/win3

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-05 Thread Frediano Ziglio
> > > When does this happen? Can you give a reproducer? > > > > > > > If you have an English client and a Linux VM just use "setxkbmap jp", on > > Windows set caps release to shift instead of caps, on Mac OS X use the > > num/scroll locks. There are just normal settings. > > Ok, I can reproduce

Re: [Spice-devel] [vdagent-win PATCH v2] Avoid to use names with reserved characters.

2016-09-05 Thread Victor Toso
Hi, On Mon, Sep 05, 2016 at 09:52:59AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Mon, Sep 05, 2016 at 12:36:26PM +0100, Frediano Ziglio wrote: > > > Some characters are reserved and should not be used in Windows > > > independently by the file system used. > > > This avoid to use paths

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-05 Thread Marc-André Lureau
Hi - Original Message - > > When does this happen? Can you give a reproducer? > > > > If you have an English client and a Linux VM just use "setxkbmap jp", on > Windows set caps release to shift instead of caps, on Mac OS X use the > num/scroll locks. There are just normal settings. Ok,

Re: [Spice-devel] [vdagent-win PATCH v2] Avoid to use names with reserved characters.

2016-09-05 Thread Frediano Ziglio
> > Hi, > > On Mon, Sep 05, 2016 at 12:36:26PM +0100, Frediano Ziglio wrote: > > Some characters are reserved and should not be used in Windows > > independently by the file system used. > > This avoid to use paths in the filename which could lead to some > > nasty hacks (like names like "..\hack

Re: [Spice-devel] [vdagent-win PATCH v2] Avoid to use names with reserved characters.

2016-09-05 Thread Victor Toso
Hi, On Mon, Sep 05, 2016 at 12:36:26PM +0100, Frediano Ziglio wrote: > Some characters are reserved and should not be used in Windows > independently by the file system used. > This avoid to use paths in the filename which could lead to some > nasty hacks (like names like "..\hack.txt"). True :)

[Spice-devel] UsbDk 1.0.15 released

2016-09-05 Thread Dmitry Fleytman
Hi All, The new version of UsbDk (1.0.15) was released. This version contains fixes and improvements for USB unplug events processing. The latest UsbDk source code available at: http://cgit.freedesktop.org/spice/win32/usbdk Latest source tarball is at: http://www.spice-space.org/download/windo

[Spice-devel] [vdagent-win PATCH v2] Avoid to use names with reserved characters.

2016-09-05 Thread Frediano Ziglio
Some characters are reserved and should not be used in Windows independently by the file system used. This avoid to use paths in the filename which could lead to some nasty hacks (like names like "..\hack.txt"). ":" is used to separate filenames from stream names and can be used to create hidden s

Re: [Spice-devel] [RFC] Adding support to ssh-agent-forward

2016-09-05 Thread Victor Toso
Hi, On Sat, Sep 03, 2016 at 01:49:06PM +0200, Fabiano Fidêncio wrote: > Howdy! > > Here is a small patch series adding support to ssh-agent-forward. > This patch series have been tested using a usable (but not 100% > working) spice-ssh-agent[0]. > > The spice-related part seems to be working fine.

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-05 Thread Frediano Ziglio
> > > > > > - Original Message - > > > > Limit the virtual keystrokes sent to the remote machine. > > > > The modifiers are synced only when the application receive or lose > > > > the focus. This reduce a lot the possible virtual keystrokes sent > > > > to the guest to synchronize the mod

Re: [Spice-devel] [vdagent-win PATCH] Avoid to use names with invalid characters.

2016-09-05 Thread Christophe Fergeau
On Mon, Sep 05, 2016 at 06:18:16AM -0400, Frediano Ziglio wrote: > > > > On Fri, Sep 02, 2016 at 04:43:53PM +0100, Frediano Ziglio wrote: > > > Check if filename contains invalid characters. > > > > Can you be more specific here about "invalid"? My guess is that these > > are characters which are

Re: [Spice-devel] [PATCH] Added debug filtering to avoid debugger to start when using in production

2016-09-05 Thread Oliver Gutierrez
This change: -** display, inputs, and cursor channels. See main.js for +** display, inputs, and cursor channels. See main.js for Is because file in repository has a trailing whitespace. It happened before in another patch I sent but now is when I finally found the reason. On Mon, Sep 5, 201

Re: [Spice-devel] [vdagent-win PATCH] Avoid to use names with invalid characters.

2016-09-05 Thread Frediano Ziglio
> > On Fri, Sep 02, 2016 at 04:43:53PM +0100, Frediano Ziglio wrote: > > Check if filename contains invalid characters. > > Can you be more specific here about "invalid"? My guess is that these > are characters which are invalid in an NTFS filesystem. > Some characters are reserved and should n

[Spice-devel] [PATCH] Added debug filtering to avoid debugger to start when using in production

2016-09-05 Thread Oliver Gutierrez
--- spiceconn.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spiceconn.js b/spiceconn.js index 903f3b0..5123e04 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -23,7 +23,7 @@ ** This is the base Javascript class for establishing and ** managing a connection to

Re: [Spice-devel] [vdagent-win PATCH] Avoid to use names with invalid characters.

2016-09-05 Thread Christophe Fergeau
On Fri, Sep 02, 2016 at 04:43:53PM +0100, Frediano Ziglio wrote: > Check if filename contains invalid characters. Can you be more specific here about "invalid"? My guess is that these are characters which are invalid in an NTFS filesystem. > Also this avoid to use paths in the filename which coul

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-05 Thread Yedidyah Bar David
On Mon, Sep 5, 2016 at 11:22 AM, Christophe Fergeau wrote: > On Sun, Sep 04, 2016 at 09:07:48AM +0300, Yedidyah Bar David wrote: >> On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote: >> >> On Tue, A

[Spice-devel] [PATCH qxl-wddm-dod v2 23/25] Fixing monitor flicker on resolution change

2016-09-05 Thread Sameeh Jubran
Passing the flag QXL_SURF_FLAG_KEEP_DATA to the new created surface causes weird flickering, thus this should be set to 0. Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp i

[Spice-devel] [PATCH qxl-wddm-dod v2 25/25] Fixing possible BSOD

2016-09-05 Thread Sameeh Jubran
Interrupts seem to arrive to the driver before the initialization phase is over (m_pHWDevice = NULL), in that case we can't handle interrupts yet. Even when m_pHWDevice isn't NULL, other fields aren't necessarly fully intialized till the StartDevice function has finished initialization, thus the f

[Spice-devel] [PATCH qxl-wddm-dod v2 22/25] Reserved must be set to 0

2016-09-05 Thread Sameeh Jubran
According to msdn, "The display miniport driver must set this value to 0" Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index faa7de4..e869578 100755 --- a/qxldod/QxlDod.c

[Spice-devel] [PATCH qxl-wddm-dod v2 07/25] On power wake call the init functions before setting the vidpn to black. Otherwise, BSOD.

2016-09-05 Thread Sameeh Jubran
--- qxldod/QxlDod.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 1c6e477..fae5c92 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -283,12 +283,16 @@ NTSTATUS QxlDod::SetPowerState(_In_ ULONG HardwareUi

[Spice-devel] [PATCH qxl-wddm-dod v2 11/25] Add arbitrary resolution and monitors_config Escape

2016-09-05 Thread Sameeh Jubran
Based on a patch by Sandy Stutsman Reviewed-by: Frediano Ziglio Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp| 177 +-- qxldod/QxlDod.h | 9 +++ qxldod/include/qxl_windows.h | 9 +++ 3 files changed, 138 insertions(+),

[Spice-devel] [PATCH qxl-wddm-dod v2 06/25] Add type enum to qxl/vga device

2016-09-05 Thread Sameeh Jubran
This patch adds type enum to the qxl/vga device class. Fixed misspelling: HwDeviceInterface Fixed misspelling: GetDxgkInterface Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 10 ++ qxldod/QxlDod.h | 25 + 2 files changed, 23 insertions(+), 12 deletions(-

[Spice-devel] [PATCH qxl-wddm-dod v2 02/25] Add delete operator

2016-09-05 Thread Sameeh Jubran
Based on a patch by Sandy Stutsman Signed-off-by: Sameeh Jubran --- qxldod/BaseObject.cpp | 11 +++ qxldod/BaseObject.h | 1 + 2 files changed, 12 insertions(+) diff --git a/qxldod/BaseObject.cpp b/qxldod/BaseObject.cpp index ac270fd..a93c040 100755 --- a/qxldod/BaseObject.cpp +++ b

[Spice-devel] [PATCH qxl-wddm-dod v2 05/25] Fix Code Integrity error generated by the Drive Verifier

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman Add MdlMappingNoExecute to MmGetSystemAddressForMDLSafe call in ExecutePresentDisplayOnly. Acked-by: Frediano Ziglio --- qxldod/QxlDod.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 3d0cd2e..dd68693 1

[Spice-devel] [PATCH qxl-wddm-dod v2 24/25] Removing unnecessary call to BlackOutScreen

2016-09-05 Thread Sameeh Jubran
This call to BlackOutScreen is not needed since the actual display surface is destroyed and created (redrawn) again. Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index a

[Spice-devel] [PATCH qxl-wddm-dod v2 15/25] Enable HW cursor support and fix handling of monochrome cursors.

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman * Turn on enable pointer * Allow for 1bpp bitmap followed by 1bpp XOR map. --- qxldod/QxlDod.cpp | 21 - qxldod/QxlDod.h | 2 +- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 39f85f2..7e2d7

[Spice-devel] [PATCH qxl-wddm-dod v2 18/25] Use frame buffer in VGA mode only

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman Framebuffer should only be used in VGA mode, as WDDM DOD driver doesn't use the frame buffer (bar0), so no reason to map in into memory. However the mode is only known at runtime therefore framebuffer logic should be active when the driver is operating in vga mode only. Ther

[Spice-devel] [PATCH qxl-wddm-dod v2 14/25] Use the second bar (VRAM) for qxl command buffer.

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman Based on a patch by Sandy Stutsman Acked-by: Frediano Ziglio Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.c

[Spice-devel] [PATCH qxl-wddm-dod v2 16/25] Remove minimum size restrict for custom resolution.

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman --- qxldod/QxlDod.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 7e2d7c1..4dcfca3 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -4512,11 +4512,10 @@ NTSTATUS QxlDevice::SetCustomDisplay(QX

[Spice-devel] [PATCH qxl-wddm-dod v2 20/25] Support future Qxl revisions

2016-09-05 Thread Sameeh Jubran
From: Dmitry Fleytman The driver determines operation mode (QXL or VGA) by checking device hardware ids including revision id field. Without this patch driver operates in VGA mode for all revisions other than 4. This patch makes driver operate in QXL mode revision 4 and newer devices. Signed-o

[Spice-devel] [PATCH qxl-wddm-dod v2 19/25] Fixing framebuffer usage logic

2016-09-05 Thread Sameeh Jubran
From: Dmitry Fleytman This patch fixes 2 issues: 1. Framebuffer should only be used in vga mode, therefore when QxlDevice is active FrameBufferIsActive flag shouldn't be checked; 2. FrameBufferIsActive flag should be set true on successfull frame buffer allocation only. Signe

[Spice-devel] [PATCH qxl-wddm-dod v2 09/25] Fix interrupt mask

2016-09-05 Thread Sameeh Jubran
Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 15037b3..d990359 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -4,6 +4,11 @@ #pragma code_seg(push) #prag

[Spice-devel] [PATCH qxl-wddm-dod v2 03/25] Add debug print macro to dump debug print statements to kernel debugger output

2016-09-05 Thread Sameeh Jubran
Signed-off-by: Sameeh Jubran --- qxldod/driver.cpp | 14 +- qxldod/driver.h | 12 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/qxldod/driver.cpp b/qxldod/driver.cpp index 4d1913c..10a24f4 100755 --- a/qxldod/driver.cpp +++ b/qxldod/driver.cpp @@ -667,

[Spice-devel] [PATCH qxl-wddm-dod v2 13/25] Code Analysis clean up

2016-09-05 Thread Sameeh Jubran
Based on a patch by Sandy Stutsman Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 473 ++ 1 file changed, 261 insertions(+), 212 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 07b6fed..ddcbe26 100755 --- a/qxldod/

[Spice-devel] [PATCH qxl-wddm-dod v2 21/25] Fixing Move rectangles implementation

2016-09-05 Thread Sameeh Jubran
As documented in MSDN, "DxgkDdiPresentDisplayOnly" should copy each "move rectangle" from a given source point in the source buffer to the destination. The current implementation dosen't take into account the shift of the given source point at all. This patch fixies the issue. Signed-off-by: Samee

[Spice-devel] [PATCH qxl-wddm-dod v2 17/25] Replacing tabs with spaces

2016-09-05 Thread Sameeh Jubran
Acked-by: Frediano Ziglio Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 94 +++ qxldod/QxlDod.h | 2 +- qxldod/driver.cpp | 2 +- 3 files changed, 49 insertions(+), 49 deletions(-) diff --git a/qxldo

[Spice-devel] [PATCH qxl-wddm-dod v2 10/25] Remove unused notify present display only interrupt

2016-09-05 Thread Sameeh Jubran
Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index d990359..5eac0a5 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -4549,12 +4549,6 @@ BOOLEAN QxlDevice::InterruptRoutine(_In_ PDXGKRNL

[Spice-devel] [PATCH qxl-wddm-dod v2 08/25] Use SrcPitch when calculating size of memory to map PresentDisplayOnly

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman Can result in a BSOD, as the image would be mapped only partially causing page faults when accessing missing piece of the image. Acked-by: Frediano Ziglio --- qxldod/QxlDod.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/

[Spice-devel] [PATCH qxl-wddm-dod v2 04/25] Set DriverStarted flag at the begining of the StartDriver function

2016-09-05 Thread Sameeh Jubran
From: Sandy Stutsman With the Driver Verifier on, a DPC generated during the call will assert if the flag is not set. Changed error handling so that if something fails, the code will break out of a do loop and reset the flag to false before returning the error status. --- qxldod/QxlDod.cpp | 11

[Spice-devel] [PATCH qxl-wddm-dod v2 00/25] Win10 support patches

2016-09-05 Thread Sameeh Jubran
This series contains the latest patches to support Windows 10. Visual Studio 2015 with Win10 WDK is required to compile this code, Current patches may be compiled and will work for Windows 10. To ease the process of the reviews, those patches are avilable on: https://github.com/daynix/qxl-wddm-do

[Spice-devel] [PATCH qxl-wddm-dod v2 01/25] Upgrade to Windows 10 WDK

2016-09-05 Thread Sameeh Jubran
* Added Windows 10 Configurations and removed older ones. * Migration to Visual Studio 2015. * Set Allow Date, Time and Timestamp property for all builds/platforms. * Fixed up project configuration names to be consistent. * unified build output directories * Simple build script added Signed-o

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-05 Thread Christophe Fergeau
On Sun, Sep 04, 2016 at 09:07:48AM +0300, Yedidyah Bar David wrote: > On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau > wrote: > > Hey, > > > > On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote: > >> On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau > >> wrote: > >> > Hey,

Re: [Spice-devel] [PATCH qxl-wddm-dod 18/26] Replacing <#ifdef USE_FRAMEBUFFER> with runtime logic

2016-09-05 Thread Sameeh Jubran
On Tue, Aug 30, 2016 at 6:54 PM, Christophe Fergeau wrote: > Shouldn't this be merged with patch 14 somehow as it is introducing > these #ifdef USE_FRAMEBUFFER in the first place? > Ture, thanks! > > Christophe > > On Tue, Aug 09, 2016 at 06:31:06PM +0300, Sameeh Jubran wrote: > > From: Dmitry F

Re: [Spice-devel] [PATCH qxl-wddm-dod 16/26] Remove minimum size restrict for custom resolution.

2016-09-05 Thread Sameeh Jubran
On Tue, Aug 30, 2016 at 6:24 PM, Frediano Ziglio wrote: > > > > From: Sandy Stutsman > > > > --- > > qxldod/QxlDod.cpp | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp > > index 3139092..74cd259 100755 > > --- a/qxldod/Qxl