Reuse and handle the return value from agent_msg_filter_process_data
---
v2 per Frediano's comments:
- clarified the commit message
- documented return values
- added fall through comment
---
server/reds.c | 69 +++
1 file changed, 31 inse
Also remove unused AGENT_MSG_FILTER_END
---
v2 per Christophe's comments:
- removed AGENT_MSG_FILTER_END
- avoid 'default' and explicitly check for the enum value
---
server/agent-msg-filter.c | 4 ++--
server/agent-msg-filter.h | 11 +--
server/reds.c | 7 +--
3 files
2016-09-13 16:43 GMT+02:00 Christophe Fergeau :
> Hey,
>
> On Tue, Sep 13, 2016 at 08:47:18AM +0200, Rob Verduijn wrote:
> > Hello,
> >
> > I'm trying to improve my spice performance on a kvm host/guest.
> > It's currently rather slow and I can see screens beeing build up, and
> > delays when drag
I haven't looked very carefully at the changes, but a few comments
about readability:
On Mon, Sep 12, 2016 at 04:32:03PM +0100, Frediano Ziglio wrote:
> This avoid to have the search the data scanning all the
> queue changing the order of these operations from O(n) to O(1).
>
> Signed-off-by: Fre
On Tue, 2016-09-13 at 17:09 +0200, Christophe Fergeau wrote:
> Hey,
>
> Looks good, couple of comments:
>
> On Mon, Sep 12, 2016 at 07:25:12PM +0200, Pavel Grunt wrote:
> > ---
> > server/agent-msg-filter.c | 4 ++--
> > server/agent-msg-filter.h | 10 +-
> > server/reds.c |
On Mon, 2016-09-12 at 12:53 +0100, Frediano Ziglio wrote:
> red-common.h included utils.h which included red-common.h
>
> Signed-off-by: Frediano Ziglio
> ---
> server/main-channel-client.c | 1 +
> server/red-channel-client.c | 1 +
> server/red-common.h | 1 -
> server/red-worker.h
Hey,
On Mon, Sep 12, 2016 at 04:32:02PM +0100, Frediano Ziglio wrote:
> This patch is intended to be merged into "RedChannelClient: store pipe
> items in a GList".
>
> GQueue improve GList for pipe usage as tail inserting/removal/access
> are O(1) instead of O(n).
> Also getting the number of ite
Hey,
Looks good, couple of comments:
On Mon, Sep 12, 2016 at 07:25:12PM +0200, Pavel Grunt wrote:
> ---
> server/agent-msg-filter.c | 4 ++--
> server/agent-msg-filter.h | 10 +-
> server/reds.c | 8 +---
> 3 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --
Hey,
On Mon, Sep 12, 2016 at 04:07:24PM +, Vans S wrote:
> I am having annoying flicker issues with the XDDM driver, where parts
> of the display that refresh (such as a moving chart) produces seizure
> inducing flickering on just that part of the display.
Have you tried disabling streaming
Hey,
Thanks for the patch, I've pushed this now.
Christophe
On Tue, Sep 13, 2016 at 02:32:19PM +0800, Li Zhijian wrote:
> 'then' -> 'than'
> 'character' -> 'characters'
>
> Signed-off-by: Li Zhijian
> ---
> docs/spice_style.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Hey,
On Tue, Sep 13, 2016 at 08:47:18AM +0200, Rob Verduijn wrote:
> Hello,
>
> I'm trying to improve my spice performance on a kvm host/guest.
> It's currently rather slow and I can see screens beeing build up, and
> delays when draging windows.
>
> It's being tunneled through openvpn, which is
Hi,
On Tue, 2016-09-13 at 15:44 +0800, Qingyun Ao wrote:
> I try to test spice with h264 on Raspberry Pi, but failed with
> error.
Please open a bug (see https://www.spice-space.org/support.html )
server should not abort. If possible attach the backtrace.
I don't know why gstreamer failed to ini
I try to test spice with h264 on Raspberry Pi, but failed with error. The
spice server is started with qemu on CentOS 7, while the spicy client is
built from spice-gtk (with gstreamer plugins including omx) on Debian
(Raspberry Pi). Can anybody give some hint?
The following are steps I used to s
13 matches
Mail list logo
