Hey Oliver,
Thanks for this patch; it broadly looks good to me, with one question:
On 09/20/2016 09:30 AM, Oliver Gutierrez wrote:
> +this.portName = new TextDecoder('utf-8').decode(new
> Uint8Array(m.name));
TextDecoder is considered experimental, and is not supported by IE.
Could
Acked-by: Jeremy White
On 09/20/2016 09:30 AM, Oliver Gutierrez wrote:
> ---
> enums.js| 2 +-
> main.js | 2 +-
> spice.html | 40
> spice_auto.html | 2 +-
> spicemsg.js | 6 +++---
> 5 files
---
server/Makefile.am| 2 +
server/smartcard-channel-client.c | 300 +++
server/smartcard-channel-client.h | 96 ++
server/smartcard.c| 360 ++
server/smartcard.h| 21 +++
Split SmartCard.
Probably some additional changes should be removed from second patch.
Frediano Ziglio (2):
Split RedCharDeviceSmartcard and SmartCardChannelClient
Convert RedChannelClient hierarchy to GObject
configure.ac| 4 +-
server/Makefile.am
Convert the RedChannelClient heirarchy into GObjects. Since the existing
constructors could fail and return NULL, I inherited the base channel
client from GInitable, which introduces a dependency on gio.
When using private structs with GObject, there's a maximum size of (I
think) 64k, which was
Not sure whether I should ACK since it's basically my patch, but
Acked-by: Jonathon Jongsma
On Thu, 2016-09-22 at 09:29 +0100, Frediano Ziglio wrote:
> Avoid to free invalid pointer.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c
Hi,
is there a android library available?
I haven't found any it yet.
Regards
Sören
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Acked-by: Jonathon Jongsma
On Thu, 2016-09-22 at 09:19 +0100, Frediano Ziglio wrote:
> These fields were added in a32e90257e834e340075e633132b52c612be4578
> as part of the multiple client support and were never used.
>
> Signed-off-by: Frediano Ziglio
On Thu, 2016-09-22 at 09:55 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Changes since v1:
> - improved comment
>
> diff --git a/server/display-channel.c
On 09/20/2016 10:05 AM, Frediano Ziglio wrote:
Keep all code to send SPICE_MSG_LIST together.
Signed-off-by: Frediano Ziglio
Ack.
---
server/dcc-send.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Changed since v1:
- moved comment
diff --git
These fields were added in a32e90257e834e340075e633132b52c612be4578
as part of the multiple client support and were never used.
Signed-off-by: Frediano Ziglio
---
server/display-channel.h | 2 --
server/red-worker.h | 1 -
2 files changed, 3 deletions(-)
Changes since
I'd like to add a comment to the commit log explaining some of the
history. It looks like these fields were added in
a32e90257e834e340075e633132b52c612be4578 as part of the multiple client
support and were never used.
Acked-by: Jonathon Jongsma
On Mon, 2016-09-19 at
On 09/21/2016 06:31 PM, Frediano Ziglio wrote:
All other options are documented using initial capital case letter.
Signed-off-by: Frediano Ziglio
Ack.
---
server/tests/replay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/tests/replay.c
Looks fine, but we could retain the warning with additional
explanation. For example (proposed):
diff --git a/server/red-worker.c b/server/red-worker.c
index 62e5d86..46f562f 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -662,8 +662,10 @@ static void
>
> Convert the RedChannelClient heirarchy into GObjects. Since the existing
> constructors could fail and return NULL, I inherited the base channel
> client from GInitable, which introduces a dependency on gio.
>
> When using private structs with GObject, there's a maximum size of (I
> think)
Acked-by: Jonathon Jongsma
On Mon, 2016-09-19 at 09:30 +0100, Frediano Ziglio wrote:
> serial was the future serial to send while last_sent_serial was the
> last sent.
> serial sent started from 1.
> To make sure sequence variable is updated just before sending the
>
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 2 ++
1 file changed, 2 insertions(+)
Changes since v1:
- improved comment
diff --git a/server/display-channel.c b/server/display-channel.c
index 8b949a2..a85c091 100644
--- a/server/display-channel.c
+++
On Mon, 2016-09-19 at 09:30 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 108e69b..3290565 100644
> ---
Avoid to free invalid pointer.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
Changes since v2:
- better encapsulation (Jonathon)
I have the sensation that Quic code is broken.. but this is
not
Acked-by: Jonathon Jongsma
On Wed, 2016-09-21 at 16:31 +0100, Frediano Ziglio wrote:
> All other options are documented using initial capital case letter.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/replay.c | 2 +-
> 1 file changed, 1
20 matches
Mail list logo