Re: [Spice-devel] [NSIS 1/3] Add Windows 10 support

On Mon, Jan 23, 2017 at 7:14 PM, Christophe Fergeau wrote: > On Mon, Jan 23, 2017 at 12:02:05PM +0200, Yedidyah Bar David wrote: >> From: Christophe Fergeau >> >> This requires WinVer from nsis 3.01. >> At the moment, the qxl-wddm-dod driver on the

Re: [Spice-devel] Dreadful performance under Windows 10 Enterprise 2016 LTSB

On Tue, Jan 24, 2017 at 12:18:37AM +0200, George Diamantopoulos wrote: > So, I guess I'm stuck waiting for iGVT-g to go upstream then :-(. Another option would be to try and see if a kvm-based VM behaves better, but I assume you cannot do that. Or if you are lucky, as the driver used on KVM is

Re: [Spice-devel] Dreadful performance under Windows 10 Enterprise 2016 LTSB

So, I guess I'm stuck waiting for iGVT-g to go upstream then :-(. On 19 January 2017 at 15:20, Christophe Fergeau wrote: > On Tue, Jan 10, 2017 at 10:06:33AM +0200, George Diamantopoulos wrote: > > Hello all, > > > > I'm trying out qxl-dod in a new installation, and

Re: [Spice-devel] [NSIS 1/3] Add Windows 10 support

On Mon, Jan 23, 2017 at 12:02:05PM +0200, Yedidyah Bar David wrote: > From: Christophe Fergeau > > This requires WinVer from nsis 3.01. > At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the > latest one from >

Re: [Spice-devel] [NSIS 2/3] Update to latest virtio-win/vdagent releases

On Mon, Jan 23, 2017 at 12:02:06PM +0200, Yedidyah Bar David wrote: > From: Christophe Fergeau > > Change-Id: I36da80234227c610a246d33c867204241b32e536 > Signed-off-by: Christophe Fergeau > --- > ovirt-guest-tools-iso.spec.in | 6 +++--- > version.txt

Re: [Spice-devel] [NSIS] 3 patches

Hey, On Mon, Jan 23, 2017 at 12:08:46PM +0200, Yedidyah Bar David wrote: > Hi all, > > I now posted here 3 patches. First two were posted by Christophe a few > weeks ago, and I amended them a bit, last is to add virtio-rng. Some details about what you "amended a bit" would have been useful ;)

Re: [Spice-devel] [PATCH v6 5/5] Do endian swapping.

On Mon, 23 Jan 2017 15:40:57 +0100 Christophe de Dinechin wrote: > On 23/01/2017 14:53, Michal Suchanek wrote: > > This allows running big endian and little endian guest side by side > > using cut & paste between them. > > > > There is a general design idea that swapping

Re: [Spice-devel] [spice-server] stat: Silence gcc warning

On 01/23/2017 12:39 PM, Frediano Ziglio wrote: On 01/20/2017 05:30 PM, Christophe Fergeau wrote: Initializing 'node' to NULL silences this warning: stat-file.c: In function 'stat_file_add_node': stat-file.c:180:15: error: 'node' may be used uninitialized in this function

Re: [Spice-devel] [PATCH v6 5/5] Do endian swapping.

On 23/01/2017 14:53, Michal Suchanek wrote: This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between

Re: [Spice-devel] [spice-server] stat: Silence gcc warning

On Mon, Jan 23, 2017 at 05:39:25AM -0500, Frediano Ziglio wrote: > > > > On 01/20/2017 05:30 PM, Christophe Fergeau wrote: > > > Initializing 'node' to NULL silences this warning: > > > > > > stat-file.c: In function 'stat_file_add_node': > > > stat-file.c:180:15: error: 'node' may be used

Re: [Spice-devel] [PATCH spice-gtk v3 6/6] usb-device-widget: Do not use GtkVBox

On Mon, 2017-01-23 at 14:54 +0100, Victor Toso wrote: > Hi, > > On Fri, Jan 20, 2017 at 04:53:53PM +0100, Pavel Grunt wrote: > > --- > >  src/usb-device-widget.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c >

[Spice-devel] [PATCH v6 4/5] vdagentd: early return on bad message size

From: Victor Toso The payload size for each message should be the size of the expected struct or bigger when it contain arrays of no fixed size. This patch creates the vdagent_message_min_size[] static array with the expected size for each message so we can check on

[Spice-devel] [PATCH v6 2/5] udscs: don't pass message type strings into the server.

The message types are defined by the protocol so the same array is always passed into the server anyway. So define the array size to be the number of message types and just use the array and limit directly in udscs. If somebody adds a message type in the future the array will contain some friendly

[Spice-devel] [PATCH v6 3/5] Move mouse-specific handling out of virtio_port_read_complete

Move some mouse-specific code from the start of virtio_port_read_complete to a separate helper as is the case with other message types. Signed-off-by: Michal Suchanek --- src/vdagentd/vdagentd.c | 43 --- 1 file changed, 24

[Spice-devel] [PATCH v6 1/5] Quiet uninitialized variable warning.

Signed-off-by: Michal Suchanek --- v2: - use g_return_if_reached --- src/vdagentd/vdagentd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index a1faf23..e2d6159 100644 --- a/src/vdagentd/vdagentd.c +++

[Spice-devel] [PATCH v6 5/5] Do endian swapping.

This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between vdagent and vdagentd is guest-specific and in native

[Spice-devel] [PATCH v6 0/5] Endian swapping and misc cleanup patches

The "Do endian swapping" patch makes it possible to run spice agent on big endian guest. Due to emulated hardware and client software limitation the only features tested are mouse events and clipboard forwarding. The remaining patches are cleanups resulting from discussion of the endian swapping

Re: [Spice-devel] [PATCH spice-gtk v3 6/6] usb-device-widget: Do not use GtkVBox

Hi, On Fri, Jan 20, 2017 at 04:53:53PM +0100, Pavel Grunt wrote: > --- > src/usb-device-widget.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c > index b394499..747887c 100644 > --- a/src/usb-device-widget.c > +++

Re: [Spice-devel] [PATCH spice-gtk v3 5/6] gtk: Avoid deprecated gdk_pointer_grab

Hi, On Fri, Jan 20, 2017 at 04:53:52PM +0100, Pavel Grunt wrote: > --- > src/spice-widget.c | 24 ++-- > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index aa03556..9d5ac3d 100644 > --- a/src/spice-widget.c > +++

Re: [Spice-devel] [PATCH spice-gtk v3 4/6] gtk: Avoid deprecated gdk_keyboard_grab

Hi, On Fri, Jan 20, 2017 at 04:53:51PM +0100, Pavel Grunt wrote: I think it doesn't hurt to include that gdk_keyboard_grab() was deprecated in 3.0 and gdk_device_grab() should be used but this one was also deprecated for gdk_seat_grab() in 3.20 :) > --- > src/spice-widget.c | 18

Re: [Spice-devel] [PATCH spice-gtk v3 3/6] gtk: Use gdk_device_warp

Hi, On Fri, Jan 20, 2017 at 04:53:50PM +0100, Pavel Grunt wrote: > gdk_display_warp_pointer has been deprecated since Gtk 3.0 Acked-by: Victor Toso > --- > src/spice-widget.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk v3 1/6] gtk: Use gdk_cursor_new_from_name

Hi, On Mon, Jan 23, 2017 at 12:40:47PM +0100, Pavel Grunt wrote: > On Mon, 2017-01-23 at 12:27 +0100, Victor Toso wrote: > > > -return gdk_cursor_new(GDK_BLANK_CURSOR); > > > +if (!gdk_window) > > > +return NULL; > > > > We might want to warn before returning NULL > > > I did it

Re: [Spice-devel] [PATCH spice-gtk v3 2/6] gtk: Use gdk_window_get_device_position

Hi, On Fri, Jan 20, 2017 at 04:53:49PM +0100, Pavel Grunt wrote: > gdk_window_get_pointer has been deprecated since Gtk 3.0 > --- > src/spice-widget.c | 54 > -- > 1 file changed, 44 insertions(+), 10 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk v3 1/6] gtk: Use gdk_cursor_new_from_name

On Mon, 2017-01-23 at 12:27 +0100, Victor Toso wrote: > Hi, > > On Fri, Jan 20, 2017 at 04:53:48PM +0100, Pavel Grunt wrote: > > Create the cursor when the widget is realized > > > > Also make the cursor work under Wayland > > Please include the information regarding the gdk_cursor_new() being

Re: [Spice-devel] [PATCH spice-gtk v3 1/6] gtk: Use gdk_cursor_new_from_name

Hi, On Fri, Jan 20, 2017 at 04:53:48PM +0100, Pavel Grunt wrote: > Create the cursor when the widget is realized > > Also make the cursor work under Wayland Please include the information regarding the gdk_cursor_new() being deprecated since 3.16 too. > --- > src/spice-widget.c | 24

[Spice-devel] [NSIS] Install virtio-rng driver

Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 Bug-Url: https://bugzilla.redhat.com/1398560 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 8 1 file changed, 8 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index

Re: [Spice-devel] [spice-server] stat: Silence gcc warning

> > On 01/20/2017 05:30 PM, Christophe Fergeau wrote: > > Initializing 'node' to NULL silences this warning: > > > > stat-file.c: In function 'stat_file_add_node': > > stat-file.c:180:15: error: 'node' may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > >

[Spice-devel] [NSIS] 3 patches

Hi all, I now posted here 3 patches. First two were posted by Christophe a few weeks ago, and I amended them a bit, last is to add virtio-rng. Also pushed them to ovirt gerrit, and jenkins built successfully: http://jenkins.ovirt.org/job/ovirt-wgt_master_create-rpms-fc24-x86_64_created/14/

[Spice-devel] [NSIS 1/3] Add Windows 10 support

From: Christophe Fergeau This requires WinVer from nsis 3.01. At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the latest one from https://www.spice-space.org/download/windows/qxl-wddm-dod/ Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5

[Spice-devel] [NSIS 3/3] Install virtio-rng driver

Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 Bug-Url: https://bugzilla.redhat.com/1398560 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 15 +++ 1 file changed, 15 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index

Re: [Spice-devel] [spice-gtk v2] Move spicy tools to its own folder

Hi, On Fri, Jan 20, 2017 at 04:20:12PM -0600, Jonathon Jongsma wrote: > On Thu, 2017-01-19 at 16:34 +0100, Victor Toso wrote: > > On Thu, Jan 19, 2017 at 03:27:21PM +0100, Christophe Fergeau wrote: > > > Acked-by: Christophe Fergeau > > > > > > unless someone else thinks