Re: [Spice-devel] [spice-server v2 09/10] sound: Turn {Playback, Record}ChannelClient into GObjects

> > This is in preparation for making them inherit from RedChannelClient. > Doing it in one go would result in a very huge commit, so this commit > starts by turning these into GObjects, while still using a > DummyChannelClient instance for sending the data. > > Based on a patch from Frediano

[Spice-devel] [nsis] Fix driver path for win2k*

On the virtio-win ISO, the win2k* drivers are in a path of the form '2k*', while the installer is looking for them in 'w2k*', and thus failing. This commit fixes the various paths This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1416533 and

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 05:59:44PM +, Daniel P. Berrange wrote: > On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote: > > > > > > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > > > > > > > When used with QEMU at least, both SPICE and VNC live in the

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote: > > > > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > > > > > When used with QEMU at least, both SPICE and VNC live in the same port > > > > range (5900+). It is thus not entirely uncommon for a user to

Re: [Spice-devel] [PATCH] qxl-wddm-dod: Fix for screen not shown after driver disabled

We use this name as video mode that the driver uses and passes to the BasicVideo is expected to be supported by BIOS or UEFI. "VGA Compatible" sounds like conformance to some specification, which is not a case. Name of the field "SupportNonVGA" related to this feature is also inclear and seems at

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

> > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > > > When used with QEMU at least, both SPICE and VNC live in the same port > > > range (5900+). It is thus not entirely uncommon for a user to mistakenly > > > connect to a SPICE server with a VNC client, or vica-verca.

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > When used with QEMU at least, both SPICE and VNC live in the same port > > range (5900+). It is thus not entirely uncommon for a user to mistakenly > > connect to a SPICE server with a VNC client, or vica-verca. > > > >

Re: [Spice-devel] [spice-server v2 06/10] sound: Remove code from spice_server_record_get_samples()

> > On Tue, Jan 24, 2017 at 08:51:00AM -0500, Frediano Ziglio wrote: > > > > > > It's ok to remove it because ? > > > > > > Based on a patch from Frediano Ziglio > > > > > > Signed-off-by: Christophe Fergeau > > > > Because I hate polling and was

Re: [Spice-devel] [PATCH] qxl-wddm-dod: Fix for screen not shown after driver disabled

> > https://bugzilla.redhat.com/show_bug.cgi?id=1411340 > Do not set SupportNonVGA field for device rev.4 and higher. > Then the class driver will not call miniport's procedure > StopDeviceAndReleasePostDisplayOwnership upon PnP stop. > QXL device modes are not compatible with VGA ones; the >

Re: [Spice-devel] [spice-server v2 06/10] sound: Remove code from spice_server_record_get_samples()

On Tue, Jan 24, 2017 at 08:51:00AM -0500, Frediano Ziglio wrote: > > > > It's ok to remove it because ? > > > > Based on a patch from Frediano Ziglio > > > > Signed-off-by: Christophe Fergeau > > Because I hate polling and was removed time ago :) > >

Re: [Spice-devel] [spice-server v2 03/10] sound: Add sanity checks in snd_{playback, record}_send

On Tue, Jan 24, 2017 at 08:45:35AM -0500, Frediano Ziglio wrote: Hey, > > diff --git a/server/sound.c b/server/sound.c > > index 1f88149..a53ebcd 100644 > > --- a/server/sound.c > > +++ b/server/sound.c > > @@ -851,6 +851,9 @@ static void snd_playback_send(void* data) > > return; > >

[Spice-devel] [PATCH] qxl-wddm-dod: Fix for screen not shown after driver disabled

https://bugzilla.redhat.com/show_bug.cgi?id=1411340 Do not set SupportNonVGA field for device rev.4 and higher. Then the class driver will not call miniport's procedure StopDeviceAndReleasePostDisplayOwnership upon PnP stop. QXL device modes are not compatible with VGA ones; the driver in this

Re: [Spice-devel] [PATCH spice v2] Avoid a 'missing braces around initializer' warning.

> > Static variables don't need initializers to be 0. > > Signed-off-by: Jeremy White > --- > v2: Simply remove the initializer; the whole structure, if static, should be > zero. > --- > server/tests/replay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Spice-devel] [spice-server v2 02/10] sound: Implement snd_channel_config_socket

On Tue, Jan 24, 2017 at 08:41:00AM -0500, Frediano Ziglio wrote: > > > > This is in preparation for switching SndChannelClient into a proper > > RedChannelClient. The prototype of the new helper matches what is > > expected from the RedChannel::config_socket vfunc. > > > > To be able to achieve

[Spice-devel] Graceful failure when VNC client connects to SPICE server ?

When used with QEMU at least, both SPICE and VNC live in the same port range (5900+). It is thus not entirely uncommon for a user to mistakenly connect to a SPICE server with a VNC client, or vica-verca. When connecting to VNC server with a SPICE client, you quickly get an error. This is because

Re: [Spice-devel] [PATCH] Update repository for virt-viewer

On Wed, Jan 25, 2017 at 12:34:10PM -0200, Eduardo Lima (Etrunko) wrote: > Virt-viewer recently moved from fedorahosted.org to pagure.io > https://www.redhat.com/archives/virt-tools-list/2017-January/msg00070.html > > Signed-off-by: Eduardo Lima (Etrunko) > --- >

[Spice-devel] [PATCH] Update repository for virt-viewer

Virt-viewer recently moved from fedorahosted.org to pagure.io https://www.redhat.com/archives/virt-tools-list/2017-January/msg00070.html Signed-off-by: Eduardo Lima (Etrunko) --- modulesets/spice.xml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Spice-devel] [RFC PATCH 01/16] OT: small optimization

> > No commit log, no real-world performance measurements showing this is needed, > ... > Not much Before: textdata bss dec hex filename 549352 9041384 551640 86ad8 (TOTALS) After: textdata bss dec hex filename 549247 9041384 551535

Re: [Spice-devel] [spice-server v3 1/2] stat: Silence gcc warning

On Tue, Jan 24, 2017 at 10:43:42AM -0500, Frediano Ziglio wrote: > > > > Initializing 'node' to NULL silences this warning: > > > > stat-file.c: In function 'stat_file_add_node': > > stat-file.c:180:15: error: 'node' may be used uninitialized in this function > > [-Werror=maybe-uninitialized] >

Re: [Spice-devel] [RFC PATCH 02/16] OT: style

> > On Wed, Jan 25, 2017 at 12:42:25PM +, Frediano Ziglio wrote: > > --- > > server/red-channel.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/server/red-channel.c b/server/red-channel.c > > index f2a35f3..15f556c 100644 > > --- a/server/red-channel.c > >

Re: [Spice-devel] [RFC PATCH 02/16] OT: style

On Wed, Jan 25, 2017 at 12:42:25PM +, Frediano Ziglio wrote: > --- > server/red-channel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/server/red-channel.c b/server/red-channel.c > index f2a35f3..15f556c 100644 > --- a/server/red-channel.c > +++

Re: [Spice-devel] [RFC PATCH 01/16] OT: small optimization

No commit log, no real-world performance measurements showing this is needed, ... On Wed, Jan 25, 2017 at 12:42:24PM +, Frediano Ziglio wrote: > --- > server/char-device.c | 6 -- > server/char-device.h | 6 +- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git

Re: [Spice-devel] [RFC PATCH 2/2] Add a message to control guest streaming

> > Allows server to tell codec and start/stop the streaming > --- > spice/stream-device.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/spice/stream-device.h b/spice/stream-device.h > index 3ecbee4..e8a32ac 100644 > --- a/spice/stream-device.h > +++

Re: [Spice-devel] [RFC PATCH 1/2] EXPERIMENTAL protocol to send streams to server

> > --- > spice/Makefile.am | 1 + > spice/stream-device.h | 79 > +++ > 2 files changed, 80 insertions(+) > create mode 100644 spice/stream-device.h > > diff --git a/spice/Makefile.am b/spice/Makefile.am > index a54ae89..4f9a607 100644 >

[Spice-devel] [RFC PATCH 0/2] New protocol to send a video stream from guest to host

This protocol is required by https://lists.freedesktop.org/archives/spice-devel/2017-January/035171.html. It's used for a specific new character device. It consists of a simple header and a couple of messages. Frediano Ziglio (2): EXPERIMENTAL protocol to send streams to server Add a

[Spice-devel] [RFC PATCH 2/2] Add a message to control guest streaming

Allows server to tell codec and start/stop the streaming --- spice/stream-device.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/spice/stream-device.h b/spice/stream-device.h index 3ecbee4..e8a32ac 100644 --- a/spice/stream-device.h +++ b/spice/stream-device.h @@ -51,6 +51,8 @@

[Spice-devel] [RFC PATCH 1/2] EXPERIMENTAL protocol to send streams to server

--- spice/Makefile.am | 1 + spice/stream-device.h | 79 +++ 2 files changed, 80 insertions(+) create mode 100644 spice/stream-device.h diff --git a/spice/Makefile.am b/spice/Makefile.am index a54ae89..4f9a607 100644 --- a/spice/Makefile.am

Re: [Spice-devel] Dreadful performance under Windows 10 Enterprise 2016 LTSB

> So, I guess I'm stuck waiting for iGVT-g to go upstream then :-(. I think would be quite a pity. The fact that our environments are mostly KVM should not avoid trying to fix Xen environment. First: can you do a video and share somehow? One of the difference between KVM and Xen is the

[Spice-devel] [RFC PATCH 15/16] char-device: Do not stop and clear interface on reset

This allows less hard reset to the device so can be used to reset the device into a clean but working state. Signed-off-by: Frediano Ziglio --- server/char-device.c | 2 -- server/reds.c| 6 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Spice-devel] [RFC PATCH 13/16] stream-channel: Support client connection/disconnection

On new client we must restart the stream so new clients can receive correct data without having to wait next full screen (which on idle screen could take ages). On disconnection we should tell the guest to stop streaming not wasting resources to stream not needed data. Signed-off-by: Frediano

[Spice-devel] [RFC PATCH 12/16] stream-channel: Allows to register callback to get new stream request

The channel needs to communicate when it receive a new stream request from the guest. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 11 +++ server/stream-channel.h | 6 ++ 2 files changed, 17 insertions(+) diff --git a/server/stream-channel.c

[Spice-devel] [RFC PATCH 16/16] stream-device: Start supporting resetting device when close/open on guest

When guest close the device the host device has to be reset too. This make easier to restart the guest device which can happen in case of reboot, agent issues or if we want to update the agent. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 26

[Spice-devel] [RFC PATCH 14/16] stream-channel: Do not show an empty blank screen on start

Start showing something when we have a surface and stream instead of showing a blank screen which is now not useful. Was useful for debugging purposes to understand that the new channel was sending messages correctly to client and client could handle them. Signed-off-by: Frediano Ziglio

[Spice-devel] [RFC PATCH 00/16] Add a streaming channel to stream video data from guest to clients.

This series of patches introduce a new DisplayChannel (in the protocol terminology) and a new guest device implementation which allows the guest to send streamed data to clients. This will allow GPU passthrough card to stream data using a new "stream" guest agent. This guest agent is required as

[Spice-devel] [RFC PATCH 11/16] stream-channel: Allows not fixed size

Remove the fixed size stream and support any display size. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/server/stream-channel.c b/server/stream-channel.c

[Spice-devel] [RFC PATCH 08/16] stream-device: Create channel for stream device

So can be used by the device to communicate with the clients. Signed-off-by: Frediano Ziglio --- server/stream-device.c | 20 1 file changed, 20 insertions(+) diff --git a/server/stream-device.c b/server/stream-device.c index 96a6b92..35ba3f0 100644 ---

[Spice-devel] [RFC PATCH 07/16] stream-channel: Start implementing DisplayChannel properly

Handle messages from clients. Some some messages to clients. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 48 ++ 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/server/stream-channel.c

[Spice-devel] [RFC PATCH 10/16] stream-device: Handle streaming data from device to channel

Handle stream data from device sending to the channel. Channel will forward to clients as proper DisplayChannel messaging creating and destroying the channel stream as needed. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 105

[Spice-devel] [RFC PATCH 09/16] stream-channel: Implements initialization

Send proper messages to client to see the display. Currently a blank display will be showed to the clients connecting. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-)

[Spice-devel] [RFC PATCH 04/16] stream-device: Add device to handle streaming

Add a stub device in guest. The aim of this device is make possible for the guest to send a stream through a DisplayChannel (in the sense of protocol channel). This stub allows the guest to send some data and you can see some debug lines of data arrived on host logs. Signed-off-by: Frediano

[Spice-devel] [RFC PATCH 01/16] OT: small optimization

--- server/char-device.c | 6 -- server/char-device.h | 6 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/server/char-device.c b/server/char-device.c index c40ed65..7c86f76 100644 --- a/server/char-device.c +++ b/server/char-device.c @@ -976,12 +976,6 @@ SpiceServer*

[Spice-devel] [RFC PATCH 05/16] stream-device: Start parsing new protocol from guest - TODO

Parse the data sent from the guest to the streaming device. TODO remove some FIXME TODO handle protocol errors Signed-off-by: Frediano Ziglio --- server/stream-device.c | 80 +-- 1 file changed, 77 insertions(+), 3 deletions(-) diff

[Spice-devel] [RFC PATCH 03/16] char-device: Allows to handle port events from any char device

From spice_server_port_event API you can send port events to any char device. Although currently this is used only for "port" devices implemented in spicevmc.c this will allow to support such events using different objects. Signed-off-by: Frediano Ziglio ---

[Spice-devel] [RFC PATCH 06/16] stream-channel: Write a really base channel to implement the streaming

Currently only compile, not used and not much sense Signed-off-by: Frediano Ziglio --- server/Makefile.am | 2 +- server/stream-channel.c | 194 +- server/stream-channel.h | 52 +++- 3 files changed, 248 insertions(+)

[Spice-devel] [RFC PATCH 02/16] OT: style

--- server/red-channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index f2a35f3..15f556c 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -682,8 +682,7 @@ int red_channel_pipes_new_add_push(RedChannel

Re: [Spice-devel] stat file and API

On 01/24/2017 07:54 PM, Frediano Ziglio wrote: Hi, Hi Frediano, as it looks somebody is touching this part of code. Looking at APIs (stat-file.h) we have these functions: RedStatFile *stat_file_new(unsigned int max_nodes); void stat_file_free(RedStatFile *stat_file); void

Re: [Spice-devel] [ovirt-users] Video performance

Hi, where would I have to add this: I mean which file or is it somewhere in the config ? I found something that sounds like it would do the same. What do you think about that ? http://www.jieyung.com/en/faq.asp?newsclassid=377=508 It's written for 3.5 and does something