Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi Christophe,    Yes, #2 may be incorrect. Let's change it to the following:     2. Qxl loaded (early in guest boot) -- Guest send max n monitor with one enabled  -- client can have n window, but only one enabled ("n" depends on the guest)     This won't affect #3, where client get correct

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi Jonathon,    Let's talk about a real computer. There're multiple ways that I can "turn off" a monitor, including 1. Turn off power of monitor; 2. Unplug the display cable; 3. Switch off the corresponding display in the guest OS.     Now on the VM, when I close a window of virt-viewer, what

Re: [Spice-devel] Windows drivers for virgl?

Hello, Any ideas on how we can help with the process? we are willing to help. :) --- Armin ranjbar On Thu, Feb 23, 2017 at 10:56 AM, Vadim Rozenfeld wrote: > On Tue, 2017-02-21 at 12:41 +0200, Yan Vugenfirer wrote: > > Hi Benrooz, > > > > I am adding Vadim to the

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi Daimon, thanks for the input. On Thu, 2017-02-23 at 05:03 +, Daimon Wang wrote: > Hi, >     I'll go against the fix as I don't see any reason for the > "assumption". > >     Let's split the question into 2 things, max monitor number and > which monitor is enabled.  >     The max monitor

[Spice-devel] [PATCH spice-server] style: Specify boolean style convention

Signed-off-by: Frediano Ziglio --- docs/spice_style.txt | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index cd874df..99c8390 100644 --- a/docs/spice_style.txt +++ b/docs/spice_style.txt @@ -47,10

[Spice-devel] [PATCH spice-server] style: Group together indentation sections

Signed-off-by: Frediano Ziglio --- docs/spice_style.txt | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index 99c8390..eb0e30e 100644 --- a/docs/spice_style.txt +++ b/docs/spice_style.txt @@

Re: [Spice-devel] [spice-gtk v1 5/7] gtk-session: move atom's debug

Hi, On Thu, Feb 23, 2017 at 02:19:31PM +0100, Pavel Grunt wrote: > On Thu, 2017-02-23 at 14:15 +0100, Pavel Grunt wrote: > > On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > > > From: Victor Toso > > > > > > We already iterate in all n_atoms and get its name with > >

Re: [Spice-devel] [spice-gtk v1 7/7] gtk-session: move variables to internal scope

On Thu, Feb 23, 2017 at 02:26:09PM +0100, Pavel Grunt wrote: > On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > >  src/spice-gtk-session.c | 7 --- > >  1 file changed, 4

Re: [Spice-devel] [spice-gtk v1 1/7] gtk-session: check if retrieving clipboard data failed

Hi, On Thu, Feb 23, 2017 at 02:01:56PM +0100, Pavel Grunt wrote: > On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > > From: Victor Toso > > > > In case of failure, > > Do we want to know about the failure? Not sure. Maybe a debug message? I did not check how this can

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi, On 01/31/2017 10:24 PM, Jonathon Jongsma wrote: When a guest is rebooted, the QXL driver gets unloaded at some point in the reboot process. When the driver is unloaded, the spice server sets a single flag to FALSE: RedWorker::driver_cap_monitors_config. This flag indicates whether the

Re: [Spice-devel] [spice-gtk v1 2/7] gtk-session: initialize array without memset

On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso Acked-by: Pavel Grunt > --- >  src/spice-gtk-session.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff

Re: [Spice-devel] [spice-gtk v1 7/7] gtk-session: move variables to internal scope

On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- >  src/spice-gtk-session.c | 7 --- >  1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/spice-gtk-session.c

Re: [Spice-devel] [spice-gtk v1 5/7] gtk-session: move atom's debug

On Thu, 2017-02-23 at 14:15 +0100, Pavel Grunt wrote: > On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > > From: Victor Toso > > > > We already iterate in all n_atoms and get its name with > > gdk_atom_name(), let's move the debug there too; > > > > As

Re: [Spice-devel] [spice-gtk v1 5/7] gtk-session: move atom's debug

On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > From: Victor Toso > > We already iterate in all n_atoms and get its name with > gdk_atom_name(), let's move the debug there too; > > As spice_util_get_debug() uses g_once(), this should not impact > performance or

Re: [Spice-devel] [spice-gtk v1 1/7] gtk-session: check if retrieving clipboard data failed

On Wed, 2017-02-22 at 14:11 +0100, Victor Toso wrote: > From: Victor Toso > > In case of failure, Do we want to know about the failure? > the GdkAtom *atoms will be set to NULL. > Including this check to an early return. > > Signed-off-by: Victor Toso

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

On Thu, Feb 23, 2017 at 11:58:53AM +0100, Christophe de Dinechin wrote: > Hi Daimon, > > > In a real system, the connected monitors and their EDID provide information > to the OS about how many monitors are available, the resolution they support, > etc. That information is persistent for the

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi Daimon, In a real system, the connected monitors and their EDID provide information to the OS about how many monitors are available, the resolution they support, etc. That information is persistent for the OS, i.e. it is still there even when the OS is down. Where do you plan to get the