Re: [Spice-devel] [PATCH spice-gtk] Use macro for more precise widget debugs

On Thu, 2017-03-09 at 22:00 +0100, Victor Toso wrote: > On Thu, Mar 09, 2017 at 04:51:24PM +0100, Pavel Grunt wrote: > > SPICE_DISPLAY_DEBUG provides information about channel and monitor > > ids. > > Yes, makes sense to me. We have CHANNEL_DEBUG, I would go with > DISPLAY_DEBUG instead. Okay >

Re: [Spice-devel] [PATCH spice-gtk] main: Handle disabled file transfer

Hi, On Fri, Mar 10, 2017 at 08:20:53AM +0100, Pavel Grunt wrote: > File transfer can be disabled by the server or agent, it is > signalized by the VD_AGENT_CAP_FILE_XFER_DISABLED set. > > Do not try to transfer files when the capability is set. > > Resolves: rhbz#1373725 > --- > Sending to show

[Spice-devel] [PATCH spice-gtk] main: Handle disabled file transfer

File transfer can be disabled by the server or agent, it is signalized by the VD_AGENT_CAP_FILE_XFER_DISABLED set. Do not try to transfer files when the capability is set. Resolves: rhbz#1373725 --- Sending to show usage of the cap proposed in:

Re: [Spice-devel] [PATCH spice-space-pages] Add documentation for using multiple monitors

On Thu, 2017-03-09 at 18:30 +0200, Snir Sheriber wrote: > Hi, > > > On 03/09/2017 02:17 PM, Frediano Ziglio wrote: > > > --- > > > Here's some additional documentation on multiple monitors. I have > > > a few open > > > questions about the driver memory stuff. > > > > > >  

Re: [Spice-devel] [PATCH spice-space-pages] Add documentation for using multiple monitors

On Thu, 2017-03-09 at 07:17 -0500, Frediano Ziglio wrote: > > --- > > Here's some additional documentation on multiple monitors. I have a > > few open > > questions about the driver memory stuff. > > > >  multiple-monitors.rst | 201 > >  ++ > >  1

Re: [Spice-devel] [PATCH spice-gtk] Use macro for more precise widget debugs

On Thu, Mar 09, 2017 at 04:51:24PM +0100, Pavel Grunt wrote: > SPICE_DISPLAY_DEBUG provides information about channel and monitor ids. Yes, makes sense to me. We have CHANNEL_DEBUG, I would go with DISPLAY_DEBUG instead. > In case of multimonitor it helps to identify the owner of the debug >

[Spice-devel] [PATCH] Amend the previous commit to change the "XXX" comments

--- Here's a possible patch to be squashed with the exclude_region documentation patch to avoid using 'XXX' comments as Frediano suggested. I also removed a couple of things where I didn't think they added much useful information. server/display-channel.c | 45

Re: [Spice-devel] [PATCH spice-server] test-leaks: Checks some leaks using TLS

[Resend, apparently stayed in my outbox for a few days] > On 7 Mar 2017, at 17:56, Frediano Ziglio wrote: > > Verify stuff are freed correctly (like TLS context). > The different PKI file required are generated with > base values (localhost and rsa 1024). I went back into

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add .gitlab-ci.yml

Hi, On Thu, 2017-03-09 at 18:17 +0200, Snir Sheriber wrote: > --- >  .gitlab-ci.yml | 14 ++ >  1 file changed, 14 insertions(+) >  create mode 100644 .gitlab-ci.yml > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > new file mode 100644 > index 000..0f63c67 > --- /dev/null > +++

Re: [Spice-devel] [spice-server 3/4] reds-stream: Use true/false instead of TRUE/FALSE

On Thu, Mar 09, 2017 at 09:15:53AM -0500, Frediano Ziglio wrote: > > > > --- > > server/reds-stream.c | 30 +++--- > > 1 file changed, 15 insertions(+), 15 deletions(-) > > > > diff --git a/server/reds-stream.c b/server/reds-stream.c > > index 096ed43..50a8584 100644 > >

[Spice-devel] [spice-server v2] RedChannelClient: Mark some private data as bool

Some RedChannelClient data members were marked as int when they only hold booleans. Signed-off-by: Christophe Fergeau --- Changes since v1: - use bool instead of gboolean - changed one preexisting gboolean ('destroying') server/red-channel-client.c | 10 +- 1 file

Re: [Spice-devel] [PATCH spice-space-pages] Add documentation for using multiple monitors

Hi, On 03/09/2017 02:17 PM, Frediano Ziglio wrote: --- Here's some additional documentation on multiple monitors. I have a few open questions about the driver memory stuff. multiple-monitors.rst | 201 ++ 1 file changed, 201 insertions(+)

[Spice-devel] [PATCH spice-gtk 1/2] Add .gitlab-ci.yml

--- .gitlab-ci.yml | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 000..0f63c67 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,14 @@ +image: fedora:latest + +before_script: + -

[Spice-devel] [PATCH spice-gtk 2/2] Adding test to gitlab ci

Disable some capabilities and try make --- .gitlab-ci.yml | 16 1 file changed, 16 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0f63c67..af74633 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -12,3 +12,19 @@ makecheck: - ./autogen.sh - make -

[Spice-devel] [PATCH spice-gtk] Use macro for more precise widget debugs

SPICE_DISPLAY_DEBUG provides information about channel and monitor ids. In case of multimonitor it helps to identify the owner of the debug message. --- I am currently looking at a bug related to not working keyboard grab in multimonitor env, and it was not clear which widget is receiving focus

Re: [Spice-devel] [spice-server 4/4] RedChannelClient: Mark some private data as boolean

On Thu, Mar 09, 2017 at 09:16:51AM -0500, Frediano Ziglio wrote: > > > > --- > > server/red-channel-client.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/server/red-channel-client.c b/server/red-channel-client.c > > index 63877ab..47583c7 100644 > > ---

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

> > On Thu, Mar 09, 2017 at 03:32:44PM +0200, Uri Lublin wrote: > > > > > I forgot, can it use "http_proxy" or not? > > > > > > > > I'm not sure what you mean here. > > > > Is it if something like the following would work > > > > export SPICE_PROXY="http_proxy://10.0.15.50:3128" > > > > > >

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

On Thu, Mar 09, 2017 at 03:32:44PM +0200, Uri Lublin wrote: > > > > I forgot, can it use "http_proxy" or not? > > > > > > I'm not sure what you mean here. > > > Is it if something like the following would work > > > export SPICE_PROXY="http_proxy://10.0.15.50:3128" > > > > export

Re: [Spice-devel] [spice-server 4/4] RedChannelClient: Mark some private data as boolean

> > --- > server/red-channel-client.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/red-channel-client.c b/server/red-channel-client.c > index 63877ab..47583c7 100644 > --- a/server/red-channel-client.c > +++ b/server/red-channel-client.c > @@ -133,15

Re: [Spice-devel] [spice-server 3/4] reds-stream: Use true/false instead of TRUE/FALSE

> > --- > server/reds-stream.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/server/reds-stream.c b/server/reds-stream.c > index 096ed43..50a8584 100644 > --- a/server/reds-stream.c > +++ b/server/reds-stream.c > @@ -202,12 +202,12 @@

[Spice-devel] [PATCH spice-server v2] Use bool rather than int return values when appropriate

From: Christophe Fergeau This commit changes all functions returning TRUE/FALSE from having an 'int' return value to 'bool'. This way it's obvious that such a function is not going to return anything else than TRUE or FALSE. --- server/char-device.c | 20

Re: [Spice-devel] [spice-server 1/4] Remove stdbool.h include from .c files

> > It's already included in red-common.h Acked-by: Frediano Ziglio All headers are still self independent. This patch does not follow "include if used directly" but I personally don't mind for system headers. > --- > server/inputs-channel.c | 1 - >

Re: [Spice-devel] [spice (stable)] Resending volume value on migration

On Thu, Mar 09, 2017 at 08:30:38AM -0500, Frediano Ziglio wrote: > > I'm glad that you asked :) > > > > On my first tests I was only paying attention to the volume bar in the > > client and in the guest. After migration I would see it move in the > > client with 0.12.4 but not with 0.13.3. > > > >

[Spice-devel] [spice-server 2/4] Use bool rather than int return values when appropriate

This commit changes all functions returning TRUE/FALSE from having an 'int' return value to 'bool'. This way it's obvious that such a function is not going to return anything else than TRUE or FALSE. --- server/char-device.c | 20 +-- server/char-device.h

[Spice-devel] [spice-server 3/4] reds-stream: Use true/false instead of TRUE/FALSE

--- server/reds-stream.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/server/reds-stream.c b/server/reds-stream.c index 096ed43..50a8584 100644 --- a/server/reds-stream.c +++ b/server/reds-stream.c @@ -202,12 +202,12 @@ bool

[Spice-devel] [spice-server 4/4] RedChannelClient: Mark some private data as boolean

--- server/red-channel-client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red-channel-client.c b/server/red-channel-client.c index 63877ab..47583c7 100644 --- a/server/red-channel-client.c +++ b/server/red-channel-client.c @@ -133,15 +133,15 @@ struct

[Spice-devel] [spice-server 1/4] Remove stdbool.h include from .c files

It's already included in red-common.h --- server/inputs-channel.c | 1 - server/red-parse-qxl.c | 1 - server/red-record-qxl.c | 1 - server/red-replay-qxl.c | 1 - server/reds-stream.h| 1 - server/reds.c | 1 - 6 files changed, 6 deletions(-) diff --git a/server/inputs-channel.c

Re: [Spice-devel] [PATCH 0/2] documentation of drawable tree

> > These are the patches that haven't been merged yet. The first patch is fairly > straightforward and has only a couple minor changes from the previous review. > The second patch has some improvements as well, even though nobody really > reviewed it last time. It still contains a lot of open

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

On 03/09/2017 03:09 PM, Christophe Fergeau wrote: On Thu, Mar 09, 2017 at 03:03:58PM +0200, Uri Lublin wrote: On 03/06/2017 04:48 PM, Christophe Fergeau wrote: On Mon, Mar 06, 2017 at 09:42:13AM -0500, Frediano Ziglio wrote: Signed-off-by: Uri Lublin --- proxy.rst | 102

Re: [Spice-devel] [spice (stable)] Resending volume value on migration

> > Hey, > > On Tue, Mar 07, 2017 at 10:42:09AM -0500, Frediano Ziglio wrote: > > > Hi, > > > > > > On Tue, Feb 28, 2017 at 11:18:15AM +0100, Victor Toso wrote: > > > > Hi, > > > > > > > > On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote: > > > > > > > > > > > > From: Victor

Re: [Spice-devel] Alignment of data within spice packets

Hi, On Thu, Mar 09, 2017 at 12:46:09PM +0100, Christophe de Dinechin wrote: > > > On 8 Mar 2017, at 22:16, Victor Toso wrote: > > > > Hi, > > > > On Wed, Mar 08, 2017 at 07:21:15PM +0100, Christophe de Dinechin wrote: > >> I have several errors like this: > >> > >>

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

On Thu, Mar 09, 2017 at 03:03:58PM +0200, Uri Lublin wrote: > On 03/06/2017 04:48 PM, Christophe Fergeau wrote: > > On Mon, Mar 06, 2017 at 09:42:13AM -0500, Frediano Ziglio wrote: > > > > > > > > Signed-off-by: Uri Lublin > > > > --- > > > > proxy.rst | 102 > > > >

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

On 03/06/2017 04:48 PM, Christophe Fergeau wrote: On Mon, Mar 06, 2017 at 09:42:13AM -0500, Frediano Ziglio wrote: Signed-off-by: Uri Lublin --- proxy.rst | 102 ++ 1 file changed, 102 insertions(+) create mode

Re: [Spice-devel] [spice-space-pages PATCH] Spice Proxy documentation

On 03/06/2017 04:42 PM, Frediano Ziglio wrote: Signed-off-by: Uri Lublin --- proxy.rst | 102 ++ 1 file changed, 102 insertions(+) create mode 100644 proxy.rst diff --git a/proxy.rst b/proxy.rst new file mode

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

Hi Pavel, Yes, in my configuration I have already set: vram: 64MB streaming mode='filter' <-- I have tested with 'all" as well with the same results image compression='auto_glz' When I connect through the Internet or from my home wi-fi (54Mbps) In the logs I can see "LOW BANDWITH" detected, and

Re: [Spice-devel] [PATCH spice-space-pages] Add documentation for using multiple monitors

> --- > Here's some additional documentation on multiple monitors. I have a few open > questions about the driver memory stuff. > > multiple-monitors.rst | 201 > ++ > 1 file changed, 201 insertions(+) > create mode 100644 multiple-monitors.rst

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

On Thu, 2017-03-09 at 06:43 -0500, Frediano Ziglio wrote: > > > It's not a small addition. Usually wifi has a much higher latency > then wired lan. For comparison on lan usually you > have 2-4 ms latency while on wifi 80-100 ms unless you have powerful > and quite idle network infrastructure >

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

Hi! Thanks a lot for your clarifications. Nevertheless, I thought that spice protocol was suited to work over the Internet. Is it right? Is there any document/advice for configuring spice server (or kvm guest) to work properly over the Internet? Thanks a lot! 2017-03-09 12:43 GMT+01:00

Re: [Spice-devel] Alignment of data within spice packets

> On 8 Mar 2017, at 22:16, Victor Toso wrote: > > Hi, > > On Wed, Mar 08, 2017 at 07:21:15PM +0100, Christophe de Dinechin wrote: >> I have several errors like this: >> >> spice-channel.c:1923:12: error: cast from 'uint8_t *' (aka 'unsigned char >> *') to >>

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

> It's not a small addition. Usually wifi has a much higher latency then wired > lan. For comparison on lan usually you > have 2-4 ms latency while on wifi 80-100 ms unless you have powerful and > quite idle network infrastructure > (but still higher than wired). > Unfortunately currently the

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

It's not a small addition. Usually wifi has a much higher latency then wired lan. For comparison on lan usually you have 2-4 ms latency while on wifi 80-100 ms unless you have powerful and quite idle network infrastructure (but still higher than wired). Unfortunately currently the protocol

Re: [Spice-devel] [spice-server 1/3] reds-stream: Introduce reds_stream_set_no_delay() helper

On Thu, Mar 09, 2017 at 06:12:47AM -0500, Frediano Ziglio wrote: > > > > That's a good point, red-socket.c? Though if it grows too close to > > GSocket, I'd probably just use that. > > > > They are so low level that even the red prefix is strong (at least in > file name). > Maybe just

Re: [Spice-devel] [spice-server 1/3] reds-stream: Introduce reds_stream_set_no_delay() helper

> > On Thu, Mar 09, 2017 at 05:37:06AM -0500, Frediano Ziglio wrote: > > > > > > The code to enable/disable on a TCP socket is duplicated in multiple > > > places in the code base, this commit replaces this duplicated code with > > > a helper in RedsStream. > > > --- > > > > > > This patch has

Re: [Spice-devel] [spice-server 1/3] reds-stream: Introduce reds_stream_set_no_delay() helper

On Thu, Mar 09, 2017 at 05:37:06AM -0500, Frediano Ziglio wrote: > > > > The code to enable/disable on a TCP socket is duplicated in multiple > > places in the code base, this commit replaces this duplicated code with > > a helper in RedsStream. > > --- > > > > This patch has already been sent a

Re: [Spice-devel] [PATCH 1/2] DisplayChannel: start documenting drawable tree

> > The code that manages pending QXL Drawable operations is fairly complex > and difficult to understand. This is an attempt to start documenting > that code to save time when we have to work on this code in the future. > --- > server/display-channel.c | 80 >

Re: [Spice-devel] [PATCH spice-server 2/2] red-channel-client: Use bool type for config_socket

> > I intend to send > https://cgit.freedesktop.org/~teuf/spice/commit/?h=vfuncs=b393b04acbdb43 > real soon now (need to test it), which is much more extensive than what > is done in this patch, do you mind postponing/dropping this version? > Don't mind, the most important stuff was vfunc

Re: [Spice-devel] [spice-server 1/3] reds-stream: Introduce reds_stream_set_no_delay() helper

> > The code to enable/disable on a TCP socket is duplicated in multiple > places in the code base, this commit replaces this duplicated code with > a helper in RedsStream. > --- > > This patch has already been sent a few times with various variations around > bool/gboolean/true/TRUE. I'd like

Re: [Spice-devel] [RFC] Spice channels compression

> On 7 Mar 2017, at 16:37, Frediano Ziglio > wrote: > >>> >>> >>> Hi Snir, >>> >>> Regarding compression and another topic recently evoked, endianness, I >>> wonder >>> if encoding using LEB128 had been discussed? >>> >>> LEB128 encodes any

[Spice-devel] [spice-gtk v2] gstaudio: Remove fixed TODOs about setting record volume

From: Victor Toso * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume This was fixed by 1b564bfb8b0db in gst-plugins-bad, see: https://bugzilla.gnome.org/show_bug.cgi?id=744383 * pulsesrc doesn't support volume property, it's all coming! This was fixed by

[Spice-devel] [spice-gtk v1] gstaudio: Remove fixed TODOs about setting record volume

From: Victor Toso * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume This was fixed by 1b564bfb8b0db in gst-plugins-bad, see: https://bugzilla.gnome.org/show_bug.cgi?id=744383 * pulsesrc doesn't support volume property, it's all coming! This was fixed by

Re: [Spice-devel] Is it possible to build without vala?

On Thu, 2017-03-09 at 09:11 +0100, Christophe Fergeau wrote: > On Wed, Mar 08, 2017 at 01:17:08PM -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > In the configure.ac, the default for vala is “no”. But if I > > > build without it, > > > I get: > > > > > >

Re: [Spice-devel] Is it possible to build without vala?

On Wed, Mar 08, 2017 at 01:17:08PM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > In the configure.ac, the default for vala is “no”. But if I build without > > it, > > I get: > > > > make[4]: Entering directory `/Users/ddd/Work/spice/spice-gtk/src/controller' > > > >