Re: [Spice-devel] [spice-server v2 2/3] tests: Port test-qxl-parsing to GTest

> > On Fri, Mar 17, 2017 at 02:10:22PM +0100, Pavel Grunt wrote: > > > + > > > +static void deinit_qxl_surface(QXLSurfaceCmd *qxl) > > > +{ > > > +free((void *)qxl->u.surface_create.data); > > > > `make syntax-check` is failing because of this > > Ah, thanks, it also fails after this patch

Re: [Spice-devel] [PATCH 02/12] qxl-wddm-dod: Use rendering offload thread

> Side note: the .gitattribute in that project seems all wrong. It makes source > files a pain to edit under Linux or macOS. Why not mark the source files as > text? To avoid cr/lf conversions. If you can find good flags to make git Windows and git Unix to work you are welcome. Got mad to try,

Re: [Spice-devel] [spice-server v2 2/3] tests: Port test-qxl-parsing to GTest

On Fri, Mar 17, 2017 at 02:10:22PM +0100, Pavel Grunt wrote: > > + > > +static void deinit_qxl_surface(QXLSurfaceCmd *qxl) > > +{ > > +free((void *)qxl->u.surface_create.data); > > `make syntax-check` is failing because of this Ah, thanks, it also fails after this patch because of the

Re: [Spice-devel] [spice-space-pages PATCH] home.rst: s/and and/and/

> > > > On 19 Mar 2017, at 15:22, Uri Lublin wrote: > > > > Reported-by: romulous75 (on IRC) > > > > Signed-off-by: Uri Lublin > > --- > > home.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/home.rst b/home.rst > > index

Re: [Spice-devel] [spice-space-pages PATCH] home.rst: s/and and/and/

> On 19 Mar 2017, at 15:22, Uri Lublin wrote: > > Reported-by: romulous75 (on IRC) > > Signed-off-by: Uri Lublin > --- > home.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/home.rst b/home.rst > index 7bef988..36fe95e 100644 >

Re: [Spice-devel] [spice-space-pages PATCH v2] Spice Proxy documentation

> On 19 Mar 2017, at 13:54, Uri Lublin wrote: > > Signed-off-by: Uri Lublin > > > Changes since v1: > 1. :modified: was removed from the top > 2. 2 ways to set up proxy -- are numbered > 3. Comment added to not use http_proxy > 4. "Installation (Fedora)"

Re: [Spice-devel] [PATCH 02/12] qxl-wddm-dod: Use rendering offload thread

Side note: the .gitattribute in that project seems all wrong. It makes source files a pain to edit under Linux or macOS. Why not mark the source files as text? > On 20 Mar 2017, at 13:08, Frediano Ziglio > wrote: > >> >> Instead of sending

Re: [Spice-devel] [PATCH 02/12] qxl-wddm-dod: Use rendering offload thread

> > Instead of sending drawable commands down from presentation > callback, collect drawables objects and pass them to dedicated > thread for processing. This reduce peak load of presentation > callback. > > Signed-off-by: Javier Celaya > Signed-off-by: Yuri

Re: [Spice-devel] [spice-space-pages PATCH] home.rst: s/and and/and/

> > Reported-by: romulous75 (on IRC) > > Signed-off-by: Uri Lublin Acked-by: Frediano Ziglio > --- > home.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/home.rst b/home.rst > index 7bef988..36fe95e 100644 > --- a/home.rst >