Re: [Spice-devel] Allocation style in QXLDOD

2017-03-23 Thread Vadim Rozenfeld
On Tue, 2017-03-21 at 19:12 +0100, Christophe de Dinechin wrote: > Hi Vadim, > > > Looking at the code for QxlDod.cpp, I see allocations that look like > this: > > 5c52e50b (Vadim Rozenfeld 2014-09-02 17:36:27 +1000 > 3169) m_ModeNumbers = reinterpret_cast (new > (PagedPool)  BYT

Re: [Spice-devel] [spice-gtk v1] channel-webdav: include comment about message handling

2017-03-23 Thread Marc-André Lureau
Hi - Original Message - > From: Victor Toso > > Channel-webdav does not handle any other message besides > SPICE_MSG_SPICEVMC_DATA it wants to let SpiceVmcInputStream handle it > and the same to deal when sending data to the server with > SPICE_MSGC_SPICEVMC_DATA using SpiceVmcOutputStre

Re: [Spice-devel] [PATCH spice-gtk v2 1/2] widget: Extend mouse mode debug

2017-03-23 Thread Frediano Ziglio
> > --- > I always forget the enum value and have to check the spice-protocol > --- > src/spice-widget.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index f548b0d..ef320eb 100644 > --- a/src/spice-widget.c > +

[Spice-devel] [PATCH spice-gtk v2 2/2] Use macro for more precise widget debugs

2017-03-23 Thread Pavel Grunt
DISPLAY_DEBUG provides information about channel and monitor ids. In case of multimonitor it helps to identify the owner of the debug message. --- I keep DISPLAY_DEBUG = SPICE_DEBUG, we can resolve the SPICE_DEBUG vs spice_debug later --- src/spice-widget-egl.c | 20 +-- src/spice-widget

[Spice-devel] [PATCH spice-gtk v2 1/2] widget: Extend mouse mode debug

2017-03-23 Thread Pavel Grunt
--- I always forget the enum value and have to check the spice-protocol --- src/spice-widget.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index f548b0d..ef320eb 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c

[Spice-devel] [spice-gtk v1] channel-webdav: include comment about message handling

2017-03-23 Thread Victor Toso
From: Victor Toso Channel-webdav does not handle any other message besides SPICE_MSG_SPICEVMC_DATA it wants to let SpiceVmcInputStream handle it and the same to deal when sending data to the server with SPICE_MSGC_SPICEVMC_DATA using SpiceVmcOutputStream. The other Spice messages are dealt in it

Re: [Spice-devel] [PATCH spice-server v4 1/3] build-sys: Add option to enable additional checks

2017-03-23 Thread Pavel Grunt
Ack, Pavel On Thu, 2017-03-23 at 12:17 +, Frediano Ziglio wrote: > This to enable extra test. > This option is used also in different projects. > > Signed-off-by: Frediano Ziglio > --- >  configure.ac | 5 + >  1 file changed, 5 insertions(+) > > Changes since v3: > - changed help descri

Re: [Spice-devel] [PATCH spice-server v4 3/3] ci: Make possible to execute additional expensive checks on GitLab

2017-03-23 Thread Pavel Grunt
On Thu, 2017-03-23 at 12:17 +, Frediano Ziglio wrote: > Install missing GStreamer plugins and enable these checks. > Currently the checks are enabled if valgrind is used. > This as the main "makecheck" job uses address sanitizer which > detects some leaks due to some Glib usage. Valgrind checks

[Spice-devel] [PATCH spice-server v4 2/3] Some automatic check on video encoders

2017-03-23 Thread Frediano Ziglio
Stress a bit video encoders. This check different combination of - encoder type; - image formats; - image clipping (encoding partial frames); - handling frames split into chunks. Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt --- configure.ac| 1 + server/tests/Makefile.a

[Spice-devel] [PATCH spice-server v4 1/3] build-sys: Add option to enable additional checks

2017-03-23 Thread Frediano Ziglio
This to enable extra test. This option is used also in different projects. Signed-off-by: Frediano Ziglio --- configure.ac | 5 + 1 file changed, 5 insertions(+) Changes since v3: - changed help description diff --git a/configure.ac b/configure.ac index 9fd455b..6ec2652 100644 --- a/config

[Spice-devel] [PATCH spice-server v4 3/3] ci: Make possible to execute additional expensive checks on GitLab

2017-03-23 Thread Frediano Ziglio
Install missing GStreamer plugins and enable these checks. Currently the checks are enabled if valgrind is used. This as the main "makecheck" job uses address sanitizer which detects some leaks due to some Glib usage. Valgrind checks uses some suppression for some Glib leaks so they will work corre

Re: [Spice-devel] [PATCH spice-vdagent] vdagentd: Handle VD_AGENT_CLIPBOARD_RELEASE

2017-03-23 Thread Victor Toso
Hi, On Thu, Mar 23, 2017 at 12:26:28PM +0100, Pavel Grunt wrote: > In fact do nothing but avoid a runtime warning > vdagent_message_clipboard_from_le: code should not be reached > > Regression since 99d9d3583143aef7143ec986cebe2980fdeeb776 I would say that this warning was introduced _hash_ or (

Re: [Spice-devel] [PATCH spice-server] reds-stream: Small syscall optimisation

2017-03-23 Thread Christophe Fergeau
On Mon, Mar 13, 2017 at 09:51:26AM +, Frediano Ziglio wrote: > Handle single chunk writev as normal write. > From some test more than 60% of the times writev is called with 1 as > counter. We can easily and very cheaply turn this call to a simpler > write avoiding the need to pass the array to

[Spice-devel] [PATCH spice-vdagent] vdagentd: Handle VD_AGENT_CLIPBOARD_RELEASE

2017-03-23 Thread Pavel Grunt
In fact do nothing but avoid a runtime warning vdagent_message_clipboard_from_le: code should not be reached Regression since 99d9d3583143aef7143ec986cebe2980fdeeb776 --- src/vdagentd/vdagentd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd

Re: [Spice-devel] [PATCH 06/12] qxl-wddm-dod: Registry-based control over VSync

2017-03-23 Thread Christophe Fergeau
On Sun, Mar 12, 2017 at 10:45:03AM +0200, Yuri Benditovich wrote: > Registry override of default behavior (disabling when enabled > by default) provided for support and troubleshooting only in case > this feature affects specific user. I'm afraid it's still unclear to me why vsync support is requi

Re: [Spice-devel] [spice-server] build-sys: Alphabetically order source file list

2017-03-23 Thread Christophe Fergeau
On Thu, Mar 23, 2017 at 07:03:30AM -0400, Frediano Ziglio wrote: > > > > The list of source files to build was in a random order, this commit > > orders them alphabetically. > > I won't say exactly random, more of a result of history :-) > (random is fine) > > Ack for me but some people could ar

Re: [Spice-devel] [spice-server] build-sys: Alphabetically order source file list

2017-03-23 Thread Frediano Ziglio
> > The list of source files to build was in a random order, this commit > orders them alphabetically. I won't say exactly random, more of a result of history :-) (random is fine) Ack for me but some people could argue about git blame results. Frediano > --- > server/Makefile.am | 100 >

Re: [Spice-devel] [spice-server] tests/pki: Use CA/certificate valid until 2048

2017-03-23 Thread Frediano Ziglio
> > As pointed out by danpb, tests/pki/server-cert.pem is only valid until > Fri Nov 29 15:51:44 UTC 2019 > > This changes tests/pki/server-cert.pem and tests/pki/ca-cert.pem to be > valid until 2048. These certificates were generated using the > instructions on https://www.spice-space.org/page/S

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

2017-03-23 Thread Frediano Ziglio
> > On Fri, Mar 10, 2017 at 09:22:13AM -0500, Frediano Ziglio wrote: > > > > > > This fixes make distcheck > > > --- > > > This applies on top of the make check-valgrind patch I sent earlier, I > > > can > > > rebase on top of git master if needed > > > > > > Christophe > > > > > > server/test

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

2017-03-23 Thread Christophe Fergeau
On Fri, Mar 10, 2017 at 09:22:13AM -0500, Frediano Ziglio wrote: > > > > This fixes make distcheck > > --- > > This applies on top of the make check-valgrind patch I sent earlier, I can > > rebase on top of git master if needed > > > > Christophe > > > > server/tests/Makefile.am | 7 ++- > >

[Spice-devel] [spice-server] build-sys: Alphabetically order source file list

2017-03-23 Thread Christophe Fergeau
The list of source files to build was in a random order, this commit orders them alphabetically. --- server/Makefile.am | 100 ++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index dfa0d6a

[Spice-devel] [spice-server] tests/pki: Use CA/certificate valid until 2048

2017-03-23 Thread Christophe Fergeau
As pointed out by danpb, tests/pki/server-cert.pem is only valid until Fri Nov 29 15:51:44 UTC 2019 This changes tests/pki/server-cert.pem and tests/pki/ca-cert.pem to be valid until 2048. These certificates were generated using the instructions on https://www.spice-space.org/page/SSLConnection Th

Re: [Spice-devel] Spice optimization over WAN

2017-03-23 Thread Oscar Segarra
Hi, thanks a lot! streaming-video= In this case, which is the difference between all, filter? and if I set streaming-video=off, how does spice transport the video? Thanks a lot. 2017-03-23 10:34 GMT+01:00 Christophe Fergeau : > On Thu, Mar 23, 2017 at 09:41:52AM +0100, Pavel Grunt wrote: > >

Re: [Spice-devel] Spice optimization over WAN

2017-03-23 Thread Christophe Fergeau
On Thu, Mar 23, 2017 at 09:41:52AM +0100, Pavel Grunt wrote: > Hi, > > On Thu, 2017-03-23 at 09:32 +0100, Oscar Segarra wrote: > > Hi,  > > > > Anybody knows if there is more information about theese parameters? > > streaming-video= Set video streams detection and > > (lossy) compression (default

Re: [Spice-devel] Spice optimization over WAN

2017-03-23 Thread Pavel Grunt
Hi, On Thu, 2017-03-23 at 09:32 +0100, Oscar Segarra wrote: > Hi,  > > Anybody knows if there is more information about theese parameters? > streaming-video= Set video streams detection and > (lossy) compression (default=filter) Spice server will do its best to detect video streams and it will cr

Re: [Spice-devel] Spice optimization over WAN

2017-03-23 Thread Oscar Segarra
Hi, Anybody knows if there is more information about theese parameters? - streaming-video= Set video streams detection and (lossy) compression (default=filter) - playback-compression= Set playback compression, using the CELT algorithm (default=on) Thanks a lot 2017-03-16 17:22 GMT+0

Re: [Spice-devel] [PATCH spice-server v3 1/2] build-sys: Add option to enable additional checks

2017-03-23 Thread Pavel Grunt
Hi, On Wed, 2017-03-22 at 16:20 +, Frediano Ziglio wrote: > This to enable extra test. > This option is used also in different projects. I would remove the last sentence > > Signed-off-by: Frediano Ziglio > --- >  configure.ac | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/co

Re: [Spice-devel] [PATCH spice-server v3 2/2] Some automatic check on video encoders

2017-03-23 Thread Pavel Grunt
On Wed, 2017-03-22 at 16:20 +, Frediano Ziglio wrote: > Stress a bit video encoders. > This check different combination of > - encoder type; > - image formats; > - image clipping (encoding partial frames); > - handling frames split into chunks. > > Signed-off-by: Frediano Ziglio Acked-by: Pav