Hi Jakub,
you should also list these in the comment describing the data type of
the result (the data type here is "none" but the comment lists results
covered by VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS) - sorry I forgot to
mention that in the first review.
Besides that it looks good to me.
>
> I’m looking at logging functions in log.c, and I wonder why we disable
> logging only at the spice_logger level.
>
> There is a test like this in spice_logger:
>
> if (glib_debug_level != 0) {
> if ((log_level & G_LOG_LEVEL_MASK) > glib_debug_level)
> return; // do
I’m looking at logging functions in log.c, and I wonder why we disable logging
only at the spice_logger level.
There is a test like this in spice_logger:
if (glib_debug_level != 0) {
if ((log_level & G_LOG_LEVEL_MASK) > glib_debug_level)
return; // do not print anything
>
> From: Christophe de Dinechin
>
> For example, something like this:
> uint8_t *p8;
> uint32_t *p32 = (uint32_t *) p8;
>
> generates a warning like this:
> spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char
> *') to
> 'uint32_t
On Tue, May 30, 2017 at 03:03:17PM +0200, Christophe de Dinechin wrote:
>
> > On 30 May 2017, at 14:57, Frediano Ziglio wrote:
> >
> >>
> >> From: Christophe de Dinechin
> >>
> >> Without #include , calls to snprintf in the file
> >> cause a warning.
>
> From: Christophe de Dinechin
>
> On macOS, neither of the two cases implemented in set_mouse_accel applies.
> We get the following eror message:
>
> CC spice-widget.lo
> spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable]
>
> On 30 May 2017, at 14:57, Frediano Ziglio wrote:
>
>>
>> From: Christophe de Dinechin
>>
>> Without #include , calls to snprintf in the file
>> cause a warning. The file is left aside on purpose,
>> since src/usbutil.c may be compiled on Windows
>
> From: Christophe de Dinechin
>
> Without #include , calls to snprintf in the file
> cause a warning. The file is left aside on purpose,
> since src/usbutil.c may be compiled on Windows where this
> file does not exist.
>
> Signed-off-by: Christophe de Dinechin
From: Christophe de Dinechin
For example, something like this:
uint8_t *p8;
uint32_t *p32 = (uint32_t *) p8;
generates a warning like this:
spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *')
to
'uint32_t *' (aka 'unsigned int *')
From: Christophe de Dinechin
This patch set contains various fixes that repair macOS builds for
spice-gtk (and presumably clang builds as a side effect), notably:
- Fixes for clang-specific warnings, notably on alignment
- Addition of macOS detection in configure script
- A
From: Christophe de Dinechin
Without #include , calls to snprintf in the file
cause a warning. The file is left aside on purpose,
since src/usbutil.c may be compiled on Windows where this
file does not exist.
Signed-off-by: Christophe de Dinechin
---
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
configure.ac | 15 +++
1 file changed, 15 insertions(+)
diff --git a/configure.ac b/configure.ac
index ff00d73..62acafc 100644
--- a/configure.ac
+++ b/configure.ac
@@
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
configure.ac | 8
spice-common | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 62acafc..caa289a 100644
---
From: Christophe de Dinechin
On macOS, neither of the two cases implemented in set_mouse_accel applies.
We get the following eror message:
CC spice-widget.lo
spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable]
SpiceDisplayPrivate *d =
From: Christophe de Dinechin
This patch set eliminates warnings detected by clang with respect
to type alignments. Vittorio Toso had submitted something
similar. In this version, I took into account comments by
Christophe Fergeau regarding how to know which casts were
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
configure.ac | 8
1 file changed, 8 insertions(+)
diff --git a/configure.ac b/configure.ac
index 6d9f378..efd7317 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,6
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
common/mem.c | 3 +--
common/mem.h | 27 ++-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/common/mem.c b/common/mem.c
index
From: Christophe de Dinechin
For example, something like this:
uint8_t *p8;
uint32_t *p32 = (uint32_t *) p8;
generates a warning like this:
spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *')
to
'uint32_t *' (aka 'unsigned int *')
18 matches
Mail list logo