[Spice-devel] [PATCH spice-vdagent v3] file-xfer: Send more detailed error messages

Send VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED or VD_AGENT_FILE_XFER_STATUS_DISABLED instead of general error, when the given error occurs. send_file_xfer_status() ensures, these errors are sent only to clients with

[Spice-devel] [PATCH spice-gtk v3] main: Handle file-xfer detailed errors

Log appropriate error messages when we receive VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_DISABLED. --- src/channel-main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/channel-main.c

[Spice-devel] [PATCH spice-protocol v3] agent: Add new file-xfer statuses

Introduce new error statuses to report more info to clients: VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_DISABLED These are only sent to clients that feature VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability. ---

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 6 Jun 2017, at 20:45, Marc-André Lureau > wrote: > > I don't think any of these measurements couldn't be reported accurately with > a regular log or structured log. Thus I don't understand what problem you try > to solve. > > Sorry, but I also have a hard

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > >> 3. Scalable, and therefore as fine-grained as we need it to be. With a > >> similar mechanism, Tao-3D has about 70 traces (see > >> https://github.com/c3d/tao-3D/blob/master/tao/traces.tbl > >> for the

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 6 Jun 2017, at 16:29, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> Answering two emails from Frediano and Marc-André that were asking closely >> related questions, to avoid duplication… >> >>> On 6 Jun 2017, at 13:28, Frediano Ziglio

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Tue, 2017-06-06 at 15:17 +0200, Christophe de Dinechin wrote: > Answering two emails from Frediano and Marc-André that were asking > closely related questions, to avoid duplication… > > On 6 Jun 2017, at 13:28, Frediano Ziglio > > wrote: > > > > Would be helpful if you had

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Answering two emails from Frediano and Marc-André that were asking closely > related questions, to avoid duplication… > > > On 6 Jun 2017, at 13:28, Frediano Ziglio wrote: > > > > Would be helpful if you had recap Pavel problems. I don't

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Answering two emails from Frediano and Marc-André that were asking closely related questions, to avoid duplication… > On 6 Jun 2017, at 13:28, Frediano Ziglio wrote: > > Would be helpful if you had recap Pavel problems. I don't remember. I did not find it in email, so it

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> > On 23 May 2017, at 12:55, Victor Toso < victort...@redhat.com > wrote: > > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > > > > or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > > > > Just to point out that we have a bug for this [0] and IMHO it

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > > > On 23 May 2017, at 12:55, Victor Toso < victort...@redhat.com > wrote: > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > > > > or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > Just to point out that we have a

[Spice-devel] RFC: Lightweight tracing mechanism

> On 23 May 2017, at 12:55, Victor Toso wrote: > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > >> or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > Just to point out that we have a bug for this [0] and IMHO it would be > the best

Re: [Spice-devel] [spice-gtk] fix check for 16 bit cursor mask

On Tue, 2017-06-06 at 05:50 -0400, Frediano Ziglio wrote: > > > > On Tue, 2017-06-06 at 05:35 -0400, Frediano Ziglio wrote: > > > ping > > > > > > - Original Message - > > > > From: "Frediano Ziglio" > > > > To: spice-devel@lists.freedesktop.org > > > > Cc: "Frediano

Re: [Spice-devel] [spice-gtk] fix check for 16 bit cursor mask

> > On Tue, 2017-06-06 at 05:35 -0400, Frediano Ziglio wrote: > > ping > > > > - Original Message - > > > From: "Frediano Ziglio" > > > To: spice-devel@lists.freedesktop.org > > > Cc: "Frediano Ziglio" > > > Sent: Wednesday, May 31, 2017 2:59:02

Re: [Spice-devel] [spice-gtk] fix check for 16 bit cursor mask

On Tue, 2017-06-06 at 05:35 -0400, Frediano Ziglio wrote: > ping > > - Original Message - > > From: "Frediano Ziglio" > > To: spice-devel@lists.freedesktop.org > > Cc: "Frediano Ziglio" > > Sent: Wednesday, May 31, 2017 2:59:02 PM > > Subject:

Re: [Spice-devel] [spice-gtk] fix check for 16 bit cursor mask

ping - Original Message - > From: "Frediano Ziglio" > To: spice-devel@lists.freedesktop.org > Cc: "Frediano Ziglio" > Sent: Wednesday, May 31, 2017 2:59:02 PM > Subject: [spice-gtk] fix check for 16 bit cursor mask > > The size was computed using

Re: [Spice-devel] [PATCH spice-server] dcc: Use more portable mnemonic

> > Hi, > > On Tue, Jun 06, 2017 at 09:40:31AM +0100, Frediano Ziglio wrote: > > The maximum value for a 32 bit variable is UINT32_MAX and not > > UINT_MAX. Currently all supported platforms have these two > > constants having the same value so this patch don't change > > nothing in the

Re: [Spice-devel] [PATCH spice-server] dcc: Use more portable mnemonic

Hi, On Tue, Jun 06, 2017 at 09:40:31AM +0100, Frediano Ziglio wrote: > The maximum value for a 32 bit variable is UINT32_MAX and not > UINT_MAX. Currently all supported platforms have these two > constants having the same value so this patch don't change > nothing in the generated code but

[Spice-devel] [PATCH spice-server] dcc: Use more portable mnemonic

The maximum value for a 32 bit variable is UINT32_MAX and not UINT_MAX. Currently all supported platforms have these two constants having the same value so this patch don't change nothing in the generated code but potentially this could change in a future. Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH v2 spice-gtk] Grab keyboard based on focus in windows client

Hi, On Tue, Jun 06, 2017 at 10:19:34AM +0300, Snir Sheriber wrote: > Currently the client grabs keyboard based on session focus, on windows > environment gtk sends grab_broken if wm_killfocus is received (when > focus is changed) while the application has the grab. It means that > when grab is

[Spice-devel] [PATCH v2 spice-gtk] Grab keyboard based on focus in windows client

Currently the client grabs keyboard based on session focus, on windows environment gtk sends grab_broken if wm_killfocus is received (when focus is changed) while the application has the grab. It means that when grab is based on the session, clicking inside focusless window will cause wm_killfocus