>
> Constants, especially when defined using #define usually use upper-case
> naming.
However this is not coherent with wmimax and wmiext.
Maybe changing all?
Another way to define compile time constant in C is using
enum but then you'll have a warning with switches.
Are you using -O0 ?
> ---
>
Hi,
On 07/03/2017 06:53 PM, Yuri Benditovich wrote:
It does not exactly removes old bugfix.
Possibly it does, but only if WinUsb (+ usbclerk) are used.
First version of the code did check for bus.addr only and for example,
ignored change of vid/pid without change of bus.addr (AFAIK this is w
quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a
constant, so a static check should be good, but my compiler (gcc 7.1.1)
is unable to know 'evol' value at compile-time. Since the removal of
spice_static_assert in favour of SPICE_VERIFY, this causes a
compile-time failure.
---
Constants, especially when defined using #define usually use upper-case
naming.
---
common/quic.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/common/quic.c b/common/quic.c
index b0ca74c..9da8c37 100644
--- a/common/quic.c
+++ b/common/quic.c
@@ -179,7 +179,
It does not exactly removes old bugfix.
First version of the code did check for bus.addr only and for example,
ignored change of vid/pid without change of bus.addr (AFAIK this is what
programmable devices like Cypress do).
Previous commit removed check for bus.addr and replaced it with check for
vi
On Mon, Jul 03, 2017 at 02:27:29PM +0300, Yuri Benditovich wrote:
> On Mon, Jul 3, 2017 at 10:16 AM, Christophe Fergeau
> wrote:
>
> > On Mon, Jul 03, 2017 at 07:48:31AM +0300, Yuri Benditovich wrote:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1425961
> > > If attached new device when one
On Mon, Jul 3, 2017 at 11:58 AM, Christophe Fergeau
wrote:
> On Fri, Jun 30, 2017 at 12:11:42PM +0300, Yuri Benditovich wrote:
> > Fixed wrong formats of printouts producing errors with WPP.
> > All fixed format strings were wrong mainly due to incorrect
> > format for pointers.
>
> Quickly glanc
>
> Signed-off-by: Pavel Grunt
> ---
> v2 per Christophe's suggestion:
> use GArray as parameter
> ---
> src/spice-channel.c | 34 --
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/src/spice-channel.c b/src/spice-channel.c
> index b8cf19c..4
>
> Add ability to produce ETW (Event Tracing for Windows) to release
> version of the driver to be able to record binary traces in case
> of problem in customer environment for further analysis.
> Logging of debug build is not changed.
>
> Signed-off-by: Yuri Benditovich
> ---
> qxldod/QxlDod
On Mon, Jul 3, 2017 at 5:44 PM, Frediano Ziglio wrote:
>
> >
> > Added file with Windows trace preprocessor definitions
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > qxldod/WppTrace.h | 51
> > qxldod/qxldod.vcxproj.filters | 133
> > +---
>
> Added file with Windows trace preprocessor definitions
>
> Signed-off-by: Yuri Benditovich
> ---
> qxldod/WppTrace.h | 51
> qxldod/qxldod.vcxproj.filters | 133
> +-
> 2 files changed, 119 insertions(+), 65 deletions(-
From: Victor Toso
Cheers,
Victor Toso (2):
file-xfer: Error messages should always be translated
file-xfer: Inform client of errors on init of xfer
src/channel-main.c | 50 ++
1 file changed, 22 insertions(+), 28 deletions(-)
--
2.13.0
___
From: Victor Toso
With SpiceFileTransferTask we suggest that Spice clients watch
(signal) SpiceMainChannel::new-file-transfer so it can follow the
transfer's progress till the moment it is finished.
On (signal) SpiceFileTransferTask::finished, we will issue if any
error has happened to the appli
From: Victor Toso
Signed-off-by: Victor Toso
---
src/channel-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index 4edd575..1c77c7b 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -3119,7 +3119,7 @@ void spice_main_f
On Mon, Jul 3, 2017 at 12:07 PM, Christophe Fergeau
wrote:
> On Fri, Jun 30, 2017 at 12:11:43PM +0300, Yuri Benditovich wrote:
> > Added file with Windows trace preprocessor definitions
> >
>
> Bit terse changelog, but why not.. :) Where is the guid coming from?
>
Guid comes from GUID generator,
On Mon, Jul 3, 2017 at 10:16 AM, Christophe Fergeau
wrote:
> On Mon, Jul 03, 2017 at 07:48:31AM +0300, Yuri Benditovich wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1425961
> > If attached new device when one device with the same vid
> > and pid already present, the notification is igno
Hi,
I just pushed v0.12.13 spice-protocol release tag.
Release tarball:
https://www.spice-space.org/download/releases/spice-protocol-0.12.13.tar.bz2
Major changes in 0.12.13
* add DISPLAY_PREFERRED_VIDEO_CODEC_TYPE
* add VP9 codec type
* add VD_AGENT_CLEAR_CAPABILITY() m
Here you really need a longer log, I have no idea who is supposed to use
these scripts, what for, when, ...
On Fri, Jun 30, 2017 at 12:11:45PM +0300, Yuri Benditovich wrote:
> Signed-off-by: Yuri Benditovich
> ---
> QxlDodCollectTrace.bat | 31 +++
> QxlDodParseTrace.
On Fri, Jun 30, 2017 at 12:11:44PM +0300, Yuri Benditovich wrote:
> Add ability to produce ETW (Event Tracing for Windows) to release
> version of the driver to be able to record binary traces in case
> of problem in customer environment for further analysis.
> Logging of debug build is not changed
On Fri, Jun 30, 2017 at 12:11:43PM +0300, Yuri Benditovich wrote:
> Added file with Windows trace preprocessor definitions
>
Bit terse changelog, but why not.. :) Where is the guid coming from?
Acked-by: Christophe Fergeau
> Signed-off-by: Yuri Benditovich
> ---
> qxldod/WppTrace.h
On Fri, Jun 30, 2017 at 12:11:42PM +0300, Yuri Benditovich wrote:
> Fixed wrong formats of printouts producing errors with WPP.
> All fixed format strings were wrong mainly due to incorrect
> format for pointers.
Quickly glanced through this, looks good, anyway this would be caught at
compile time
On Mon, Jul 03, 2017 at 09:48:35AM +0200, Victor Toso wrote:
> Hi,
>
> On Fri, Jun 30, 2017 at 12:12:06PM +0200, Christophe Fergeau wrote:
> > On Fri, Jun 30, 2017 at 10:37:36AM +0200, Victor Toso wrote:
> > > Hi,
> > >
> > > On Fri, Jun 30, 2017 at 10:14:27AM +0200, Pavel Grunt wrote:
> > > > Si
Hi,
On Fri, Jun 30, 2017 at 12:12:06PM +0200, Christophe Fergeau wrote:
> On Fri, Jun 30, 2017 at 10:37:36AM +0200, Victor Toso wrote:
> > Hi,
> >
> > On Fri, Jun 30, 2017 at 10:14:27AM +0200, Pavel Grunt wrote:
> > > Signed-off-by: Pavel Grunt
> > > ---
> > > v2 per Christophe's suggestion:
> >
On Fri, Jun 30, 2017 at 10:37:36AM +0200, Victor Toso wrote:
> Hi,
>
> On Fri, Jun 30, 2017 at 10:14:27AM +0200, Pavel Grunt wrote:
> > Signed-off-by: Pavel Grunt
> > ---
> > v2 per Christophe's suggestion:
> > use GArray as parameter
> > ---
> > src/spice-channel.c | 34
On Mon, Jul 03, 2017 at 07:48:31AM +0300, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1425961
> If attached new device when one device with the same vid
> and pid already present, the notification is ignored and
> attached device is not redirected (if auto share set) and
>
25 matches
Mail list logo
