[Spice-devel] [PATCH v5 1/8] Bump GLib version to 2.34

This is required for the following GMainLoop integration, which utilizes some of the new functions/definitions, namely: [definition][GLib version] g_clear_pointer() 2.34 G_SOURCE_REMOVE 2.32 G_SOURCE_CONTINUE 2.32 g_unix_signal_add() 2.30 GLib version accross distributions: - Fedora 26

Re: [Spice-devel] [PATCH spice-gtk v2] spicy: Add call of gst_deinit at program exit

Hi - Original Message - > From: Christophe de Dinechin > > This is useful for some instrumentation, e.g. the leaks tracer, > that perform some of their operations within gst_deinit. > > Without this patch, if you run spicy with > GST_DEBUG="GST_TRACER:7"

[Spice-devel] [PATCH spice-gtk v2] spicy: Add call of gst_deinit at program exit

From: Christophe de Dinechin This is useful for some instrumentation, e.g. the leaks tracer, that perform some of their operations within gst_deinit. Without this patch, if you run spicy with GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ... the leak tracer

[Spice-devel] [PATCH spice-server v2] Use standard "Red" namespace

The objects RedsStream and RedsSASL are currently using the namespace "Reds" rather than the standard "Red" namespace used throughout the rest of the project. Change these to be consistent. This also means changing method names and some related enumeration types. The files were also renamed to

Re: [Spice-devel] [PATCH spice-server 1/2] Use standard "Red" namespace

On Thu, 2017-10-19 at 02:19 -0400, Frediano Ziglio wrote: > > > > The objects RedsStream and RedsSASL are currently using the > > namespace > > "Reds" rather than the standard "Red" namespace used throughout the > > rest > > of the project. Change these to be consistent. This also means > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 15:10, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: >>> One reason is that you may use a library dynamically, and you may dlclose() >>> it, and then atexit() will likely crash. >> >> Is that a

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 15:10, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: >>> One reason is that you may use a library dynamically, and you may dlclose() >>> it, and then atexit() will likely crash. >> >> Is that a

[Spice-devel] MacOS Client Crashing upon Connection to graphic Server is established

Hello Spice Dev-Team, in order to connect to a virtual desktop hosted on a university system using "Red Head Virtualization", I installed the bundled Spice Version for macOS from your Site (https://www.spice-space.org/osx-client.html). The initial connection to the VM seams to Work, but

Re: [Spice-devel] [PATCH] drm/qxl: workaround broken qxl hw primary setting.

On Thu, 2017-10-19 at 07:28 -0400, Frediano Ziglio wrote: > > This tries to work out when the commit is likely just a pageflip > > and avoid touching the primary surface, this might go wrong at > > some point but I believe it's the same level as wrong as the old > > code > > base. > > > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: > > One reason is that you may use a library dynamically, and you may dlclose() > > it, and then atexit() will likely crash. > > Is that a real or theoretical scenario? Who loads this library dynamically > currently?

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > On 19 Oct 2017, at 13:49, Marc-André Lureau < marcandre.lur...@redhat.com > > > wrote: > > > - Original Message - > > > > > On 19 Oct 2017, at 13:15, Marc-André Lureau < > > > > marcandre.lur...@redhat.com > > > > > > > > > > > > > > > wrote: > > > > > > > > > > Hi > > > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 13:49, Marc-André Lureau > wrote: > > > > - Original Message - >> >>> On 19 Oct 2017, at 13:15, Marc-André Lureau >>> wrote: >>> >>> Hi >>> >>> - Original Message - > > From:

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 08:53:08AM -0400, Frediano Ziglio wrote: > > > > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > > > even > > > > if they were originally dlopend. If

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > > even > > > if they were originally dlopend. If the library has used a pthread local > > > with > > > a destructor function, then

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > even > > if they were originally dlopend. If the library has used a pthread local > > with > > a destructor function, then unloading the

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote: > > > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > > > > > This is useful for some instrumentation,

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote: > > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > This is useful for some instrumentation, e.g. the leaks tracer,

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

- Original Message - > > > On 19 Oct 2017, at 13:15, Marc-André Lureau > > wrote: > > > > Hi > > > > - Original Message - > >>> > >>> From: Christophe de Dinechin > >>> > >>> This is useful for some instrumentation, e.g.

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > > > > > that perform some of their operations within gst_deinit. > > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 13:19, Frediano Ziglio wrote: > >> >> Hi >> >> - Original Message - From: Christophe de Dinechin This is useful for some instrumentation, e.g. the leaks tracer, that perform some of their

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 13:15, Marc-André Lureau > wrote: > > Hi > > - Original Message - >>> >>> From: Christophe de Dinechin >>> >>> This is useful for some instrumentation, e.g. the leaks tracer, >>> that perform some of their

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> On 19 Oct 2017, at 12:32, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> This is useful for some instrumentation, e.g. the leaks tracer, >> that perform some of their operations within gst_deinit. >> >> Without this patch, if you

Re: [Spice-devel] [PATCH] drm/qxl: workaround broken qxl hw primary setting.

> > From: Dave Airlie > > QXL hw can't change primary surfaces easily, the server sends a msg > and the client flickers a lo when it does. The old pre-atomic > page flip code endeavoured to workaround this with a copy operation. > > This worked by another accident of how

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > Hi > > - Original Message - > > > > > > From: Christophe de Dinechin > > > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > > that perform some of their operations within gst_deinit. > > > > > > Without this patch, if you run spicy

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

Hi - Original Message - > > > > From: Christophe de Dinechin > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > that perform some of their operations within gst_deinit. > > > > Without this patch, if you run spicy with > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

> > From: Christophe de Dinechin > > This is useful for some instrumentation, e.g. the leaks tracer, > that perform some of their operations within gst_deinit. > > Without this patch, if you run spicy with > GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ... >

[Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

From: Christophe de Dinechin This is useful for some instrumentation, e.g. the leaks tracer, that perform some of their operations within gst_deinit. Without this patch, if you run spicy with GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ... the leak tracer

Re: [Spice-devel] [PATCH] drm/qxl: workaround broken qxl hw primary setting.

> > From: Dave Airlie > > QXL hw can't change primary surfaces easily, the server sends a msg > and the client flickers a lo when it does. The old pre-atomic typo: lo -> lot > page flip code endeavoured to workaround this with a copy operation. > not clear. Do you mean a

Re: [Spice-devel] [PATCH spice-server 2/2] RedStream: make some functions static

> > These were not used outside of red-stream.c, so make them static and > remove them from the header. Acked-by: Frediano Ziglio > --- > server/red-stream.c | 6 +++--- > server/red-stream.h | 3 --- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server 1/2] Use standard "Red" namespace

> > The objects RedsStream and RedsSASL are currently using the namespace > "Reds" rather than the standard "Red" namespace used throughout the rest > of the project. Change these to be consistent. This also means changing > method names and some related enumeration types. > > The files were