[Spice-devel] [PATCH spice-server] fixup! Move stream creation/maintenance funcs to DisplayChannel

--- Here's a potential fix to be squashed with patch 3/7 that moves the VideoStream initialization to video-stream.h as I mentioned in the last email. server/display-channel.c | 25 + server/video-stream.c| 28 server/video-stream.h|

Re: [Spice-devel] [PATCH spice-server 2/7] VideoStream: store channel in stream

On Thu, 2017-11-30 at 13:40 -0500, Frediano Ziglio wrote: > > > > This allows us to unref the stream directly rather than needing to > > pass > > the associated DisplayChannel to stream_unref(). The same is also > > true > > for stream_agent_unref, since the only reason that > >

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

On Thu, 2017-11-30 at 13:06 -0500, Frediano Ziglio wrote: > > On Thu, Nov 30, 2017 at 6:24 PM, Frediano Ziglio < fziglio@redhat.c > > om > > > wrote: > > > > On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau < cfergeau@ > > > > redhat.com > > > > > > > > > wrote: > > > > > On Mon, Nov 13, 2017

Re: [Spice-devel] [PATCH spice-server 2/7] VideoStream: store channel in stream

> > This allows us to unref the stream directly rather than needing to pass > the associated DisplayChannel to stream_unref(). The same is also true > for stream_agent_unref, since the only reason that stream_agent_unref() > required a DisplayChannel parameter was to pass it to stream_unref(). >

Re: [Spice-devel] [PATCH spice-server 4/7] DisplayChannel: Use NSEC_PER_MILLISEC

> > Instead of using 1000*1000 > > Signed-off-by: Jonathon Jongsma > --- > server/display-channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index 96feabc3c..1c14344be 100644 > ---

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

> On Thu, Nov 30, 2017 at 6:24 PM, Frediano Ziglio < fzig...@redhat.com > > wrote: > > > On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau < cferg...@redhat.com > > > > > > > > wrote: > > > > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: > > > > >> This is a preparatory

Re: [Spice-devel] [PATCH spice-server 1/7] Rename RedStreamClipItem to VideoStreamClipItem

> > Avoid confusion with RedStream which is a totally unrelated object. > > Signed-off-by: Jonathon Jongsma > --- > server/dcc-send.c | 4 ++-- > server/dcc.c | 2 +- > server/video-stream.c | 10 +- > server/video-stream.h | 6 +++--- > 4 files

[Spice-devel] [PATCH spice-server] StreamDevice: assert preconditions in parsing functions

Be a bit more defensive about handling incoming messages from the stream device. This also makes these functions consistent with handle_msg_format(). These assertions are only enabled if ENABLE_EXTRA_CHECKS is defined. Signed-off-by: Jonathon Jongsma Acked-by: Frediano

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

On Thu, Nov 30, 2017 at 6:24 PM, Frediano Ziglio wrote: > > > On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau < > cferg...@redhat.com > > > wrote: > > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: > > >> This is a preparatory patch for GTK+ vdagent

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

> On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau < cferg...@redhat.com > > wrote: > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: > >> This is a preparatory patch for GTK+ vdagent redesign. > >> > >> Since most of the vdagent code still uses X11 lib, > >> force GDK to use

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau wrote: > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: >> This is a preparatory patch for GTK+ vdagent redesign. >> >> Since most of the vdagent code still uses X11 lib, >> force GDK to use X11 backend by

Re: [Spice-devel] [PATCH spice-common v3] protocol: Allow to specify a surface will be streamed

ping - Original Message - > From: "Frediano Ziglio" > To: spice-devel@lists.freedesktop.org > Sent: Tuesday, November 21, 2017 11:41:32 AM > Subject: Re: [Spice-devel] [PATCH spice-common v3] protocol: Allow to specify > a surface will be streamed > > ping > > > >

[Spice-devel] [PATCH spice-server v2] Use verify instead of G_STATIC_ASSERT

verify guarantee that the condition is always a compile time constant. Signed-off-by: Frediano Ziglio --- server/glib-compat.h| 2 +- server/red-parse-qxl.c | 4 ++-- server/spice-bitmap-utils.h | 4 ++-- server/tests/replay.c | 22

Re: [Spice-devel] [PATCH spice-gtk v2 0/5] Fix introspection method bindings

Hi - Original Message - > On Tue, Sep 19, 2017 at 10:33:56PM +0800, Matthew Francis wrote: > > Various C functions have not been named correctly to be picked up as bound > > methods under introspection. This renames them to ensure correct binding. > > I'm very late to the party, but had

[Spice-devel] [PATCH spice-server] inputs-channel: Prefer channel core over global core interface

Potentially a channel can run with a different core interface than the global one attached to RedsState so instead of calling reds_core_* functions use the code interface attached to the channel. Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 16

[Spice-devel] [PATCH spice-server 1/2] inputs-channel: Encapsulate SpiceTabletState

Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index ac598424..464ac21e 100644 --- a/server/inputs-channel.c +++

[Spice-devel] [PATCH spice-server 2/2] inputs-channel: Avoid some allocation using RedsState pointer

Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index 464ac21e..8e9eae49 100644 --- a/server/inputs-channel.c +++

Re: [Spice-devel] [PATCH spice-gtk v2 0/5] Fix introspection method bindings

On Tue, Sep 19, 2017 at 10:33:56PM +0800, Matthew Francis wrote: > Various C functions have not been named correctly to be picked up as bound > methods under introspection. This renames them to ensure correct binding. I'm very late to the party, but had you considered using (rename-to NEWNAME)

[Spice-devel] [PATCH spice-server] Use verify instead of G_STATIC_ASSERT

verify guarantee that the condition is always a compile time constant. Signed-off-by: Frediano Ziglio --- server/glib-compat.h| 2 +- server/red-parse-qxl.c | 4 ++-- server/spice-bitmap-utils.h | 4 ++-- server/tests/replay.c | 22

[Spice-devel] [PATCH spice-server] tests: Use GLib memory functions

Signed-off-by: Frediano Ziglio --- server/tests/test-display-base.c | 42 server/tests/test-display-streaming.c| 2 +- server/tests/test-display-width-stride.c | 4 +-- server/tests/test-gst.c | 12 -

Re: [Spice-devel] [PATCH spice-server v2 2/2] Rename StreamAgent to VideoStreamAgent

> > Just to avoid confusion between different uses of the word Stream (e.g. > RedStream) clarify that it's related to video streams > > Signed-off-by: Jonathon Jongsma > --- > Changes in v2: > - broke long lines, changed function declaration indentation > >

Re: [Spice-devel] [PATCH spice-server v2 1/2] Rename Stream to VideoStream

> > To prevent confusion between Stream (a video stream) and RedStream (a > generic data stream between client and server), change the name to > VideoStream to be more explicit about what it is. > > Signed-off-by: Jonathon Jongsma > --- > Changes in v2: > - broke long