Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
> > > On 9 Feb 2018, at 14:20, Frediano Ziglio wrote: > > > >>> > >>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > >>> > >>> Signed-off-by: Frediano Ziglio > >>> --- > >>> server/stream-device.c | 169 > >>>

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Christophe de Dinechin
> On 9 Feb 2018, at 14:20, Frediano Ziglio wrote: > >>> >>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: >>> >>> Signed-off-by: Frediano Ziglio >>> --- >>> server/stream-device.c | 169 >>>

Re: [Spice-devel] [PATCH spice-server v4 1/4] stream-device: Avoid device to get stuck if multiple messages are batched

2018-02-09 Thread Frediano Ziglio
> > On Mon, 2018-01-15 at 09:10 +, Frediano Ziglio wrote: > > If messages are sent together by the agent the device is reading > > only part of the data. This cause Qemu to not poll for new data and > > stream_device_read_msg_from_dev won't be called again. > > This can cause a stall. To

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
> > > On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > --- > > server/stream-device.c | 169 > > +++-- > > 1 file changed, 162 insertions(+), 7 deletions(-) > > > >

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Christophe de Dinechin
> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > server/stream-device.c | 169 +++-- > 1 file changed, 162 insertions(+), 7 deletions(-) > > Changes since v1: > -

Re: [Spice-devel] [PATCH v3 02/11] Added External References section

2018-02-09 Thread Christophe de Dinechin
> On 9 Feb 2018, at 10:50, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> docs/spice_style.txt | 20 >> 1 file changed, 20 insertions(+) >>

Re: [Spice-devel] [PATCH spice-server] style: Update style to include some C++ element

2018-02-09 Thread Christophe de Dinechin
> On 8 Feb 2018, at 15:48, Lukáš Hrázký wrote: > > On Thu, 2018-02-08 at 15:33 +0100, Christophe de Dinechin wrote: >>> On 8 Feb 2018, at 14:53, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-07 at 10:10 +0100, Christophe de Dinechin wrote: Frediano

Re: [Spice-devel] [PATCH v3 09/11] Add mention of header guards

2018-02-09 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index

Re: [Spice-devel] [PATCH v3 08/11] Add mention of fall-through comments

2018-02-09 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index 68dbeeef..eb2ee252 100644 > ---

Re: [Spice-devel] [PATCH v3 02/11] Added External References section

2018-02-09 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 20 > 1 file changed, 20 insertions(+) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index

[Spice-devel] [PATCH spice-server v2 2/2] stream-device: Implement mouse movement

2018-02-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/stream-device.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) Changes since v1: - none, just for the series diff --git a/server/stream-device.c b/server/stream-device.c index

[Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/stream-device.c | 169 +++-- 1 file changed, 162 insertions(+), 7 deletions(-) Changes since v1: - add some comments with some implementation explanation; - better computation of max cursor