[Spice-devel] [PATCH v2 23/24] Rename 'streamfd' variable to 'stream', no longer a file descriptor

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 14/24] Create a class encapsulating the X11 display cursor capture

From: Christophe de Dinechin This class will need to be moved to a separate file in a later patch. This is done in two steps to make the evolution of the code easier to track, as well as to facilitate later 'git bisect' Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH v2 06/24] Replace inefficient C-style initialization with C++-style

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

From: Christophe de Dinechin This also introduces the spice::streaming_error::Error class, which we can reuse later as a base class for all agent-specific errors. This class provides a formatted 'message()' class that returns a string, making it easier to format errors

[Spice-devel] [PATCH v2 13/24] Add more meaningful syslog reporting

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 09/24] Reorder headers according to style guide

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 21/24] Reformat 'if' statments according to style guide

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 07/24] Get rid of C-style memset initializations, use C++ style aggregates

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 47 ++- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 17/24] Move the capture loop in the ConcreteAgent, get rid of global agent variable

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/concrete-agent.hpp| 4 src/spice-streaming-agent.cpp | 19 +-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git

[Spice-devel] [PATCH v2 10/24] Since we use a namespace, simplify name of local classes

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 16/24] Remove client_codecs global variable, moved inside the 'Stream' class

From: Christophe de Dinechin This is not a really nice abstraction at this point, but still a step in the right way Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 16 ++-- 1 file changed, 10 insertions(+), 6

[Spice-devel] [PATCH v2 12/24] Convert message writing from C style to C++ style

From: Christophe de Dinechin - The Stream class now deals with locking and sending messages - The Message<> template class deals with the general writing mechanisms - Three classes, FormatMessage, FrameMessage and X11CursorMessage represent individual messages The various

[Spice-devel] [PATCH v2 08/24] Use C++ style for cursor message initialization instead of C style

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 47 +-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 19/24] Make streaming_requested a method in Stream

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 20/24] Throw an exception in case we can't write a complete packet.

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 05/24] Use RAII to cleanup stream in case of exception or return

From: Christophe de Dinechin Get rid of C-style 'goto done' in do_capture. Get rid of global streamfd, pass it around (cleaned up in later patch) Fixes a race condition, make sure we only use stream after opening Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH v2 02/24] log_binary is really a boolean

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index

[Spice-devel] [PATCH v2 24/24] Rename 'Stream' to 'IOChannel'

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/concrete-agent.hpp| 4 +-- src/spice-streaming-agent.cpp | 64 +-- 2 files changed, 34 insertions(+), 34 deletions(-) diff

[Spice-devel] [PATCH v2 11/24] Move read, write and locking into the 'Stream' class

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 105 +++--- 1 file changed, 57 insertions(+), 48 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 15/24] Create FrameLog class to abstract logging of frames

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 99 ++- 1 file changed, 60 insertions(+), 39 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

From: Christophe de Dinechin I also added a catch-all clause for double plus extra safety Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Spice-devel] [PATCH v2 00/24] WIP: Refactor the streaming agent towards a more standard C++ style

From: Christophe de Dinechin The streaming agent started as C code. This series converts the style to something that is more usual for C++, notably: - Adds encapsulation and RAII for resources such as the stream - Splits functionality into several classes with clear roles -

[Spice-devel] [PATCH v2 04/24] Do not create std::string for constants

From: Christophe de Dinechin As per e-mail discussions (https://patchwork.freedesktop.org/patch/200629/), using std::string for C-style string constants is against C++ good practices, see

[Spice-devel] [PATCH v2 01/24] Add missing header

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/concrete-agent.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/concrete-agent.cpp b/src/concrete-agent.cpp index 0720782..4cf70e7 100644 --- a/src/concrete-agent.cpp

[Spice-devel] [PATCH v2 03/24] Eliminate signed/unsigned warning

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/mjpeg-fallback.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp index fd37167..5758893 100644 ---

Re: [Spice-devel] [PATCH spice-gtk v2 3/4] uri: generate spice://host:port or spice+tls://host:port

On Wed, Feb 21, 2018 at 10:17 AM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> --- >> src/spice-session.c | 31 +++ >> tests/session.c |

Re: [Spice-devel] [PATCH spice-gtk v2 2/4] uri: learn to parse spice+tls:// form

Hi On Wed, Feb 21, 2018 at 10:24 AM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> spice:// has a weird scheme encoding, where it can accept both plain >> and tls ports with URI query parameters. However, it's not very >> convenient nor

Re: [Spice-devel] SUSE 91 / SUSE 93 supported xf86 Version

Hey, On Mon, Jan 29, 2018 at 08:24:59AM +0100, ralfbuhrm...@bundeswehr.org wrote: > Dear Spice-Developer, > > i'm a civilian Employer in the the German Navy and have a little Problem. > > We are using a Linux-Based Trainer Software using SUSE 9.1 and 9.3. With > our new Hardware, we have

Re: [Spice-devel] [PATCH spice-streaming-agent v4 0/4] Handle more completely device messages

On Wed, 2018-02-21 at 15:47 +, Frediano Ziglio wrote: > Avoids losing sync with the device. > Handle some missing messages. > > Changes since v3: > - reverse function order to avoid function declaration. > > Changes since v2: > - fix typo; > - use the term "handle" instead of "read"; > -

Re: [Spice-devel] [PATCH spice-streaming-agent v3 1/4] Use exception handling data from streaming device

Lukáš Hrázký writes: > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: >> In all paths errors from this function are treated like fatal >> error, there's no need to handle all manually potentially >> forgetting to handle errors. >> Also avoid to deal directly with logging moving the

[Spice-devel] [PATCH spice-streaming-agent v4 3/4] Handle capabilities

Do not bail if the server is attempting to communicate some extensions but just ignore as at the moment we support none. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 29 + 1 file changed, 29 insertions(+) diff --git

[Spice-devel] [PATCH spice-streaming-agent v4 1/4] Use exception handling data from streaming device

In all paths errors from this function are treated like fatal error, there's no need to handle all manually potentially forgetting to handle errors. Also avoid to deal directly with logging moving the responsibility to other layers. Signed-off-by: Frediano Ziglio ---

[Spice-devel] [PATCH spice-streaming-agent v4 4/4] Stub to handle errors from server

Base error message handling. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 0e419bc..aeee5d3 100644 ---

[Spice-devel] [PATCH spice-streaming-agent v4 2/4] Separate handling start/stop message from server

Prepare to add support for other messages. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 46 +-- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH spice-streaming-agent v4 0/4] Handle more completely device messages

Avoids losing sync with the device. Handle some missing messages. Changes since v3: - reverse function order to avoid function declaration. Changes since v2: - fix typo; - use the term "handle" instead of "read"; - return void from handling functions. Changes since v1: - avoid the usage of

Re: [Spice-devel] [PATCH spice-streaming-agent v3 2/4] Separate handling start/stop message from server

> > On Wed, 2018-02-21 at 05:45 -0500, Frediano Ziglio wrote: > > > > > > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > > > Prepare to add support for other messages. > > > > > > > > Signed-off-by: Frediano Ziglio > > > > --- > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 4/4] Stub to handle errors from server

On Wed, 2018-02-21 at 05:51 -0500, Frediano Ziglio wrote: > > > > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > > Base error message handling. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > src/spice-streaming-agent.cpp | 9 + > > > 1

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

> > I'm late to the party, but a one-line commit log for a patch adding 160 > lines of code is *not* acceptable. > > Christophe > Yes, was a mistake. Frediano > On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 2/4] Separate handling start/stop message from server

On Wed, 2018-02-21 at 05:45 -0500, Frediano Ziglio wrote: > > > > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > > Prepare to add support for other messages. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > src/spice-streaming-agent.cpp | 26

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

I'm late to the party, but a one-line commit log for a patch adding 160 lines of code is *not* acceptable. Christophe On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/stream-device.c | 169 >

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

On Wed, 2018-02-21 at 10:19 +0100, Lukáš Hrázký wrote: > > > > I chose short names because I was in that namespace. Otherwise, > > > > I > > > > agree with you. > > > > > > > > Do you think that the name is still too vague even within the > > > > namespace? > > > > > > I think so. Everything in

Re: [Spice-devel] aSPICE keyboard layout problems

Hey, I am cc-ing the SPICE developers mailing list in order to raise awareness of this user issue (apologies for cross-posting). Unfortunately, due to limitations of the SPICE protocol, input is sent as keyboard scan codes to the remote machine rather than Unicode characters. This is the reason

Re: [Spice-devel] Gitlab - 2018!

Hi, On Wed, Feb 21, 2018 at 12:21:41PM +0100, Christophe Fergeau wrote: > On Mon, Feb 19, 2018 at 04:15:07PM +0100, Victor Toso wrote: > > Hi, > > > > There was a thread in 2016 about moving to gitlab [0] which it > > was not complete done. New projects have been started in gitlab > > instead of

Re: [Spice-devel] Gitlab - 2018!

On Mon, 2018-02-19 at 16:15 +0100, Victor Toso wrote: > Hi, > > There was a thread in 2016 about moving to gitlab [0] which it > was not complete done. New projects have been started in gitlab > instead of freedesktop and without notice, some users are even > filling bugs there already [1]. > >

Re: [Spice-devel] broken spice dependancy

On Wed, Feb 21, 2018 at 03:17:12AM -0800, Bat Man wrote: > Can you please remove gtk-doc as a mandatory requirment for installing > spice-gtk. The thing is its supporting library. A cool one but support > none the less. NO ONE reads the documentation. Your build system is > antiquated. Please

Re: [Spice-devel] broken spice dependancy

Hey, For what it's worth, inflamatory emails such as this one are not welcome on this list, and usually not the best way of getting help/feedback. gtk-doc should not be required for building from tarballs if you pass --disable-gtk-doc to configure. It even seems to be disabled by default on my

[Spice-devel] broken spice dependancy

Can you please remove gtk-doc as a mandatory requirment for installing spice-gtk. The thing is its supporting library. A cool one but support none the less. NO ONE reads the documentation. Your build system is antiquated. Please update it and remove gtk-doc as a requirement. It is breaking

Re: [Spice-devel] Gitlab - 2018!

On Mon, Feb 19, 2018 at 04:15:07PM +0100, Victor Toso wrote: > Hi, > > There was a thread in 2016 about moving to gitlab [0] which it > was not complete done. New projects have been started in gitlab > instead of freedesktop and without notice, some users are even > filling bugs there already

Re: [Spice-devel] [PATCH spice-streaming-agent v3 4/4] Stub to handle errors from server

> > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > Base error message handling. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/spice-streaming-agent.cpp | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/4] Handle capabilities

> > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > Do not bail if the server is attempting to communicate some extensions > > but just ignore as at the moment we support none. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/spice-streaming-agent.cpp |

Re: [Spice-devel] [PATCH spice-streaming-agent v3 2/4] Separate handling start/stop message from server

> > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > > Prepare to add support for other messages. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/spice-streaming-agent.cpp | 26 ++ > > 1 file changed, 18 insertions(+), 8

Re: [Spice-devel] [PATCH spice-streaming-agent v3 2/4] Separate handling start/stop message from server

On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > Prepare to add support for other messages. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 26 ++ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-streaming-agent v3 4/4] Stub to handle errors from server

On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > Base error message handling. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/4] Handle capabilities

On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > Do not bail if the server is attempting to communicate some extensions > but just ignore as at the moment we support none. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 30

Re: [Spice-devel] [PATCH spice-streaming-agent v3 1/4] Use exception handling data from streaming device

On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote: > In all paths errors from this function are treated like fatal > error, there's no need to handle all manually potentially > forgetting to handle errors. > Also avoid to deal directly with logging moving the responsibility > to other

Re: [Spice-devel] [PATCH 16/17] Remove client_codecs global variable, moved inside the 'Stream' class

On Tue, 2018-02-20 at 17:20 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 16:51, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > This is not a

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > - The Stream class

Re: [Spice-devel] [PATCH spice-gtk v2 2/4] uri: learn to parse spice+tls:// form

> From: Marc-André Lureau > > spice:// has a weird scheme encoding, where it can accept both plain > and tls ports with URI query parameters. However, it's not very > convenient nor very common to use (who really want to mix plain & tls > channels?). > > Instead,

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

On Tue, 2018-02-20 at 15:24 -0600, Jonathon Jongsma wrote: > On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > > > On 20 Feb 2018, at 10:43, Lukáš Hrázký > > > > wrote: > > > > > > > > On Fri,

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] tests: add spice+tls:// tests

> > From: Marc-André Lureau > > They couldn't not be introduced before, because the test needs both > parsing and generation. > > Signed-off-by: Marc-André Lureau > --- > tests/session.c | 24 +++- > 1 file

Re: [Spice-devel] [PATCH spice-gtk v2 3/4] uri: generate spice://host:port or spice+tls://host:port

> From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > src/spice-session.c | 31 +++ > tests/session.c | 20 ++-- > 2 files changed, 33 insertions(+), 18 deletions(-) > >

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

On Tue, 2018-02-20 at 18:37 +0100, Christophe de Dinechin wrote: > [Forgot to send, sorry for delay] > > > On 19 Feb 2018, at 19:03, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote: > > > > On 16 Feb 2018, at 17:40, Frediano Ziglio

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

> On 20 Feb 2018, at 22:24, Jonathon Jongsma wrote: > > On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: >> On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: On