Re: [Spice-devel] [spice-gtk v1 09/11] channel-display: don't debug latency for each frame

2018-03-29 Thread Victor Toso
On Tue, Mar 13, 2018 at 12:25:40PM +0100, Victor Toso wrote: > From: Victor Toso > > Becomes quite hard to find meaning on something that is printed every > time. Only print latency value if it is a new min/max or if average > latency is 10% bigger/lower then usual. > > Not

Re: [Spice-devel] [spice-gtk v1 00/11] misc improvements in channel-display

2018-03-29 Thread Victor Toso
Hi, On Tue, Mar 13, 2018 at 12:25:31PM +0100, Victor Toso wrote: > From: Victor Toso > > Hi, > > The first four patches are related to using hash table to track stream's > structure, discussed with Lukas at [0]. The others are trying to: > - reduce too much code in one

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-29 Thread Victor Toso
Hi, On Fri, Mar 23, 2018 at 04:40:28PM +0100, Christophe de Dinechin wrote: > > > > On 23 Mar 2018, at 15:57, Lukáš Hrázký wrote: > > > > From: Lukáš Hrázký > > > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > > belongs to

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-29 Thread Christophe Fergeau
On Thu, Mar 29, 2018 at 10:36:06AM +0200, Christophe de Dinechin wrote: > > > > On 29 Mar 2018, at 10:05, Christophe Fergeau wrote: > > > > On Wed, Mar 28, 2018 at 05:54:21PM +0200, Christophe de Dinechin wrote: > >>> With that said, I find the current "ODR" portion of the

Re: [Spice-devel] gstreamer for view/record spice session

2018-03-29 Thread Victor Toso
On Wed, Mar 28, 2018 at 08:25:59PM +0300, Krutskikh Ivan wrote: > Hi! > > Is it possible ro use gstreamer to view or record spice screen session? Not yet, but RFE is open at https://bugs.freedesktop.org/show_bug.cgi?id=51714 signature.asc Description: PGP signature

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-29 Thread Christophe Fergeau
On Wed, Mar 28, 2018 at 05:35:35PM +0200, Christophe de Dinechin wrote: > > On 28 Mar 2018, at 17:04, Christophe Fergeau wrote: > > The part I'm missing is how you extract this limited number of full > > strings that we'll need to translate into a po file (or equivalent). Is

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-29 Thread Christophe de Dinechin
> On 29 Mar 2018, at 10:05, Christophe Fergeau wrote: > > On Wed, Mar 28, 2018 at 05:54:21PM +0200, Christophe de Dinechin wrote: >>> With that said, I find the current "ODR" portion of the commit log >>> misleading, it's easy to get the impression that after this change,

Re: [Spice-devel] gstreamer for view/record spice session

2018-03-29 Thread Snir Sheriber
Hi, On 03/28/2018 08:25 PM, Krutskikh Ivan wrote: Hi! Is it possible ro use gstreamer to view or record spice screen session? I'm not sure if i understood what you meant, can you elaborate? Anyway maybe one of these options will work for you: -Record spice server traffic and then replay

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-29 Thread Christophe Fergeau
On Wed, Mar 28, 2018 at 05:54:21PM +0200, Christophe de Dinechin wrote: > > With that said, I find the current "ODR" portion of the commit log > > misleading, it's easy to get the impression that after this change, we > > won't have any ODR problem anymore (this is what I initially thought!). > >

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-29 Thread Christophe de Dinechin
> On 29 Mar 2018, at 09:14, Christophe de Dinechin wrote: > > > >> On 28 Mar 2018, at 18:46, Christophe Fergeau wrote: >> >> On Wed, Mar 28, 2018 at 06:06:19PM +0200, Christophe de Dinechin wrote: If my task is to "move version check to the

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-29 Thread Christophe de Dinechin
> On 28 Mar 2018, at 18:46, Christophe Fergeau wrote: > > On Wed, Mar 28, 2018 at 06:06:19PM +0200, Christophe de Dinechin wrote: >>> If my task is to "move version check to the agent", do I _have_ to change >>> the semantics of the version check? No. >> >> Of course you

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-29 Thread Christophe de Dinechin
> On 7 Mar 2018, at 12:51, Christophe Fergeau wrote: > > On Wed, Mar 07, 2018 at 12:28:57PM +0100, Christophe de Dinechin wrote: >>> This behaviour seems inconsistent with std::runtime_error(const char *) >>> which as far as I can tell does not have this lifetime