Hi,
On Thu, Jan 17, 2019 at 03:04:32AM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it.
>
> Later, I think it would make sense to switch to G_BIG_ENDIAN instead.
Indeed,
> Fixes:
>
Hi,
On Thu, Jan 17, 2019 at 03:08:43AM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> WORDS_BIGENDIAN is defined by autofoo macro.
> meson doesn't define it. Let's use the GLib defines instead.
We will probably need to fix spice-common too.
> Signed-off-by: Marc-André
Hey Iordan
On Thu, Jan 17, 2019 at 3:45 AM i iordanov wrote:
>
> Hello,
>
> Happy new year!
>
> I tried to build spice-gtk 0.34 and 0.35 with OpenSSL 1.1.0, and I got some
> linking errors:
>
>
Hello,
Happy new year!
I tried to build spice-gtk 0.34 and 0.35 with OpenSSL 1.1.0, and I got some
linking errors:
jni/src/../libs/deps/x86/root/lib/libspice-client-glib-2.0.a(spice-channel.o):spice-channel.c:function
spice_channel_class_intern_init: error: undefined reference to
From: Marc-André Lureau
../subprojects/spice-common/common/quic.c: In function 'fill_model_structures':
../subprojects/spice-common/common/quic.c:695:55: error: comparison of integer
expressions of different signedness: 'int' and 'unsigned int'
[-Werror=sign-compare]
From: Marc-André Lureau
WORDS_BIGENDIAN is defined by autofoo macro.
meson doesn't define it. Let's use the GLib defines instead.
Signed-off-by: Marc-André Lureau
---
tools/spicy-screenshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/spicy-screenshot.c
On Thu, Jan 17, 2019 at 3:04 AM wrote:
>
> From: Marc-André Lureau
>
> WORDS_BIGENDIAN is defined by autofoo macro.
> meson doesn't define it. Let's use the GLib define instead.
>
> Signed-off-by: Marc-André Lureau
> ---
> tools/spicy-screenshot.c | 2 +-
> 1 file changed, 1 insertion(+), 1
From: Marc-André Lureau
autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it.
Later, I think it would make sense to switch to G_BIG_ENDIAN instead.
Fixes:
https://gitlab.freedesktop.org/spice/spice-common/issues/2
Signed-off-by: Marc-André Lureau
---
meson.build | 3 +++
From: Marc-André Lureau
WORDS_BIGENDIAN is defined by autofoo macro.
meson doesn't define it. Let's use the GLib define instead.
Signed-off-by: Marc-André Lureau
---
tools/spicy-screenshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/spicy-screenshot.c
On Wed, Jan 16, 2019 at 6:08 AM Marc-André Lureau
wrote:
> On Wed, Jan 16, 2019 at 2:47 PM james harvey wrote:
> > Am I understanding correctly that the Jan 10 patches which completely
> > fix spice for me and others experiencing clipboard problems aren't
> > being added in any form, and that
Hi Daniel.
> v5: Actually try to sort them, and while at it, sort all the ones I
> touch.
Applied this variant on top of drm-misc and did a build test.
Looked good for ia64, x86 and alpha.
Took a closer look at the changes to atmel_hlcd - and they looked OK.
But I noticed that atmel_hlcdc uses
On Mon, Jan 07, 2019 at 03:50:12PM +0200, Yuri Benditovich wrote:
> On Mon, Nov 26, 2018 at 7:41 PM Christophe Fergeau
> wrote:
> > In _SpiceUsbDeviceManagerPrivate, you replaced
> > #ifndef G_OS_WIN32
> > libusb_device *libdev;
> > #endif
> >
> > with
> >
> > #ifndef G_OS_WIN32
> >
Hi,
I'm picking up the Virgl remote support patchset with the goal of
adapting it for use with Xspice.
If I'm not mistaken the latest version of this patchset is in the
virgl-spice branches of the following repositories:
On Wed, Jan 16, 2019 at 12:28:00PM +0100, Gerd Hoffmann wrote:
> > > +static int qxl_check_mode(struct qxl_device *qdev,
> > > + unsigned int width,
> > > + unsigned int height)
> > > +{
> > > + if (width * height * 4 > qdev->vram_size)
> >
> > Is someone
Adds an interface method to the FrameCapture class to get the device
display info (device address and device display id) for each display of
the graphics device that is captured.
Also adds functions to the API implementing this functionality for X11
in variants with and without DRM (the non-DRM
Receives the GraphicsDeviceInfo message from the streaming agent and
stores the data in a list on the streaming device.
Signed-off-by: Lukáš Hrázký
---
server/display-limits.h| 3 ++
server/red-qxl.c | 2 +-
server/red-stream-device.c | 78 +-
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 18 +++
server/red-stream-device.h | 7 +
server/reds.c | 63
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
spice/stream-device.h | 31 +++
1 file
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 3 ++
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c
Adds serialization of the GraphicsDeviceInfo message and sends it to the
server when it starts to stream.
Signed-off-by: Lukáš Hrázký
---
src/spice-streaming-agent.cpp | 54 +--
1 file changed, 45 insertions(+), 9 deletions(-)
diff --git
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
spice/vd_agent.h | 23 +++
1 file changed, 23 insertions(+)
diff --git
>
> Hi,
>
> On 1/16/19 12:35 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > NEWS | 25 +
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/NEWS b/NEWS
> > index 3f54f77..1693621 100644
>
From: Marc-André Lureau
- Fix the following warnings:
./spice-gtk-sections.txt:467: warning: No declaration found for
SPICE_GTK_CHECK_VERSION.
./spice-gtk-sections.txt:468: warning: No declaration found for
SPICE_GTK_MAJOR_VERSION.
./spice-gtk-sections.txt:469: warning: No declaration found
Hi,
On 1/16/19 12:35 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
NEWS | 25 +
1 file changed, 25 insertions(+)
diff --git a/NEWS b/NEWS
index 3f54f77..1693621 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,28 @@
On Tue, 2019-01-15 at 08:31 -0500, Frediano Ziglio wrote:
> >
> > Receives the GraphicsDeviceInfo message from the streaming agent and
> > stores the data in a list on the streaming device.
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > server/display-limits.h| 3 ++
> > server/red-qxl.c
>
> Hi
>
> On Wed, Jan 16, 2019 at 3:38 PM Frediano Ziglio wrote:
> >
> > >
> > > Hi
> > >
> > > On Wed, Jan 16, 2019 at 3:14 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> > > > > > Hi
>
Hi
On Wed, Jan 16, 2019 at 3:38 PM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Wed, Jan 16, 2019 at 3:14 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Hi,
> > > >
> > > > On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> > > > > Hi
> > > > >
> > > > >
> > > > > On Fri,
If test is run with root (for instance on Gitlab CI) creating
a file on a directory with no permission will succeed and
test will fail.
Instead create a link trying to create a file in /proc/1
directory (which fails also using root account).
Signed-off-by: Frediano Ziglio
---
>
> Hi
>
> On Wed, Jan 16, 2019 at 3:14 PM Frediano Ziglio wrote:
> >
> > >
> > > Hi,
> > >
> > > On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> > > > Hi
> > > >
> > > >
> > > > On Fri, Jan 11, 2019 at 3:03 PM wrote:
> > > > >
> > > > > From: Marc-André Lureau
> > > > >
Hi
On Wed, Jan 16, 2019 at 3:14 PM Frediano Ziglio wrote:
>
> >
> > Hi,
> >
> > On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > >
> > > On Fri, Jan 11, 2019 at 3:03 PM wrote:
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > There is a racy bug in
> > +static int qxl_check_mode(struct qxl_device *qdev,
> > + unsigned int width,
> > + unsigned int height)
> > +{
> > + if (width * height * 4 > qdev->vram_size)
>
> Is someone checking for integer overflows already?
Need to have a look. This is just
>
> Hi,
>
> On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> >
> > On Fri, Jan 11, 2019 at 3:03 PM wrote:
> > >
> > > From: Marc-André Lureau
> > >
> > > There is a racy bug in pulsesrc that we can't easily workaround:
> > >
Hi
On Wed, Jan 16, 2019 at 2:47 PM james harvey wrote:
>
> On Wed, Jan 16, 2019 at 4:10 AM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > Similar to 172c521271a3d - if we don't, the agent might be waiting for
> > data till some timeout happens in the system, blocking copy-paste
> >
Hi,
On Wed, Jan 16, 2019 at 02:33:49PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 16, 2019 at 1:18 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Wed, Jan 16, 2019 at 01:07:27PM +0400, Marc-André Lureau wrote:
> > > > Not true. Possible client-side bug, reproducible on X11, as I
> > > >
Hi,
On Wed, Jan 16, 2019 at 05:46:58AM -0500, james harvey wrote:
> On Wed, Jan 16, 2019 at 4:10 AM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > Similar to 172c521271a3d - if we don't, the agent might be waiting for
> > data till some timeout happens in the system, blocking copy-paste
>
Hi
On Wed, Jan 16, 2019 at 1:18 PM Victor Toso wrote:
>
> Hi,
>
> On Wed, Jan 16, 2019 at 01:07:27PM +0400, Marc-André Lureau wrote:
> > > Not true. Possible client-side bug, reproducible on X11, as I
> > > discussed before. As mentioned in the comment, we are sending
> > > wrong selection-grab
Hi
On Wed, Jan 16, 2019 at 10:03 AM Victor Toso wrote:
>
> Hi,
>
> On Wed, Jan 16, 2019 at 12:08:31AM +0400, Marc-André Lureau wrote:
> > On Tue, Jan 15, 2019 at 8:11 PM Victor Toso wrote:
> > >
> > > From: Victor Toso
> > >
> > > Hi,
> > >
> > > Several iteractions trying to avoid some bug in
>
> Make easier to test file creation
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/file-xfers.c | 88
> src/vdagent/file-xfers.h | 1 +
> 2 files changed, 53 insertions(+), 36 deletions(-)
>
> diff --git a/src/vdagent/file-xfers.c
Hi,
On Wed, Jan 16, 2019 at 09:49:22AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> Changes since v1:
> - move file to a new tests/ directory;
> - add missing .gitignore changes;
> - improve test to catch errors in open() other than EEXISTS.
> ---
Signed-off-by: Frediano Ziglio
---
Changes since v1:
- move file to a new tests/ directory;
- add missing .gitignore changes;
- improve test to catch errors in open() other than EEXISTS.
---
.gitignore | 17 +
Makefile.am | 22
>
> Add a helper functions to check video modes. Also add a helper to check
> framebuffer buffer objects, using the former for consistency. That way
> we should not fail in qxl_primary_atomic_check() because video modes
> which are too big will not be added to the mode list in the first place.
Hi,
On Wed, Jan 16, 2019 at 04:15:50AM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > For some reason I miss in my inbox the 6/7 patch. Looking at,
> > seems that mailman got it.
> >
> >
> > https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html
> >
> > My only
Hi,
On Wed, Jan 16, 2019 at 01:07:27PM +0400, Marc-André Lureau wrote:
> > Not true. Possible client-side bug, reproducible on X11, as I
> > discussed before. As mentioned in the comment, we are sending
> > wrong selection-grab to the guest.
>
> Sorry, I don't follow "we are sending wrong
Hi,
On Wed, Jan 16, 2019 at 12:43:06PM +0400, Marc-André Lureau wrote:
> Hi
>
>
> On Fri, Jan 11, 2019 at 3:03 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > There is a racy bug in pulsesrc that we can't easily workaround:
> >
From: Victor Toso
Similar to 172c521271a3d - if we don't, the agent might be waiting for
data till some timeout happens in the system, blocking copy-paste
feature and possibly freezing applications.
A way to reproduce is copy-paste big clipboard data between two spice
clients.
Also add some
Hi
On Wed, Jan 16, 2019 at 12:56 PM Victor Toso wrote:
>
> Hi,
>
> On Wed, Jan 16, 2019 at 12:40:36PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Jan 16, 2019 at 11:44 AM Victor Toso wrote:
> > >
> > > From: Victor Toso
> > >
> > > Similar to 172c521271a3d - if we don't, the agent
Hi,
On Wed, Jan 16, 2019 at 12:40:36PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 16, 2019 at 11:44 AM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > Similar to 172c521271a3d - if we don't, the agent might be waiting for
> > data till some timeout happens in the system,
Hi
On Fri, Jan 11, 2019 at 3:03 PM wrote:
>
> From: Marc-André Lureau
>
> There is a racy bug in pulsesrc that we can't easily workaround:
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/69
>
> It is fixed with 1.15, and will be backported to upcoming 1.14.5.
>
>
On 1/15/19 2:26 PM, Neil Armstrong wrote:
On 15/01/2019 11:41, Daniel Vetter wrote:
Having the probe helper stuff (which pretty much everyone needs) in
the drm_crtc_helper.h file (which atomic drivers should never need) is
confusing. Split them out.
To make sure I actually achieved the goal
Commit 098268a33c7c8008ccec9050aea8f0763f1c06d5 (systemd: Update path
in unit file) was a really incomplete change. Let's change every
occurrence of /var/run to /run.
Signed-off-by: Christian Hesse
---
README | 2 +-
data/spice-vdagentd | 4 ++--
Hi Daniel,
Thank you for the patch.
On Tuesday, 15 January 2019 12:41:37 EET Daniel Vetter wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I
On Tue, Jan 15, 2019 at 5:41 AM Daniel Vetter wrote:
>
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I actually achieved the goal here I went through all
Hi
On Wed, Jan 16, 2019 at 11:44 AM Victor Toso wrote:
>
> From: Victor Toso
>
> Similar to 172c521271a3d - if we don't, the agent might be waiting for
> data till some timeout happens in the system, blocking copy-paste
> feature and possibly freezing applications.
>
> A way to reproduce is
Add a helper function to add custom video modes to a connector.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_display.c | 84 +++
1 file changed, 49 insertions(+), 35 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
Add a helper functions to check video modes. Also add a helper to check
framebuffer buffer objects, using the former for consistency. That way
we should not fail in qxl_primary_atomic_check() because video modes
which are too big will not be added to the mode list in the first place.
Add all standard modes from the kernel's video mode data base.
Keep a few non-standard modes in the qxl mode list.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_display.c | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git
Hi,
For some reason I miss in my inbox the 6/7 patch. Looking at,
seems that mailman got it.
https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html
My only suggestion is to move the test to root directory instead
of srcdir. I'd prefer also to use the glib test framework
57 matches
Mail list logo
