Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 6:21 PM Frediano Ziglio wrote: > Looking at http://mesonbuild.com/Subprojects.html looks like > subprojects should be Meson project too. > While spice-common is now a Meson project keycodemapdb is not > so it does not seem that great to declare it as subproject. Ok,

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
> Hi > > On Fri, Feb 15, 2019 at 5:21 PM Frediano Ziglio wrote: > > > > > Hi > > > > > > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio > > > wrote: > > > > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > > > Follow meson build system conventions. > > > > > > > > > > This will

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 5:21 PM Frediano Ziglio wrote: > > > Hi > > > > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote: > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > Follow meson build system conventions. > > > > > > > > This will allow meson to handle it as a

Re: [Spice-devel] [PATCH spice-gtk 08/12] meson: remove our own submodule update

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 5:19 PM Frediano Ziglio wrote: > > > Hi > > > > On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote: > > > > > > > From: Marc-André Lureau > > > > > > > > Our own handling was limited, since it checked only spice-common. > > > > > > > > This is handled by meson

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
> Hi > > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > Follow meson build system conventions. > > > > > > This will allow meson to handle it as a subproject. > > > > > > Signed-off-by: Marc-André Lureau > > > --- > > > Changes since

Re: [Spice-devel] [PATCH spice-gtk 08/12] meson: remove our own submodule update

2019-02-15 Thread Frediano Ziglio
> Hi > > On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > > > Our own handling was limited, since it checked only spice-common. > > > > > > This is handled by meson since v0.40 for subprojects. > > > > > > Signed-off-by: Marc-André Lureau > > >

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Marc-André Lureau
On Fri, Feb 15, 2019 at 4:54 PM Frediano Ziglio wrote: > > > Hi > > > > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote: > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > Follow meson build system conventions. > > > > > > > > This will allow meson to handle it as a subproject.

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
> Hi > > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > Follow meson build system conventions. > > > > > > This will allow meson to handle it as a subproject. > > > > > > Signed-off-by: Marc-André Lureau > > > --- > > > Changes since

Re: [Spice-devel] [PATCH spice-gtk 05/12] meson: add vcs_tag to session init debug log

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > Use the trick recommended here to generate a vcs_tag.h at build-time: > > https://github.com/mesonbuild/meson/issues/3903 > > > > Hopefully, meson will learn to generate project version from git:

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > Follow meson build system conventions. > > > > This will allow meson to handle it as a subproject. > > > > Signed-off-by: Marc-André Lureau > > --- > > Changes since v1: > > - rebase; > > -

Re: [Spice-devel] [PATCH spice-gtk 08/12] meson: remove our own submodule update

2019-02-15 Thread Marc-André Lureau
Hi On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > Our own handling was limited, since it checked only spice-common. > > > > This is handled by meson since v0.40 for subprojects. > > > > Signed-off-by: Marc-André Lureau > > --- > >

Re: [Spice-devel] [PATCH spice-gtk] desktop-integration: Avoid empty private structure

2019-02-15 Thread Marc-André Lureau
On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote: > > This causes a critical warning as private structures should not > be empty. > > Signed-off-by: Frediano Ziglio ack > --- > src/desktop-integration.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/desktop-integration.c

[Spice-devel] [PATCH v5] spice: set device address and device display ID in QXL interface

2019-02-15 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the

Re: [Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Follow meson build system conventions. > > This will allow meson to handle it as a subproject. > > Signed-off-by: Marc-André Lureau > --- > Changes since v1: > - rebase; > - support still Autoconf. > --- > .gitmodules | 4 ++-- >

Re: [Spice-devel] [PATCH spice-gtk 05/12] meson: add vcs_tag to session init debug log

2019-02-15 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Use the trick recommended here to generate a vcs_tag.h at build-time: > https://github.com/mesonbuild/meson/issues/3903 > > Hopefully, meson will learn to generate project version from git: > https://github.com/mesonbuild/meson/issues/688 > > Signed-off-by:

[Spice-devel] [PATCH v4] spice: set device address and device display ID in QXL interface

2019-02-15 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the

Re: [Spice-devel] [PATCH spice-html5 2/3] Fix the console toggle in the new ES6 environment.

2019-02-15 Thread Cedric Bosdonnat
On Thu, 2019-02-14 at 12:55 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > spice.html | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/spice.html b/spice.html > index f9e1af4..d744ef9 100644 > --- a/spice.html > +++ b/spice.html > @@ -146,8

[Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
From: Marc-André Lureau Follow meson build system conventions. This will allow meson to handle it as a subproject. Signed-off-by: Marc-André Lureau --- Changes since v1: - rebase; - support still Autoconf. --- .gitmodules | 4 ++-- meson.build |

[Spice-devel] [PATCH spice-gtk] desktop-integration: Avoid empty private structure

2019-02-15 Thread Frediano Ziglio
This causes a critical warning as private structures should not be empty. Signed-off-by: Frediano Ziglio --- src/desktop-integration.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/desktop-integration.c b/src/desktop-integration.c index 8458efaa..6f569ae2 100644 ---

[Spice-devel] [PATCH spice-gtk v2] Move src/keycodemapdb -> subprojects/keycodemapdb

2019-02-15 Thread Frediano Ziglio
From: Marc-André Lureau Follow meson build system conventions. This will allow meson to handle it as a subproject. Signed-off-by: Marc-André Lureau --- Changes since v1: - rebase; - support still Autoconf. --- .gitmodules | 4 ++-- meson.build |

Re: [Spice-devel] [PATCH spice-html5 1/3] Generate package.json from the Makefile.

2019-02-15 Thread Cedric Bosdonnat
On Thu, 2019-02-14 at 12:55 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > .gitignore | 1 + > Makefile| 30 +- > package.json => package.json.in | 2 +- > 3 files changed, 23 insertions(+), 10

Re: [Spice-devel] [PATCH spice-gtk 08/12] meson: remove our own submodule update

2019-02-15 Thread Frediano Ziglio
> From: Marc-André Lureau > > Our own handling was limited, since it checked only spice-common. > > This is handled by meson since v0.40 for subprojects. > > Signed-off-by: Marc-André Lureau > --- > build-aux/meson/check-spice-common | 5 - > meson.build| 3 --- >

Re: [Spice-devel] [PATCH spice-gtk 03/12] meson: fix po generation

2019-02-15 Thread Frediano Ziglio
> Hi > On Tue, Feb 12, 2019 at 12:35 PM Frediano Ziglio wrote: > > > > > > > From: Marc-André Lureau > > > > > > Use glib preset (from meson v0.37) to catch all our translatable > > > strings and use good default settings. > > > Comparing with Autoconf they catch a bit less strings, I'll send

Re: [Spice-devel] [PATCH spice-html5 3/3] Hide the message console by default.

2019-02-15 Thread Cedric Bosdonnat
On Thu, 2019-02-14 at 12:55 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > spice.css | 2 ++ > spice.html | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/spice.css b/spice.css > index 4c61cb3..968ba16 100644 > --- a/spice.css > +++ b/spice.css > @@

Re: [Spice-devel] Why does spice server keep sending streaming data while video is not being played?

2019-02-15 Thread 陈炤
Thanks for your answer! I changed to another player and the issus was gone. At 2019-02-14 17:44:46, "Uri Lublin" wrote: >On 2/14/19 4:40 AM, 陈炤 wrote: >> Hi, >> >> My spice server is 0.14.1 and gtk is master in the repository. >> >> I was testing video stream. I set video-streaming to

Re: [Spice-devel] Why does spice server keep sending streaming data while video is not being played?

2019-02-15 Thread 陈炤
Yes, my player cause this. I changed my player to another one and the issue was gone. Thanks a lot! At 2019-02-14 17:36:26, "Frediano Ziglio" wrote: Hi, My spice server is 0.14.1 and gtk is master in the repository. I was testing video stream. I set video-streaming to "filter" and