Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

2019-03-15 Thread Jakub Janku
Hey, On Fri, Mar 15, 2019 at 8:02 PM Marc-André Lureau wrote: > > Hi > > On Fri, Mar 15, 2019 at 4:43 PM Jakub Janku wrote: > > > > Hi, > > > > On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > >

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

2019-03-15 Thread Marc-André Lureau
Hi On Fri, Mar 15, 2019 at 4:43 PM Jakub Janku wrote: > > Hi, > > On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > > > If two grab messages in opposite directions "meet" on their way > > > to their

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

2019-03-15 Thread Jakub Janku
Hi, On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > If two grab messages in opposite directions "meet" on their way > > to their destinations, we end up in a state when both spice-gtk > > and spice-vdagent think that

Re: [Spice-devel] [PATCH spice-common] meson: Remove some useless checks

2019-03-15 Thread Eduardo Lima (Etrunko)
On 3/13/19 2:24 PM, Frediano Ziglio wrote: > Do not check for functions not used or available in C89 and earlier. > Autoconf check for them to support archaic systems. > > Signed-off-by: Frediano Ziglio > --- > meson.build | 5 - > 1 file changed, 5 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server v2] Move channel registration to constructed vfunc

2019-03-15 Thread Jonathon Jongsma
On Fri, 2019-03-15 at 05:05 -0400, Frediano Ziglio wrote: > > > > For the Display Channel and the Cursor channel, move the call to > > reds_register_channel() to the _constructed() vfunc rather than > > calling > > it explicitly from RedWorker. This matches what other channels do. > > --- > >

Re: [Spice-devel] [PATCH spice-server 2/2] Remove support for 64 bit pointers on protocol

2019-03-15 Thread Frediano Ziglio
ping > > Import "codegen: Remove support for --ptrsize" change from spice-common > and update code accordingly. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 2 +- > server/dcc-send.c| 2 +- > server/reds.c| 2 +- > server/smartcard.c | 2 +- >

[Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-15 Thread Frediano Ziglio
To avoid possibly regression check it only if extra checks are enabled. This allowed to check previous "Move channel registration to constructed vfunc" commit. Signed-off-by: Frediano Ziglio --- server/reds.c | 5 + 1 file changed, 5 insertions(+) diff --git a/server/reds.c b/server/reds.c

Re: [Spice-devel] [PATCH spice-server v2] Move channel registration to constructed vfunc

2019-03-15 Thread Frediano Ziglio
> > For the Display Channel and the Cursor channel, move the call to > reds_register_channel() to the _constructed() vfunc rather than calling > it explicitly from RedWorker. This matches what other channels do. > --- > Changes in v2: > - remove cursor channel registration in stream device > >

Re: [Spice-devel] [PATCH spice-server v2] Move channel registration to constructed vfunc

2019-03-15 Thread Frediano Ziglio
> > For the Display Channel and the Cursor channel, move the call to > reds_register_channel() to the _constructed() vfunc rather than calling > it explicitly from RedWorker. This matches what other channels do. Acked-by: Frediano Ziglio > --- > Changes in v2: > - remove cursor channel