From: Marc-André Lureau
Do not rely on internal state when receiving clipboard events, as this
may race with external events. Use gtk_clipboard_set_with_owner()
Signed-off-by: Marc-André Lureau
---
src/vdagent/clipboard.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff -
From: Marc-André Lureau
Improve readability a bit, reindent slightly.
Signed-off-by: Marc-André Lureau
---
src/vdagent/vdagent.c | 37 ++---
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
index 13ef2
From: Marc-André Lureau
Implement the behaviour described in protocol "vdagent: introduce
VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL".
Signed-off-by: Marc-André Lureau
---
src/vdagentd/vdagentd.c | 40 +++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git
From: Marc-André Lureau
Do not send a release event between two grabs, this helps with window
manager interaction issues on peer side.
Advertise this behaviour via a capability introduced in spice-protocol
0.12.16, so the client doesn't need to do some time-based filtering.
(the capability shou
From: Marc-André Lureau
This will allow easier lifecycle management,
and usage of gtk_clipboard_set_with_owner()
Signed-off-by: Marc-André Lureau
---
src/vdagent/clipboard.c | 67 +++--
src/vdagent/clipboard.h | 12 +---
src/vdagent/vdagent.c | 7 +++-
From: Marc-André Lureau
This is required for using the new GObject macros.
According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump
GLib version to 2.34"), RHEL6 is no longer supported.
GLib version across some distributions, from repology:
- Debian Stable (9): 2.50.3
- CentOS 7: 2.5
From: Marc-André Lureau
The following patches are going to introduce GObject. It's not a big
change, since usually glib comes installed with gobject on most systems.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 12 ++--
configure.ac | 2 +-
2 files changed, 7 insertions(+), 7
From: Marc-André Lureau
Modernize a bit the code, using gtk_clipboard_get_selection().
Signed-off-by: Marc-André Lureau
---
src/vdagent/clipboard.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/src/vdagent/clipboard.c b/src/vdagent/clipboard
From: Marc-André Lureau
Set a default profile for git-publish.
(https://github.com/stefanha/git-publish)
Signed-off-by: Marc-André Lureau
---
.gitpublish | 4
1 file changed, 4 insertions(+)
create mode 100644 .gitpublish
diff --git a/.gitpublish b/.gitpublish
new file mode 100644
index
From: Marc-André Lureau
Hi,
This series implements 2 protocol capabilities for solving some
clipboard race issues, and other minor improvements.
For a description of the changes, see related patches and protocol changes:
- [PATCH spice-protocol] vdagent: introduce
VD_AGENT_CAP_CLIPBOARD_NO_REL
From: Marc-André Lureau
According to repology,
- Debian Stable (9): 3.22.11
- CentOS 7: 3.22.30
- Fedora 26: 3.22.21 (fwiw, Fedora 30: 3.24.7)
Signed-off-by: Marc-André Lureau
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index
From: Marc-André Lureau
According to sd_seat_get_active(2), you must free() the pointer.
Signed-off-by: Marc-André Lureau
---
src/vdagentd/systemd-login.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagentd/systemd-login.c b/src/vdagentd/systemd-login.c
index a11b66d..0b2dd0a 1006
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 32 +++-
src/spice-gtk-session.c | 1 -
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index e359e8d..ced037e 100644
--- a
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
configure.ac| 2 +-
meson.build | 2 +-
src/channel-main.c | 2 ++
src/spice-gtk-session.c | 9 -
4 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index d
From: Marc-André Lureau
Hi,
This series implements 2 protocol capabilities for solving some
clipboard race issues.
For a description of the changes, see related patches and protocol changes:
- [PATCH spice-protocol] vdagent: introduce
VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB
- [PATCH spice-
From: Marc-André Lureau
The protocol uses a u8 for the selection value. Make sure the given
argument value fits there, or throw a critical.
The other places seem to use u8 variables already.
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 1 +
1 file changed, 1 insertion(+)
diff --
On Fri, Mar 22, 2019 at 02:56:46PM +0100, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Set a default profile for git-publish.
> (https://github.com/stefanha/git-publish)
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitpublish | 4
> 1 file changed, 4 insertions(+)
>
From: Marc-André Lureau
This capability means the peer will not send a release event between
two subsequent grabs. This helps with interaction issues with
clipboard managers which can be worked around by time-based filters at
this point. With this capability, there is no need for such filter.
Si
From: Marc-André Lureau
When this capability is negoticated by both the client & the agent,
the clipboard grab messages have an associated serial counter.
The serial is reset to 0 upon client connection.
The counter is increment by 1 on each grab message, by both sides.
The sender of the messa
From: Marc-André Lureau
Set a default profile for git-publish.
(https://github.com/stefanha/git-publish)
Signed-off-by: Marc-André Lureau
---
.gitpublish | 4
1 file changed, 4 insertions(+)
create mode 100644 .gitpublish
diff --git a/.gitpublish b/.gitpublish
new file mode 100644
index
On this page:
https://www.spice-space.org/support.html
It points to bugzilla for bugs, but spice doesn't exist there anymore.
It needs updating to point to gitlab i presume.
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.o
> Subject: [Spice-devel] [PATCH] remove a duplicate line
>
duplicate -> duplicated
> Signed-off-by: kunming.xie
Apart from that patch it's fine,
acked
> ---
> server/dcc-send.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 326e6fa8..8
Signed-off-by: kunming.xie
---
server/dcc-send.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 326e6fa8..84fa1be7 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -1979,7 +1979,6 @@ static void red_marshall_image(RedChannelClient *rcc,
Hi James,
If you have the time, could you give this a try?
Cheers,
On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> There has been several reports of clipboard issues that seem related
> to clipboard managers interactions. Alth
24 matches
Mail list logo
