Hi
On Thu, Mar 28, 2019 at 6:05 PM Frediano Ziglio wrote:
>
> >
> > ..Hi
> >
> > On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio wrote:
> > > > The role of the grab message is to take ownership of the clipboard (to
> > > > advertize clipboard data available). It may come at any time from both
>
Hi
On Thu, Mar 28, 2019 at 5:30 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Do not send a release event between two grabs, this helps with window
> > manager interaction issues on peer side.
> >
>
> I would explain which kind of issue this is supposed to fix.
They react
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> The only caller only called that function.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel-private.h | 1 +
> server/display-channel.c | 10 --
> server/display-channel.h | 2 ++
> server/red-worker.c
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Do not check it after assigning to reds->config->image_compression,
> check the value as soon as possible.
> This prevent potential invalid settings.
>
> Signed-off-by: Frediano Ziglio
> ---
>
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> DisplayChannelClient get them directly from reds (they are changed
> only during initialisation so they can be read freely from any
> thread).
>
> Signed-off-by: Frediano Ziglio
> ---
>
This also looks like a patch that should get squashed (maybe parts
should be squashed into two different previous commits, see below), but
I agree with all of the changes.
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
>
Personally, I would squash this patch with the previous one
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Now that stuff are a bit more on their correct place some
> function can be static.
>
> Signed-off-by: Frediano Ziglio
> ---
>
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> No reasons to expose red_qxl_is_running, this was used to not
> send capability is the state was not running.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 3 ---
> server/red-qxl.c
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 108 +
> server/display-channel.h | 7 +++
> server/red-worker.c | 114
>
> This fixes a warning about missing prototype for backtrace()
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/backtrace.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/common/backtrace.c b/common/backtrace.c
> index c4edde1..ff72d1b 100644
>
>
> QUIC_VERSION_MINOR is never used.. Set QUIC_VERSION_MINOR to the same
> version as QUIC_VERSION_MAJOR to avoid breaking backwards compatibility,
> and fix the QUIC_VERSION macro.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/quic.c | 4 ++--
> 1 file
>
> The for(;;) hack was taken from glib's logging macros.
>
> Signed-off-by: Christophe Fergeau
> ---
> common/log.h | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/common/log.h b/common/log.h
> index 7c67e7a..b397306 100644
> --- a/common/log.h
> +++ b/common/log.h
> @@
>
> Signed-off-by: Christophe Fergeau
> ---
> common/verify.h | 24 +++-
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/common/verify.h b/common/verify.h
> index 267de29..b2e5f64 100644
> --- a/common/verify.h
> +++ b/common/verify.h
> @@ -1,19 +1,19 @@
>
> encoder->type is only going to be set by lz_set_sizes() after the
> error() call. We can use 'type' directly which is what encoder->type is
> going to be set to.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/lz.c | 2 +-
> 1 file changed, 1 insertion(+),
>
> test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> prevent multiple #include for the same header.
>
> Signed-off-by: Christophe Fergeau
> ---
> tests/test-marshallers.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-marshallers.h
>
> They were suggested by gcc when using -Wsuggest-attribute=format
>
> Signed-off-by: Christophe Fergeau
> ---
> common/log.c | 13 +++--
> tests/test-logging.c | 1 +
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/common/log.c b/common/log.c
> index
This fixes a warning about missing prototype for backtrace()
Signed-off-by: Christophe Fergeau
---
common/backtrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/backtrace.c b/common/backtrace.c
index c4edde1..ff72d1b 100644
--- a/common/backtrace.c
+++ b/common/backtrace.c
@@
test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
prevent multiple #include for the same header.
Signed-off-by: Christophe Fergeau
---
tests/test-marshallers.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
index
canvas_base.c is #included by spice-common users. They currently don't
enable this warning, but if/when they do, we don't want code from
spice-common to trigger it.
Signed-off-by: Christophe Fergeau
---
common/canvas_base.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
The for(;;) hack was taken from glib's logging macros.
Signed-off-by: Christophe Fergeau
---
common/log.h | 8
1 file changed, 8 insertions(+)
diff --git a/common/log.h b/common/log.h
index 7c67e7a..b397306 100644
--- a/common/log.h
+++ b/common/log.h
@@ -20,6 +20,7 @@
#include
Hey,
This is the first set of hopefully more patches, long story short, I
wanted to add manywarnings.m4 to spice-common, but its compilation is
not fully clean at the moment. Here are patches for some of the warnings
I got when trying to add support for it.
Christophe
encoder->type is only going to be set by lz_set_sizes() after the
error() call. We can use 'type' directly which is what encoder->type is
going to be set to.
Signed-off-by: Christophe Fergeau
---
common/lz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/lz.c
QUIC_VERSION_MINOR is never used.. Set QUIC_VERSION_MINOR to the same
version as QUIC_VERSION_MAJOR to avoid breaking backwards compatibility,
and fix the QUIC_VERSION macro.
Signed-off-by: Christophe Fergeau
---
common/quic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Signed-off-by: Christophe Fergeau
---
common/verify.h | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..b2e5f64 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,19 +1,19 @@
/* Compile-time
They were suggested by gcc when using -Wsuggest-attribute=format
Signed-off-by: Christophe Fergeau
---
common/log.c | 13 +++--
tests/test-logging.c | 1 +
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/common/log.c b/common/log.c
index b73da71..7cb3e36 100644
>
> ..Hi
>
> On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio wrote:
> > > The role of the grab message is to take ownership of the clipboard (to
> > > advertize clipboard data available). It may come at any time from both
> > > side, and override the current grab owner. It may come from the
>
> From: Marc-André Lureau
>
> Do not send a release event between two grabs, this helps with window
> manager interaction issues on peer side.
>
I would explain which kind of issue this is supposed to fix.
> Advertise this behaviour via a capability introduced in spice-protocol
> 0.12.16,
Hi
On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote:
>
> Hi,
>
> On Fri, Mar 22, 2019 at 4:13 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > This is required for using the new GObject macros.
>
> Which macros are you referring to?
> G_DECLARE_FINAL_TYPE is available since 2.44
That's
Hi
On Thu, Mar 28, 2019 at 4:27 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > This is required for using the new GObject macros.
> >
> > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump
> > GLib version to 2.34"), RHEL6 is no longer supported.
> >
> >
Acked-by: Jonathon Jongsma
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> Currently channel threading/handling is spread between RedQxl,
> RedWorker and RedChannel.
> Move more to RedChannel simplify RedQxl and RedWorker.
>
> Signed-off-by: Frediano Ziglio
> ---
>
> On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> > The only way to add new message to Dispatcher was to register
> > using a number. These numbers corresponded to array indexes.
> > This is good if the list of messages is allocated statically
> > and contiguously, on the contrary this
..Hi
On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio wrote:
> > The role of the grab message is to take ownership of the clipboard (to
> > advertize clipboard data available). It may come at any time from both
> > side, and override the current grab owner. It may come from the guest
> > (after
>
> From: Marc-André Lureau
>
> This is required for using the new GObject macros.
>
> According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump
> GLib version to 2.34"), RHEL6 is no longer supported.
>
> GLib version across some distributions, from repology:
> - Debian Stable (9):
On Tue, 2019-03-26 at 19:10 +, Frediano Ziglio wrote:
> The only way to add new message to Dispatcher was to register
> using a number. These numbers corresponded to array indexes.
> This is good if the list of messages is allocated statically
> and contiguously, on the contrary this method is
> Hi
>
> On Wed, Mar 27, 2019 at 4:50 PM Frediano Ziglio wrote:
> >
> > > Hi
> > >
> > > On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > From: Marc-André Lureau
> > > > >
> > > > > When this capability is negoticated by both the client & the agent,
> >
> On Thu, Mar 28, 2019 at 04:25:31AM -0400, Frediano Ziglio wrote:
> > >
> > > On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > > > Signed-off-by: Frediano Ziglio
> > > > ---
> > > > docs/spice_threading_model.txt | 8
> > > > 1 file changed, 8 insertions(+)
> > > >
Hi Spice Developer(s),
Not sure this email should go to you, but I am not sure where else to go.
Recently started using Spice with libvirt and found great performance.
I have started a Windows 10 guest vm and it is working fine with 1 monitor.
I saw on your website
On Thu, Mar 28, 2019 at 04:25:31AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > docs/spice_threading_model.txt | 8
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff
Hi
On Wed, Mar 27, 2019 at 4:50 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > When this capability is negoticated by both the client & the agent,
> > >
> > > negotiated
> > >
> > >
>
> On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > docs/spice_threading_model.txt | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/docs/spice_threading_model.txt
> > b/docs/spice_threading_model.txt
> >
41 matches
Mail list logo
