On 3/29/19 6:47 AM, Frediano Ziglio wrote:
> Pull some fixes and features.
> One of the feature is the support for @output setting to redirect
> log output.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/recorder | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
This commit adds a SPICE_UNREACHABLE macro (courtesy of Frediano)
so that gcc does not think that code control can go past
spice_return_{val_,}if_fail(), spice_critical() and spice_error()
This avoids this kind of warnings:
fallthrough.c:
#include "log.h"
int main(int argc, char **argv)
{
On Wed, Mar 27, 2019 at 04:24:02AM -0400, Frediano Ziglio wrote:
> ping
Acked-by: Christophe Fergeau
though imo this should be reflected in version numbering ;)
>
> > >
> > > This is breaking spice-protocol API even if this should not impact
> > > current code. Do we want to advertise this
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote:
> ping
I guess I would reword this as "char-device: Don't use RedClient API"
RedCharDevice only use red_client_get_server() once, we can store a
Reds* in RedCharDeviceClient instead. This will make it possible to turn
the RedClient
Hey,
Your VM configuration does not seem to have a spicevmc channel device,
so I assume spice-vdagent is not running in the guest? This is required
for proper mouse behaviour in multiscreen setups.
Christophe
On Thu, Mar 28, 2019 at 10:59:16AM +0100, Mathias Egekvist wrote:
> Hi Spice
On Thu, Mar 28, 2019 at 10:27:46AM -0400, Frediano Ziglio wrote:
> > On Thu, Mar 28, 2019 at 04:25:31AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > > > > Signed-off-by: Frediano Ziglio
> > > > > ---
> > > > >
For the series,
Acked-by: Christophe Fergeau
On Fri, Mar 29, 2019 at 12:29:58PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/server/red-channel.c b/server/red-channel.c
> index
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/verify.h | 22 +-
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/common/verify.h b/common/verify.h
> index 267de29..ecd8cdb 100644
> --- a/common/verify.h
> +++
Signed-off-by: Christophe Fergeau
---
common/verify.h | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..ecd8cdb 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,6 +1,6 @@
/* Compile-time
On Fri, Mar 29, 2019 at 06:44:49AM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/verify.h | 24 ++--
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
> > diff --git a/common/verify.h b/common/verify.h
> > index
On Fri, Mar 29, 2019 at 06:51:54AM -0400, Frediano Ziglio wrote:
> >
> > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > will never return.
> >
> > Signed-off-by: Christophe Fergeau
>
> I prefer the "for" way. But by the way, this is not telling the compiler
> that
On Fri, Mar 29, 2019 at 07:18:35AM -0400, Frediano Ziglio wrote:
> > On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote:
> > > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> > > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > > >
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/server/red-channel.c b/server/red-channel.c
index 121c7e475..4015c12df 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@ -70,6 +70,9 @@ struct RedChannelPrivate
Easier to understand.
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/red-worker.c b/server/red-worker.c
index bc63fc34f..a30148a55 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -83,7 +83,7
Signed-off-by: Frediano Ziglio
---
server/red-worker.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/server/red-worker.h b/server/red-worker.h
index 34c5b4aff..a107c178c 100644
--- a/server/red-worker.h
+++ b/server/red-worker.h
@@ -202,12 +202,6 @@ typedef struct
Hi
On Fri, Mar 29, 2019 at 10:17 AM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Thu, Mar 28, 2019 at 5:30 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > Do not send a release event between two grabs, this helps with window
> > > > manager interaction
> On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote:
> > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > > > will never return.
> > > >
> > > > Signed-off-by: Christophe Fergeau
Hi
On Fri, Mar 29, 2019 at 10:11 AM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Thu, Mar 28, 2019 at 6:05 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > ..Hi
> > > >
> > > > On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio
> > > > wrote:
> > > > > > The role of the grab message is to take
ClientCbs were removed, all is automated in RedChannel.
Signed-off-by: Frediano Ziglio
---
docs/spice_threading_model.txt | 8
1 file changed, 8 deletions(-)
diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
index 1ed82d4b4..62be39bbf 100644
---
Signed-off-by: Frediano Ziglio
---
docs/spice_threading_model.txt | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
index 9351141c8..1ed82d4b4 100644
--- a/docs/spice_threading_model.txt
+++
ping
>
> Allows the plugins to add information to the log.
>
> Signed-off-by: Frediano Ziglio
> ---
> Not entirely happy to export a kind of C function, any suggestion
> welcome
> ---
> include/spice-streaming-agent/plugin.hpp | 5 +
> src/concrete-agent.cpp | 16
On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote:
> > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > > will never return.
> > >
> > > Signed-off-by: Christophe Fergeau
> > > ---
>
> On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > will never return.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/log.h | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff
On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> will never return.
>
> Signed-off-by: Christophe Fergeau
> ---
> common/log.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/common/log.h
>
> Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> will never return.
>
> Signed-off-by: Christophe Fergeau
I prefer the "for" way. But by the way, this is not telling the compiler
that spice_log (NOT g_log) is not returning but to call abort() after
spice_log.
I don't
>
> test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> prevent multiple #include for the same header.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> tests/test-marshallers.h | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>
>
> They were suggested by gcc when using -Wsuggest-attribute=format
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/log.c | 1 +
> tests/test-logging.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/common/log.c b/common/log.c
> index
>
> Signed-off-by: Christophe Fergeau
> ---
> common/verify.h | 24 ++--
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/common/verify.h b/common/verify.h
> index 267de29..3f3dece 100644
> --- a/common/verify.h
> +++ b/common/verify.h
> @@ -1,10 +1,10
They were suggested by gcc when using -Wsuggest-attribute=format
Signed-off-by: Christophe Fergeau
---
common/log.c | 1 +
tests/test-logging.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/common/log.c b/common/log.c
index b73da71..ce162a1 100644
--- a/common/log.c
+++
Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
will never return.
Signed-off-by: Christophe Fergeau
---
common/log.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/common/log.h b/common/log.h
index 7c67e7a..1482358 100644
--- a/common/log.h
+++ b/common/log.h
@@
test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
prevent multiple #include for the same header.
Signed-off-by: Christophe Fergeau
---
tests/test-marshallers.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/test-marshallers.h
encoder->type is only going to be set by lz_set_sizes() after the
error() call. We can use 'type' directly which is what encoder->type is
going to be set to.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/lz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This fixes a warning about missing prototype for backtrace()
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/backtrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/backtrace.c b/common/backtrace.c
index c4edde1..ff72d1b 100644
--- a/common/backtrace.c
QUIC_VERSION_MINOR is never used.. Set QUIC_VERSION_MINOR to the same
version as QUIC_VERSION_MAJOR to avoid breaking backwards compatibility,
and fix the QUIC_VERSION macro.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/quic.c | 4 ++--
1 file changed, 2
canvas_base.c is #included by spice-common users. They currently don't
enable this warning, but if/when they do, we don't want code from
spice-common to trigger it.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/canvas_base.c | 8
1 file changed, 4
Signed-off-by: Christophe Fergeau
---
common/verify.h | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..3f3dece 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,10 +1,10 @@
/* Compile-time
On Thu, Mar 28, 2019 at 01:54:01PM -0400, Frediano Ziglio wrote:
> >
> > test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> > prevent multiple #include for the same header.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > tests/test-marshallers.h | 1 +
> > 1 file
> canvas_base.c is #included by spice-common users. They currently don't
> enable this warning, but if/when they do, we don't want code from
> spice-common to trigger it.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> common/canvas_base.c | 8
> 1 file
> On Thu, Mar 28, 2019 at 02:02:58PM -0400, Frediano Ziglio wrote:
> > >
> > > The for(;;) hack was taken from glib's logging macros.
> > >
> > > Signed-off-by: Christophe Fergeau
> > > ---
> > > common/log.h | 8
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git
On Thu, Mar 28, 2019 at 01:56:06PM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/verify.h | 24 +++-
> > 1 file changed, 15 insertions(+), 9 deletions(-)
> >
> > diff --git a/common/verify.h b/common/verify.h
> > index
On Thu, Mar 28, 2019 at 02:02:58PM -0400, Frediano Ziglio wrote:
> >
> > The for(;;) hack was taken from glib's logging macros.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/log.h | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/common/log.h b/common/log.h
Pull some fixes and features.
One of the feature is the support for @output setting to redirect
log output.
Signed-off-by: Frediano Ziglio
---
common/recorder | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/recorder b/common/recorder
index 03eb4b6..10b1787 16
---
>
> Hi
>
> On Thu, Mar 28, 2019 at 5:30 PM Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > Do not send a release event between two grabs, this helps with window
> > > manager interaction issues on peer side.
> > >
> >
> > I would explain which kind of issue this is
>
> Hi
>
> On Thu, Mar 28, 2019 at 6:05 PM Frediano Ziglio wrote:
> >
> > >
> > > ..Hi
> > >
> > > On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio
> > > wrote:
> > > > > The role of the grab message is to take ownership of the clipboard
> > > > > (to
> > > > > advertize clipboard data
Signed-off-by: Frediano Ziglio
---
README.Windows | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 README.Windows
diff --git a/README.Windows b/README.Windows
new file mode 100644
index 0..a953813de
--- /dev/null
+++ b/README.Windows
@@ -0,0 +1,18 @@
+SPICE
Between Unix and Windows socket are quite different:
- on Windows sockets have a different namespace from C file
descriptors so you can't use read/write/close or similar functions;
- errors are not stored in errno but you must be read/write the
errors with specific function;
- sometimes
Although this feature can be ported to Windows doing so would
require the usage of g_spawn_async_with_fds, which is only available
in GLib 2.58 or some specific Win32 code.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c| 7 +++
server/tests/test-record.c | 7 +--
2 files
Allows to easier port socketpair.
Windows does not have this function, we need to create a pair
using 2 internet sockets and connecting one to the other.
The SPICE core interface implementation provided by Qemu under
Windows requires, under Windows, to provide SOCKET handles
so pipes or other
test-stream test is passing file descriptor using Unix socket.
test-stat-file needs some porting work of mmap feature.
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 9 +++--
server/tests/meson.build | 9 +++--
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index 4fb2d2bf6..ab3d87c7c 100644
--- a/server/red-stream.c
+++ b/server/red-stream.c
@@ -114,7 +114,7 @@ static int
Windows needs some specific setting to use network.
Signed-off-by: Frediano Ziglio
---
configure.ac | 20 +++-
meson.build | 15 ---
server/tests/meson.build | 5 -
3 files changed, 35 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Frediano Ziglio
---
server/net-utils.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/server/net-utils.c b/server/net-utils.c
index 802509a49..3034dc5e1 100644
--- a/server/net-utils.c
+++ b/server/net-utils.c
@@ -35,6 +35,7 @@
#include
#include
Not supported, %m is a GNU extension of sscanf.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 28542bd09..302da5858 100644
--- a/server/reds.c
+++
Signed-off-by: Frediano Ziglio
---
server/tests/test-leaks.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c
index 64130c22a..be9fe2d2e 100644
--- a/server/tests/test-leaks.c
+++ b/server/tests/test-leaks.c
@@ -35,6
Signed-off-by: Frediano Ziglio
---
server/red-common.h | 1 +
server/reds.c | 11 ++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/red-common.h b/server/red-common.h
index 181ed283c..6b5d0b2e0 100644
--- a/server/red-common.h
+++ b/server/red-common.h
@@
Replace poll call with select.
As socket is set to non-blocking we must support it so if
we detect an EAGAIN error wait for data.
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 20
1 file changed, 20 insertions(+)
diff --git a/server/dispatcher.c
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index bae73f7db..9a49a9899 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@ -115,8 +115,8 @@
Set correctly errno to make callers handle correctly encrypted
traffic.
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index e8e88fb39..87939dc9a
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 2 +
server/tests/meson.build | 2 +
server/tests/test-channel.c | 1 +
server/tests/test-loop.c | 1 +
server/tests/test-stream-device.c | 1 +
server/tests/win-alarm.c | 65
"interface" and "MAX_MONITORS" are defined in some Windows system
headers causing garbage code to be fed to the compiler.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 52 ++--
server/reds.c| 68
2
- global signals;
- CLOEXEC flag;
- mmap and statistics;
- IPTOS_LOWDELAY flag;
- Unix sockets;
- sharing file descriptors through Unix sockets;
- TCP_CORK flag.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 2 ++
server/red-stream.c | 11 ++-
Signed-off-by: Frediano Ziglio
---
server/tests/test-channel.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/tests/test-channel.c b/server/tests/test-channel.c
index fcea98aa2..372c8d79f 100644
--- a/server/tests/test-channel.c
+++
Windows support is useful to use with Qemu under Windows as host or
to implement servers like Xspice.
Mainly SPICE server uses lot of libraries to expose a TCP protocol.
As TCP is implemented with socket library which is quite portable was
not that hard to port.
Beside some minor feature (see
63 matches
Mail list logo
