Re: [Spice-devel] [PATCH spice-common] build: Remove unused git-version-gen file

2019-05-29 Thread Eduardo Lima (Etrunko)
On 5/17/19 7:43 AM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > build-aux/git-version-gen | 158 -- > 1 file changed, 158 deletions(-) > delete mode 100755 build-aux/git-version-gen > > diff --git a/build-aux/git-version-gen

Re: [Spice-devel] [PATCH spice-gtk] meson: Workaround gtk+ exposing Objective C in headers on macOS

2019-05-29 Thread Marc-André Lureau
On Wed, May 29, 2019 at 12:05 PM Frediano Ziglio wrote: > > Apply the same workaround in 3c9b37bfc7c88969dfe16b8bfd874745e0fceb8a > for Meson. > > Signed-off-by: Frediano Ziglio ack > --- > meson.build | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/meson.build b/meson.build >

[Spice-devel] [PATCH spice-gtk] meson: Workaround gtk+ exposing Objective C in headers on macOS

2019-05-29 Thread Frediano Ziglio
Apply the same workaround in 3c9b37bfc7c88969dfe16b8bfd874745e0fceb8a for Meson. Signed-off-by: Frediano Ziglio --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index 8c6288f3..4c065a43 100644 --- a/meson.build +++ b/meson.build @@ -341,6

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-05-29 Thread Frediano Ziglio
ping > > ping > > > > > Do not declare the structure as aligned. > > The start/end-packed.h headers affects only MingW or Microsoft > > compilers. To have unaligned structure with GCC compiler you have > > to use SPICE_ATTR_PACKED. This way the definition are the same for > > all compiler. > >

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-05-29 Thread Frediano Ziglio
ping > > ping > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > as aligned and no packed using GCC (no MingW). > > This structure is only packed under MingW or Microsoft compilers. > > This structure is not technically a definition for QXL device but > > is used

Re: [Spice-devel] [PATCH spice-gtk 0/4] Check distribution with CI

2019-05-29 Thread Frediano Ziglio
ping the series > > Make sure we can build distribution. > Some small updates also to fix some minor issues. > > CI results at > https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/37744 > > Frediano Ziglio (4): > ci: Test we can create a no dirty package > spice-client-gtk-module:

Re: [Spice-devel] [PATCH spice-common] build: Remove unused git-version-gen file

2019-05-29 Thread Frediano Ziglio
ping > > Signed-off-by: Frediano Ziglio > --- > build-aux/git-version-gen | 158 -- > 1 file changed, 158 deletions(-) > delete mode 100755 build-aux/git-version-gen > > diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen > deleted file mode

Re: [Spice-devel] [PATCH spice-gtk] usb-device-manager: Define _SpiceUsbDevice instead of SpiceUsbDeviceInfo

2019-05-29 Thread Frediano Ziglio
ping > > SpiceUsbDevice* was converted to SpiceUsbDeviceInfo* as _SpiceUsbDevice > was never defines. Define instead the structure to avoid useless > casts. > > Signed-off-by: Frediano Ziglio > --- > src/usb-device-manager.c | 59 ++-- > 1 file changed, 20