Re: [Spice-devel] [PATCH v1 09/33] drm/qxl: drop use of drmP.h

2019-06-30 Thread Gerd Hoffmann
On Sun, Jun 30, 2019 at 08:18:58AM +0200, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > While touching the files divided includes in blocks, > and when needed sort the blocks. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: vir

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-06-30 Thread Uri Lublin
On 5/13/19 12:45 PM, Frediano Ziglio wrote: Do not declare the structure as aligned. The start/end-packed.h headers affects only MingW or Microsoft compilers. They also define/undef SPICE_ATTR_PACKED which affects Linux. BTW, if we define PACKED as ALIGNED(1) does that work for Windows too (I