[Spice-devel] [PATCH x11spice v2 1/3] Use unsigned int/size_t for display width/height/buffer size

2019-07-16 Thread Brendan Shanks
Signed-off-by: Brendan Shanks --- src/display.c | 8 src/display.h | 14 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/display.c b/src/display.c index 01e0e85..47f6bd7 100644 --- a/src/display.c +++ b/src/display.c @@ -59,7 +59,7 @@ static xcb_scree

[Spice-devel] [PATCH x11spice v2 2/3] Create separate shm_segment_t struct for SHM segments

2019-07-16 Thread Brendan Shanks
Signed-off-by: Brendan Shanks --- doc/spice_indent | 1 + src/display.c| 30 +++--- src/display.h| 8 ++-- src/scan.c | 2 +- src/session.c| 2 +- src/spice.c | 2 +- 6 files changed, 25 insertions(+), 20 deletions(-) diff --git a/doc/spice

[Spice-devel] [PATCH x11spice v2 0/3] Add cache for SHM segments

2019-07-16 Thread Brendan Shanks
Add a cache to x11spice for SHM segments. v2 should address Frediano's comments: style, use of G_N_ELEMENTS, using unsigned types for width/height/size, creating a separate struct to hold all the segment-specific variables, and reducing traversals of the cache. Brendan Shanks (3): Use unsigned

[Spice-devel] [PATCH x11spice v2 3/3] Add cache for SHM segments

2019-07-16 Thread Brendan Shanks
Add a cache to allow the reuse of SHM segments. Shared memory segments are added to the cache instead of being deallocated, and the cache is searched instead of/before allocating a new segment. Both the SHM segments and their attachment with the X server are cached. The cache currently has a fixe

Re: [Spice-devel] [spice-gtk 4/5] usb-redir: delete usb-backend context on initialization error

2019-07-16 Thread Yuri Benditovich
On Mon, Jul 15, 2019 at 5:28 PM Frediano Ziglio wrote: > > > > > On Mon, Jul 15, 2019 at 5:04 PM Frediano Ziglio wrote: > > > > > > > > > > > The delete in error flow was missing. > > > > > > > > Signed-off-by: Yuri Benditovich > > > > --- > > > > src/usb-device-manager.c | 1 + > > > > 1 file

Re: [Spice-devel] [PATCH spice-server 2/2] websocket: Make header self-independent

2019-07-16 Thread Uri Lublin
On 6/27/19 6:03 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio Ack, with comment/suggestion below. --- server/websocket.h | 4 1 file changed, 4 insertions(+) diff --git a/server/websocket.h b/server/websocket.h index 7707e6804..ec452038b 100644 --- a/server/websocket.h +

Re: [Spice-devel] [PATCH spice-server 1/2] websocket: Add header guards

2019-07-16 Thread Uri Lublin
On 6/27/19 6:03 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio Ack. Uri. --- server/websocket.h | 5 + 1 file changed, 5 insertions(+) diff --git a/server/websocket.h b/server/websocket.h index 22120d939..7707e6804 100644 --- a/server/websocket.h +++ b/server/websocket.h @

Re: [Spice-devel] [PATCH spice-server 1/2] websocket: Add header guards

2019-07-16 Thread Frediano Ziglio
ping the series > > ping the series > > > > > Signed-off-by: Frediano Ziglio > > --- > > server/websocket.h | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/server/websocket.h b/server/websocket.h > > index 22120d939..7707e6804 100644 > > --- a/server/websocket.h > > +++ b

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-16 Thread Frediano Ziglio
ping series > > Do not declare the structure as aligned. > The start/end-packed.h headers affects structures without > specification only using MingW or Microsoft compilers. For other > platform SPICE_ATTR_PACKED macro should be used. This way the > definition are the same for all compiler. > Th

Re: [Spice-devel] [PATCH spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-16 Thread Uri Lublin
On 7/16/19 1:55 PM, Snir Sheriber wrote: This allows to set plugin key=value properties on run time. To add encoder plugin property use the following syntax: -gst.prop="key=value" Is this the correct syntax, or do you need a -c ? Make sure syntax is accurate and that the property is supported

Re: [Spice-devel] [PATCH spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-16 Thread Frediano Ziglio
> > This allows to set plugin key=value properties on run time. > To add encoder plugin property use the following syntax: > -gst.prop="key=value" > Make sure syntax is accurate and that the property is supported by > the chosen plugin, wrong/invalid properties will be ignored silently. > Specifi

[Spice-devel] [PATCH spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-16 Thread Snir Sheriber
This allows to set plugin key=value properties on run time. To add encoder plugin property use the following syntax: -gst.prop="key=value" Make sure syntax is accurate and that the property is supported by the chosen plugin, wrong/invalid properties will be ignored silently. Specific encoder availa