[Spice-devel] [PATCH x11spice 07/10] Call xf86DPMSInit() in DUMMYScreenInit().

2019-09-16 Thread Jeremy White
From: Henri Verbeet This is probably not strictly needed, but it's easy and gets rid of the "Xlib: extension "DPMS" missing on display ":2"." message. Signed-off-by: Henri Verbeet Signed-off-by: Jeremy White --- spice-video-dummy/src/spicedummy_driver.c | 2 ++ 1 file changed, 2

[Spice-devel] [PATCH x11spice 03/10] Use a proper prototype for CreateWindow() in struct dummyRec.

2019-09-16 Thread Jeremy White
From: Henri Verbeet Signed-off-by: Henri Verbeet Signed-off-by: Jeremy White --- spice-video-dummy/src/dummy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h index d287a59a..dc4ab92f 100644 ---

[Spice-devel] [PATCH x11spice 02/10] Add .dirstamp to .gitignore.

2019-09-16 Thread Jeremy White
From: Henri Verbeet Signed-off-by: Henri Verbeet Signed-off-by: Jeremy White --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index aee6c93a..7052d3ff 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ install-sh missing .deps +.dirstamp

[Spice-devel] [PATCH x11spice 01/10] Style: tweak a few spaces to match Spice style.

2019-09-16 Thread Jeremy White
Signed-off-by: Jeremy White --- spice-video-dummy/src/dummy.h | 2 +- spice-video-dummy/src/spicedummy_driver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h index cb8afc37..d287a59a 100644 ---

[Spice-devel] [PATCH x11spice 10/10] Do not use show_cursor_check on older Xorg builds.

2019-09-16 Thread Jeremy White
Versions prior to 1.20 do not have the show_cursor_check function. Signed-off-by: Jeremy White --- spice-video-dummy/src/display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/spice-video-dummy/src/display.c b/spice-video-dummy/src/display.c index 786e6916..31be0416 100644

[Spice-devel] [PATCH x11spice 06/10] Implement page flips.

2019-09-16 Thread Jeremy White
From: Henri Verbeet Signed-off-by: Henri Verbeet Signed-off-by: Jeremy White --- spice-video-dummy/src/present.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/spice-video-dummy/src/present.c b/spice-video-dummy/src/present.c index ad29dc91..40290d70 100644 ---

[Spice-devel] [PATCH x11spice 04/10] Enable warnings for spice-video-dummy.

2019-09-16 Thread Jeremy White
From: Henri Verbeet Signed-off-by: Henri Verbeet Signed-off-by: Jeremy White --- spice-video-dummy/src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-video-dummy/src/Makefile.am b/spice-video-dummy/src/Makefile.am index 6befa46b..1dc4df8e 100644 ---

[Spice-devel] [PATCH x11spice 05/10] Provide support for outputs and crtcs.

2019-09-16 Thread Jeremy White
This allow us to size and dynamically resize the dummy driver. Signed-off-by: Jeremy White --- spice-video-dummy/src/Makefile.am | 2 +- spice-video-dummy/src/display.c | 415 ++ spice-video-dummy/src/dri2.c | 5 +-

[Spice-devel] [PATCH x11spice 00/10] Provide a simulated set of outputs and crtcs

2019-09-16 Thread Jeremy White
The spice-video-dummy driver has two flaws. First, by not providing a crtc, we take the Present extension into a code path where it simulates a refresh rate, and the simulated rate is 1Hz. Applications that query and use that rate then perform badly. You can see that most easily with glxgears.

[Spice-devel] [PATCH x11spice 08/10] Do not provide a stub client_monitors_config in the QXLInterface.

2019-09-16 Thread Jeremy White
Using NULL causes the server to relay the message on to the agent, which does a superior job to anything we currently want to do. Signed-off-by: Jeremy White --- src/spice.c | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/src/spice.c

[Spice-devel] [PATCH x11spice 09/10] Explicitly call ConfigNotify() on the root window in crtc_resize().

2019-09-16 Thread Jeremy White
From: Henri Verbeet So that any GL clients on the root window (e.g. compositors) know they need to resize their buffers. Is this a hack? It seems like it; other drivers don't appear to need to explicitly call this. Without it though, compositors don't handle screen resizes well. Signed-off-by:

[Spice-devel] [PATCH v7 08/20] usb-redir: extend USB backend to support emulated devices

2019-09-16 Thread Victor Toso
From: Yuri Benditovich Redirection of emulated devices requires special approach, as usbredirhost can't be used for that (it works only with libusb devices). For emulated devices we create instance of usbredirparser that implements USB redirection protocol. In order to work with the same set of

[Spice-devel] [PATCH v7 07/20] usb-backend: include usbredirparser

2019-09-16 Thread Victor Toso
From: Yuri Benditovich This patch introduces the usage of usbredirparser in SpiceUsbBackendChannel. The focus of this patch is to the code path of real devices. As we don't know beforehand if a SpiceUsbBackendChannel will be used by real or emulated devices, an instance of usbredirparser must

[Spice-devel] [PATCH v7 20/20] test-cd-emu: Test no libusb context support

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Although currently not supported by the code (libusb_context in SpiceUsbBackend is never NULL), try to support it in order to be able to have only emulated devices if the libusb layer is failing. Signed-off-by: Frediano Ziglio --- tests/cd-emu.c | 16 +--- 1

[Spice-devel] [PATCH v7 04/20] usb-backend: no emulated isoch devices

2019-09-16 Thread Victor Toso
From: Yuri Benditovich SpiceUsbBackendDevice deals with real and emulated devices but there is no plans to implement emulated isochronous devices. This patch adds check to edev (emulated device) in the guard, fix the return value to FALSE instead of plain 0 and return early in case the code

[Spice-devel] [PATCH v7 10/20] fixup! usb-redir: add files for SCSI and USB MSC implementation

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Do not use 0x%u as format, misleasding, %u is decimal. Also most of these are formatting lun number which in multiple cases are expressed as decimal. --- src/cd-scsi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/cd-scsi.c

[Spice-devel] [PATCH v7 19/20] test-cd-emu: Make sure we can call spice_usb_backend_channel_flush_writes

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Currently we call this function when the SPICE channel is up however this function should continue to work as in theory the channel could avoid to handle the message and stop the flow (for instance to implement some kind of flow limitation) and so will need to call this

[Spice-devel] [PATCH v7 05/20] usb-backend: add guard and doc to check_filter()

2019-09-16 Thread Victor Toso
From: Victor Toso * Add documentation on spice_usb_backend_device_check_filter() * Add guard on libusb_device * Adds G_GNUCE_INTERNAL as this is only called internally in usb-device-manager.c * Changed the style a bit, still under 100 char in a single line This is a preparatory patch for

[Spice-devel] [PATCH v7 17/20] test-cd-emu: Test attach/detach emulated device

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Mock some usb-backend functions to be able to simulate device attachment and detachment. Create session and channel to pass some valid pointer anyway. Emulate channel state correctly. Make sure HELLO packets are sent correctly at the beginning and no more afterwards. Test

[Spice-devel] [PATCH v7 06/20] usb-backend: add safe check on attach()

2019-09-16 Thread Victor Toso
From: Frediano Ziglio At this moment, spice_usb_backend_channel_attach() is only related to real devices and this call might happen on channel-up event that can possibly come before usbredirhost has been created. Signed-off-by: Victor Toso --- src/usb-backend.c | 5 + 1 file changed, 5

[Spice-devel] [PATCH v7 13/20] build: Do not build usbredir dependent file is usbredir disabled

2019-09-16 Thread Victor Toso
From: Frediano Ziglio These files would end up to compile empty code, no reason to compile and link them. Signed-off-by: Frediano Ziglio --- src/meson.build | 10 +- src/usb-backend.c | 4 src/usbutil.c | 3 --- src/usbutil.h | 4 4 files changed, 5

[Spice-devel] [PATCH v7 02/20] usb-redir: move implementation of device description to USB backend

2019-09-16 Thread Victor Toso
From: Yuri Benditovich For local USB device the USB backend returns the same device description as spice-usb-manager did, for emulated devices it uses the description provided by device's implementation. Signed-off-by: Yuri Benditovich Acked-by: Frediano Ziglio --- src/usb-backend.c|

[Spice-devel] [PATCH v7 11/20] usb-redir: add implementation of emulated CD device

2019-09-16 Thread Victor Toso
From: Yuri Benditovich This module contains implementation of emulated device interface for shared CD. Signed-off-by: Yuri Benditovich Acked-by: Frediano Ziglio --- src/usb-device-cd.c | 784 src/usb-device-cd.h | 34 ++ 2 files changed, 818

[Spice-devel] [PATCH v7 03/20] usb-redir: do not use spice_usb_acl_helper for emulated devices

2019-09-16 Thread Victor Toso
From: Yuri Benditovich Signed-off-by: Yuri Benditovich Acked-by: Frediano Ziglio --- src/channel-usbredir.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 0a711c2..e407bac 100644 ---

[Spice-devel] [PATCH v7 15/20] test-cd-emu: Add base test for cd-emulation

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Just allocate and free to test for base leaks and reference counting. Signed-off-by: Frediano Ziglio --- tests/cd-emu.c| 97 +++ tests/meson.build | 4 ++ 2 files changed, 101 insertions(+) create mode 100644

[Spice-devel] [PATCH v7 12/20] usb-redir: enable redirection of emulated CD drive

2019-09-16 Thread Victor Toso
From: Yuri Benditovich Add implementation of emulated device to build. Now it is possible to create emulated CD devices. Signed-off-by: Yuri Benditovich --- src/meson.build | 12 1 file changed, 12 insertions(+) diff --git a/src/meson.build b/src/meson.build index

[Spice-devel] [PATCH v7 01/20] usb-redir: define interfaces to support emulated devices

2019-09-16 Thread Victor Toso
From: Yuri Benditovich SpiceUsbBackendDevice structure is extended to support additional kind of device that is emulated by Spice-GTK and not present locally (and does not have libusb_device), such device has instead pointer to SpiceUsbEmulatedDevice abstract structure. Specific implementation

[Spice-devel] [PATCH v7 14/20] usb-redir: command-line option to create emulated CD drive

2019-09-16 Thread Victor Toso
From: Yuri Benditovich Added command-line option for sharing emulated CD devices. It uses property interface of usb-device-manager to create CD, this is a temporary solution until public API of usb-device-manager defined for shared CD management from both GUI and command line. Signed-off-by:

[Spice-devel] [PATCH v7 18/20] test-cd-emu: Test detach and reattach

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Make sure device can be detached and attached again. Signed-off-by: Frediano Ziglio --- tests/cd-emu.c | 104 +++-- 1 file changed, 75 insertions(+), 29 deletions(-) diff --git a/tests/cd-emu.c b/tests/cd-emu.c index

[Spice-devel] [PATCH v7 16/20] build: Use a convenience library for tests

2019-09-16 Thread Victor Toso
From: Frediano Ziglio Instead of linking all object inside spice-client-glib build a library from these object and link to each test. This will allow to override some object file for mocking purposes. Signed-off-by: Frediano Ziglio --- tests/meson.build | 8 +++- 1 file changed, 7

[Spice-devel] [PATCH v7 00/20] added feature of sharing CD image

2019-09-16 Thread Victor Toso
From: Victor Toso Hi, One patch that was not acked but a must to integrate most of this patches was the "usb-redir: extend USB backend to support emulated devices", previously v6 04/18 https://lists.freedesktop.org/archives/spice-devel/2019-September/050730.html Frediano improved the

Re: [Spice-devel] Running SPICE on ppc64le

2019-09-16 Thread Niccolò Belli
The funny part is that I'm *not* on Big Endian, my ppc64 runs Little Endian Fedora. For some reason spice (and QXL apparently) don't get compiled on ppc64le: are you suggesting that if I somehow enable it at compilation time then it should work out of the box? If so, why did Fedora disable it?

Re: [Spice-devel] Running SPICE on ppc64le

2019-09-16 Thread Frediano Ziglio
> Hi, > Is there any reason why Spice is not available on ppc64le? > I've read there are still some issues with big endian, but what's wrong > with little endian? > I would really love to be able to use QXL and especially USB redirection > on my Raptor Blackbird (Power 9). > > Bests, > Niccolo'

Re: [Spice-devel] [Nouveau] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-09-16 Thread Ben Skeggs
On Wed, 11 Sep 2019 at 07:53, Thierry Reding wrote: > > On Sat, Sep 07, 2019 at 09:58:46PM -0400, Ilia Mirkin wrote: > > On Wed, Aug 21, 2019 at 7:55 AM Thierry Reding > > wrote: > > > > > > On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs wrote: > > > > On Wed, 14 Aug 2019 at 20:14, Gerd