Hi Hans,
One more thing:
> GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that.
GFP_DMA32 had no effect for me on arm64. Probably I need to recheck.
Best regards,
Dmitry.
On Donnerstag, 12. März 2020 11:18:26 CET Hans Verkuil wrote:
> On 3/12/20 11:15 AM, Dmitry Sepp
On 3/11/20 9:10 PM, Jeremy White wrote:
Hi,
I'm afraid that does not help on the gcc 4.8.5 on RHEL 7.X, particularly
with structures that contain other structures.
gcc -Wall -DTHREE -o /dev/null -c test.c
test.c: In function ‘handle_sigterm’:
test.c:12:12: warning: missing braces around
If I can suggest, for sigaction, just use memset!
It's weird structure defined in different way in different systems, and also
on the same system could be different depending on some flags.
It's a weird combination of unions and structures, in reality some field name
you use are preprocessor
On 3/12/20 11:15 AM, Dmitry Sepp wrote:
> Hi Hans,
>
> Thank you for your great detailed review!
>
> I won't provide inline answers as your comments totally make sense. There is
> only one thing I want to mention:
>
>>> + struct video_plane_format plane_format[VIRTIO_VIDEO_MAX_PLANES];
>>
>>
On 3/12/20 11:29 AM, Dmitry Sepp wrote:
> Hi Hans,
>
> I'm not sure about crosvm, for us it is probably still feasible to implement
> FWHT in the device (but it is unfortunately not supposed to be upstreamed
> yet).
>
> The main question is what would be the proper user-space tool to test
Hi Hans,
I'm not sure about crosvm, for us it is probably still feasible to implement
FWHT in the device (but it is unfortunately not supposed to be upstreamed
yet).
The main question is what would be the proper user-space tool to test that? Is
v4l2-ctl OK for that? As for gstreamer, AFAIK it
On Thu, Mar 12, 2020 at 6:54 PM Hans Verkuil wrote:
>
> On 3/12/20 10:49 AM, Keiichi Watanabe wrote:
> > Hi Hans,
> >
> > On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote:
> >>
> >> Hi Dmitry,
> >>
> >> On 2/18/20 9:27 PM, Dmitry Sepp wrote:
> >>> Hi all,
> >>>
> >>> This is a v4l2 virtio
On 3/12/20 10:49 AM, Keiichi Watanabe wrote:
> Hi Hans,
>
> On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote:
>>
>> Hi Dmitry,
>>
>> On 2/18/20 9:27 PM, Dmitry Sepp wrote:
>>> Hi all,
>>>
>>> This is a v4l2 virtio video driver for the virtio-video device
>>> specification v3 [1].
>>>
>>> The
Hi Hans,
On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote:
>
> Hi Dmitry,
>
> On 2/18/20 9:27 PM, Dmitry Sepp wrote:
> > Hi all,
> >
> > This is a v4l2 virtio video driver for the virtio-video device
> > specification v3 [1].
> >
> > The first version of the driver was introduced here [2].
>
Hi Hans,
Thanks for reviewing.
Sure, we understand the driver must pass v4l2-compliance. But the spec is not
finalized yet, so it was a bit out of the scope.
Best regards,
Dmitry.
On Mittwoch, 11. März 2020 14:26:46 CET Hans Verkuil wrote:
> Hi Dmitry,
>
> On 2/18/20 9:27 PM, Dmitry Sepp
10 matches
Mail list logo
