Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread Victor Toso
Hi, On Tue, May 12, 2020 at 12:53:02AM +0200, br...@netc.fr wrote: > > > Uri (and others), > > I found the similar question in a few corners of the internet > and I think adding at least the additional default mouse > buttons should not be all that much work. You can take a look at this

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread bruts
Uri (and others), I found the similar question in a few corners of the internet and I think adding at least the additional default mouse buttons should not be all that much work. With some guidance I could probably do it myself, though the guidance would need to be quite substantial :)

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread bruts
Hi Uri, Ok that's probably a bridge too far for me without any help from a developer... Any chance I could get this help you think, or will I have to wait until future release when this might be implemented? As I wrote in the first post, my thumb is kind of addicted to the BACK button

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread Uri Lublin
On 5/11/20 4:47 PM, br...@netc.fr wrote: Uri, Would it be as simple as adding: ioctl(uinput->fd, UI_SET_KEYBIT,  BTN_BACK); ioctl(uinput->fd, UI_SET_KEYBIT,  BTN_FORWARD); and re-compiling / testing? I'm sorry, but it is not that simple. That's the agent side. You also need the

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread bruts
Uri, Would it be as simple as adding: ioctl(uinput->fd, UI_SET_KEYBIT,  BTN_BACK); ioctl(uinput->fd, UI_SET_KEYBIT,  BTN_FORWARD); and re-compiling / testing? I am not an experienced coder and have not had the time yet to get a good overview of the spice-vdagent code, so this might

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread Uri Lublin
On 5/11/20 4:08 PM, br...@netc.fr wrote: Hi, Yes most likely. I find these lines of code: /* buttons */     ioctl(uinput->fd, UI_SET_EVBIT, EV_KEY);     ioctl(uinput->fd, UI_SET_KEYBIT, BTN_LEFT);     ioctl(uinput->fd, UI_SET_KEYBIT, BTN_MIDDLE);     ioctl(uinput->fd, UI_SET_KEYBIT,

Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?

2020-05-11 Thread bruts
Hi, Yes most likely. I find these lines of code: /* buttons */     ioctl(uinput->fd, UI_SET_EVBIT, EV_KEY);     ioctl(uinput->fd, UI_SET_KEYBIT, BTN_LEFT);     ioctl(uinput->fd, UI_SET_KEYBIT, BTN_MIDDLE);     ioctl(uinput->fd, UI_SET_KEYBIT, BTN_RIGHT);     /* wheel */    

[Spice-devel] About decisions and reviews

2020-05-11 Thread Marc-André Lureau
Hi, About "Move code to C++": https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62 I would like to know how the decision happened. As long as I have been involved in the Spice project, we had open discussions and did mandatory review for anything non-trivial. This change is

Re: [Spice-devel] Failed to build spice-vdagent 0.20 under ubuntu 18.04

2020-05-11 Thread Frediano Ziglio
> ./autogen.sh > checking for a BSD-compatible install... /usr/bin/install -c > checking whether build environment is sane... yes > checking for a thread-safe mkdir -p... /bin/mkdir -p > checking for gawk... gawk > checking whether make sets $(MAKE)... yes > checking whether make supports nested