Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit 75679dc95d450173319f462b25f267cb3025778f Author: Frediano Ziglio Date: Wed Apr 1 20:43:04 2020 +0100 dispatcher: Use IS-A relationship for Dispatcher hierarchy Signed-off-by: Frediano Ziglio This patch adds class inheritance to the `Dispatcher` to avoid the usage of the `parent`

Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit 2023bb376713a39c47607f2698ad0f5e43ddf994 Author: Frediano Ziglio Date: Mon May 20 16:23:54 2019 +0100 red-channel-client: Remove "self" It was left unchanged to reduce diff. Signed-off-by: Frediano Ziglio This patch removes the historical usage of `self`, and uses instead the

Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit bea4ad66b9603f4d733da42ea0ad28cb7cf8d1de Author: Frediano Ziglio Date: Thu May 30 06:33:16 2019 +0100 char-device: Remove pool handling Memory pool handling does not give much but make code more complex. Current implementation tends to only increasing buffer sizes leading to

[Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
Hello spice-devel I worked on the review of Frediano's C++ patches during the last weeks, I tried to understand the gist of the commits and summarize it in the review message. It's not an in-depth review, and I only spotted minor details. A few patches are not acked, mostly because they were too

Re: [Spice-devel] Using QXL & Spice with Windows Host & QEMU

2020-06-08 Thread Frediano Ziglio
> > Hello everyone, > > when using Qemu 4.2.0 with a Windows host, qemu-system-x86_64 reports: > "QXL VGA not available" > > I used the following Qemu args for testing: > qemu-system-x86-x64.exe -accel hax -machine q35 -m 4GB -cdrom > xubuntu-20.04-desktop-amd64.iso > > Using either "-vga

Re: [Spice-devel] Using QXL & Spice with Windows Host & QEMU

2020-06-08 Thread Marc-André Lureau
Hi On Mon, Jun 8, 2020 at 6:00 PM wrote: > Hello everyone, > > when using Qemu 4.2.0 with a Windows host, qemu-system-x86_64 reports: > "QXL VGA not available" > > I used the following Qemu args for testing: > qemu-system-x86-x64.exe -accel hax -machine q35 -m 4GB -cdrom >

[Spice-devel] Using QXL & Spice with Windows Host & QEMU

2020-06-08 Thread laurens . nikolaisen
Hello everyone, when using Qemu 4.2.0 with a Windows host, qemu-system-x86_64 reports: "QXL VGA not available" I used the following Qemu args for testing: qemu-system-x86-x64.exe -accel hax -machine q35 -m 4GB -cdrom xubuntu-20.04-desktop-amd64.iso Using either "-vga stdt" or "-vga vmware"