Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Jakub Janku
On Wed, Sep 9, 2020 at 5:27 PM Frediano Ziglio wrote: > > > Hi > > > On Wed, Sep 9, 2020 at 6:45 PM Jakub Janku < jja...@redhat.com > wrote: > > > > On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio < fzig...@redhat.com > > > > wrote: > > > > > > > > > > > > > On Wed, Sep 9, 2020 at 4:16 PM Frediano

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Frediano Ziglio
> Hi > On Wed, Sep 9, 2020 at 6:45 PM Jakub Janku < jja...@redhat.com > wrote: > > On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio < fzig...@redhat.com > > > wrote: > > > > > > > > > On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio < fzig...@redhat.com > > > > > wrote: > > > > > > > > > > > > >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Marc-André Lureau
Hi On Wed, Sep 9, 2020 at 6:45 PM Jakub Janku wrote: > On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio wrote: > > > > > On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio > wrote: > > > > > > > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > > > > > > > Author: Jakub Janků <

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Jakub Janku
On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio wrote: > > > On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio wrote: > > > > > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > > > > > Author: Jakub Janků < jja...@redhat.com > > > > > > > > > > Date: Sat May 23 16:28:52 2020 +0200 > >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Jakub Janku
On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio wrote: > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > Author: Jakub Janků < jja...@redhat.com > > > > > > Date: Sat May 23 16:28:52 2020 +0200 > > > > > > session: make spice_session_get_webdav_server() public > > > > > > It will

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Frediano Ziglio
> On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio wrote: > > > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > > > Author: Jakub Janků < jja...@redhat.com > > > > > > > > Date: Sat May 23 16:28:52 2020 +0200 > > > > > > > > > session: make spice_session_get_webdav_server() public >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Frediano Ziglio
> > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > Author: Jakub Janků < jja...@redhat.com > > > > Date: Sat May 23 16:28:52 2020 +0200 > > > session: make spice_session_get_webdav_server() public > > > It will be necessary to access the webdav server from spice-gtk-session.c > > >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

2020-09-09 Thread Marc-André Lureau
Hi, On Wed, Sep 9, 2020 at 5:50 PM GitLab Mirror < gitlab-mir...@kemper.freedesktop.org> wrote: > meson.build | 13 - > src/map-file |1 > src/spice-glib-sym-file |1 > src/spice-gtk-session.c | 399 > +++ >

Re: [Spice-devel] Is it a possible memory leak (spice-gtk/src/channel-display.c)?

2020-09-09 Thread Frediano Ziglio
> Hi all, for the latest commit in 'spice-gtk/src/channel-display.c', in the > static function > 'create_canvas', the first returning point (line 997) and the 'if > (surface->primary)' (line 1036) > is not taken then the second returning point, the allocated memory for > surface would be lost. >

[Spice-devel] Is it a possible memory leak (spice-gtk/src/channel-display.c)?

2020-09-09 Thread Ding Fei
Hi all, for the latest commit in 'spice-gtk/src/channel-display.c', in the static function 'create_canvas', the first returning point (line 997) and the 'if (surface->primary)' (line 1036) is not taken then the second returning point, the allocated memory for surface would be lost. All the