[Spice-devel] [PATCH spice-gtk] ci: Avoid Meson warning during CI

2023-11-03 Thread Frediano Ziglio
Avoids: WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Note that due to a problem with mingw64-meson script is not possible to remove that warning for Windows builds. Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 6

[Spice-devel] [PATCH spice-gtk] build: Avoids a Meson warning

2023-11-03 Thread Frediano Ziglio
Avoids: WARNING: Project specifies a minimum meson_version '>= 0.56' but uses features which were added in newer versions: * 0.58.0: {'str.replace'} This was a regression introduced by commit 3892983edab7d9d1bcb808f6bdc4fdcfb3914683 (cfr "Use visibility instead of just filtering using version

[Spice-devel] [PATCH spice-common] build: Avoid Meson warning

2023-11-03 Thread Frediano Ziglio
Avoids: WARNING: You should add the boolean check kwarg to the run_command call. It currently defaults to false, but it will default to true in future releases of meson. See also: https://github.com/mesonbuild/meson/issues/9300 Signed-off-by: Frediano Ziglio --- meson

[Spice-devel] [PATCH spice-gtk 2/2] gstreamer: Fallback to S/W decoder if H/W one is not working

2023-11-03 Thread Frediano Ziglio
In case the H/W decoder is not able to decode the stream (like too high profile) try the S/W version. This is done detecting the failure and trying to recreate the pipeline in case: - we are using a H/W pipeline; - we didn't decode any frame (otherwise it means we lost the beginning or it was not

[Spice-devel] [PATCH spice-gtk 1/2] gstreamer: Fix leak using GstBus watch

2023-11-03 Thread Frediano Ziglio
This patch fixes a leak due to not freeing GstBus watch. The watch is attached (as GSource) to the main loop and retains a pointer to the bus so we need to remove it to release the bus when we release the pipeline. This was detected forcibly creating and destroying lot of streams. After a while the

Re: [Spice-devel] [PATCH spice-gtk 2/2] gstreamer: Avoid dangling pointers in free_pipeline

2023-11-03 Thread Frediano Ziglio
Il giorno ven 3 nov 2023 alle ore 04:58 Kasireddy, Vivek ha scritto: > > Hi Frediano, > > > > > Although currently after free_pipeline we free the entire structure > > the name and the function suggests that we only free the pipeline. > > Also this is fixing a future possible problem with the seri