On Tue, Jan 08, 2019 at 04:40:47PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jan 8, 2019 at 4:24 PM Christophe Fergeau wrote:
> >
> > On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com wrote:
> > > +URI Parameters
> > > +
On Wed, Dec 19, 2018 at 11:49:26AM +0100, Victor Toso wrote:
> Hi,
>
> On Wed, Dec 19, 2018 at 10:06:53AM +0800, wangjiedong wrote:
> > Actually there are 2 questions.
>
> > Firstly , on Windows 7 vm i can install
> > spice-webdavd-x64-2.2.msi and no error , but the service
> > spice-webdavd in
Acked-by: Christophe Fergeau
On Mon, Dec 17, 2018 at 10:26:57AM +, Frediano Ziglio wrote:
> An array of WSABUF can be used with WSASend.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/marshaller.c | 10 --
> common/marshaller.h | 4 ++--
> 2 files changed
er the wrapper/launcher generated in
> tests/test_region.exe is generated not considering dependencies in
> libspice-common.la (one of wrapper job is to add some definitions to
> PATH variable).
> Still the patch solves the weird issue.
Actually, since test-region.c uses both pixman
On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com wrote:
> +URI Parameters
> +--
> +
> +A description of host information and URI parameters is provided in
> +this section. Information on the constraints of various data types is
> +provided in Section "Data Types".
On Tue, Dec 18, 2018 at 12:19:28PM -0500, Frediano Ziglio wrote:
> > On Thu, Dec 13, 2018 at 02:20:25PM +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > common/ssl_verify.c | 5 +-
> > > common/ssl_verify.h | 4 ++
> > > tests/Makefile.am | 20
Hey,
On Sun, Jan 06, 2019 at 02:12:55PM +0100, ucontacti ss wrote:
> Dear developers,
>
> While I was looking in the packets using Wireshark I saw that the Major and
> Minor version is 2 and not 1 anymore. And there are some discrepancies in
> the Spice protocol v1.0 and the actual value of
Acked-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 06:01:45PM +, Frediano Ziglio wrote:
> These constants are meant to be used in format string for pointers
> types. Use them for portability.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c | 2 +-
&g
On Tue, Jan 08, 2019 at 11:02:04AM +0200, Uri Lublin wrote:
> win-usb-dev also uses libusb.
> Similar to commit 3e23fff9, set libusb backend to UsbDk.
> Without this patch usb devices are not seen by win-usb-dev
> (windows clients), when UsbDk driver is installed.
>
> Signed-off-by: Uri Lublin
>
On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote:
> Since we would like to release v0.36 soonish, and there are valid
> concerns that such a change now is a bit too risky, I propose to:
>
> - make GStreamer a blessed dependency in 0.36 for audio & video (since
> it is required
Acked-by: Christophe Fergeau
On Tue, Jan 08, 2019 at 01:48:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> v2.5.1 was released the 2015-11-24.
>
> According to repology, from the distro we care about, CentOS 6,
> openSUSE Leap 42.3 have too
On Mon, Jan 07, 2019 at 11:19:11PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau wrote:
> >
> > On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
&g
xno"; then
> +AC_MSG_ERROR([smarcard support explicitly requested, but some
> required packages are not available])
I think this will cause a change of behaviour if someone uses
--enable-smartcard=foo, before that patch the behaviour was the same as
--enable-smartcard, aft
On Mon, Jan 07, 2019 at 11:02:04PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 7, 2019 at 6:15 PM Christophe Fergeau wrote:
> >
> > On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
On Mon, Jan 07, 2019 at 11:15:55PM +0400, Marc-André Lureau wrote:
> On Mon, Jan 7, 2019 at 8:21 PM Christophe Fergeau wrote:
> >
> > On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > >
Acked-by: Christophe Fergeau
On Fri, Jan 04, 2019 at 10:56:24AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 16
> src/vdagentd/vdagentd.c | 16
> 2 files changed, 24 insertions(
e first there's a
> previous
Not the easiest code to follow imo, not sure there's a better way to
write it though..
Acked-by: Christophe Fergeau
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Mon, Jan 07, 2019 at 12:01:02PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The pulse backend is getting deprecated.
Not sure this is something we should do right before a release rather
than right after the release so that the gstreamer backend on linux gets
a
On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Removed unused vapigen/vapidir variables as well.
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 +
> meson_options.txt | 3 +--
> 2 files changed, 6
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:58PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-gstaudio.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/sr
On Mon, Jan 07, 2019 at 12:00:55PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> It makes it non-obvious what that variable actually is.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 ---
me to install a meson-mingw64 build, with
> -Dgtk_doc=disabled, as it fails to build currently for other reasons
> which I don't have time to investigate yet.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 10 +-
> meso
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:53PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../src/./spice-audio.h:22:2: warning: #warning "Only can be
> included directly" [-Wcpp]
> #warning "
On Mon, Jan 07, 2019 at 12:00:52PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The desktop-integration code works by attempting to connect to GNOME
> Session Manager. If it is absent, it will print a "Warning no
> automount-inhibiting implementation available"
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:51PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:50PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Contrary to spice server dependency, spice-gtk doesn't have a known
> minimum version requirement.
Ideally, we'd still check for some not very old liblz4 to avoid compile
time failures,
Missed that one, but
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:36PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> libusb 1.0.16 was released on 11 Jul 2013, that should be long enough.
>
> From the distro we care about, accord
Acked-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 2 files changed, 4 inser
On Mon, Jan 07, 2019 at 12:00:47PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 32 +++-
> meson_options.txt | 3 +--
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
>
On Mon, Jan 07, 2019 at 12:00:46PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 15 +--
> meson_options.txt | 3 +--
> 3 files changed, 6 insertions(+), 13
On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 8 +++-
> meson_options.txt | 3 +--
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
>
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:43PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 6 --
> meson_options.txt | 3 +--
> 2 files changed, 5 inser
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:44PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 14 +-
> meson_options.tx
ch will turn most of
the options into autodetected features, then we will be able to disable
everything at once using -Dauto_features=disabled?
The log is not very easy to parse :)
Reviewed-by: Christophe Fergeau
Christophe
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml |
ld though.
Reviewed-by: Christophe Fergeau
Christophe
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 42c18f0..91d0742 100644
> --- a/meson.b
t;%d",
> udevinfo->class);
> ^~~~
A bit unexpected as this is a fallout from the #include ->
#include change, but regardless of that,
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/win-usb-dev.c | 10 +-
>
The .h even only needs glib-object.h, it's the .c file which is going to
need gio/gio.h
Reviewed-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Mon, Jan 07, 2019 at 12:00:37PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> v2.5.1 was released the 2015-11-24.
>
> According to repology, from the distro we care about, CentOS 6,
> openSUSE Leap 42.3 have too old version (0.1.2).
>
> I didn't bother updating
usb_dep = dependency('libusbredirparser-0.5', required : false)
> - if not usb_dep.found()
> -usb_dep = dependency('libusbredirparser', version : '>= 0.4')
> - endif
> - spice_glib_deps += usb_dep
> -
> - deps = {'libusbredirhost' : '>= 0.4.2',
> + deps = {
Reviewed-by: Christophe Fergeau
though they depend on the patches making gstreamer a hard dep which are
still under discussion.
Christophe
On Mon, Jan 07, 2019 at 12:00:34PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add required dependency on gstream
On Mon, Jan 07, 2019 at 12:00:30PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Deprecated for several releases now (v0.31).
Ok, though it does not hurt either as it's going to be dropped when
autotools is dropped.
Reviewed-by: Christophe Fergeau
>
On Mon, Jan 07, 2019 at 03:12:45PM +0400, Marc-André Lureau wrote:
> g_warning or g_debug, not a big difference to me here.
>
> But g_debug() is likely to be missed, since it is silent by default.
Yes, and being silent for now is the goal since the vast majority of
systems will be hitting that
On Mon, Jan 07, 2019 at 02:12:34PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau wrote:
> >
> > On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > > >
> > >
On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> >
> > > I'll work on a patch to remove pulse.
> > >
> >
> > It seems too soon.
>
> yes, we haven't done enough testing of the gstreamer backend on Linux.
> The recording path at least fails very often for me due to a race:
>
Acked-by: Christophe Fergeau
On Fri, Jan 04, 2019 at 08:37:04AM +, Frediano Ziglio wrote:
> Remove HAVE_CONFIG_H check, is always defined.
"it is always defined"
> Remove indentation of includes, now not in a condition and also
> some were indented some not
Acked-by: Christophe Fergeau
I was looking for these in the previous patch ;)
On Fri, Jan 04, 2019 at 08:37:05AM +, Frediano Ziglio wrote:
> Make sure all module files include config.h
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagentd/console-kit.c| 1 +
ak;
> case 32:
> +// on X11 a format of 32 is always a long
Maybe add a comma to ease reading "on X11, a format ..."
Acked-by: Christophe Fergeau
> len *= sizeof(long);
> break;
> }
> --
> 2.20.1
>
> __
quot;to make it possible"
Did you observe issues without that?
Acked-by: Christophe Fergeau
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/vdagent/vdagent.c b/src
On Fri, Jan 04, 2019 at 08:37:01AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 10 ++
> src/vdagentd/vdagentd.c | 10 ++
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/src/vdagent/vdagent.c
quot;to tell it is wanted"
Acked-by: Christophe Fergeau
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagentd/vdagentd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> index a2f0946..ec679fd 100644
Hey,
On Thu, Jan 03, 2019 at 04:25:00PM -0600, Eric Blake wrote:
> On 12/27/18 8:51 AM, Niccolò Belli wrote:
> > On mercoledì 26 dicembre 2018 13:38:28 CET, Frediano Ziglio wrote:
> >> Yes, this looks like a format string error in the upper (not into
> >> spice) layer.
> >>
> >> This potentially
On Fri, Jan 04, 2019 at 08:23:15AM +, Frediano Ziglio wrote:
> The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> Being a memory mapped structure potentially used with lockless access,
> it is not good to have it unaligned.
> The current tool that reads this memory mapped
On Thu, Jan 03, 2019 at 12:15:02PM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Jan 02, 2019 at 02:58:45PM +, Frediano Ziglio wrote:
> > > Windows needs some specific setting to use network.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > configure.ac | 20 +++-
On Thu, Jan 03, 2019 at 11:54:15AM -0500, Frediano Ziglio wrote:
>
> What about:
>
> "interface" and "MAX_MONITORS" are defined in some Windows system
> headers causing garbage code to be fed to the compiler.
Yes this is the missing bit.
Christophe
signature.asc
Description: PGP signature
On Sat, Dec 22, 2018 at 09:27:02AM -0500, Frediano Ziglio wrote:
>
> > On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio wrote:
> > >
> > > Signed-off-by: Frediano Ziglio
> >
> > I would suggest to wrap with #if _WIN32, otherwise it's really weird
> > to see those undef without context.
> >
>
> } else {
> qxl->u.surface_create.data =
> QXLPHYSICAL_FROM_PTR(replay_malloc(replay, size));
> @@ -1321,7 +1322,7 @@ SPICE_GNUC_VISIBLE QXLCommandExt*
> spice_replay_next_cmd(SpiceReplay *replay,
> cmd = rep
On Wed, Jan 02, 2019 at 02:58:45PM +, Frediano Ziglio wrote:
> Windows needs some specific setting to use network.
>
> Signed-off-by: Frediano Ziglio
> ---
> configure.ac | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> Changes since v1:
> - all changes in
On Thu, Jan 03, 2019 at 10:15:43AM -0500, Frediano Ziglio wrote:
> >
> > On Thu, Jan 03, 2019 at 02:14:24PM +, Frediano Ziglio wrote:
> > > The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> > > Being a memory mapped structure potentially used with lockless access
> > >
On Thu, Jan 03, 2019 at 10:15:43AM -0500, Frediano Ziglio wrote:
> >
> > On Thu, Jan 03, 2019 at 02:14:24PM +, Frediano Ziglio wrote:
> > > The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> > > Being a memory mapped structure potentially used with lockless access
> > >
pice_session_init).
I've tested migration + usbredir and spicy-stats, and I did not hit any
of the 2 bugs we had in the past (and I've checked that without " Revert
"channel-usbredir: Fix crash on channel-up" I can still reproduce the
migration bug, and without your patch, I g
Acked-by: Christophe Fergeau
On Thu, Jan 03, 2019 at 02:00:14PM +, Frediano Ziglio wrote:
> Due to previous commit "make syntax-check" command reports:
>
> prohibit_signal_without_use
> server/tests/test-display-base.c
> maint.mk: the above files include signal.
On Thu, Jan 03, 2019 at 02:14:24PM +, Frediano Ziglio wrote:
> The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> Being a memory mapped structure potentially used with lockless access
> is not good to have it unaligned.
> The current tool that reads this memory mapped file
On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote:
> GST_TYPE_PIPELINE is undeclared when gstvideo is disabled
I'd rahter that we keep using the more specific type. Feel free to have
a
#ifndef HAVE_GST_VIDEO
#define GST_TYPE_PIPELINE G_TYPE_POINTER
#endif
but would that code be used
On Wed, Jan 02, 2019 at 09:39:46AM -0500, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> > > I just noticed that the problem looks limited to special characters.
> > > For example if I set "Password" as password it works, while if I
On Wed, Jan 02, 2019 at 03:07:06PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> > I just noticed that the problem looks limited to special characters.
> > For example if I set "Password" as pa
Hey,
On Tue, Dec 25, 2018 at 06:20:03PM +0800, 陈炤 wrote:
> Hi,
>
>
> Does SPICE have a solution to capture video stream, and pass-through it to
> the client?
> I want this feature for these reasons:
> 1. Currently SPICE render video on server side, which would consume CPU of
> the server. If
Hey,
On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> I just noticed that the problem looks limited to special characters.
> For example if I set "Password" as password it works, while if I set
> "Password%%" it doesn't. It's weird because both my server and my desktop
> client
Fine with me,
Acked-by: Christophe Fergeau
On Wed, Jan 02, 2019 at 01:02:26PM +, Frediano Ziglio wrote:
> SPICE_ATTR_PRINTF uses __printf__ format attribute.
> spice_log internally uses g_string_append_vprintf which uses
> G_GNUC_PRINTF attribute.
> G_GNUC_PRINTF can b
On Wed, Jan 02, 2019 at 08:07:22AM -0500, Frediano Ziglio wrote:
> >
> > On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
> > >
> > > > Hi
> > > >
> > > > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > Windows needs some specific setting to
On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
>
> > Hi
> >
> > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio wrote:
> > >
> > > Windows needs some specific setting to use network.
> > >
> > > Signed-off-by: Frediano Ziglio
> >
> > with neat below
> > Reviewed-by:
On Sat, Dec 22, 2018 at 10:02:36AM -0500, Frediano Ziglio wrote:
> >
> > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio wrote:
> > >
> > > These constants are meant to be used in format string for size_t
> > > types. Use them for portability.
> >
> > PRI*PTR is for [u]intptr_t.
> >
> > There
On Wed, Jan 02, 2019 at 06:30:50AM -0500, Frediano Ziglio wrote:
> > On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > Fixes
> > > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > >
On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Fixes
> WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> 'spice-client-glib-usb-acl-helper'
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 2 +-
>
h looks good to me, and since
we already depend on a fairly new gtk+ (3.22), these APIs are going to
be available.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/usb-device-widget.c | 23 +--
> 1 file changed, 9 insertions(+)
On Thu, Dec 20, 2018 at 04:41:48PM -0500, james harvey wrote:
> On Thu, Dec 20, 2018 at 12:36 PM Christophe Fergeau
> wrote:
> > Hey,
> >
> > With this patch applied, I cannot seem to be able to copy from client to
> > guest when using wayland.
> >
> > C
Hey,
With this patch applied, I cannot seem to be able to copy from client to
guest when using wayland.
Christophe
On Wed, Dec 19, 2018 at 03:29:44PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> If SpiceGtkSession is holding the keyboard, that's huge indication
> that we should not be
Acked-by: Christophe Fergeau
On Thu, Dec 20, 2018 at 04:00:30PM +, Frediano Ziglio wrote:
> Commit 4398554be49b removed last usage of Ring/RingItem structures,
> there's no need to include the header anymore.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/channel-
On Wed, Dec 19, 2018 at 09:55:52AM -0500, Frediano Ziglio wrote:
> Out of this patch but related. What will happen to systems during upgrade?
> Will the dependency (sockets.target wants spice-vdagentd.socket) removed?
> I suppose for RPM the script will do it, not sure about a possible
> "make
On Wed, Dec 19, 2018 at 09:52:57AM -0500, Frediano Ziglio wrote:
> The "Requisite" still prevents the socket to be activated with a
> "systemctl enable spice-vdagentd.socket" launched manually.
> You can obviously complaint that users should not do that but
> I don't think that if the system says
-virtio\x2dports-com.redhat.spice.0.device is not active.
[DEPEND] Dependency failed for Activation socket for spice guest agent daemon.
https://bugzilla.redhat.com/show_bug.cgi?id=1545212
Signed-off-by: Christophe Fergeau
---
New patch following initial discussion
data/spice-vdagentd.socket
On Wed, Dec 19, 2018 at 04:11:09AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> > > >
> > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > > > to the relevant virtio devices, which automatically adds
.
> > After your patch, we store 'key1\0val1\0' in key, which fits and saves
> > some memory.
> >
> > Acked-by: Christophe Fergeau
> >
>
> Thanks for the review. I assume that these comments are an alternative
> comments but there's nothing about Coverity, how sh
On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> >
> > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > to the relevant virtio devices, which automatically adds Wants=${device}
> > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
> >
On Thu, Dec 13, 2018 at 02:20:25PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> common/ssl_verify.c | 5 +-
> common/ssl_verify.h | 4 ++
> tests/Makefile.am | 20 ++
> tests/test-ssl-verify.c | 141
> 4
parsing key1=val1,key2=val2,... and in doing that, we currently
store 'key1' in key, and 'val1' in val, and then 'key2', 'val2', and so
on.
After your patch, we store 'key1\0val1\0' in key, which fits and saves
some memory.
Acked-by: Christophe Fergeau
>
> Signed-off-by: Frediano Zigli
as this is causing boot time warnings:
[ INFO ] dev-virtio\x2dports-com.redhat.spice.0.device is not active.
[DEPEND] Dependency failed for Activation socket for spice guest agent daemon.
https://bugzilla.redhat.com/show_bug.cgi?id=1545212
Signed-off-by: Christophe Fergeau
---
data/spice-vdagentd.socket
Hey, I'm assuming these tests are currently successful?
If yes,
Acked-by: Christophe Fergeau
On Sun, Dec 16, 2018 at 05:57:55PM +, Frediano Ziglio wrote:
> As spice-common is used by spice-gtk which should run on Windows
> even spice-common should compile and run on Windows so
Hey,
On Mon, Dec 17, 2018 at 10:37:02AM +0800, 陈炤 wrote:
> Below is how SPICE handles commands:
>
>
> For some reason I want to move the lipspice code into guest OS(rather than in
> qemu), and the structure would look like:
Have you looked at Xspice/x11spice? they might be doing something
On Tue, Dec 11, 2018 at 01:48:15PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> As this is NOP from previous patch and has been deprecated since v0.34
When --spice-color-depth is used, it might be nicer for now to add an
error message that this feature has been removed because it was
6 @@ struct _SpiceSessionPrivate {
>
> GStrv disable_effects;
> GStrv secure_channels;
> -gint color_depth;
>
> int connection_id;
> int protocol;
> @@ -667,8 +666,8 @@ static void spice_sessio
Acked-by: Christophe Fergeau
On Wed, Dec 12, 2018 at 09:18:49AM +, Frediano Ziglio wrote:
> Use AS_HELP_STRING in order to fix indentation of configure --help.
> Default is now auto, as the "[enable_celt051="auto"]" parameter.
>
> Signed-off-by: Frediano Z
Hey,
On Sun, Dec 09, 2018 at 03:26:30PM +0200, Snir Sheriber wrote:
> This patch is changing the way gstvideooverlay is being set.
> Once pipeline is created a pointer is passed to the widget using
> GObject signal, so we can set there the overlay interface and call
> its functions from widget
openssl configuration, which forbids 2048 bit
keys, and causes test suite failures.
Apart from this,
Acked-by: Christophe Fergeau
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/pki/ca-cert.pem | 27 ++-
> s
Acked-by: Christophe Fergeau
On Thu, Nov 29, 2018 at 05:42:08PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-widget.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 312c
Hey,
On Thu, Nov 29, 2018 at 12:23:16PM -0500, Frediano Ziglio wrote:
> > For example, when Marc-André added the json-glib dependency (
> > https://lists.freedesktop.org/archives/spice-devel/2018-August/045202.html
> > ), we did not get first a patch adding the new dep and not doing
> >
For the series,
Acked-by: Christophe Fergeau
On Thu, Nov 29, 2018 at 07:51:53AM +, Frediano Ziglio wrote:
> Avoid in some situations an malicious server to led to some minor
> reading buffer overflows. These overflows cannot cause code execution
> or information leakage.
>
Hey,
On Thu, Nov 29, 2018 at 08:50:47AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote:
> > > > On 27 Nov 2018, at 15:38, Christophe Fergeau
> > > > wrote:
> > > > I'm not really
At the moment, we'll unconditionally release the guest QXL resources in
red_put_drawable() even if red_get_drawable() failed and did not
initialize drawable->release_info_ext properly.
This commit only sets RedDrawable::qxl once the guest resource have been
successfully retrieved, and only free
---
server/red-parse-qxl.c | 11 +++
server/red-parse-qxl.h | 3 ++-
server/red-worker.c| 3 +--
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
index e88e75096..1608caff2 100644
--- a/server/red-parse-qxl.c
+++
201 - 300 of 6456 matches
Mail list logo
