Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

On Thu, Jan 11, 2018 at 08:10:39AM -0500, Frediano Ziglio wrote: > > > > Hi > > > > - Original Message - > > > On Tue, Jan 09, 2018 at 12:16:33PM -0500, Marc-André Lureau wrote: > > > > I think it's problematic for traditional applications as well. > > > > clipboard access is probably

Re: [Spice-devel] [PATCH spice-server] RFC: Support abstract Unix sockets

On Wed, Nov 22, 2017 at 11:54:10AM +, Frediano Ziglio wrote: > Allows to specify abstract Unix sockets addresses. > These Unix sockets are supported on Linux and allows to not > have file system names. > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 3 +++ > 1

Re: [Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package

On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote: > It needs the corresponding library to be installed, as well as > pkg-config since it installs a .pc file. > --- > Since the plugins are going to be dlopened, and since the main package > does not ship a .so we need to link to,

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: > > One reason is that you may use a library dynamically, and you may dlclose() > > it, and then atexit() will likely crash. > > Is that a real or theoretical scenario? Who loads this library dynamically > currently?

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 08:53:08AM -0400, Frediano Ziglio wrote: > > > > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > > > even > > > > if they were originally dlopend. If

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > even > > if they were originally dlopend. If the library has used a pthread local > > with > > a destructor function, then unloading the

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote: > > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > This is useful for some instrumentation, e.g. the leaks tracer,

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > Not really familiar with GitLab merge requests but on GitHub they > > > remain open till

Re: [Spice-devel] [PATCH spice-gtk] Use designated struct initializer

On Fri, Jul 07, 2017 at 04:26:33PM +0200, Pavel Grunt wrote: > Silence -Wmissing-field-initializers warnings. This doesn't make sense for many of these cases you've changed > diff --git a/src/channel-main.c b/src/channel-main.c > index 4edd575..104b18a 100644 > --- a/src/channel-main.c > +++

Re: [Spice-devel] [PATCH spice-gtk v3 5/5] Use SPICE_ALIGNED_CAST to silence warning with ucontext on macOS

On Wed, May 17, 2017 at 07:08:26AM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > configure.ac| 3 ++- > src/channel-cursor.c| 6 +++--- >

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

On Thu, May 11, 2017 at 07:08:13AM -0400, Frediano Ziglio wrote: > > > > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > >

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > configure.ac | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/configure.ac

Re: [Spice-devel] [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated)

On Fri, Apr 28, 2017 at 07:48:01AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS > > (deprecated) > > > > It's also deprecated on Linux afaik, but it's still the preferred way in qemu > too. > > An

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST

On Fri, Mar 10, 2017 at 01:16:37PM +0100, Christophe Fergeau wrote: > This fixes make distcheck > --- > This applies on top of the make check-valgrind patch I sent earlier, I can > rebase on top of git master if needed > > Christophe > > server/tests/Makefile.am | 7 ++- > 1 file changed, 6

Re: [Spice-devel] [spice-gtk] doc: Remove perl(Text::CSV) references

On Fri, Mar 10, 2017 at 12:29:55PM +0100, Christophe Fergeau wrote: > It's no longer used since commit e271222e "Switch over to using > keycodemapdb submodule" > --- > README | 2 +- > src/Makefile.am | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) ACK > diff --git a/README

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Thu, Mar 02, 2017 at 07:59:42AM +0100, Pavel Grunt wrote: > On Mon, 2017-02-27 at 10:44 +0000, Daniel P. Berrange wrote: > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > > > Hello Daniel, > > > > > > On Mon, 2017-02-27 at 10:25 +, Danie

[Spice-devel] [PATCH v4] Switch over to using keycodemapdb submodule

Consume the keymaps.csv file from a git submodule instead of having a private copy. This makes it easier to ensure all users of the keymap (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent set of data. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- C

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Thu, Mar 02, 2017 at 08:16:15AM +0100, Pavel Grunt wrote: > On Thu, 2017-03-02 at 07:59 +0100, Pavel Grunt wrote: > > On Mon, 2017-02-27 at 10:44 +0000, Daniel P. Berrange wrote: > > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > > > > Hello D

Re: [Spice-devel] [spice v1] syntax-check: Fix missing AUTHORS

<dinec...@redhat.com> > Cole Robinson <crobi...@redhat.com> > Daniel P. Berrange <berra...@redhat.com> > Dan Kenigsberg <dan...@redhat.com> FWIW, git can trivially auto-fill an AUTHORS file at make dist time. Libvirt does it as follows: Rename AUTHORS

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, Feb 27, 2017 at 02:37:37PM +0100, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 01:13:25PM +0000, Daniel P. Berrange wrote: > > A long while back, Pavel learnt that under XWayland we needed to > > use XkbGetMap instead of XkbGetKeyboard: &g

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, Feb 27, 2017 at 02:24:16PM +0100, Pavel Grunt wrote: > On Mon, 2017-02-27 at 13:13 +0000, Daniel P. Berrange wrote: > > A long while back, Pavel learnt that under XWayland we needed to > > use XkbGetMap instead of XkbGetKeyboard: > > > >   commit 95e322a6bbc29

[Spice-devel] keymap detection under XWayland broken again ?

A long while back, Pavel learnt that under XWayland we needed to use XkbGetMap instead of XkbGetKeyboard: commit 95e322a6bbc29dc9c28724fb80706464e276b89f Author: Pavel Grunt Date: Fri Feb 20 16:19:50 2015 +0100 vncdisplaykeymap: Use XkbGetMap and XkbGetNames

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

On Mon, Feb 27, 2017 at 12:44:27PM +0100, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 06:39:14AM -0500, Frediano Ziglio wrote: > > > > > > On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > Hello Daniel, > > On Mon, 2017-02-27 at 10:25 +0000, Daniel P. Berrange wrote: > > Consume the keymaps.csv file from a git submodule instead of having > > a private copy. This makes it easier to ensure all us

[Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

Consume the keymaps.csv file from a git submodule instead of having a private copy. This makes it easier to ensure all users of the keymap (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent set of data. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- C

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

On Wed, Feb 22, 2017 at 11:47:10AM +0100, Christophe Fergeau wrote: > On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > > Hi, > > > > > > On 02/21/2017 06:37 PM, Christophe Fergeau wrote: > > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > > > > Remove handling

Re: [Spice-devel] [PATCH spice-gtk v5 6/6] usb-device-widget: Migrate to GtkGrid from GtkBox

On Mon, Feb 20, 2017 at 12:44:52PM +0100, Victor Toso wrote: > Hi, > > On Fri, Feb 17, 2017 at 11:24:55AM +0100, Pavel Grunt wrote: > > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be > > deprecated. Just use the GtkGrid and GtkContainer api. > > Sure > > > --- > > GtkContainer is an

[Spice-devel] [PATCH v2] Switch over to using keycodemapdb submodule

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Changed in v2: - Newer submodule hash to pull in python 3 portability fixes .gitmodules | 3 + configure.ac | 11 -- src/Makefile.am | 30 ++-- src/keycodemapdb | 1 + src/keymap-gen.pl

Re: [Spice-devel] bool or gboolean

On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > Hi, > question was raised recently on the ML and IRC. > > Some time ago we decided to use gboolean but some of us would like > to discuss again. > > As any style changes there's no right or wrong, mainly personal > opinions but

Re: [Spice-devel] [PATCH] Switch over to using keycodemapdb submodule

On Wed, Feb 15, 2017 at 04:44:22PM +0100, Pavel Grunt wrote: > nice, although the python script looks pretty heavy. Different users of the keymap database have different output formats. We don't want ever user re-implementing the same logic, as that's just as bad what we have today. So the tool

[Spice-devel] [PATCH] Switch over to using keycodemapdb submodule

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .gitmodules | 3 + configure.ac | 11 -- src/Makefile.am | 30 ++-- src/keycodemapdb | 1 + src/keymap-gen.pl | 214 --- src/keymaps.csv

Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

On Tue, Feb 14, 2017 at 08:33:09AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > > > Allow easier processing by scripts and csv editors > > > --- > > > Also it renders nicely on github > > > https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv > > >

[Spice-devel] [PATCH] Allow websockify path to be controlled

The spice_auto.html file allows websockify path to be set via a query parameter, but the standard spice.html does not provide any mechanism for this. Add another form input field to allow it to be set, defaulting to /websockify Signed-off-by: Daniel P. Berrange <berra...@redhat.

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 05:59:44PM +, Daniel P. Berrange wrote: > On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote: > > > > > > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > > > > > > > Wh

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote: > > > > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > > > > > When used with QEMU at least, both SPICE and VNC live in the same port > > > > range (5900+). It is thus not entirely uncommon for a user to

Re: [Spice-devel] Graceful failure when VNC client connects to SPICE server ?

On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote: > > > > When used with QEMU at least, both SPICE and VNC live in the same port > > range (5900+). It is thus not entirely uncommon for a user to mistakenly > > connect to a SPICE server with a VNC client, or vica-verca. > > > >

[Spice-devel] Graceful failure when VNC client connects to SPICE server ?

When used with QEMU at least, both SPICE and VNC live in the same port range (5900+). It is thus not entirely uncommon for a user to mistakenly connect to a SPICE server with a VNC client, or vica-verca. When connecting to VNC server with a SPICE client, you quickly get an error. This is because

Re: [Spice-devel] [vdagent-win RFC PATCH 0/5] Replace CxImage code

On Wed, Nov 09, 2016 at 10:32:40AM +, Frediano Ziglio wrote: > CxImage is used for image conversion for clipboard support. > CxImage have currently some issue: > - library is old and unsupported; > - required an old libpng library. > Currently the MingW binary we distribute due to some > issue

Re: [Spice-devel] [PATCH spice-protocol v2] Add ioctls structures to qxl_windows.h

On Tue, Aug 16, 2016 at 03:58:50PM +0300, Sameeh Jubran wrote: > This patch defines the structures of ioctls that are used between > win-vdagent and the qxl-wddm-dod driver. > > Signed-off-by: Sameeh Jubran > --- > spice/qxl_windows.h | 15 +++ > 1 file changed,

Re: [Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote: > > The following patch broke compilation of xf86-video-qxl: > > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb > Author: Christophe Fergeau > Date: Thu Mar 5 15:28:22 2015 +0100 > > Mark unused public

Re: [Spice-devel] Virt manager

On Mon, Jun 06, 2016 at 01:14:21PM -0600, Garret Acott wrote: > Anybody know how to reach the https://www.virt-manager.org guys? The site is > down with a DB error. Or do you have an alternative place to download those > files from? Looking for the virt-viewer for windows in particular. Hmm, it

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

On Mon, Jun 06, 2016 at 04:34:09PM +0300, Alexander Bokovoy wrote: > On Mon, 06 Jun 2016, Daniel P. Berrange wrote: > > On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > I'm

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from > > him: > > > > "I'd really like to find a way to do it with pure SASL properties so that > > the > > code

Re: [Spice-devel] [PATCH] Make sure g_object_new receive the correct data

On Fri, Jun 03, 2016 at 07:16:57AM -0400, Frediano Ziglio wrote: > > > diff --git a/server/spicevmc.c b/server/spicevmc.c > > > index b662d94..a863e39 100644 > > > --- a/server/spicevmc.c > > > +++ b/server/spicevmc.c > > > @@ -580,8 +580,8 @@ red_char_device_spicevmc_new(SpiceCharDeviceInstance

Re: [Spice-devel] [PATCH] Make sure g_object_new receive the correct data

On Fri, Jun 03, 2016 at 12:00:24PM +0100, Frediano Ziglio wrote: > g_object_new is a variadic function which take property values. > As compiler cannot check if these property values are correct > make sure they are using casts. > This actully fix a crash in reds.c for 32 bit architectures. > >

Re: [Spice-devel] Gtk-doc VS Doxygen

On Fri, May 20, 2016 at 06:44:01AM -0400, Frediano Ziglio wrote: > Hi, > I'd like to have some standard on the internal documentation of > spice-server. > > The current situation is quite messy having different styles. > I think the worst think is not having any documentation, so better messy

Re: [Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote: > A patch of this size cannot be accepted, no matter how good it is. > We need to find a way to split it. > > Any proposal would be good. There's some simple things which could be done ahead of the main conversion to GObject. -

Re: [Spice-devel] [PATCH] reds: constification

On Thu, Feb 04, 2016 at 04:03:10PM +, Frediano Ziglio wrote: > Make version_string a constant. > Also there is no need to have a pointer but declare the buffer as static > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Spice-devel] RFC: drop spice-gtk gtk+ 2.0 support

On Mon, Jan 18, 2016 at 02:07:49PM +0100, Fabiano Fidêncio wrote: > On Mon, Dec 21, 2015 at 4:54 PM, Marc-André Lureau > wrote: > > Hi, > > > > With virt-viewer now dropping gtk 2.0, I don't know anyone left using > > the spice-gtk with gtk+ 2.0. Thus I'd like to

Re: [Spice-devel] [PATCH v3 4/4] worker: use glib main loop

On Wed, Jan 13, 2016 at 12:18:45PM +, Daniel P. Berrange wrote: > On Wed, Jan 13, 2016 at 11:39:09AM +, Frediano Ziglio wrote: > > Use the glib mainloop instead of writing our own. The glib loop is both > > cleaner to use and is more extensible. It is also very mature

Re: [Spice-devel] [PATCH v3 4/4] worker: use glib main loop

On Wed, Jan 13, 2016 at 11:39:09AM +, Frediano Ziglio wrote: > Use the glib mainloop instead of writing our own. The glib loop is both > cleaner to use and is more extensible. It is also very mature and > reduces the maintenance burden on the spice server. Why not take it further and provide

Re: [Spice-devel] [PATCH v7 01/23] protocol: Add support for the VP8 and h264 video codecs

On Wed, Dec 16, 2015 at 04:16:04PM +0100, Francois Gouget wrote: > Clients that support multiple codecs must advertise the > SPICE_DISPLAY_CAP_MULTI_CODEC capability and one > SPICE_DISPLAY_CAP_CODEC_XXX per supported codec. > > Signed-off-by: Francois Gouget > --- >

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

On Mon, Nov 09, 2015 at 01:30:15PM +0100, Jose Carlos Norte Fernandez wrote: > Thanks for your comments Daniel! > > It wasn’t our intention to add the badgeware paragraph in the first place, > it was there because we recovered our header license text from our past > open source components (from 4

Re: [Spice-devel] [PATCH spice ] Add support for clients connecting with the WebSocket protocol.

On Fri, Oct 30, 2015 at 03:52:56PM -0500, Jeremy White wrote: > We do this by auto detecting the inbound http(s) 'GET' and probing > for a well formulated WebSocket binary connection, such as used > by the spice-html5 client. If detected, we implement a set of > cover functions that abstract the

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

On Fri, Oct 30, 2015 at 10:05:23PM +0900, Daniel P. Berrange wrote: > On Fri, Oct 30, 2015 at 01:24:36PM +0100, j...@eyeos.com wrote: > > > > > I note the attribution clause in your license. As it stands now, I > > > don't think that would cause any trouble (be

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

On Fri, Oct 30, 2015 at 01:24:36PM +0100, j...@eyeos.com wrote: > > > I note the attribution clause in your license. As it stands now, I > > don't think that would cause any trouble (because of the 'however' of 5 > > (d) of the agpl). But it would probably be useful to get a clear > > expression

Re: [Spice-devel] [spice-gtk] build-sys:tests: Error out unless --enable-static is used

On Tue, Oct 13, 2015 at 10:56:00AM +0200, Christophe Fergeau wrote: > The binaries in tests/ need a static build of spice-gtk libraries in > order to be built, but by default, we disable static libraries at > LT_INIT() time. > As the compile failure can be quite cryptic when someone > tries to

Re: [Spice-devel] [spice-common PATCH] ssl_verify.c: Add IPv6 support

On Mon, Sep 07, 2015 at 06:55:47PM +0200, Lukas Venhoda wrote: > Add inet_pton and inet_ntop which supports IPv6 address. > inet_aton left for compatibility. You really should not use any of the inet_* functions, even the ones which technically support IPv6. Instead use

Re: [Spice-devel] [libvirt] [PATCH v4] qemu: Use heads parameter for QXL driver

On Wed, Jul 22, 2015 at 09:59:00AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 04:36:45PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote: On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200

Re: [Spice-devel] [libvirt] [PATCH v4] qemu: Use heads parameter for QXL driver

On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote: On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200

Re: [Spice-devel] [libvirt] [PATCH v4] qemu: Use heads parameter for QXL driver

On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015

Re: [Spice-devel] [libvirt] [PATCH v4] qemu: Use heads parameter for QXL driver

On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

On Tue, Jun 30, 2015 at 04:44:10PM -0500, Jeremy White wrote: This module uses the usbredir protocol and user space tools, which are used by the SPICE project. Signed-off-by: Jeremy White jwh...@codeweavers.com [snip] diff --git a/drivers/usb/usbredir/Kconfig b/drivers/usb/usbredir/Kconfig

Re: [Spice-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver

On Tue, Jun 09, 2015 at 09:49:44AM +0100, Frediano Ziglio wrote: This patch allow to limit number of heads using qxl driver. By default qxl driver is not limited on any kind on head use so can decide to use as much heads. libvirt has this as a video card parameter (actually set to 1 but not

Re: [Spice-devel] [PATCH v4] Check too long password

On Wed, Jun 03, 2015 at 04:22:35PM +0200, Cédric Bosdonnat wrote: Make sure that the password lenght is under the maximum lenght. If not Nit-pick if you re-post, s/lenght/length/g or someone can fixup when merging report it as an authentication failure with an adapted message. --- Diff to

Re: [Spice-devel] [spice-gtk] Add spec files

On Thu, Apr 16, 2015 at 12:30:27PM +0200, Marc-André Lureau wrote: I don't think there are valid reason to put fedora-specific spec file in upstream. You can easily build a rpm with fedpkg. nack We've done this for years with all libvirt related packages and it has proved pretty userful for

Re: [Spice-devel] [PATCH spice-gtk] vncdisplaykeymap: Add support for Xwayland keymap

On Wed, Feb 18, 2015 at 09:47:55AM -0500, Marc-André Lureau wrote: - Original Message - From: Daniel P. Berrange berra...@redhat.com Both Wayland and Xwayland use the evdev + 8 map for keycodes, just as regular Xorg with evdev does. This code is copied from gtk-vnc

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to build the Windows client. Anyway, I don't mind using one solution

Re: [Spice-devel] [PATCH RFC] Add HACKING file

On Mon, Dec 08, 2014 at 04:25:24PM +0100, Christophe Fergeau wrote: On Mon, Dec 08, 2014 at 03:37:32PM +0100, Marc-André Lureau wrote: So much of this is quite irrelevant to the discussion at hand about unreviewed commit rule. I know this is about a lot of stuff, libvirt HACKING fine had

Re: [Spice-devel] [spice-gtk 03/11] Add missing (C) to copyright line

On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote: On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote: Quoting GNU maintainer manual:

Re: [Spice-devel] [spice-gtk 03/11] Add missing (C) to copyright line

On Thu, Oct 30, 2014 at 02:55:05PM +0100, Christophe Fergeau wrote: On Thu, Oct 30, 2014 at 01:38:26PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote: On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com wrote

Re: [Spice-devel] [PATCH] m4: Update manywarnings from gnulib

On Thu, Oct 02, 2014 at 06:17:53PM +0200, Fabiano Fidêncio wrote: From: Cole Robinson crobi...@redhat.com Fixes these noisy errors on Fedora 21: gcc: warning: switch '-Wmudflap' is no longer supported Thanks, I've applied this Daniel -- |: http://berrange.com -o-

Re: [Spice-devel] [PATCH spice-gtk] Add a SPICE_GTK_CHECK_VERSION macro

On Mon, Feb 24, 2014 at 03:03:56PM +0100, Marc-André Lureau wrote: --- configure.ac | 10 ++ doc/reference/spice-gtk-sections.txt | 4 +++ gtk/Makefile.am | 4 +++ gtk/spice-client.h | 1 + gtk/spice-version.h.in

Re: [Spice-devel] Potential New Development for SPICE

On Wed, Feb 19, 2014 at 11:47:43AM -0600, adaptent wrote: Dear Sirs, I have been utilizing SPICE to analyze atoms, which I believe may be the first time this has ever been done. I'd certainly be impressed if our SPICE program had been used to analyse atoms! Unfortunately I think you might

Re: [Spice-devel] Win 8 Display Resolution

On Wed, Feb 12, 2014 at 10:13:18PM +1000, Lindsay Mathieson wrote: Without a QXL driver isn't it limited to 1024x768 resolution? You should be able to go higher than that. IIUC even the cirrus driver supports more than that, but if not then the 'vga' driver for QEMU should. It is mostly

[Spice-devel] SPICE for text mode serial consoles ?

A long time back OpenStack had a remote text console service, in parallel with its VNC console console. This was later deleted because it was using insecure code from an unmaintained 3rd party project. Fairly frequently though people raise the issue of re-enabling remote text (ie serial) console

Re: [Spice-devel] SPICE for text mode serial consoles ?

directions. On Wed, Jan 15, 2014 at 10:37 AM, Daniel P. Berrange berra...@redhat.comwrote: A long time back OpenStack had a remote text console service, in parallel with its VNC console console. This was later deleted because it was using insecure code from an unmaintained 3rd party

Re: [Spice-devel] SPICE for text mode serial consoles ?

On Wed, Jan 15, 2014 at 11:18:42AM -0500, Marc-André Lureau wrote: - Original Message - A long time back OpenStack had a remote text console service, in parallel with its VNC console console. This was later deleted because it was using insecure code from an unmaintained 3rd

Re: [Spice-devel] [PATCH spice-server] Use TLS version 1.0 or better

On Wed, Nov 27, 2013 at 05:23:53PM +0100, David Jaša wrote: When creating a TLS socket, both spice-server and spice-gtk currently call SSL_CTX_new(TLSv1_method()). The TLSv1_method() function set the protocol version to TLS 1.0 exclusively. The correct way to support multiple protocol versions

Re: [Spice-devel] [spice-gtk] Use latest warnings.m4 from gnulib

On Fri, Sep 27, 2013 at 09:17:55AM +0200, Christophe Fergeau wrote: The one we were using does not work properly with clang, causing the build process to try to use -f/-W options that are not supported by clang. --- The same patch has already been ACKed and pushed in

Re: [Spice-devel] [virt-tools-list] More on virt-viewer for windows

On Tue, Sep 17, 2013 at 12:38:03PM -0600, Eric Blake wrote: [adding libvir-list, for some cross-compiling development hints] On 09/17/2013 11:57 AM, Fernando Lozano wrote: Yes, the libvirt comes grom 0.10.2. I'm running the latest windows binaries provided by spice-space.org:

Re: [Spice-devel] [virt-tools-list] Strange behaviour using qemu+ssh on virt-manager

On Tue, Sep 17, 2013 at 02:38:52PM -0300, Fernando Lozano wrote: Hi there, I am experimenting with different security settings for libvirtd, so I can give sysadmins administrative access to the KVM hypervisor without giving them root access on the host. I had success using TLS (with

Re: [Spice-devel] [spice-gtk] Use system-wide trust certificate store

On Wed, Sep 18, 2013 at 02:40:52PM +0200, Christophe Fergeau wrote: Currently, spice-gtk will look in $HOME/.spicec/spice_truststore.pem by default for its trust certificate store (to verify the certificates used during SPICE TLS connections). However, these days a system-wide trust store can

Re: [Spice-devel] [spice-gtk] Use system-wide trust certificate store

On Wed, Sep 18, 2013 at 03:24:36PM +0200, Christophe Fergeau wrote: On Wed, Sep 18, 2013 at 02:11:20PM +0100, Daniel P. Berrange wrote: For SPICE though, users are pretty unlikely to be purchasing certs from the commercial CA (protection racket) vendors. They'll almost certainly be using

Re: [Spice-devel] [virt-tools-list] More on virt-viewer for windows

On Wed, Sep 18, 2013 at 08:24:26AM -0600, Eric Blake wrote: On 09/18/2013 08:19 AM, Fernando Lozano wrote: Hi, Can someone from the Spice community chime in? Why is spice-space.org shipping a Fedora 18 build of libvirt (0.10.2.x) rather than Fedora 19 (1.0.5.x)? Who does the builds, and

[Spice-devel] [PATCH] Free coroutine stack when releasing coroutine

From: Daniel P. Berrange berra...@redhat.com The coroutine_init function mmap's a stack for the ucontext coroutine, but nothing ever munmaps it. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- gtk/coroutine_ucontext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk

[Spice-devel] [PATCH] Abort if mmap of coroutine stack fails

From: Daniel P. Berrange berra...@redhat.com If we fail to mmap the stack, abort the processs rather than returning an error. This is standard practice in glib apps, and the caller was not checking the coroutine_init() return code leading to memory corruption. Signed-off-by: Daniel P. Berrange

Re: [Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

On Sun, Sep 01, 2013 at 09:43:17PM +0300, Uri Lublin wrote: bitmap_consistent should return true or false. Currently it aborts instead of returning false, due to spice_error. Replacing spice_error with spice_warning, provides information and returns false, as expected. This fixes Fedora

Re: [Spice-devel] SPICE_INTERFACE_KEYBOARD - scancodes vs. utf8

On Tue, Aug 06, 2013 at 03:42:29PM +, Dietmar Maurer wrote: Having utf8 input was discussed a few weeks ago, it is needed for html and android clients for ex. Note that this is a completely different problem. When running a virtual machine you need the scancodes, so you can

Re: [Spice-devel] allow config download with https

On Fri, Jul 26, 2013 at 11:26:24AM +, Dietmar Maurer wrote: In my opinion, we could support running 'remote-viewer https://proxmox.example.com/myvm.vv', Well, but we need to handle basic auth. I guess gio/gvfs should be able to fetch files from http[s] (no libcurl please ;). Is it

Re: [Spice-devel] why getScanCode() will not work for keyboard input

On Tue, Jun 25, 2013 at 01:26:46PM +0200, Marc-André Lureau wrote: Hi On Mon, Jun 24, 2013 at 8:08 AM, i iordanov iiorda...@gmail.com wrote: Hi Marc-Andre, (And anybody else who wants to weigh in on this). After some research, reading and experimentation, here is what I've discovered.

Re: [Spice-devel] [spice-gtk] automake: Disable portability warnings

On Mon, Jun 24, 2013 at 11:27:54AM +0200, Christophe Fergeau wrote: -Wportability used to be automatically disabled with automake = 1.12 when using silent rules, but this is no longer the case with automake 1.13 which is what fedora 19 uses:

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73 +++--- 1 file changed, 69 insertions(+), 4 deletions(-) IIUC, implicit in your patch here is that the

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

On Mon, Jun 24, 2013 at 02:45:25PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

On Mon, Jun 24, 2013 at 03:23:30PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 03:04 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:45:25PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de

Re: [Spice-devel] [spice-gtk 0/5] Add support for looking up connection credentials in a file

On Tue, Jun 04, 2013 at 11:16:26AM -0400, Marc-André Lureau wrote: - Mensaje original - On Tue, Jun 04, 2013 at 10:44:45AM -0400, Marc-André Lureau wrote: This patch series adds support for something similar to what is described in http://libvirt.org/auth.html: when a

Re: [Spice-devel] [PATCH spice-gtk 6/7] keymaps: add basic x11 keysyms

On Fri, May 10, 2013 at 10:46:07PM +0200, Marc-André Lureau wrote: Ok, this isn't a good idea, but atm, the browser don't seem to send hardware keycode, and so Gtk+ broadway backend decided to use keysyms representation, which spice-gtk receives as hardware keycodes... Since Gdk keysyms are

Re: [Spice-devel] Fixing the spice-gtk version scheme mess

On Wed, Feb 13, 2013 at 04:44:10PM +0100, Christophe Fergeau wrote: On Wed, Feb 13, 2013 at 04:23:12PM +0100, Marc-André Lureau wrote: On Wed, Feb 13, 2013 at 4:19 PM, Christophe Fergeau cferg...@redhat.com wrote: After this thread and the spice-gtk 0.17 release, I'm _very_ surprised

Re: [Spice-devel] Fixing the spice-gtk version scheme mess

On Wed, Feb 13, 2013 at 05:17:25PM +0100, Marc-André Lureau wrote: Hi On Wed, Feb 13, 2013 at 5:14 PM, Daniel P. Berrange berra...@redhat.com wrote: FYI libvirt Fedora packages no longer carry patches as a general rule. Instead for libvirt we aim to provide stable release branches

[Spice-devel] [PATCH spice-html5] Add spice_auto.html for automated console display

From: Daniel P. Berrange berra...@redhat.com Add a spice_auto.html which removes the form inputs and obtains connection details from query parameters. The optional 'token' parameter is an opaque string passed to the websockets server to allow it to auto-determine the correct console. Otherwise

  1   2   3   >