[Spice-devel] SPICE: contributor guidelines

2020-06-11 Thread Francesco Giudici
Hi SPICE community! After thinking a while on the discussion in the thread: "SPICE: changing the merge rules - a proposal" I would like to come back on the topic and make explicit the way merge requests, changes and reviews are expected to be managed in our community. The core points that

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

2020-05-18 Thread Francesco Giudici
Hi, On 18/05/20 12:56, Daniel P. Berrangé wrote: On Fri, May 15, 2020 at 07:05:50PM +0200, Francesco Giudici wrote: Hi, the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code contributions to the project: every merge request (beside

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

2020-05-18 Thread Francesco Giudici
Hi, On 15/05/20 23:58, Marc-André Lureau wrote: Hi On Fri, May 15, 2020 at 7:06 PM Francesco Giudici <mailto:fgiud...@redhat.com>> wrote: Hi,    the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code cont

[Spice-devel] SPICE: changing the merge rules - a proposal

2020-05-15 Thread Francesco Giudici
Hi, the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code contributions to the project: every merge request (beside trivial patches) should be reviewed and acked at least by one before getting merged. While everyone agrees with this

Re: [Spice-devel] About decisions and reviews

2020-05-12 Thread Francesco Giudici
On 12/05/20 19:13, Marc-André Lureau wrote: Hi On Tue, May 12, 2020 at 5:07 PM Francesco Giudici wrote: On 12/05/20 11:24, Daniel P. Berrangé wrote: On Mon, May 11, 2020 at 12:16:24PM +0200, Marc-André Lureau wrote: Hi, About "Move code to C++": https://gitlab.freedesktop

Re: [Spice-devel] About decisions and reviews

2020-05-12 Thread Francesco Giudici
On 12/05/20 11:24, Daniel P. Berrangé wrote: On Mon, May 11, 2020 at 12:16:24PM +0200, Marc-André Lureau wrote: Hi, About "Move code to C++": https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62 I would like to know how the decision happened. As long as I have been involved in the