Re: [Spice-devel] [PATCH spice-gtk] Fix build without egl

- Original Message - > spice_display_widget_gl_scanout is defined only when building with egl > ./.libs/libspice-client-gtk-3.0.so: undefined reference to > `spice_display_widget_gl_scanout' > --- > src/spice-widget-priv.h | 2 ++ > src/spice-widget.c | 2 +- > 2 files changed, 3

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > ... > > > > > > > 3. If you want to test, a git checkout is enough to test (assuming you > > > > did > > > > the git fetch above). Simpler IMO than git am (even if I assume most of > > > > us > > > > have scripts to process incoming mail) > > > > qemu uses

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > > > > > On 21 Jul 2017, at 12:41, Frediano Ziglio wrote: > > > > > >> > > >> On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > >>> Beside that I wonder why I had to wait 8 months for these reviews, > > >>> not counting

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

Hi - Original Message - > On Tue, 2017-07-18 at 16:50 +0200, Christophe de Dinechin wrote: > > > On 18 Jul 2017, at 16:48, Christophe Fergeau > > > wrote: > > > > > > Hey, > > > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin > > > wrote: > >

Re: [Spice-devel] [spice-gtk] build-sys: Lower gettext requirement

- Original Message - > spice-gtk currently requires gettext 0.19 which is a fairly recent > release (not available in el7.3 and older, nor in ubuntu 14.04 LTS). > They both have a gettext newer than 0.18.2, so we can require that. > > Requiring 0.18 or 0.18.1 is throwing automake errors

Re: [Spice-devel] [spice-gtk] build-sys: Lower gettext requirement

automake errors because of our use > of -Werror, so we side-step this by requiring 0.18.2. > > Signed-off-by: Christophe Fergeau <cferg...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > configure.ac | 2 +- > spice-common | 2 +- >

Re: [Spice-devel] [spice-gtk] cursor: Add sanity checks for hotspot x/y values

98 > > Signed-off-by: Christophe Fergeau <cferg...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > src/channel-cursor.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/channel-cursor.c b/src/channel-cur

Re: [Spice-devel] [PATCH spice-gtk] Do not update .po files with ./autogen.sh && make

- Original Message - > It is enough to update them just before the release (`make dist`) > > Reported-by: Victor Toso ack > --- > also remove a intltool leftover > --- > Makefile.am | 1 - > po/Makevars | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-)

Re: [Spice-devel] [PATCH spice-gtk 2/2] build-sys: modernize gettext

- Original Message - > On Thu, Jul 13, 2017 at 12:13:59PM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Jul 13, 2017 at 08:58:42AM -0400, Marc-André Lureau wrote: > > > > Hi > > > > >

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix build for GStreamer < 1.5.1

Hi - Original Message - > GST_DEBUG_GRAPH_SHOW_FULL_PARAMS is available since that > --- > src/channel-display-gst.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c > index 87e472c..fcb9e25 100644 > ---

Re: [Spice-devel] [spice-gtk] build-sys: Update keycodemapdb submodule

- Original Message - > This brings in 2 bug fixes, one of these is important on RHEL7 to > workaround an argparser bug with the python2 version it ships. > > Signed-off-by: Christophe Fergeau ack > --- > src/keycodemapdb | 2 +- > 1 file changed, 1 insertion(+),

Re: [Spice-devel] [PATCH spice-gtk 2/2] build-sys: modernize gettext

Hi - Original Message - > On Thu, Jul 13, 2017 at 08:58:42AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Wed, Jul 12, 2017 at 03:20:26PM +, Marc-André Lureau wrote: > > > > > > > > >

Re: [Spice-devel] [PATCH spice-gtk 0/3] spice-gtk: Drop frames if they pile up because client is overloaded

Hi - Original Message - > From: Christophe de Dinechin > > This patch series is a crude attempt at getting rid of the frames backlog > when the spice client is overloaded. Another parameter I have been > playing wiht is the max-bytes parameter in the GStreamer >

Re: [Spice-devel] [PATCH spice-gtk 2/3] Drop frames if the backlog is above some limit

- Original Message - > From: Christophe de Dinechin > > Experience has shown that if the machine running the guest is overloaded, > it may pile up a lot of backlog in the frames queue. This patch clears > the queue if it exceeds 100 entries. This value is

Re: [Spice-devel] [PATCH spice-gtk 2/2] build-sys: modernize gettext

Hi - Original Message - > On Wed, Jul 12, 2017 at 03:20:26PM +0000, Marc-André Lureau wrote: > > > > > > This is the latest gettext release, which is not even 1 year old, is > > > this the only one which is going to work? Or is it possible to

Re: [Spice-devel] [PATCH spice-gtk v2] win-usb-dev: fix device arrival event logic

o; > > bi = G_UDEV_DEVICE(b)->priv->udevinfo; > > > > -same_vid = (ai->vid == bi->vid); > > -same_pid = (ai->pid == bi->pid); > > +same_bus = (ai->bus == bi->bus); > > +same_addr = (ai->addr == bi->addr); > >

[Spice-devel] Fwd: [Spice-commits] 5 commits - autogen.sh configure.ac Makefile.am NEWS po/fr.po po/it.po po/Makevars README src/win-usb-dev.c

. Sorry for the mess. -- Forwarded message - From: Marc-André Lureau <elma...@kemper.freedesktop.org> Date: Thu, Jul 13, 2017 at 11:57 AM Subject: [Spice-commits] 5 commits - autogen.sh configure.ac Makefile.am NEWS po/fr.po po/it.po po/Makevars README src/win-usb-dev.c To: <s

Re: [Spice-devel] [PATCH spice-gtk 2/2] build-sys: modernize gettext

Hi On Tue, May 9, 2017 at 5:24 PM Christophe Fergeau <cferg...@redhat.com> wrote: > On Tue, May 09, 2017 at 05:45:50PM +0300, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > intltool and glib-gettext are s

[Spice-devel] ANNOUNCE: spice-protocol release 0.12.13

() macro * add VD_AGENT_CAP_FILE_XFER_DISABLED * add VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE * add new file-xfer statuses for detailed error * Change enums.h license to MIT -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel

Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

Hi - Original Message - > Hi, > > > > > I don't see much alternative. Do you a other proposal? > > > > I think my use case simply requires the ability to pass the pass word in > a way that cannot be intercepted by any kind of hook; whether it be >

Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

Hi - Original Message - > >>> > >>> I don't see much alternative. Do you a other proposal? > >>> > >> > >> I think my use case simply requires the ability to pass the pass word in > >> a way that cannot be intercepted by any kind of hook; whether it be > >> wireshark, or an inotify hook.

Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

Hi - Original Message - > On 06/14/2017 03:46 PM, Marc-André Lureau wrote: > > Hi Jeremy > > > > - Original Message - > >> On 06/14/2017 02:55 PM, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau <marcandre.lur...

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

- Original Message - > On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote: > > Question: can GDK have no X11? > chances are low but there may be a distro shipping gtk without the x11 > backend > > > I suppose only wayland compiled in? > or win32 or quartz (macOS). > > The issue I

Re: [Spice-devel] [PATCH spice-gtk v2] Unrealize egl display only if it has context

ack - Original Message - > Avoids a critical to be logged when closing remote-viewer: > "gl_make_current: assertion 'd->egl.context_ready' failed" > --- > src/spice-widget.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/spice-widget.c

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

Hi, looks fine, how did you reproduce a build issue and make sure it fixed it? - Original Message - > --- > src/spice-gtk-session.c | 2 +- > src/spice-widget-egl.c | 14 +- > src/spice-widget.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

Hi - Original Message - > On Mon, 2017-06-19 at 06:00 -0400, Marc-André Lureau wrote: > > > > - Original Message - > > > > > > > > > - Original Message - > > > > Avoids a critical to be logged when closing

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

- Original Message - > > > - Original Message - > > Avoids a critical to be logged when closing remote-viewer: > > "gl_make_current: assertion 'd->egl.context_ready' failed" > > ack, thanks actually, why not check egl.context_ready? (you might be switch back to 2d, and

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

- Original Message - > Avoids a critical to be logged when closing remote-viewer: > "gl_make_current: assertion 'd->egl.context_ready' failed" ack, thanks > --- > src/spice-widget-egl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/spice-widget-egl.c

Re: [Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

l@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > ___ > > Spice-devel mailing list > > Spice-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/spice-dev

Re: [Spice-devel] [PATCH spice-common 1/2] log: Forbid the usage of obsolete SPICE_LOG_DOMAIN

Hi - Original Message - > As we decided to not use GLib domains do not allow the usage of > this obsolete macro to use different logging domains. > Will be replaced by some different categorization. > > Signed-off-by: Frediano Ziglio > --- > common/log.c |

Re: [Spice-devel] [PATCH spice-common 2/2] log: Force format in log macro to be a string

Hi - Original Message - > Make sure format is a string and not a pointer. > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > common/log.h | 10 +- > 1 file changed

Re: [Spice-devel] [PATCH spice-common 1/2] quic: constantify some variable

On Mon, Jun 12, 2017 at 11:21 AM Frediano Ziglio <fzig...@redhat.com> wrote: > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > common/quic.c | 6 +++--- > 1 file changed, 3 insertions(

Re: [Spice-devel] [PATCH spice-server] log: Do not print function name twice during logging

Hi - Original Message - > On Fri, 2017-06-16 at 17:37 +0100, Frediano Ziglio wrote: > > spice_error/spice_warning already print location information > > so don't print them twice. > > Acked-by: Jonathon Jongmsa > > (By the way, if I remember correctly, Marc-Andre's

Re: [Spice-devel] [PATCH spice-gtk v2] option: deprecate a few esoteric options from --spice group

Hi - Original Message - > On Thu, Jun 15, 2017 at 05:50:01PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > I propose to deprecate the options that have very unclear results, or > > that are un

Re: [Spice-devel] [PATCH spice-gtk] option: deprecate a few esoteric options from --spice group

Hi - Original Message - > On Thu, Jun 15, 2017 at 04:13:12PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > I propose to deprecate the options that have very unclear results, or > > that are un

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

Hi - Original Message - > > > (fwiw, I prefer the shorter version…) > > Remember that the dump only shows up in case of crash. > > Are you arguing problems are easier to debug with less data? Yes, less noise, but relevant data. Saying that becuase your short version is already full of

Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

Hi Jeremy - Original Message - > On 06/14/2017 02:55 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > The spice-controller was a small library to let NPAPI browser plugins > > communicate with the s

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

Hi - Original Message - > >> c) Bugs which we have to be able to reproduce, because there is no > >> useful information in the debug log, e.g. > >> https://bugzilla.redhat.com/show_bug.cgi?id=1017261. Here, we know an > >> assertion failed, but nothing about what happened to get there, so

Re: [Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

Hi - Original Message - > This feature was marked obsolete by efd1d3cb4d8eee more than > an year ago. > > Signed-off-by: Frediano Ziglio I suggest a follow-up patch to remove all #if SPICE_DISABLE_ABORT handling (I sent a patch to spice-gtk since it seems useless

Re: [Spice-devel] [PATCH spice-server] log: remove not widely used logging domain usage

Hi, - Original Message - > As discussed recently the usage of domain for logging has > different issues (they are not filtered and handled coherently) > and are not widely used in the code. > > Signed-off-by: Frediano Ziglio ack > --- > server/dispatcher.c | 2 --

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, Jun 8, 2017 at 12:59 PM Christophe Fergeau <cferg...@redhat.com> wrote: > On Thu, Jun 08, 2017 at 04:41:55AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Jun 08, 2017 at 04:31:20AM -0400,

Re: [Spice-devel] [PATCH spice-gtk 0/5] "Couldn't find current GLX or EGL context" on X11

On Thu, Jun 8, 2017 at 12:56 AM <marcandre.lur...@redhat.com> wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Hi, > > The following patches fixes the "Couldn't find current GLX or EGL > context" error on X11. I don't kno

Re: [Spice-devel] [PATCH spice-gtk 3/5] widget: skip spice_egl_resize_display() if context is not ready

On Thu, Jun 8, 2017 at 3:39 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Thu, Jun 8, 2017 at 12:55 PM Pavel Grunt <pgr...@redhat.com> wrote: > >> On Thu, 2017-06-08 at 00:55 +0400, marcandre.lur...@redhat.com wrote: >> > From: Marc-An

Re: [Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

ano Ziglio wrote: > > > > > This feature was marked obsolete by efd1d3cb4d8eee more than > > > > > an year ago. > > > > > > > > How many stable releases has this been in? > > > > > > * Spice-gtk: v0.31, v0.32, v0.33 and

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > On Fri, 2017-06-09 at 14:29 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi > > > > > > - Original Message - > > > > > If I was reading the code of a pro

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi - Original Message - > > If you set G_LOG_USE_STRUCTURED, glib will use structured log API. But > > there is a single structured log handler (contrary to traditional glog > > that can have per-domain). > > Hm, I have yet to play with the API to say for sure but I thought we > could

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

> > > > > If deemed necessary, you can also avoid expensive log computation > > > > with > > > > SPICE_LOG_ENABLED() macro help. > > Do you have some WIP in spice-gtk? Not yet, I just added a call to spice_log_ini

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

"Spice". Maybe we can > > code this as a preparation change before these changes. > > > >> > >> From: Marc-André Lureau <marcandre.lur...@redhat.com> > >> > >> Hi, > >> > >> This is a RFC series to clean-up Spice

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

t; primary surface conditions. > > > > > > When GL is enabled, use GL scanout informations. > > > Mouse mode is always client when GL surfaces are used. > > > > > > This patch and most of the message are based on a patch from > > > Marc-André

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

e is always client when GL surfaces are used. > > This patch and most of the message are based on a patch from > Marc-André Lureau, just moving responsibility from reds to RedQxl. > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> > --- > server/red-qxl.c | 7 +++

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

ng about common things it seems we quite agree to not using > multiple domains calling GLib but just use "Spice". Maybe we can > code this as a preparation change before these changes. Yes, but I would land categories first, as we already have various G_LOG domains (or subdomains)

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi - Original Message - > On Mon, Jun 12, 2017 at 05:41:26PM +0200, Christophe Fergeau wrote: > > On Mon, Jun 12, 2017 at 12:19:53PM +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > >

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Top remark: here is what I expected to see discussed when I shared the code. > Sending a github link isn't really sharing code. It is not our cmmon practice, so we can't easily review/discuss it. > 1. What categories do we want? > 2. How do spread the

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > The macro was misused and not doing static check. > Spice have other working static check macros to use. > The macro is used only by spice-common so removing it > does not cause issues to other depending projects. > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] Debugging helper functions

Hi - Original Message - > The topic of debugging popped up in the thread about logging. There is one > thing I did not find in Spice, which I think would be helpful, namely > debugging helper functions. > > Here is an example of what I have in mind: >

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Hi > > - Original Message - > > On Fri, Jun 09, 2017 at 12:11:50PM -0400, Marc-André Lureau wrote: > > > I don't get the problem with spice-gtk logging though. > > > > I never remember whether G_MESSAGES_DEBUG=all,

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > On Fri, Jun 09, 2017 at 12:11:50PM -0400, Marc-André Lureau wrote: > > I don't get the problem with spice-gtk logging though. > > I never remember whether G_MESSAGES_DEBUG=all, SPICE_DEBUG=1 and > --spice-debug are the sa

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > On Mon, Jun 12, 2017 at 06:26:58AM -0400, Frediano Ziglio wrote: > > > > > > > > > I think we should replace SPICE_VERIFY / verify with G_STATIC* > > > > > equivalents. > > > > > > > > > > > > > We actually can't for compatibility reason. Some version of GLib

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > The macro was misused and not doing static check. > > > Spice have other working static check macros to use. > > > The macro is used only by spice-common so removing it > > > does not cause issues to other

Re: [Spice-devel] [PATCH spice-common 1/2] quic: constantify some variable

Hi - Original Message - > > > > - Original Message - > > > Signed-off-by: Frediano Ziglio > > > --- > > > common/quic.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/common/quic.c b/common/quic.c > > > index

Re: [Spice-devel] [PATCH spice-common 1/2] quic: constantify some variable

- Original Message - > Signed-off-by: Frediano Ziglio > --- > common/quic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/common/quic.c b/common/quic.c > index 5b00d65..59565ae 100644 > --- a/common/quic.c > +++ b/common/quic.c > @@

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > The macro was misused and not doing static check. > Spice have other working static check macros to use. > The macro is used only by spice-common so removing it > does not cause issues to other depending projects. > See also "[PATCH spice-common 1/4] log:

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

Hi On Wed, Feb 1, 2017 at 4:16 PM Marc-André Lureau <mlur...@redhat.com> wrote: > > > - Original Message - > > > > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > > > Since 2.8, QEMU now longer creates QXL prima

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Mon, Jun 12, 2017 at 12:40 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Fri, Jun 9, 2017 at 10:08 PM Jonathon Jongsma <jjong...@redhat.com> > wrote: > >> On Fri, 2017-06-09 at 12:11 -0400, Marc-André Lureau wrote: >&g

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi On Fri, Jun 9, 2017 at 10:08 PM Jonathon Jongsma <jjong...@redhat.com> wrote: > On Fri, 2017-06-09 at 12:11 -0400, Marc-André Lureau wrote: > > > > > > > - Original Message - > > > > > > > On 9 Jun 2017, at 17:16, J

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > Hi > > - Original Message - > > > If I was reading the code of a project and noticed that they checked a > > > global variable every time before calling g_debug(), I would find that > > > very odd. For example: > > > > > > void foo(void) > > > { > > >

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > > If I was reading the code of a project and noticed that they checked a > > global variable every time before calling g_debug(), I would find that > > very odd. For example: > > > > void foo(void) > > { > > if (foo_get_debug()) { > >

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > On Fri, 2017-06-09 at 12:41 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is > > > unnecessary since g_log()

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is > > > unnecessary since g_log() will already check whether the message will > > > actually be printed. The only benefit to calling this function

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

Hi - Original Message - > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is > unnecessary since g_log() will already check whether the message will > actually be printed. The only benefit to calling this function from > SPICE_DEBUG() is that it ensures that the SPICE_DEBUG

Re: [Spice-devel] RFC: Lightweight tracing mechanism

- Original Message - > [drop_stats]id=0 #in-frames=99 #late=99 (100.00%, avg 2995.89 ms) > #drop-on-playback=0 (0.00%) > [drop_stats]id=0 #in-frames=198 #late=198 (100.00%, avg 2160.48 ms) > #drop-on-playback=3 (1.52%) > [drop_stats]id=0 #in-frames=297 #late=297 (100.00%, avg 1881.11

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi I'll focus on your examples, as I think it's the most relevant for the discussion (let's avoid side-track). - Original Message - > > spicy -t drop_stats=100 -h turbo -p 5901 > [drop_stats]id=0 #in-frames=100 #late=100 (100.00%, avg 1639.24 ms) > #drop-on-playback=8 (8.00%) >

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com > > > wrote: > > > > F

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Use shorter line, use the common "d" variable for private data access, > > a

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, 2017-06-08 at 00:55 +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Use shorter line, use the common "d" variable for private data > > access,

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > On 7 Jun 2017, at 13:51, Marc-André Lureau <marcandre.lur...@redhat.com> > > wrote: > > > > Hi > > > > - Original Message ----- > >> > >>> On 6 Jun 2017, at 20:45, Marc-André Lureau <

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > On 6 Jun 2017, at 20:45, Marc-André Lureau <marcandre.lur...@redhat.com> > > wrote: > > > > I don't think any of these measurements couldn't be reported accurately > > with a regular log or structured log. Thus I do

Re: [Spice-devel] RFC: Lightweight tracing mechanism

id not find where the existing code does anything that would correspond > >> to > >> this > >> SPICE_XXX_DEBUG=alignment:foo:bar (I did ask). Any pointer? In any case, > >> what I saw in glib did not respond to my needs. > >> > >> > >>

Re: [Spice-devel] RFC: Lightweight tracing mechanism

es not > like it at all. > So I only did two in common (ssl and rect) and one in gtk (channel, by > modifying CHANNEL_DEBUG) > > > Also you introduced a new "TRACE" logging level; why DEBUG was not enough? > > This is transitional, to be able to distinguish pre

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > > > On 23 May 2017, at 12:55, Victor Toso < victort...@redhat.com > wrote: > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > > > > or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > Just to point out that we have a

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

- Original Message - > data and cursor->data contains the same data (see the memcpy > above) but data is not aligned to uint32_t and require also > additional casts. Using cursor->data avoid these issues. > > Signed-off-by: Frediano Ziglio looks good, ack > --- >

Re: [Spice-devel] [spice-gtk] Remove link_msg from _SpiceChannelPrivate

- Original Message - > The field is used only to initialize a buffer allocated > inside spice_channel_send_link > > Signed-off-by: Frediano Ziglio ack > --- > src/spice-channel-priv.h | 1 - > src/spice-channel.c | 17 + > 2 files changed, 9

Re: [Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

- Original Message - > Hi > > Apparently, it is available on macos: > https://trac.macports.org/browser/trunk/dports/graphics/libepoxy/Portfile > > but your patch looks correct nonetheless (with the commit summary updated) Ah it may be just epoxy/egl.h not availale on macos, my bad >

Re: [Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

Hi Apparently, it is available on macos: https://trac.macports.org/browser/trunk/dports/graphics/libepoxy/Portfile but your patch looks correct nonetheless (with the commit summary updated) - Original Message - > Signed-off-by: Christophe de Dinechin > --- >

Re: [Spice-devel] [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated)

Hi - Original Message - > Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS > (deprecated) > It's also deprecated on Linux afaik, but it's still the preferred way in qemu too. An alternative would be to implement sigaltstack I suppose (available in qemu). >

Re: [Spice-devel] [PATCH spice-gtk 0/2] Make sure to set initial cursor

Hi - Original Message - > Hi Marc-André, > > On Fri, 2017-04-28 at 04:54 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi, > > > > > > It can happen that the initial cursor is not set for some

Re: [Spice-devel] [spice-gtk v1] file-xfer: Fix bad filename encoding

Hi - Original Message - > Hi, > > On Wed, Apr 12, 2017 at 07:19:54AM -0400, Frediano Ziglio wrote: > > > > > > > > From: Victor Toso > > > > > > Manual for G_FILE_ATTRIBUTE_STANDARD_NAME states: > > > > The name is the on-disk filename which may not be in any known

Re: [Spice-devel] [PATCH spice-gtk v2 4/5] git.mk: fix gettext m4 files to ignore

On Tue, Apr 11, 2017 at 11:14 AM Victor Toso <victort...@redhat.com> wrote: > Ah! > > On Tue, Mar 28, 2017 at 04:48:59PM +0200, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > See also upstream p

Re: [Spice-devel] [RFC spice-gtk 0/5] Quality of Service and monitoring network usage

Hi - Original Message - > Hi, > > On Fri, Apr 07, 2017 at 09:31:57AM -0400, Marc-André Lureau wrote: > > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=100550 > > > > > > So, a few notes of this experience: > > > > > > * I'm

Re: [Spice-devel] [RFC spice-gtk 0/5] Quality of Service and monitoring network usage

Hi - Original Message - > From: Victor Toso > > Hi, > > For a while now I've been playing with the overall network usage with > spice-gtk and trying to think in a way to avoid situations where > channels which are transferring files don't interfere too much on >

Re: [Spice-devel] [spice-gtk v1] channel-webdav: Do not crash if no PhodavServer is found

Hi - Original Message - > From: Victor Toso > > This fixes a crash when spice_session_get_webdav_server() returns NULL > which can easily happen if no shared folder is set. > > We still lack a way to tell the Guest about the failure as it waits > the data to mount

Re: [Spice-devel] [spice-gtk v1] channel-webdav: Do not crash if no PhodavServer is found

- Original Message - > Hi > > - Original Message - > > From: Victor Toso > > > > This fixes a crash when spice_session_get_webdav_server() returns NULL > > which can easily happen if no shared folder is set. > > > > Can you start the phodav server

Re: [Spice-devel] [spice-gtk v1] channel-webdav: Do not crash if no PhodavServer is found

Hi - Original Message - > From: Victor Toso > > This fixes a crash when spice_session_get_webdav_server() returns NULL > which can easily happen if no shared folder is set. > Can you start the phodav server without shared folder? How did you reproduce? > We

Re: [Spice-devel] [PATCH spice-gtk 4/4] Add default .gitpublish profile

- Original Message - > On Tue, 2017-03-28 at 16:37 +0200, Victor Toso wrote: > > Hi, > > > > On Tue, Mar 28, 2017 at 03:51:34PM +0200, marcandre.lur...@redhat.co > > m wrote: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> >

Re: [Spice-devel] [PATCH spice-gtk 3/4] build-sys: modernize gettext

On Tue, Mar 28, 2017 at 3:52 PM <marcandre.lur...@redhat.com> wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > intltool and glib-gettext are somehow related, and upstream gettext > should now support everything needed for GNOME projects. > > intlto

Re: [Spice-devel] [Spice-commits] 2 commits - autogen.sh git.mk Makefile.am README

wrong push, reverting sorry for the noise On Tue, Mar 28, 2017 at 3:00 PM Marc-André Lureau < elma...@kemper.freedesktop.org> wrote: > Makefile.am | 45 +++-- > README |2 +- > autogen.sh |1 - >

Re: [Spice-devel] [spice-gtk v2] audio: debug audio codec when audio stream starts

- Original Message - > From: Victor Toso > > We already debug a few parameters but the audio codec is missing. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436249 > Signed-off-by: Victor Toso ack > --- >

Re: [Spice-devel] [spice-gtk v1] audio: debug audio codec when audio stream starts

- Original Message - > From: Victor Toso > > We already debug a few parameters but the audio codec is missing. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436249 > Signed-off-by: Victor Toso > --- > src/channel-playback.c

Re: [Spice-devel] [spice-gtk v1] channel-webdav: include comment about message handling

cribed above. > > Signed-off-by: Victor Toso <victort...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > src/channel-webdav.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/src/chann

Re: [Spice-devel] [spice-gtk 1/2] Fix possible multimedia time overflow

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > > > > > > > > > > > > 3 - 4294967295 == 4 is not a portable assumption. Neither is > > > > > > > (uint32_t) 3 - (uint32_t) 4294967295 == 4 > > > > > > > > > > > > Ok, I am not an expert in portability, do

<    1   2   3   4   5   6   7   8   9   10   >