Re: [Spice-devel] [spice-gtk PATCH v2] spice-widget: init egl only after first gl_scanout

Hi - Original Message - > > By the way, this egl initialization in the realize handler is actually > breaking spice-gtk with newer gtk+ (specifically gtk+ master). The > cairo widget stops redrawing until the widget gets resized, and then it > freezes again until the next resize. When I

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

hi - Original Message - > Hi, > > > On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > While reviewing lz4 patch, I found that there are potential leaks. This > > is

Re: [Spice-devel] [spice-gtk PATCH v2] spice-widget: init egl only after first gl_scanout

Hi - Original Message - > > - Original Message - > > When using GtkDrawingArea and EGL was not used, it was still initialized. > > This produced warning messages on systems where EGL is not supported. > > Not sure it's really a big problem since we require GL anyway. > > Which

Re: [Spice-devel] [spice-gtk PATCH v2] spice-widget: init egl only after first gl_scanout

Hi - Original Message - > When using GtkDrawingArea and EGL was not used, it was still initialized. > This produced warning messages on systems where EGL is not supported. Not sure it's really a big problem since we require GL anyway. Which system doesn't support egl? > > Move

Re: [Spice-devel] [PATCH spice-gtk 3/3] main: Do not request to resize when have desired size

= 0; > for (i = 0; i < SPICE_N_ELEMENTS(c->display); i++) { > -- > 2.9.2 > > _______ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 2/3] move SpiceDisplayConfig from main channel to session

ed_displays; > +GArray *monitors = NULL; > +g_object_get(c->channel, "monitors", , NULL); > +if (index < monitors->len) { > +SpiceDisplayMonitorConfig *monitor; > +

Re: [Spice-devel] [PATCH spice-gtk 0/3] Avoid sending extra resize requests

Hi - Original Message - > Hi, > > Intention of these patches is to avoid sending unnecessary resize requests > which causes strange behavior ("flickering") of GNOME on Wayland guests [0]. > The main channel now compares new resize requests with the information about > the monitor

Re: [Spice-devel] [Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > Forgot to add RFC to the subject > > > > > > > What's the rationale? if you share the texture id, you must share the GL > > context too, right? Why not use a lower level dmabuf fd that can be > > imported >

Re: [Spice-devel] [Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

Hi - Original Message - > Forgot to add RFC to the subject > What's the rationale? if you share the texture id, you must share the GL context too, right? Why not use a lower level dmabuf fd that can be imported by the server gl context (which is also what the protocol require anyway)?

Re: [Spice-devel] [PATCH spice-gtk] configure: Add ${top_builddir}/spice-common to COMMON_CFLAGS

ack - Original Message - > This fixes the build when done out of the tree, because of recent commit > in spice-common with auto-generated files. > > Signed-off-by: Eduardo Lima (Etrunko) > --- > configure.ac | 2 +- > spice-common | 2 +- > 2 files changed, 2

Re: [Spice-devel] [PATCH v2] Usbredir: Avoid compression of isochronous devices

ice_get_pid(const SpiceUsbDevice > *device) > return info->pid; > } > > +gboolean spice_usb_device_is_isochronous(const SpiceUsbDevice *device) > +{ > + const SpiceUsbDeviceInfo *info = (const SpiceUsbDeviceInfo *)device; > + > +g_return_val_

Re: [Spice-devel] [PATCH RFC EXP] remote Virgl support

Hi - Original Message - > > Do you know which one? At the beginning I was worried this was true > > even for QXL but is not. Looks like it only happens for Virgl. > > > > See some commits here: https://github.com/elmarco/qemu/commits/virgl > > In particular >

Re: [Spice-devel] [PATCH RFC EXP] remote Virgl support

Hi - Original Message - > > > Hi > > > > - Original Message - > > > > > > > Hi, > > > > > > > > > Yes you want to use EGL here, I think we could probably put more code > > > > > in > > > > > qemu > > > > > to help with this case. > > > > > > > > Sure, if anything is needed

Re: [Spice-devel] [PATCH RFC EXP] remote Virgl support

Hi - Original Message - > > > Hi, > > > > > Yes you want to use EGL here, I think we could probably put more code in > > > qemu > > > to help with this case. > > > > Sure, if anything is needed we'll get that sorted ;) > > > > I suspect spice-server needs access to the gl context

Re: [Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

Hi - Original Message - > This variable is accessed from 2 different threads (main thread and USB > event thread), so some care must be taken to read/write it. > --- event_thread_run is a bool, you should make it a gint, probably even volatile. > src/usb-device-manager.c | 6 +++--- >

Re: [Spice-devel] [spice-gtk 1/3] usbredir: Fix GTask leak

ack - Original Message - > spice_usbredir_channel_disconnect_device_async() creates a GTask and > then calls g_task_run_in_thread(). This method will take the reference > it needs on the GTask, it does not take ownership of the passed-in > GTask. This means we need to unref the GTask we

Re: [Spice-devel] gitlab

Hi On Wed, Jun 22, 2016 at 5:31 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Wed, Jun 22, 2016 at 11:05:11AM -0400, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >> > Hi all, >> > >> > I created a s

Re: [Spice-devel] gitlab

Hi - Original Message - > Hi all, > > I created a spice group in gitlab [0] mirroring the repository from > freedesktop which should be updated every hour. > > [0] https://gitlab.com/groups/spice > > But I would like to discuss the transition to use gitlab for source code > at some

[Spice-devel] ANNOUNCE: spice-gtk v0.32 released

spice-gtk-0.32.tar.bz2 -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 2/2] session: Keep brackets around ipv6 hostname

ack - Original Message - > According to rfc2732: > "To use a literal IPv6 address in a URL, the literal address should be > enclosed in "[" and "]" characters." > > Resolves: rhbz#1331777 > --- > src/spice-session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 1/2] session: Removed write-only variable

- Original Message - > --- > src/spice-session.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/spice-session.c b/src/spice-session.c > index 8b3cdd0..888d9fb 100644 > --- a/src/spice-session.c > +++ b/src/spice-session.c > @@ -416,7 +416,6 @@ static int

Re: [Spice-devel] [PATCH spice-gtk] Update NEWS for 0.32 release

- Original Message - > Hi, > > On Tue, 2016-06-21 at 14:28 +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@gmail.com> > > > > Signed-off-by: Marc-André Lureau <marcandre.lur..

Re: [Spice-devel] [spice-gtk] main: channel-main to increase file-transfer reference

if we created a per-task cancellable above, free it */ > -- > 2.5.5 > > _______ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-common] Adjust verify.h licence

ack - Original Message - > verify.h can be licensed as LGPLv2+ rather than GPLv3, see > http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=modules/verify;h=5216ce890dac58e596a27341e31258e5d6c0d702;hb=HEAD > > A verify.h file with the appropriate licence can be generated from a >

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

Hi On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio <fabi...@fidencio.org> > wrote: >>> gtk_widget_set_can_focus(widget, true); >>> +gtk_event_box_set_abo

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

tch because of this is just my preference :-) The line above uses lowercase 'true', I guess I'll change it too then ;) -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk] build: Fix _DEPENDENCIES use

ack - Original Message - > We want to trigger rebuild of libspice-client-gtk-3.0.la or > libspice-client-glib-2.0.la whenever the corresponding symbol file > changes. > However _DEPENDENCIES is not the right way of handling that as it will > disable automatic automake dependency

Re: [Spice-devel] [spice-common 2/3] codegen: Remove unused write_message_marshaller argument

ack - Original Message - > "is_server" is not used in this method > --- > python_modules/marshal.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/python_modules/marshal.py b/python_modules/marshal.py > index 1d38d3d..cc6cbdf 100644 > ---

Re: [Spice-devel] [spice-common 1/3] Update verify.h to latest version

ack - Original Message - > --- > common/verify.h | 144 > ++-- > 1 file changed, 89 insertions(+), 55 deletions(-) > > diff --git a/common/verify.h b/common/verify.h > index 8445e3d..2f43837 100644 > --- a/common/verify.h > +++

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

Hi - Original Message - > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Since the switch to a container widget (gtkstack then gtkeventbox), the > > grab may be lost when clicking on the display. Since events are treated > >

Re: [Spice-devel] [PATCH spice-gtk] widget: use scanout offset when using virgl

ping On Mon, Jun 13, 2016 at 7:11 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Ignoring the display area offset doesn't work nicely with virgl. Imho, > this condition is wrong even in QXL case. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.co

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

ough I fail to reproduce the problem (I am still using older drivers/agents). I think we can just use the solution I proposed for the virgl case, until someone else is hurt by this again and we can find a proper solution. -- Marc-André Lureau __

[Spice-devel] [PATCH spice-gtk] widget: use scanout offset when using virgl

Ignoring the display area offset doesn't work nicely with virgl. Imho, this condition is wrong even in QXL case. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

karound the issue with an extra test such as if (monitors->len == 1 && !d->egl.enabled)... But that condition looks wrong to me anyway. My understanding is that there is some confusing between monitor configuration position (the monitor config on main channel), and the scan

Re: [Spice-devel] [spice-gtk] Remove some warnings compiling for Windows

ack - Original Message - > GetLastError returns a DWORD which is a "unsigned long" on Windows > so use "%lu" formatting instead of "%u". > > Signed-off-by: Frediano Ziglio > --- > src/controller/test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [Spice-devel] [PATCH] Remove deprecated init functions

ack - Original Message - > No need to keep API compatibility in spice-common. > > Signed-off-by: Frediano Ziglio > --- > common/quic.h | 2 -- > common/rop3.h | 2 -- > common/sw_canvas.h | 2 -- > 3 files changed, 6 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 3/3] channel-display: Remove deprecated init functions

Hi - Original Message - > They are called at the construct time since spice-common commit: > 5b6be16b37370bb774aa3c2a7d5c41791fdc3a1e Ok, ack then (imho the old functions should have been dropped in this commit, we don't need to have API/ABI stability in spice-common) > --- >

Re: [Spice-devel] [PATCH spice-gtk 2/3] tests-uri: Define g_assert_nonnull

ack - Original Message - > It is available since Glib 2.40 > --- > tests/uri.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/uri.c b/tests/uri.c > index ea8b794..5bfed2d 100644 > --- a/tests/uri.c > +++ b/tests/uri.c > @@ -19,6 +19,11 @@ > #include > #include

Re: [Spice-devel] [PATCH spice-gtk 1/3] Require gtk+ 3.12

ack - Original Message - > Allow to use gtk_stack_get_child_by_name > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 3fe8055..6e65188 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -123,8 +123,8

Re: [Spice-devel] 回复： how to use spicy-screenshot without interrupt the normal connection ?

Hi - Original Message - > Hi, >  I have a question to ask you,I have know I can exit the fullscreen of spicy >  connection by using  “Shift + F12”my questio is whether  there is  any >  method  to  add a sliver or bar  to the fullscreen of spicy connection on >  the central top of the

Re: [Spice-devel] [spice-gtk 3/9] widget: Always hook keyboard on Windows

Hi - Original Message - > > > > Hi > > > > On Wed, Jun 8, 2016 at 1:10 PM, Frediano Ziglio wrote: > > > This prevents some keyboard handling like IME processing to > > > take place. > > > > But it doesn't explain how it fixed it. > > > > > > > > This fixes

Re: [Spice-devel] [spice-gtk 2/9] widget: Do not mix function linkage

rruption depending on compiler flags. > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > src/spice-widget.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/

Re: [Spice-devel] [spice-gtk 9/9] Sync only on focus change

focus_in_event(GtkWidget *widget, > GdkEventFocus *focus G_GNUC_UN > > release_keys(display); > if (!d->disable_inputs) > -spice_gtk_session_sync_keyboard_modifiers(d->gtk_session); > +spice_gtk_session_set_focus(d->gtk_session, TRUE); > if (d-&g

Re: [Spice-devel] [spice-gtk 4/9] Move code to handle modifier in a specific file

ICE_INPUTS_NUM_LOCK; > -} > -if (keyboard_state.led_mask & 0x04) { > -modifiers |= SPICE_INPUTS_SCROLL_LOCK; > -} > -#elif defined(G_OS_WIN32) > -if (GetKeyState(VK_CAPITAL) & 1) { > -modifiers |= SPICE_INPUTS_CAPS_LOCK; > - } > - if (GetKeyState(VK_NUMLOCK) & 1) { > -modifiers |= SPICE_

Re: [Spice-devel] [spice-gtk 5/9] Add set_keyboard_lock_modifiers

+g_warning("set_keyboard_lock_modifiers not implemented"); > +#endif > +} > diff --git a/src/keyboard-modifiers.h b/src/keyboard-modifiers.h > index d87a930..016be84 100644 > --- a/src/keyboard-modifiers.h > +++ b/src/keyboard-modifiers.h > @@ -28,6 +28,7

Re: [Spice-devel] [spice-gtk 3/9] widget: Always hook keyboard on Windows

+} > +#endif > + Why did you move the Hook/Unhook outside of try_keyboard_grab/ungrab? (here is a lot of conditions that are checked before grabing the systems keys, for ex you don't want to take the grab just because you have the focus, that would break cycling between apps wi

Re: [Spice-devel] [spice-gtk v2] Implements set_keyboard_lock_modifiers for Windows

all */ > +HKEY key; > +LONG err; > +err = RegOpenKeyEx(HKEY_LOCAL_MACHINE, LAYOUT_REGKEY, 0, KEY_READ, ); > +if (err != ERROR_SUCCESS) { > +g_error("RegOpenKeyEx error %ld", err); > +return; > +} > + > +unsigned i; > +for (i = 0; ; ++i) { > +char name[64]; > +err = RegEnumKey(key, i, name, G_N_ELEMENTS(name)); > +if (err == ERROR_NO_MORE_ITEMS) > +break; > +if (err != ERROR_SUCCESS) { > +g_error("RegEnumKey error %ld", err); > +break; > +} > +keyboard_check_single(key, name); > +} > + > +RegCloseKey(key); > +/* check for multiple keyboards > + * > + * KbdLayerDescriptor - no parameter, returns a table > + * KbdLayerMultiDescriptor > + * pass a pointer, structure like, output > + * struct Xxx { > + * uint32_t num_layout_valid; > + * struct { > + * WCHAR dll_name[32]; > + * uint32_t unknown1; > + * uint32_t unknown2; > + * } layers[8]; > + * } > + * KbdLayerRealDllFile > + * BOOL KbdLayerRealDllFile(HKL hkl, WCHAR *realDllName, > PCLIENTKEYBOARDTYPE pClientKbdType, LPVOID reserve) > + * returns TRUE if we need to load another file (this is just a stub) > + * realDllName returned keyboard name > + * pClientKbdType used for terminal server, NULL for physical one > + * reserve NULL > + * KbdLayerRealDllFileNT4 - obsolete > + * KbdNlsLayerDescriptor - no parameter, returns NLS table, if not no > need to parse but MapVirtualKey works > + */ > +} > + > +static void keyboard_check_single(HKEY key, const char *name) > +{ > +char *end = NULL; > +errno = 0; > +unsigned long num = strtoul(name, , 16); > +if (errno || *end) { > +g_error("wrong value %s", name); > +return; > +} > + > +printf("trying keyboard %s\n", name); > +keyboard_cache((HKL) (DWORD_PTR) num); > +printf("\n"); > +} > + > +int main(void) > +{ > +/* make g_critical abort */ > +g_log_set_fatal_mask(G_LOG_DOMAIN, > G_LOG_FATAL_MASK|G_LOG_LEVEL_ERROR|G_LOG_LEVEL_CRITICAL); > + > +keyboard_modifiers_test(); > +return 0; > +} > -- > 2.7.4 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk v2] Implements set_keyboard_lock_modifiers for Windows

tests/Makefile.am| 8 + > tests/keyboard-test.c| 98 +++ Doesn't seem to apply after the last 6 patch. Do you have a git branch with your series? thanks -- Marc-André Lureau ___ Spice-devel mailing list Spice-

Re: [Spice-devel] [spice-gtk 7/9] Implements set_keyboard_lock_modifiers for Windows

Hi - Original Message - > > > index 000..9c7dfba > > > --- /dev/null > > > +++ b/tests/keyboard-test.c > > > @@ -0,0 +1,9 @@ > > > +#define KEYBOARD_MODIFIERS_TEST 1 > > > + > > > +#include "../src/keyboard-modifiers.c" > > > > I would rather not include the C file, but have the

Re: [Spice-devel] [spice-gtk 7/9] Implements set_keyboard_lock_modifiers for Windows

- Original Message - > Signed-off-by: Frediano Ziglio > --- > src/keyboard-modifiers.c | 534 > +++ > tests/Makefile.am| 15 ++ > tests/keyboard-test.c| 9 + > 3 files changed, 558 insertions(+) > create

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

Hi - Original Message - > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from > him: > > "I'd really like to find a way to do it with pure SASL properties so that the > code would work for both SPNEGO and Kerberos. SPNEGO NTLMSSP would make it > working for

Re: [Spice-devel] [PATCH spice-gtk] mingw: Fix -Werror format & missing-prototypes

ack - Original Message - > --- > src/spice-widget.c | 2 +- > src/usb-device-manager.c | 6 +++--- > src/win-usb-clerk.h | 4 ++-- > src/win-usb-driver-install.c | 3 ++- > 4 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/src/spice-widget.c

Re: [Spice-devel] [PATCH] streaming: Tweak the GStreamer decoder to avoid a compiler warning

} > - > -/* The frame is now ready for display */ > -frame->sample = sample; > -g_queue_push_tail(decoder->display_queue, frame); > break; > } > l = l->next; > -- > 2.8.1 > ___

Re: [Spice-devel] [PATCH spice-gtk 1/7] build-sys: enable -Wmissing-prototypes

On Tue, May 31, 2016 at 10:51 AM, Pavel Grunt <pgr...@redhat.com> wrote: > Why removing G_GNUC_INTERNAL ? It is declared the -priv header and used only > internally. (Also an extra space was added) My bad, fixed. -- Marc-André Lureau ___

Re: [Spice-devel] [PATCH spice-gtk 4/7] gst: fix potential null pointer dereference

gt;sample = sample; > ~~^~~~ > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > --- > src/channel-display-gst.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/channel-display-gst.c b/src/chann

[Spice-devel] [PATCH spice-gtk 4/7] gst: fix potential null pointer dereference

CC channel-display-gst.lo channel-display-gst.c: In function ‘new_sample’: channel-display-gst.c:192:31: error: potential null pointer dereference [-Werror=null-dereference] frame->sample = sample; ~~^~~~ Signed-off-by: Marc-André Lur

[Spice-devel] [PATCH spice-gtk 7/7] build-sys: update manywarnings.m4

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- m4/manywarnings.m4 | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4 index 3e6dd21..90823b0 100644 --- a/m4/manywarnings.m4 ++

[Spice-devel] [PATCH spice-gtk 5/7] Fix many -Werror=format warnings

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-base.c | 2 +- src/channel-cursor.c | 2 +- src/channel-display-gst.c | 4 +-- src/channel-display-mjpeg.c| 2 +- src/channel-dis

[Spice-devel] [PATCH spice-gtk 6/7] build-sys: -Wshift-overflow=2

manywarnings.m4 update will bring new flags that fail with some glib/gst headers. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8f1e91b..3fe8055

[Spice-devel] [PATCH spice-gtk 3/7] build-sys: remove -Wmissing-declarations

The warning doesn't show up anymore. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 3c90e9e..8f1e91b 100644 --- a/configure.ac +++ b/configure.ac @@ -

[Spice-devel] [PATCH spice-gtk 2/7] build-sys: remove some gtk+ 2.0 warnings flags

As we dropped gtk+ 2.0 anyway. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 7 --- 1 file changed, 7 deletions(-) diff --git a/configure.ac b/configure.ac index c94d41b..3c90e9e 100644 --- a/configure.ac +++ b/configure.ac @@ -585,13 +585,6 @@ dnl

[Spice-devel] [PATCH spice-gtk 1/7] build-sys: enable -Wmissing-prototypes

Turns out it is possible to fix the warnings now. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- src/channel-base.c | 20 ++-- src/channel-playback.c | 1 + src/giopipe.c | 6 +- src/spice-gstaudio.c

Re: [Spice-devel] [PATCH spice-gtk v4 3/8] spice-uri: Add missing include

Hi - Original Message - > Hi Marc-André, > > On Mon, 2016-05-30 at 11:54 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Related: rhbz#1335239 > > > > include header, but what for? > > It should

Re: [Spice-devel] [PATCH spice-gtk v4 3/8] spice-uri: Add missing include

Hi - Original Message - > Related: rhbz#1335239 include header, but what for? Shouldn't it be merged with some other patch? > --- > src/spice-uri.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index 8cf870d..3bdb502 100644 > ---

Re: [Spice-devel] how to use spicy-screenshot without interrupt the normal connection ?

Hi - Original Message - > > > Hi， > > how to use spicy-screenshot and not to interrupt the normal connection ? > any suggestions ? very appreciate !!! If the server has the experimental multi-client support enabled, using spicy-screenshot should not interrupt the existing connection.

Re: [Spice-devel] [phodav PATCH 2/3 v7] spice-webdavd-windows: Check for mapped shared folder

- Original Message - > Hi > On Thu, May 26, 2016 at 1:07 PM, Marc-André Lureau < mlur...@redhat.com > > wrote: > > > - Original Message - > Rather than the user name of the driver, it would be more reliable to check > the conne

Re: [Spice-devel] [PATCH spice-gtk] Update README

ack - Original Message - > Remove gtk2 related stuff. > Recommend dnf for installing dependencies. > --- > README | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/README b/README > index e80e168..43ee08a 100644 > --- a/README > +++ b/README > @@

Re: [Spice-devel] [spice-gtk v1] removing harmless tabs

Hi - Original Message - > By harmless I mean not changing whole functions that were implemented > with tab indentation. > > Just for reference, after this patch: > > grep $'\t' src/*.[ch] | wc -l > 413 > nack, I would rather not have style changes only commit. > grep -l $'\t'

Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

Hi - Original Message - > When using remote-viewer --full-screen with a VM/client with multiple > monitors, a race can be observed during auto-configuration. First, the > client monitors config is sent to the guest: > (remote-viewer:19480): GSpice-DEBUG: channel-main.c:1166 main-1:0:

Re: [Spice-devel] [PATCH spice-gtk 2/2] file-transfer-task: Hide internals of SpiceFileTransferTask

rTaskClass > -{ > -GObjectClass parent_class; > -}; > - Notice this is a "small" API break. We have done only spice-client-gtk API/ABI break in the coming 0.32 series. > GType spice_file_transfer_task_get_type(void) G_GNUC_CONST; > > char* spice_file_transfer_task_

[Spice-devel] [PATCH spice-gtk 2/2] main: remove unneeded gtk-doc comments

They are no longer in the doc, and not really useful anyway Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-main.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/channel-main.c b/src/channel-main.c index c9bc668..92e01ce 100644 --- a/src/c

[Spice-devel] [PATCH spice-gtk 1/2] main: remove SpiceFileTransferTaskPrivate

The struct is already private Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-main.c | 227 +++-- src/spice-file-transfer-task.h | 1 - 2 files changed, 107 insertions(+), 121 deletions(-) diff --git a/src/c

[Spice-devel] [PATCHv2 3/4] gtk: remove unneeded check

spice_cairo_draw_event() can deal with d->canvas.surface == NULL. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index a37faad..f13a066 100644 --- a/src/spice

[Spice-devel] [PATCHv2 1/4] gtk: move canvas related data in its own structure

Group canvas related data to a sub-structure. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-cairo.c | 38 +++-- src/spice-widget-priv.h | 17 +++-- src/spice-widget.c

[Spice-devel] [PATCHv2 2/4] gtk: rename spicex_* functions

spice-gtk used to have x11/shm backend, now it's only cairo Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/spice-widget-cairo.c | 8 src/spice-widget-priv.h | 8 src/spice-widget.

[Spice-devel] [PATCHv2 4/4] egl: fix delayed widget realize

. Deal with gl scanout updates when the widget is not yet realized, and mark the display as ready when egl is enabled (when last display draw signal is from gl). Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 25 ++--- 1 file chang

Re: [Spice-devel] [PATCH spice-gtk 5/5] egl: fix delayed widget realize

Hi On Wed, May 25, 2016 at 8:42 AM, Pavel Grunt <pgr...@redhat.com> wrote: > On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: >> When the display is not yet realized, spice_display_widget_gl_scanout() >> will fail because the egl context is not ready. The displ

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: move canvas related data in its own structure

Hi - Original Message - > Hi, > > On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > > Group canvas related data to a sub-structure. > I am ok with groupping part of the patch, but there are some changes which > should be documented & go in a separa

Re: [Spice-devel] [PATCH spice-gtk 3/5] egl: bind the scanout texture

ce. What about: glEGLImageTargetTexture2DOES() changes the current bound texture. If the last texture bound is the cursor, update_scanout() will modify the cursor texture, instead of the display. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freede

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Use correct enum value

ack - Original Message - > GDK_GRAB_BROKEN is not GdkGrabStatus value, but GdkEventType > --- > src/spice-widget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index cbca5dc..e337321 100644 > --- a/src/spice-widget.c

Re: [Spice-devel] [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

Hi - Original Message - > On Mo, 2016-05-23 at 16:03 +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > > > Hi, > > > > > > Resuming to work on this after 2

[Spice-devel] [PATCH spice-gtk 4/5] gtk: rename spicex_* functions

spice-gtk used to have x11/shm backend, now it's only cairo Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-cairo.c | 8 src/spice-widget-priv.h | 8 src/spice-widget.c | 27 +-- 3 files changed, 21 inse

[Spice-devel] [PATCH spice-gtk 2/5] widget: move canvas related data in its own structure

Group canvas related data to a sub-structure. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-cairo.c | 40 +++-- src/spice-widget-priv.h | 17 ++--- src/spice-widget.c

[Spice-devel] [PATCH spice-gtk 1/5] display: lower to debug gstreamer codec support

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index a301e67..3ee515b 100644 --- a/src/channel-display.c +++ b/src/channel-dis

Re: [Spice-devel] [PATCH spice-gtk 0/2] Minor updates before the next release

ack series - Original Message - > Mainly to include the fix for the lz decompression crash: > https://bugzilla.redhat.com/show_bug.cgi?id=1285469 > > Pavel Grunt (2): > Update .mailmap > Update spice-common submodule > > .mailmap | 11 +-- > spice-common | 2 +- > 2

Re: [Spice-devel] [PATCH spice-gtk] RFC: update NEWS for 0.32 release

Hi - Original Message - > Hey, > > On Mon, May 23, 2016 at 07:09:16PM +0200, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > > --- > > > > Hi, > > > > It would be nice to release spice-gtk

Re: [Spice-devel] [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

should do here? Fix spice to handle that case? > Should qemu do something else instead? Such as not calling > spice_qxl_gl_scanout() to keep the previous dma-buf alive? I can't really make sense of a call to spice_qxl_gl_draw_async() if there is no scanout backing. So I c

Re: [Spice-devel] [PATCH spice-gtk 7/7] egl: set current context, fix multiple display

Hi - Original Message - > On Mon, May 23, 2016 at 06:40:40AM -0400, Marc-André Lureau wrote: > > > > > > - Original Message - > > > Hi, > > > > > > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote: > > >

[Spice-devel] [PATCHv2 3/3] egl: set current context, fix multiple display

tps://bugzilla.redhat.com/show_bug.cgi?id=1337721 Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 65 ++ 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget-eg

[Spice-devel] [PATCHv2 2/3] egl: don't terminate display

This is global to the display connection: all egl resources will be released, including those from other widgets or from the application. Fix spice/virgl display being rendered black after another widget display is destroyed. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --

[Spice-devel] [PATCHv2 1/3] egl: don't destroy wayland egl context

The egl context is from Gtk on Wayland. Destroy it only on X11. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/spice-widget-egl.c b/src/spice-

Re: [Spice-devel] [PATCH spice-gtk 7/7] egl: set current context, fix multiple display

- Original Message - > Hi, > > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote: > > On X11, each widget has its own context. Make sure we are using the > > widget associated context when using gl. > > > > Fixes: > > https://bugz

Re: [Spice-devel] [PATCH spice-gtk 6/7] egl: don't terminate display

- Original Message - > Hi, > > On Mon, May 23, 2016 at 05:53:35AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi, > > > > > > On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote: &g

Re: [Spice-devel] [PATCH spice-gtk 6/7] egl: don't terminate display

Hi - Original Message - > Hi, > > On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, May 23, 2016 at 10:21 AM, Victor Toso <li...@victortoso.com> wrote: > > > Could you also include a fix that calls e

Re: [Spice-devel] [PATCH spice-gtk 3/7] egl: don't destroy wayland egl context

Hi On Mon, May 23, 2016 at 10:13 AM, Pavel Grunt <pgr...@redhat.com> wrote: > Hi Marc-André, > > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote: >> The egl context is from Gtk on Wayland. Destroy it only on X11. >> > It deserves a comment in the code (li

Re: [Spice-devel] [PATCH spice-gtk 6/7] egl: don't terminate display

Hi On Mon, May 23, 2016 at 10:21 AM, Victor Toso <li...@victortoso.com> wrote: > Could you also include a fix that calls eglTerminate ? Since this is global resources, spice-gtk (a library) can't do that by itself without risking to break somebody else code. -- Marc-And

Re: [Spice-devel] [PATCH spice-gtk 5/7] egl: fix multiple gl display flickering

On Fri, May 20, 2016 at 5:16 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > For some unclear reason, when multiple display use gl in the same > process (with virt-manager for ex), the texture content can be > overwritten by another display on update. > > Alt

[Spice-devel] [PATCH spice-gtk 5/7] egl: fix multiple gl display flickering

the other context texture, there is something fishy. Set the image texture target before drawing to solve this for now. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src

[Spice-devel] [PATCH spice-gtk 3/7] egl: don't destroy wayland egl context

The egl context is from Gtk on Wayland. Destroy it only on X11. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget

[Spice-devel] [PATCH spice-gtk 6/7] egl: don't terminate display

This is global to the display connection: all egl resources will be released, including those from other widgets or from the application. Fix spice/virgl display being rendered black after another widget display is destroyed. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --

<    2   3   4   5   6   7   8   9   10   11   >