(adding back Daniel)
Den 10.02.2020 17.57, skrev Noralf Trønnes:
>
>
> Den 10.02.2020 16.06, skrev Daniel Vetter:
>> On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote:
>>> Move final cleanups to qxl_drm_release() callback.
>>> Add drm_atomic_helper_
Den 10.02.2020 16.06, skrev Daniel Vetter:
> On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote:
>> Move final cleanups to qxl_drm_release() callback.
>> Add drm_atomic_helper_shutdown() call to qxl_pci_remove().
>>
>> Signed-off-by: Gerd Hoffmann
>> ---
>>
Den 07.02.2020 09.41, skrev Thomas Zimmermann:
> The simple-encoder helpers initialize an encoder with an empty
> implementation. This covers the requirements of most of the existing
> DRM drivers. A call to drm_simple_encoder_create() allocates and
> initializes an encoder instance, a call to
Den 29.01.2019 09.25, skrev Gerd Hoffmann:
> qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt
> instead, to avoid wasting resources (swiotlb bounce buffers for
> example).
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-
Den 28.01.2019 09.59, skrev Gerd Hoffmann:
> On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 18.01.2019 13.20, skrev Gerd Hoffmann:
>>> Switch qxl over to the new generic fbdev emulation.
>>>
>>> Signed-off-by:
e the
> commit message with that.
>
This is actually my first review of a driver that I'm not familiar with.
I'm not quite sure how much in depth understanding that is required to
put my ack on it. Going further into the patchset I realised that
there's no way that I can
user_bo->shadow->surf = user_bo->surf;
> + if (user_bo->shadow != qdev->dumb_shadow_bo) {
> + if (user_bo->shadow) {
> + drm_gem_object_put_unlocked
> + (_bo->shadow
are too big will not be added to the mode list in the first place.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Den 18.01.2019 13.19, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> The shadow bo is used as qxl surface, so allocate it as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-
s are rare enough by pure luck.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
is balanced.
>
> Signed-off-by: Gerd Hoffmann
> ---
Just a note: You catch the one-to-many kmap type of unbalance, but not
the one-too-many kunmap situation.
Acked-by: Noralf Trønnes
> drivers/gpu/drm/qxl/qxl_drv.h| 1 +
> drivers/gpu/drm/qxl/qxl_object.c | 6 ++
> d
pot anything suspicious
looking.
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
goto modeset_cleanup;
>
> + drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
I couldn't find that this was part of old fbdev code, so it would be
nice to mention it in the commit message.
Acked-by: Noralf Trønnes
> + drm_fbdev_generic_se
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
eed to dereference pointers each time it
> needs the value, and when reading the code you don't have to trace where
> and why qdev->monitors_config->max_allowed is set.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> dumb buffers are used as qxl surfaces, so allocate them as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-
t; drivers/gpu/drm/qxl/qxl_draw.c | 232 ---
>>> drivers/gpu/drm/qxl/qxl_fb.c | 300
>>> -
>>> drivers/gpu/drm/qxl/Makefile | 2 +-
>>> 4 files changed, 1 insertion(+), 554 deletions(-)
>>> delete mode 100644
s which must be allocated there.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add a helper function to add custom video modes to a connector.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedeskt
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> slot_id_bits and slot_gen_bits can be read directly from qxlrom instead.
> va_slot_mask is never used anywhere.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spic
condition, but
the condition for applying the cursor is changed from bo_old->is_primary
to !bo->is_primary.
It probably makes sense to someone that knows the driver.
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Den 18.01.2019 13.19, skrev Gerd Hoffmann:
> Not used, is always NULL.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mail
---
> drivers/gpu/drm/qxl/Makefile | 2 +-
> 4 files changed, 1 insertion(+), 554 deletions(-)
> delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c
>
Nice!
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists
adapted to upstream changes ]
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Drop pointless indirection, remove the mem_slots array and index
> variables, drop dynamic allocation. Store memslots in qxl_device
> instead.
>
> Signed-off-by: Gerd Hoffmann
> ---
Looks sane:
Acked-
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add all standard modes from the kernel's video mode data base.
> Keep a few non-standard modes in the qxl mode list.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
27 matches
Mail list logo
