Re: [Spice-devel] [PATCH v1 0/6] Move all drivers to a common dma-buf locking convention

2022-07-19 Thread Tomasz Figa
ers/gpu/drm/qxl/qxl_prime.c | 4 +- > drivers/gpu/drm/tegra/gem.c | 27 +-- > drivers/infiniband/core/umem_dmabuf.c | 11 +- > .../common/videobuf2/videobuf2-dma-contig.c | 26 +-- > .../media/common/videobuf2/videobuf2-dma-sg.c | 23 +- > .../common/videobuf2/videobuf2-vmalloc.c | 17 +- For the videobuf2 changes: Acked-by: Tomasz Figa Best regards, Tomasz

Re: [Spice-devel] [PATCH RFC v4 0/1] Virtio Video Device Specification

2020-07-09 Thread Tomasz Figa
On Wed, Jul 8, 2020 at 6:35 AM Alexandre Courbot wrote: > > On Fri, Jul 3, 2020 at 6:55 PM Tomasz Figa wrote: > > > > On Fri, Jul 3, 2020 at 11:27 AM Alexandre Courbot > > wrote: > > > > > > On Fri, Jul 3, 2020 at 6:18 PM Michael S. Tsirkin wrote: >

Re: [Spice-devel] [PATCH RFC v4 0/1] Virtio Video Device Specification

2020-07-03 Thread Tomasz Figa
On Fri, Jul 3, 2020 at 11:27 AM Alexandre Courbot wrote: > > On Fri, Jul 3, 2020 at 6:18 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 03, 2020 at 02:45:15PM +0900, Alexandre Courbot wrote: > > > Hi Dmitry, > > > > > > On Thu, Jul 2, 2020 at 10:47 PM Dmitry Sepp > > > wrote: > > > > > > > >

Re: [Spice-devel] [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver

2020-03-14 Thread Tomasz Figa
On Fri, Mar 13, 2020 at 11:27 AM Dmitry Sepp wrote: > > Hi Tomasz, > > On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote: > > On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp > > > > wrote: > > > Hi Hans, > > > > > > One more thing: &

Re: [Spice-devel] [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver

2020-03-13 Thread Tomasz Figa
On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp wrote: > > Hi Hans, > > One more thing: > > > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that. > > GFP_DMA32 had no effect for me on arm64. Probably I need to recheck. > What's the reason to use any specific GFP flags at all?

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-16 Thread Tomasz Figa
On Mon, Jan 13, 2020 at 10:27 PM Gerd Hoffmann wrote: > > Hi, > > > > Well, no. Tomasz Figa had splitted the devices into three groups: > > > > > > (1) requires single buffer. > > > (2) allows any layout (including the one (1) devices

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-16 Thread Tomasz Figa
On Tue, Jan 14, 2020 at 7:35 PM Dmitry Sepp wrote: > > Hi Keiichi, > > thank you for the update. > > On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote: > > Hi, > > > > On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote: > > > On

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-13 Thread Tomasz Figa
> > > Ok, let's consider the following case: > > - the device expects planes in separate buffers. > > - say, Android on the guest side also imports planes in separate buffers > > into the driver. > > - but he driver only supports one buffer + offsets. > &

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-13 Thread Tomasz Figa
ill used as a reference frame, > > > > even if one sends the drain request. > > > It might be that I'm getting your point wrong, but do you mean some > > > hardware > > > can mark a buffer as ready to be displayed yet still using the underlying > > >

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-13 Thread Tomasz Figa
Dmitry Sepp > > > > > > > > > > > > > wrote: > > > > > > Hi, > > > > > > > > > > > > On Montag, 6. Januar 2020 11:30:22 CET Keiichi Watanabe wrote: > > > > > > > Hi Dmitry,

Re: [Spice-devel] [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-13 Thread Tomasz Figa
On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp > wrote: > > > > Hi Keiichi, > > > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > > > Hi Dmitry, > > > > > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp > >

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-06 Thread Tomasz Figa
On Mon, Dec 30, 2019 at 9:16 PM Dmitry Sepp wrote: > > > On Donnerstag, 19. Dezember 2019 14:28:23 CET Dmitry Sepp wrote: > > Hi Keiichi, > > > > Thank you for the update. Please see some comments below. > > > > Also, we need to bring the virtio_video_control back as it is in fact used > > by the

Re: [Spice-devel] [PATCH v2 0/1] VirtIO video device specification

2019-12-21 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 1:36 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp > wrote: > > > > Hi Keiichi, > > > > On Mittwoch, 18. Dezember 2019 14:02:13 CET Keiichi Watanabe wrote: > > > Hi, > > > This is the 2nd version of virtio-video patch. The PDF

Re: [Spice-devel] [PATCH v2 0/1] VirtIO video device specification

2019-12-21 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 3:18 PM Tomasz Figa wrote: > > On Sat, Dec 21, 2019 at 1:36 PM Keiichi Watanabe > wrote: > > > > Hi Dmitry, > > > > On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp > > wrote: > > > > > > Hi Keiichi, > > >

Re: [Spice-devel] [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-21 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 12:46 AM Dmitry Sepp wrote: > On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote: > > On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp > > wrote: > > > On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote: [snip] > > > > +enum virtio_video_format

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 7:55 PM Dmitry Sepp wrote: > > Hi Tomasz, > > On Donnerstag, 19. Dezember 2019 10:59:02 CET Tomasz Figa wrote: > > On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp > wrote: > > > Hi, > > > > > > On Donnerstag, 19. Dezember 2019

Re: [Spice-devel] [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 6:26 PM Dmitry Sepp wrote: > > Hi Gerd, > > On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote: > > Hi, > > > > > +The device MUST mark the last buffer with the > > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain > > > +sequence. > > > >

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp wrote: > > Hi, > > On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote: > > On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote: > > > On Wed, Dec 18, 2019 at 10:40 PM Gerd Ho

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-18 Thread Tomasz Figa
On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote: > > Hi, > > > +The device MUST mark the last buffer with the > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain > > +sequence. > > No, that would build a race condition into the protocol. The device > could complete the