Re: [Spice-devel] bad id bug in glz decoder

2018-04-23 Thread Usepr Xf
I found this code in glz_encoder.c in spice-server: static inline void encode_64(Encoder *encoder, uint64_t word) { encode_32(encoder, (uint32_t)(word >> 32)); encode_32(encoder, (uint32_t)(word & 0xff)); // <- is it wrong? 0xff should be deleted } On Fri, Apr 13, 2018 at

Re: [Spice-devel] bad id bug in glz decoder

2018-04-13 Thread Usepr Xf
Hello all, I was wondering if you have had a chance to look at the e-mail below yet? It's about the wrong id problem of glz algorithm. Many thanks On Wed, Apr 11, 2018 at 12:28 PM, Usepr Xf wrote: > Hi all, > > Sorry to be a bother. > > After a long time running of glz e

[Spice-devel] bad id bug in glz decoder

2018-04-11 Thread Usepr Xf
Hi all, Sorry to be a bother. After a long time running of glz encode&decode (approx. 4hrs), I came across this error. The higher bits (> 24) of the image id is truncated, which makes *dist* less than *id*. This error seems to happen when the *dist* across *(1<<24)* Can you help me solve this