I suggest to use
https://github.com/virtio-win/kvm-guest-drivers-windows/issues instead of
spice-devel mail list unless you think the problem is somehow related to
spice-devel
Thanks
Yuri
On Sat, Dec 16, 2023 at 11:16 AM Carlos González
wrote:
> I'm coming directly from this mess:
>
>
The procedure was:
We sign the driver for Win10 only and then produce 2 driver packages: one
for Win 10 (with signed one) and another one for 8.1 (we call it
'compatible') as is. It is signed by RH certificate and has all the
respective limitations.
On Wed, Feb 15, 2023 at 10:44 AM Yan
On Mon, Jul 13, 2020 at 12:12 PM Frediano Ziglio wrote:
> >
> > Hi,
> >
> > > @@ -4795,7 +4796,8 @@ NTSTATUS QxlDevice::HWClose(void)
> > > {
> > > PAGED_CODE();
> > > QxlClose();
> > > -if (m_bUefiMode)
> > > +/* QXL device rev 5+ requires explicit reset to switch to VGA
>
https://bugzilla.redhat.com/show_bug.cgi?id=1851845
v5 device requires explicit reset to switch to VGA mode.
Signed-off-by: Yuri Benditovich
---
qxldod/QxlDod.cpp | 4 +++-
qxldod/QxlDod.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/qxldod/QxlDod.cpp b/qxldod
Suppress unneeded stampinf logs during driver build.
Signed-off-by: Yuri Benditovich
---
qxldod/qxldod.vcxproj | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qxldod/qxldod.vcxproj b/qxldod/qxldod.vcxproj
index 15e36d9..0091b83 100755
--- a/qxldod/qxldod.vcxproj
+++ b
https://bugzilla.redhat.com/show_bug.cgi?id=1758524
Examples are displays 320*200 and 800*480
Signed-off-by: Yuri Benditovich
---
qxldod/QxlDod.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h
index d889b9d..016b1aa 100755
--- a/qxldod
https://bugzilla.redhat.com/show_bug.cgi?id=1791804
The remapping will work only when the driver controls
the placement of drawn pointer, i.e. when the input
device in VM is usb-mouse and the Spice Agent is not
active.
Signed-off-by: Yuri Benditovich
---
qxldod/QxlDod.cpp | 26
;
>
> Does WDDMInterface::escape only support qxl type video card?
Yes, this is private interface
>
> ________
> From: Yuri Benditovich
> Sent: Tuesday, January 14, 2020 10:07 AM
> To: franklin zhou
> Cc: Frediano Ziglio ; Spice Lis
Which QXL driver is installed on 2012: qxl.sys for xp/Win7 or
qxldod.sys for win8+?
On Tue, Jan 14, 2020 at 11:43 AM Frediano Ziglio wrote:
>
>
> > In windows server 2012, the follow line " status = _pfnEscape();
> > "
> > always cause error,
> > status is: 0xc00d, error message is:
r questions:
> - I see UsbDK does not use difx. Is it easier to use difx ?
> - Do people run Windows 10 x86 (32 bit)? Do we need such a driver ?
>
> Ack.
>
> Thanks,
> Uri.
>
> On 11/22/19 8:39 AM, Yuri Benditovich wrote:
> > Signed-off-by: Yuri Bend
Can you please merge it and update the downstream.
No need to build the downstream, just to update the repo.
Thanks,
Yuri
On Wed, Dec 4, 2019 at 1:48 PM Uri Lublin wrote:
>
> On 11/22/19 9:06 AM, Yuri Benditovich wrote:
> > Signed-off-by: Yuri Benditovich
>
> This is very s
On Fri, Dec 6, 2019 at 12:30 PM Frediano Ziglio wrote:
>
> >
> > From: Alexander Nezhinsky
> >
> > Turn shared CD devices added using command line into hot-plugged devices
> > which are redirected according to 'auto-connect' filter rules.
> > By default command line devices are added using
On Fri, Dec 6, 2019 at 12:04 PM Frediano Ziglio wrote:
>
> >
> > From: Alexander Nezhinsky
> >
> > The following functions are added:
> > spice_usb_device_manager_create_shared_cd_device
> > spice_usb_device_manager_is_device_shared_cd
> > spice_usb_device_manager_remove_shared_cd_device
> >
> >
ot need difx.
> - Do people run Windows 10 x86 (32 bit)? Do we need such a driver ?
>
Sure. MSI for x86 will install driver for x86.
> Ack.
>
> Thanks,
> Uri.
>
> On 11/22/19 8:39 AM, Yuri Benditovich wrote:
> > Signed-off-by: Yuri Bend
ping
On Fri, Nov 22, 2019 at 9:06 AM Yuri Benditovich
wrote:
>
> Signed-off-by: Yuri Benditovich
> ---
> xddm/QXLInstaller.wxs | 88 +++
> 1 file changed, 88 insertions(+)
> create mode 100644 xddm/QXLInstaller.wxs
>
> diff --git
Signed-off-by: Yuri Benditovich
---
xddm/QXLInstaller.wxs | 88 +++
1 file changed, 88 insertions(+)
create mode 100644 xddm/QXLInstaller.wxs
diff --git a/xddm/QXLInstaller.wxs b/xddm/QXLInstaller.wxs
new file mode 100644
index 000..664b3ed
--- /dev
Signed-off-by: Yuri Benditovich
---
QXLWDDMDODInstaller.wxs | 94 +
1 file changed, 94 insertions(+)
create mode 100644 QXLWDDMDODInstaller.wxs
diff --git a/QXLWDDMDODInstaller.wxs b/QXLWDDMDODInstaller.wxs
new file mode 100644
index 000..64145cc
Currently the MSI built for x86 system can be easily installed
on x64 system. When the script is processed by WIX this can be
prevented by passing '-dNoWOW=yes' to the WIX-candle.
Signed-off-by: Yuri Benditovich
---
spice-vdagent.wxs.in | 5 +
1 file changed, 5 insertions(+)
diff --git
/vd_agent/tree/wix_align
Yuri Benditovich (3):
win32/vd_agent: Fix WIX error on .wxs script
win32/vd_agent: Customize MSI product name and install location
win32/vd_agent: Optionally disable installation of x86 MSI on x64
system
Makefile.am | 5 -
spice-vdagent.wxs.in | 17
Customize these properties of WIX script during build under
WIXL or Windows.
Signed-off-by: Yuri Benditovich
---
Makefile.am | 5 -
spice-vdagent.wxs.in | 8
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 3020824..80e82c6
Allows the same WIXL script to be used for WIX on Windows.
WIX raises error if Win64 property is not set for x64 MSI.
Signed-off-by: Yuri Benditovich
---
spice-vdagent.wxs.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spice-vdagent.wxs.in b/spice-vdagent.wxs.in
> test-cd-emu: Test detach and reattach
> test-cd-emu: Make sure we can call
> spice_usb_backend_channel_flush_writes
> test-cd-emu: Test no libusb context support
>
> Victor Toso (1):
> usb-backend: add guard and doc to check_filter()
>
> Yuri Benditovich (10
On Fri, Aug 23, 2019 at 10:59 AM Victor Toso wrote:
>
> On Thu, Aug 22, 2019 at 11:27:19AM +0300, Yuri Benditovich wrote:
> > On Thu, Aug 22, 2019 at 9:56 AM Frediano Ziglio wrote:
> > > > On Tue, Aug 13, 2019 at 2:59 PM Frediano Ziglio
> > > > wrote:
On Thu, Aug 22, 2019 at 1:40 PM Frediano Ziglio wrote:
>
>
> > On Thu, Aug 22, 2019 at 1:20 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Aug 12, 2019 at 12:57:20PM +0300, Yuri Benditovich wrote:
> > > > This series of patc
On Thu, Aug 22, 2019 at 1:20 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Aug 12, 2019 at 12:57:20PM +0300, Yuri Benditovich wrote:
> > This series of patches adds feature of sharing CD image via
> > redirection of emulated CD device. Currently the trigger to
> > cre
On Thu, Aug 22, 2019 at 1:18 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Aug 12, 2019 at 12:57:21PM +0300, Yuri Benditovich wrote:
> > SpiceUsbBackendDevice structure is extended to support
> > additional kind of device that is emulated by Spice-GTK
> > and not pres
On Wed, Aug 21, 2019 at 7:29 PM Uri Lublin wrote:
>
> On 8/21/19 3:25 AM, zhou qi wrote:
> > Hello, I write a demo under windows unsing *spice-client-glib only*, I> can
> > get usb devices from UsbManager. but hotplug is not working. no> device
> > change event recieved.
>
> Hello,
>
> > I
On Wed, Aug 21, 2019 at 7:29 PM Uri Lublin wrote:
>
> On 8/21/19 3:25 AM, zhou qi wrote:
> > Hello, I write a demo under windows unsing *spice-client-glib only*, I> can
> > get usb devices from UsbManager. but hotplug is not working. no> device
> > change event recieved.
>
> Hello,
>
> > I
'hello' is sent by the parser.
> > > It would be more clear to implement just what you described
> > > above, why the implementation is a bit different.
> >
> > Due to corner case described below.
> >
> >
his is worth to be mentioned in the documentation.
>
>
> On Tue, Aug 20, 2019 at 12:09 PM Yuri Benditovich <
> yuri.benditov...@daynix.com> wrote:
>
>>
>> On Tue, Aug 20, 2019 at 12:59 PM Brian Wengel
>> wrote:
>>
>>> OK. at least we know wh
BTW, I see that Windows' libspice*.dll released with mingw do not have any
version information (that usually for Windows binaries comes during build
from resource file).
On Tue, Aug 20, 2019 at 12:46 PM Yuri Benditovich <
yuri.benditov...@daynix.com> wrote:
> I see the virt-viewer 8.0
12 (07-08-18)
> - Log-file attached
>
> :-)
>
> On Mon, Aug 19, 2019 at 2:10 PM Yuri Benditovich <
> yuri.benditov...@daynix.com> wrote:
>
>> Hi Brian,
>>
>> Which backend you use on your Spice Client machine, UsbDk or WinUsb?
>> What is the
Hi Brian,
Which backend you use on your Spice Client machine, UsbDk or WinUsb?
What is the version of remote-viewer and the version of libusb-1.0.dll (it
should be in the same directory when remote-viewer.exe)
I'd also suggest to make a debug log (usually "remote-viewer ...
--spice-debug >
On Tue, Aug 13, 2019 at 2:29 PM Frediano Ziglio wrote:
>
> >
> > Add implementation of emulated device to build.
> > Now it is possible to create emulated CD devices.
> >
> > Signed-off-by: Yuri Benditovich
>
> Would be better to compile only if needed,
he 'hello' is sent by the parser.
> It would be more clear to implement just what you described
> above, why the implementation is a bit different.
Due to corner case described below.
>
> > When libusb device is redirected via a channel, instance of
> > usbredirhost serves it.
> >
f
> > virtual functions required to redirect such virtual device.
> >
> > Signed-off-by: Yuri Benditovich
>
> Acked-by: Frediano Ziglio
>
> But I would merge 2/9 into
No problem, if you want to merge them together when merging upstream.
I've left it asid
Add implementation of emulated device to build.
Now it is possible to create emulated CD devices.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/meson.build b/src/meson.build
index fe19c16..3837a9d 100644
--- a/src/meson.build
This module contains implementation of emulated device
interface for shared CD.
Signed-off-by: Yuri Benditovich
---
src/usb-device-cd.c | 783
src/usb-device-cd.h | 34 ++
2 files changed, 817 insertions(+)
create mode 100644 src/usb-device-cd.c
For local USB device the USB backend returns the same device
description as spice-usb-manager did, for emulated devices it
uses the description provided by device's implementation.
Signed-off-by: Yuri Benditovich
Acked-by: Frediano Ziglio
---
src/usb-backend.c| 41
on its device type. Implementation module will define
constructor for specific device type.
Device structure is abstract but always starts from table of
virtual functions required to redirect such virtual device.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 1 +
src/usb-backend.c
From: Frediano Ziglio
---
src/usb-backend.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index de2b55e..7f9fcc1 100644
--- a/src/usb-backend.c
+++ b/src/usb-backend.c
@@ -200,7 +200,7 @@ static int
Added command-line option for sharing emulated CD devices.
It uses property interface of usb-device-manager to
create CD, this is a temporary solution until public API of
usb-device-manager defined for shared CD management from both
GUI and command line.
Signed-off-by: Yuri Benditovich
---
src
of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 616
Signed-off-by: Yuri Benditovich
Acked-by: Frediano Ziglio
---
src/channel-usbredir.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..8fd6b41 100644
--- a/src/channel-usbredir.c
by reviews (mainly based on fixups
of Frediano Ziglio)
Frediano Ziglio (1):
usb-redir: cosmetic style fixes
Yuri Benditovich (8):
usb-redir: define interfaces to support emulated devices
usb-redir: move implementation of device description to USB backend
usb-redir: do not use
On Thu, Aug 8, 2019 at 1:41 PM Frediano Ziglio wrote:
>
> Change reference counting semantic for emulated devices.
> Make the same as not emulated.
> This fix a leak if spice_usb_backend_device_eject is not called.
> Consistently the reference counter for SpiceUsbBackendDevice is
> now the number
evice
> > > > > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > > > depends on its device type. Implementation module will
> > > > > > > > > > define
> > > > > > > > &g
> > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > depends on its device type. Implementation module will define
> > > > > > > > constructor for specific de
> > > > > +
> > > > > > +if (be->own_devices_mask == 0x) {
> > > > > > +g_set_error(err, SPICE_CLIENT_ERROR,
> > > > > > SPICE_CLIENT_ERROR_FAILED,
> > > > > > +_("
device type. Implementation module will define
> > > > constructor for specific device type.
> > > > Device structure is abstract but always starts from table of
> > > > virtual functions required to redirect such virt
f
> > virtual functions required to redirect such virtual device.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 1 +
> > src/usb-backend.c | 102 +++-
> > src/usb-backend.h | 3
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..8fd6b41 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
This module contains implementation of emulated device
interface for shared CD.
Signed-off-by: Yuri Benditovich
---
src/usb-device-cd.c | 790
src/usb-device-cd.h | 37 +++
2 files changed, 827 insertions(+)
create mode 100644 src/usb-device-cd.c
Add implementation of emulated device to build.
Now it is possible to create emulated CD devices.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/meson.build b/src/meson.build
index fe19c16..3837a9d 100644
--- a/src/meson.build
on its device type. Implementation module will define
constructor for specific device type.
Device structure is abstract but always starts from table of
virtual functions required to redirect such virtual device.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 1 +
src/usb-backend.c
of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 585
For local USB device the USB backend returns the same device
description as spice-usb-manager did, for emulated devices it
uses the description provided by device's implementation.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c| 41
src
This series of patches adds feature of sharing CD image via
redirection of emulated CD device. Currently the trigger to
create the device is command-line option:
'--spice-share-cd
Changes from v1: fixes resulted by reviews (mainly based on fixups
of Frediano Ziglio)
Yuri Benditovich (8):
usb
Added command-line option for sharing emulated CD devices.
It uses property interface of usb-device-manager to
create CD, this is a temporary solution until public API of
usb-device-manager defined for shared CD management from both
GUI and command line.
Signed-off-by: Yuri Benditovich
---
src
On Thu, Aug 1, 2019 at 3:26 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Jul 29, 2019 at 12:26:11PM +0300, Yuri Benditovich wrote:
> > On Mon, Jul 29, 2019 at 11:03 AM Frediano Ziglio wrote:
> > > What does it means? The code cannot be improved before being
> > >
On Tue, Jul 30, 2019 at 4:59 PM Frediano Ziglio wrote:
>
> >
> > On Tue, Jul 30, 2019 at 1:43 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > This module contains implementation of emulated device
> > > > interface fo
of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fix
On Tue, Jul 30, 2019 at 1:43 PM Frediano Ziglio wrote:
>
> >
> > This module contains implementation of emulated device
> > interface for shared CD.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/usb-device-cd.c | 794 +++
, 2019 at 2:14 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > > On Mon, Jul 29, 2019 at 12:27 PM Frediano Ziglio
> > > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > &g
> > > wrote:
> > > > >
> > > > > > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio
> > > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Jul
io wrote:
> > >
> > > > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
> > > > > > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso
> > > > > > wrote:
> > >
> > >
> > > > > > > >
> > > > > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > &g
SpiceUsbEmulatedDevice
> > > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > depends on its device type (currently only 'CD device'
> > > > > > > > defined). Implementation module registers const
On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > > >
tation module registers constructor for
> > > > > > this device type. Device structure is abstract but always
> > > > > > starts from table of virtual functions required to redirect
> > > > > > such virtual device.
> > > > > >
>
On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
>
> Hi,
>
> On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > On Fri, Jul 26, 2019 at 10:09 AM
On Fri, Jul 26, 2019 at 6:51 PM Frediano Ziglio wrote:
>
> > On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Register constructor for emulated CD device. Now creation
> > > > of CD devices at startup is pos
On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote:
> > > >
On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote:
>
> >
> > Register constructor for emulated CD device. Now creation
> > of CD devices at startup is possible.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 6 ++
>
On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote:
>
> Hi,
>
> On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote:
> > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio wrote:
> > > > > > > @@ -1440,6 +1446,10 @@ gchar
> > > > >
On Fri, Jul 26, 2019 at 1:02 PM Frediano Ziglio wrote:
>
> > On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote:
> > >
> > > > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
&g
on its device type (currently only 'CD device'
> > > > defined). Implementation module registers constructor for
> > > > this device type. Device structure is abstract but always
> > > > starts from table of virtual functions required to redirect
> > > &g
On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote:
>
> > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Signed-off-by: Yuri Benditovich
> > > > ---
> > > > src/channel-usbredir.c | 29 ++
e structure with backend
> > > > > device fields set to NULL and use it for indication. Device
> > > > > description for such device will be 'USB Redirection'.
> > > > > Unreferencing of such device will be 'no operation'.
> > > > >
> &g
On Thu, Jul 25, 2019 at 1:33 PM Victor Toso wrote:
>
> On Wed, Jul 24, 2019 at 01:53:45PM +0300, Yuri Benditovich wrote:
> > Added command-line option for shared CD devices and respective
> > property in usb-device-manager.
> >
> > Signed-off-by: Yuri Benditovich
&
On Thu, Jul 25, 2019 at 1:32 PM Victor Toso wrote:
>
> Hi,
>
> On Thu, Jul 25, 2019 at 05:09:17AM -0400, Frediano Ziglio wrote:
> > >
> > > Added command-line option for shared CD devices and respective
> > > property in usb-device-manager.
>
On Thu, Jul 25, 2019 at 12:09 PM Frediano Ziglio wrote:
>
> >
> > Added command-line option for shared CD devices and respective
> > property in usb-device-manager.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/spice-option.c | 15
act but always
> > starts from table of virtual functions required to redirect
> > such virtual device.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 1 +
> > src/usb-backend.c | 128 +
On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote:
>
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/channel-usbredir.c | 29 ++---
> > 1 file changed, 14 insertions(+), 15 deletions(-)
> >
> > diff --git a/sr
hen the device is not created yet. For that we
> > allocate temporary SpiceUsbDevice structure with backend
> > device fields set to NULL and use it for indication. Device
> > description for such device will be 'USB Redirection'.
> > Unreferencing of such device will b
On Thu, Jul 25, 2019 at 11:08 AM Victor Toso wrote:
>
> Hi,
>
> On Wed, Jul 24, 2019 at 01:53:43PM +0300, Yuri Benditovich wrote:
> > SpiceUsbBackendDevice structure is extended to support
> > additional kind of device that is emulated by Spice-GTK
> > and not pres
on its device type (currently only 'CD device'
defined). Implementation module registers constructor for
this device type. Device structure is abstract but always
starts from table of virtual functions required to redirect
such virtual device.
Signed-off-by: Yuri Benditovich
---
src/meson.build
Ability to retrieve device description for emulated USB
device, defined by implementation. For example, for shared
CD the implementation may use basename of ISO file.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
Added command-line option for shared CD devices and respective
property in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/spice-option.c | 15 +++
src/usb-device-manager.c | 33 +
2 files changed, 48 insertions(+)
diff --git a/src
This module contains implementation of emulated device
interface for shared CD.
Signed-off-by: Yuri Benditovich
---
src/usb-device-cd.c | 794
1 file changed, 794 insertions(+)
create mode 100644 src/usb-device-cd.c
diff --git a/src/usb-device-cd.c
Register constructor for emulated CD device. Now creation
of CD devices at startup is possible.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 6 ++
src/usb-backend.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/meson.build b/src/meson.build
index 49fec52..944b083
This series of patches adds feature of sharing CD image via
redirection of emulated CD device. Currently the trigger to
create the device is command-line option:
'--spice-share-cd
Yuri Benditovich (9):
usb-redir: define interfaces to support emulated devices
usb-redir: device error signal
of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 583
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..961a464 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
fields set to NULL and use it for indication. Device
description for such device will be 'USB Redirection'.
Unreferencing of such device will be 'no operation'.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c| 3 +++
src/usb-device-manager.c | 14 --
2 files changed, 15
Newer API (glib 2.32) is safe, in case of error it does not
abort the process and returns error information.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 7c9b544
'redirecting' field
in Windows to prevent update of device list when
libusb opens the device (device redirection causes
temporary removal of target device)
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
src/meson.build | 4 +-
src/usb-backend.c| 250
This series is dedicated to unification of Linux Windows flows
in usb-device-manager. It moves differences related to libusb
to USB backend module and simplifies implementation of procedures
related to USB redirection.
Changes from v2: cosmetic changes
Yuri Benditovich (4):
usb-redir: unify
nes of code and also removes all the
differences between Linux and Windows in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c| 28 -
src/usb-backend.c | 49 +++---
src/usb-backend.h | 2 -
src/usb-device-mana
-by: Yuri Benditovich
---
src/usb-backend.c| 5 -
src/usb-backend.h| 3 ++-
src/usb-device-manager.c | 3 ++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 3f99739..2a2f9fa 100644
--- a/src/usb-backend.c
+++ b/src/usb
1 - 100 of 421 matches
Mail list logo
