Re: [Spice-devel] [PATCH] Make sure g_object_new receive the correct data

2016-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2016 at 07:16:57AM -0400, Frediano Ziglio wrote: > > > diff --git a/server/spicevmc.c b/server/spicevmc.c > > > index b662d94..a863e39 100644 > > > --- a/server/spicevmc.c > > > +++ b/server/spicevmc.c > > > @@ -580,8 +580,8 @@ red_char_device_spicevmc_new(SpiceCharDeviceInstance

Re: [Spice-devel] [PATCH] Make sure g_object_new receive the correct data

2016-06-03 Thread Frediano Ziglio
> > On Fri, Jun 03, 2016 at 12:00:24PM +0100, Frediano Ziglio wrote: > > g_object_new is a variadic function which take property values. > > As compiler cannot check if these property values are correct > > make sure they are using casts. > > This actully fix a crash in reds.c for 32 bit

Re: [Spice-devel] [PATCH] Make sure g_object_new receive the correct data

2016-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2016 at 12:00:24PM +0100, Frediano Ziglio wrote: > g_object_new is a variadic function which take property values. > As compiler cannot check if these property values are correct > make sure they are using casts. > This actully fix a crash in reds.c for 32 bit architectures. > >