[Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 --- client/screen.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 0b3ba6f..a0dc0df 100644 --- a/client/screen.cpp +++ b/client/screen.cpp @@ -87,6 +87,7 @@

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 10:54:57AM +0200, Uri Lublin wrote: Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 ACK. --- client/screen.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 0b3ba6f..a0dc0df 100644 ---

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Christophe Fergeau
What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? On Thu, Dec 22, 2011 at 10:54:57AM +0200, Uri Lublin wrote: Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 --- client/screen.cpp |2 +- 1 files

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Christophe Fergeau
On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? The compiler warns about it. When the

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? The compiler warns about it. When the

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
On 12/22/2011 11:26 AM, Christophe Fergeau wrote: On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something