Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-19 Thread Uri Lublin
On 07/18/2011 01:32 PM, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 01:19:05PM +0300, Uri Lublin wrote: On Mon, Jul 18, 2011 at 11:13:50AM +0200, Christophe Fergeau wrote: Or this can be checked for in configure.ac I'm not sure configure.ac is the place to check it. Why not? If you

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-19 Thread Christophe Fergeau
On Tue, Jul 19, 2011 at 02:22:14PM +0300, Uri Lublin wrote: I guess I misunderstood what is suggested to be checked in configure.ac From the two options below I meant the second. Checking that backtrace or backtrace_symbols are available during compile time should be done in configure.ac.

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Christophe Fergeau
On Thu, Jul 14, 2011 at 10:50:49AM +0300, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. What use case do you have in mind for this? Is it meant for

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: On Thu, Jul 14, 2011 at 10:50:49AM +0300, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT,

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Christophe Fergeau
On Mon, Jul 18, 2011 at 11:57:47AM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: What use case do you have in mind for this? Is it meant for use during development when something asserts but we forgot to run it in gdb? Or do you want to get more

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 11:13:50AM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 11:57:47AM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: What use case do you have in mind for this? Is it meant for use during development when

[Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-14 Thread Alon Levy
Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. --- common/Makefile.am|2 + common/backtrace.c| 88 +

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-14 Thread Uri Lublin
On 07/14/2011 10:50 AM, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. --- diff --git a/common/backtrace.c b/common/backtrace.c + +while

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-14 Thread Alon Levy
On Thu, Jul 14, 2011 at 11:53:30AM +0300, Uri Lublin wrote: On 07/14/2011 10:50 AM, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. --- diff --git