Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

On Mon, 18 Apr 2016, Victor Toso wrote: > Hi, > > On Wed, Mar 02, 2016 at 04:27:34PM +0100, Victor Toso wrote: > > > As I don't see any new issues and also due the fact that stream-video is > > > off by default, I'd ack this two patches > > > > > > Acked-by: Victor Toso >

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Wed, Mar 02, 2016 at 04:27:34PM +0100, Victor Toso wrote: > > As I don't see any new issues and also due the fact that stream-video is > > off by default, I'd ack this two patches > > > > Acked-by: Victor Toso > > * I tested both patches but only the first one is

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, Small fixes to my last email :) On Wed, Mar 02, 2016 at 04:14:09PM +0100, Victor Toso wrote: > I did get what you mean here, are you referring to > drawable->red_drawable->u.copy.src_area ? * s/did/did not/ > With and without those two patches, following bug happens: >

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Sat, Feb 27, 2016 at 01:53:16PM -0500, Frediano Ziglio wrote: > > Hi, > > > > On Fri, Feb 26, 2016 at 10:03:40PM +0100, Victor Toso wrote: > > > Hi, > > > > > > On Wed, Feb 24, 2016 at 06:30:34PM +0100, Francois Gouget wrote: > > > > They always match the size of the source bitmap area: >

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

> Hi, > > On Fri, Feb 26, 2016 at 10:03:40PM +0100, Victor Toso wrote: > > Hi, > > > > On Wed, Feb 24, 2016 at 06:30:34PM +0100, Francois Gouget wrote: > > > They always match the size of the source bitmap area: > > > * because for sized frames they are set from the source area, > > > * and

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Fri, Feb 26, 2016 at 10:03:40PM +0100, Victor Toso wrote: > Hi, > > On Wed, Feb 24, 2016 at 06:30:34PM +0100, Francois Gouget wrote: > > They always match the size of the source bitmap area: > > * because for sized frames they are set from the source area, > > * and because otherwise the

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Wed, Feb 24, 2016 at 06:30:34PM +0100, Francois Gouget wrote: > They always match the size of the source bitmap area: > * because for sized frames they are set from the source area, > * and because otherwise the initial stream's size is that of regular > frames by definition. > Note also

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Fri, Feb 26, 2016 at 09:39:49PM +0100, Victor Toso wrote: > Hi, > > On Fri, Feb 26, 2016 at 04:56:00PM +0100, Francois Gouget wrote: > > On Fri, 26 Feb 2016, Frediano Ziglio wrote: > > > > > > > > > > They always match the size of the source bitmap area: > > > > * because for sized frames

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

Hi, On Fri, Feb 26, 2016 at 04:56:00PM +0100, Francois Gouget wrote: > On Fri, 26 Feb 2016, Frediano Ziglio wrote: > > > > > > > They always match the size of the source bitmap area: > > > * because for sized frames they are set from the source area, > > > * and because otherwise the initial

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

On Fri, 26 Feb 2016, Frediano Ziglio wrote: [...] > Personally I don't understand the "sized" thing. If mjpeg is just a sequence > of jpeg and if we can't have a single stream (I never saw a video changing > frame size every frame...) looks like we just compress the images we are > sending with

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

> > On Fri, 26 Feb 2016, Frediano Ziglio wrote: > > > > > > > They always match the size of the source bitmap area: > > > * because for sized frames they are set from the source area, > > > * and because otherwise the initial stream's size is that of regular > > > frames by definition. > > >

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

On Fri, 26 Feb 2016, Frediano Ziglio wrote: > > > > They always match the size of the source bitmap area: > > * because for sized frames they are set from the source area, > > * and because otherwise the initial stream's size is that of regular > > frames by definition. > > Note also that we

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

> > They always match the size of the source bitmap area: > * because for sized frames they are set from the source area, > * and because otherwise the initial stream's size is that of regular > frames by definition. > Note also that we do not lose any flexibility since the source area >

[Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

They always match the size of the source bitmap area: * because for sized frames they are set from the source area, * and because otherwise the initial stream's size is that of regular frames by definition. Note also that we do not lose any flexibility since the source area parameter can be used