Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-28 Thread Javier Celaya
El Lunes, 26 de enero de 2015 17:00:04 Javier Celaya escribió: El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-26 Thread Christophe Fergeau
On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to build the Windows client. Anyway, I don't mind using one solution or another, so you tell me. spice-common may be referencing MSVC++ as the

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to build the Windows client. Anyway, I don't mind using one solution

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-26 Thread Javier Celaya
El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-23 Thread Christophe Fergeau
Hey, As this is not going to be built using MSVC, I don't think it's a huge problem using ntohl. If you really don't want to use it, I'd favour adding a dependency on glib, and using GUINT32_FROM_LE. Christophe On Thu, Jan 22, 2015 at 05:21:20PM +0100, Javier Celaya wrote: ---

[Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index cfbba5e..0f6b7f4 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -27,7 +27,6 @@ #include math.h #ifdef USE_LZ4