Re: [Spice-devel] [PATCH RESEND] Don't set SpiceLinkReply::pub_key if client advertises SASL cap

2014-11-07 Thread Marc-André Lureau
ack On Tue, Oct 21, 2014 at 3:54 PM, Christophe Fergeau cferg...@redhat.com wrote: If the client advertises the SASL cap, it means it guarantees it will be able to use SASL if the server supports, and that it does not need a valid SpiceLinkReply::pub_key field when using SASL. When the

Re: [Spice-devel] [PATCH RESEND] Don't set SpiceLinkReply::pub_key if client advertises SASL cap

2014-11-06 Thread Christophe Fergeau
No taker for a review ? Christophe On Tue, Oct 21, 2014 at 03:54:08PM +0200, Christophe Fergeau wrote: If the client advertises the SASL cap, it means it guarantees it will be able to use SASL if the server supports, and that it does not need a valid SpiceLinkReply::pub_key field when using

[Spice-devel] [PATCH RESEND] Don't set SpiceLinkReply::pub_key if client advertises SASL cap

2014-10-21 Thread Christophe Fergeau
If the client advertises the SASL cap, it means it guarantees it will be able to use SASL if the server supports, and that it does not need a valid SpiceLinkReply::pub_key field when using SASL. When the client cap is set, we thus don't need to create a RSA public key if SASL is enabled server